BOINC / boinc

html/inc/pm.inc

Spacing +11 added lines, -11 removed lines

@@ -51,7 +51,7 @@ 
     return $x;
 }
 
-function pm_team_form($user, $teamid, $error=null) {
+function pm_team_form($user, $teamid, $error = null) {
     global $bbcode_html, $bbcode_js;
     $team = BoincTeam::lookup_id($teamid);
     if (!$team) {
@@ -61,7 +61,7 @@ 
         error_page("not admin");
     }
 
-    page_head(tra("Send message to team"),'','','', $bbcode_js);
+    page_head(tra("Send message to team"), '', '', '', $bbcode_js);
 
     $subject = post_str("subject", true);
     $content = post_str("content", true);
@@ -113,7 +113,7 @@ 
 function pm_form_page($replyto, $userid, $error = null) {
     global $bbcode_html, $bbcode_js;
     global $g_logged_in_user;
-    page_head(tra("Send private message"),'','','', $bbcode_js);
+    page_head(tra("Send private message"), '', '', '', $bbcode_js);
 
     if (post_str("preview", true) == tra("Preview")) {
         $content = post_str("content", true);
@@ -137,7 +137,7 @@ 
         if (!$user) {
             error_page("Sender no longer exists");
         }
-        $writeto = UNIQUE_USER_NAME?$user->name:$userid." (".$user->name.")";
+        $writeto = UNIQUE_USER_NAME ? $user->name : $userid." (".$user->name.")";
         $subject = $message->subject;
         if (substr($subject, 0, 3) != "re:") {
             $subject = "re: ".$subject;
@@ -147,15 +147,15 @@ 
         if (!$user) {
             error_page("Sender no longer exists");
         }
-        $writeto = UNIQUE_USER_NAME?$user->name:$userid." (".$user->name.")";
+        $writeto = UNIQUE_USER_NAME ? $user->name : $userid." (".$user->name.")";
     } else {
         $writeto = sanitize_tags(post_str("to", true));
         $subject = post_str("subject", true);
         $content = post_str("content", true);
     }
 
-    $content = $content?htmlspecialchars($content):'';
-    $subject = $subject?htmlspecialchars($subject):'';
+    $content = $content ?htmlspecialchars($content) : '';
+    $subject = $subject ?htmlspecialchars($subject) : '';
 
     if ($error != null) {
         echo "<p class=\"text-danger\">".$error."</p>\n";
@@ -211,7 +211,7 @@ 
 function send_pm_notification_email(
     $logged_in_user, $to_user, $subject, $content
 ) {
-    $message  = "
+    $message = "
 You have received a new private message at ".PROJECT.".
 
 From: $logged_in_user->name (ID $logged_in_user->id)
@@ -241,7 +241,7 @@ 
     $pm = BoincPrivateMessage::lookup_id($notify->opaque);
     $from_user = BoincUser::lookup_id($pm->senderid);
     if (!$pm || !$from_user) return null;
-    return "<a href=pm.php>".tra("Private message%1 from %2, subject:" , "</a>", $from_user->name )." $pm->subject";
+    return "<a href=pm.php>".tra("Private message%1 from %2, subject:", "</a>", $from_user->name)." $pm->subject";
 }
 
 function pm_send_msg($from_user, $to_user, $subject, $content, $send_email) {
@@ -305,11 +305,11 @@ 
 
 function pm_email_remind($user) {
     if (!$user->prefs->pm_notification) {
-        return "<br><small>" .
+        return "<br><small>".
             tra(
                 "For email notification, %1 edit community prefs %2",
                 '<a href="edit_forum_preferences_form.php">', '</a>'
-            ) .
+            ).
             "</small>"
         ;
     }

html/inc/team.inc

Spacing +16 added lines, -16 removed lines

@@ -40,7 +40,7 @@ 
     row2('<b>'.tra('Search criteria (use one or more)').'</b>', '');
     row2(
         tra('Key words').'<br><small>'.tra('Find teams with these words in their names or descriptions').'</small>',
-        '<input class="form-control" type="text" name="keywords" value="' . htmlspecialchars($params->keywords) . '">');
+        '<input class="form-control" type="text" name="keywords" value="'.htmlspecialchars($params->keywords).'">');
     row2_init(tra('Country'));
     echo '<select class="form-control" name="country"><option value="" selected>---</option>';
     $country = $params->country;
@@ -48,7 +48,7 @@ 
     echo country_select_options($country);
     echo "</select></td></tr>\n";
     row2(tra('Type of team'), team_type_select($params->type, true));
-    $checked = $params->active?"checked":"";
+    $checked = $params->active ? "checked" : "";
     row2(tra('Show only active teams'), "<input type=checkbox name=active $checked>");
     row2("", "<input class=\"btn btn-primary\" type=submit name=submit value=\"".tra('Search')."\">");
     end_table();
@@ -95,7 +95,7 @@ 
     row2("Created", date_str($team->create_time));
     if (defined("SHOW_NONVALIDATED_TEAMS")) {
         $founder = $team->founder;
-        row2("Founder email validated", $founder->email_validated?"Yes":"No (team will not be exported)");
+        row2("Founder email validated", $founder->email_validated ? "Yes" : "No (team will not be exported)");
     }
     if (strlen($team->url)) {;
         if (strstr($team->url, "http://")) {
@@ -168,7 +168,7 @@ 
     }
     row1(tra('Members'));
     row2(tra('Founder'),
-        $team->founder?user_links($team->founder, BADGE_HEIGHT_MEDIUM):"---"
+        $team->founder ?user_links($team->founder, BADGE_HEIGHT_MEDIUM) : "---"
     );
     if (count($team->admins)) {
         $first = true;
@@ -355,7 +355,7 @@ 
     foreach ($deltas as $delta) {
         $u = BoincUser::lookup_id($delta->userid);
         if ($u->teamid == $teamid) {
-            $new_members[] = $u->id;  // they might have later quit
+            $new_members[] = $u->id; // they might have later quit
         }
     }
     return array_unique($new_members);
@@ -438,7 +438,7 @@ 
     if (!$user->teamid) return;
     $user->update("teamid=0");
     $team = BoincTeam::lookup_id($user->teamid);
-    if ($team && $team->ping_user==$user->id) {
+    if ($team && $team->ping_user == $user->id) {
         $team->update("ping_user=-ping_user");
     }
     BoincTeamAdmin::delete("teamid=$user->teamid and userid=$user->id");
@@ -477,33 +477,33 @@ 
     start_table();
     row2(tra('Team name, text version').'
         <br><p class=\"text-muted\">'.tra('Don\'t use HTML tags.').'</p>',
-        '<input class="form-control" name="name" type="text" size="50" value="'.($team?$team->name:"").'">'
+        '<input class="form-control" name="name" type="text" size="50" value="'.($team ? $team->name : "").'">'
     );
     row2(tra('Team name, HTML version').'
         <br><p class=\"text-muted\">
         '.tra('You may use %1 limited HTML tags %2.', '<a href="html.php" target="_new">', '</a>').'
         '.tra('If you don\'t know HTML, leave this box blank.').'</p>',
-        '<input class="form-control" name="name_html" type="text" size="50" value="'.str_replace('"',"'",($team?$team->name_html:"")).'">'
+        '<input class="form-control" name="name_html" type="text" size="50" value="'.str_replace('"', "'", ($team ? $team->name_html : "")).'">'
     );
     row2(tra('URL of team web page, if any').':<br><font size=-2>('.tra('without "http://"').')
         '.tra('This URL will be linked to from the team\'s page on this site.'),
-        '<input class="form-control" type="text" name="url" size="60" value="'.($team?$team->url:"").'">'
+        '<input class="form-control" type="text" name="url" size="60" value="'.($team ? $team->url : "").'">'
     );
     row2(tra('Description of team').':
         <br><p class=\"text-muted\">
         '.tra('You may use %1 limited HTML tags %2.', '<a href="html.php" target="_new">', '</a>').'
         </p>',
-        '<textarea class="form-control" name="description" rows=10>'.($team?$team->description:"").'</textarea>'
+        '<textarea class="form-control" name="description" rows=10>'.($team ? $team->description : "").'</textarea>'
     );
 
-    row2(tra('Type of team').':', team_type_select($team?$team->type:null));
+    row2(tra('Type of team').':', team_type_select($team ? $team->type : null));
 
     row2_init(tra('Country'));
     echo '<select class="form-control" name="country">';
-    echo country_select_options($team?$team->country:null);
+    echo country_select_options($team ? $team->country : null);
     echo "</select></td></tr>\n";
 
-    $x = (!$team || $team->joinable)?"checked":"";
+    $x = (!$team || $team->joinable) ? "checked" : "";
     row2(tra("Accept new members?"), "<input type=checkbox name=joinable $x>");
     // Check if we're using reCaptcha to prevent spam accounts
     //
@@ -571,12 +571,12 @@ 
 //
 function new_transfer_request_ok($team, $now) {
     if ($team->ping_user <= 0) {
-        if ($team->ping_time < $now - 60 * 86400) {
+        if ($team->ping_time < $now - 60*86400) {
             return true;
         }
         return false;
     }
-    if ($team->ping_time < $now - 90 * 86400) {
+    if ($team->ping_time < $now - 90*86400) {
         return true;
     }
     return false;
@@ -611,7 +611,7 @@ 
     if (!is_valid_country($country)) {
         $country = tra('None');
     }
-    $country = BoincDb::escape_string($country);  // for Cote d'Ivoire
+    $country = BoincDb::escape_string($country); // for Cote d'Ivoire
 
     $clause = sprintf(
         "(userid, create_time, name, name_lc, url, type, name_html, description, country, nusers, expavg_time) values(%d, %d, '%s', '%s', '%s', %d, '%s', '%s', '%s', %d, unix_timestamp())",

html/ops/sample_table_stats.php

Spacing +13 added lines, -13 removed lines

@@ -27,25 +27,25 @@
     row_array(array("Name", "Engine", "Version", "Row Format", "Rows", "Avg Row Length (KB)", "Data Length (MB)", "Max Data Length (MB)", "Index Length (MB)", "Data free (MB)", "Create Time", "Update Time", "Check Time", "Create Options", "Comment"));
     db_init();
     $result = _mysql_query("show table status");
-    while($row = _mysql_fetch_array($result)) {
+    while ($row = _mysql_fetch_array($result)) {
         $size += ($row["Data_length"] + $row["Index_length"]);
         $engine = $row["Engine"];
         //if (!$engine) $engine = $row["Type"];
         row_array(array(
             $row["Name"],
             $engine,
-            $row["Version"] ,
-            $row["Row_format"] ,
-            $row["Rows"] ,
-            round($row["Avg_row_length"]/1024,2) ,
-            round($row["Data_length"]/(1024*1024),2) ,
-            round($row["Max_data_length"]/(1024*1024),2) ,
-            round($row["Index_length"]/(1024*1024),2) ,
-            round($row["Data_free"]/(1024*1024),2) ,
-            $row["Create_time"] ,
-            $row["Update_time"] ,
-            $row["Check_time"] ,
-            $row["Create_options"] ,
+            $row["Version"],
+            $row["Row_format"],
+            $row["Rows"],
+            round($row["Avg_row_length"]/1024, 2),
+            round($row["Data_length"]/(1024*1024), 2),
+            round($row["Max_data_length"]/(1024*1024), 2),
+            round($row["Index_length"]/(1024*1024), 2),
+            round($row["Data_free"]/(1024*1024), 2),
+            $row["Create_time"],
+            $row["Update_time"],
+            $row["Check_time"],
+            $row["Create_options"],
             $row["Comment"]
         ));
     }

html/inc/consent.inc

Spacing +5 added lines, -5 removed lines

@@ -21,7 +21,7 @@ 
 require_once("../inc/boinc_db.inc");
 require_once("../inc/util.inc");
 
-define('CONSENT_TYPE_ENROLL','ENROLL');
+define('CONSENT_TYPE_ENROLL', 'ENROLL');
 
 function check_termsofuse() {
     return defined('TERMSOFUSE_FILE') and file_exists(TERMSOFUSE_FILE);
@@ -32,13 +32,13 @@ 
     $source, $ctime = 0
 ) {
     $mys = BoincDb::escape_string($source);
-    if ($ctime==0) {
+    if ($ctime == 0) {
         $mytime = $user->create_time;
     } else {
         $mytime = $ctime;
     }
     return BoincConsent::insert(
-        "(userid, consent_type_id, consent_time, consent_flag, consent_not_required, source) " .
+        "(userid, consent_type_id, consent_time, consent_flag, consent_not_required, source) ".
         "values($user->id, $consent_type_id, $mytime, $consent_flag, $consent_not_required, '$mys')"
     );
 
@@ -65,10 +65,10 @@ 
 // The integer is the consent_type_id- the id from consent_type table.
 // If the boolean is FALSE, the integer returned is -1.
 //
-function check_consent_type($name, $checkenabled=TRUE) {
+function check_consent_type($name, $checkenabled = TRUE) {
     $name = BoincDb::escape_string($name);
     $ct = BoincConsentType::lookup("shortname = '$name'");
-    if ($ct and ( !$checkenabled or ($ct->enabled)) ) {
+    if ($ct and (!$checkenabled or ($ct->enabled))) {
         return array(TRUE, $ct->id);
     }
     return array(FALSE, -1);

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -52,10 +52,10 @@ 
             "userid=$user->id AND consent_type_id=$ctid AND consent_flag=1"
         );
         if ($consent_result) {
-            return TRUE;
+            return true;
         }
     }
-    return FALSE;
+    return false;
 }
 
 // Check if a particular consent_type name is available.
@@ -65,13 +65,13 @@ 
 // The integer is the consent_type_id- the id from consent_type table.
 // If the boolean is FALSE, the integer returned is -1.
 //
-function check_consent_type($name, $checkenabled=TRUE) {
+function check_consent_type($name, $checkenabled=true) {
     $name = BoincDb::escape_string($name);
     $ct = BoincConsentType::lookup("shortname = '$name'");
     if ($ct and ( !$checkenabled or ($ct->enabled)) ) {
-        return array(TRUE, $ct->id);
+        return array(true, $ct->id);
     }
-    return array(FALSE, -1);
+    return array(false, -1);
 }
 
 // When a user uses the Web site to login, this function checks the

html/user/openid_login.php

Spacing +3 added lines, -3 removed lines

@@ -16,7 +16,7 @@ 
 // You should have received a copy of the GNU Lesser General Public License
 // along with BOINC.  If not, see <http://www.gnu.org/licenses/>.
 
-NOT FINISHED.   DON'T USE
+NOT FINISHED.DON'T USE
 
 require 'openid.php';
 include_once("../inc/boinc_db.inc");
@@ -26,14 +26,14 @@ 
 
 function show_error($str) {
     page_head("Can't create account");
-    echo "$str<br>\n";
+    echo "$str < br > \n";
     page_tail();
     exit();
 }
 
 try {
     $openid = new LightOpenID;
-    echo "<pre>";
+    echo " < pre > ";
     if(!$openid->mode) {
         if(isset($_POST['openid_identifier'])) {
             $openid->identity = $_POST['openid_identifier'];

html/user/prefs_edit.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
 $subset = sanitize_tags(get_str("subset"));
 $venue = sanitize_tags(get_str("venue", true));
 $columns = get_int("cols", true);
-$c = $columns?"&cols=$columns":"";
+$c = $columns ? "&cols=$columns" : "";
 check_subset($subset);
 if ($action) {
     check_tokens($user->authenticator);

html/inc/util_basic.inc

Spacing +6 added lines, -6 removed lines

@@ -56,10 +56,10 @@ 
     return file_exists("$d/stop_sched");
 }
 
-function xml_error($num=-1, $msg=null, $file=null, $line=null) {
+function xml_error($num = -1, $msg = null, $file = null, $line = null) {
     global $xml_outer_tag;
     if (!$msg) {
-        switch($num) {
+        switch ($num) {
         case -112: $msg = "Invalid XML"; break;
         case -136: $msg = "Not found"; break;
         case -137: $msg = "Name or email address is not unique"; break;
@@ -105,7 +105,7 @@ 
 // If it's a single-tag element, and it's present, just return the tag
 //
 function parse_element($xml, $tag) {
-    $closetag = "</" . substr($tag,1);
+    $closetag = "</".substr($tag, 1);
     $x = strstr($xml, $tag);
     if ($x) {
         if (strstr($tag, "/>")) return $tag;
@@ -121,8 +121,8 @@ 
 
 function parse_next_element($xml, $tag, &$cursor) {
     $element = null;
-    $closetag = "</" . substr($tag,1);
-    $pos = substr($xml,$cursor);
+    $closetag = "</".substr($tag, 1);
+    $pos = substr($xml, $cursor);
     $x = strstr($pos, $tag);
     if ($x) {
         if (strstr($tag, "/>")) return $tag;
@@ -222,7 +222,7 @@ 
 // whose OSs may have such restrictions.
 //
 function is_valid_filename($x) {
-    if (strlen($x)>255) return false;
+    if (strlen($x) > 255) return false;
     // \w means A-Za-z0-9_
     return preg_match('/^[\w\-.]+$/', $x);
 }

html/user/forum_thread_vote.php

Spacing +1 added lines, -1 removed lines

@@ -30,6 +30,6 @@
 if (!$thread) error_page('No such thread');
 $logged_in_user = get_logged_in_user();
 
-$posts = get_thread_posts($threadid, 0,true);
+$posts = get_thread_posts($threadid, 0, true);
 header("Location: forum_rate.php?choice=p&post=".$posts[0]->id);
 ?>

html/user/forum_moderate_post.php

Spacing +5 added lines, -5 removed lines

@@ -50,7 +50,7 @@ 
 start_table();
 
 $get_reason = true;
-if (get_str('action')=="hide") {
+if (get_str('action') == "hide") {
     //display input that selects reason
     echo "<input type=hidden name=action value=hide>";
     row1(tra("Hide post"));
@@ -67,12 +67,12 @@ 
             )
         )
     );
-} elseif (get_str('action')=="move") {
+} elseif (get_str('action') == "move") {
     row1(tra("Move post"));
     echo "<input type=hidden name=action value=move>";
     row2(tra("Destination thread ID:"), "<input name=\"threadid\">");
     // TODO: display where to move the post as a dropdown instead of having to get ID
-} elseif (get_str('action')=="banish_user") {
+} elseif (get_str('action') == "banish_user") {
     $userid = get_int('userid');
     $user = BoincUser::lookup_id($userid);
     if (!$user) {
@@ -80,7 +80,7 @@ 
     }
     BoincForumPrefs::lookup($user);
     $x = $user->prefs->banished_until;
-    if ($x>time()) {
+    if ($x > time()) {
         error_page(tra("User is already banished"));
     }
     row1(tra("Banish user"));
@@ -98,7 +98,7 @@ 
     echo "<input type=\"hidden\" name=\"id\" value=\"".$postid."\">\n";
     echo "<input type=\"hidden\" name=\"userid\" value=\"".$userid."\">\n";
     echo "<input type=\"hidden\" name=\"confirmed\" value=\"yes\">\n";
-} elseif (get_str('action')=="delete") {
+} elseif (get_str('action') == "delete") {
     echo "<input type=hidden name=action value=delete>";
     row2(
         "Are you sure want to delete this post?  This cannot be undone.",