Passed
Branch master (7a17e1)
by Vitalii
08:27
created
html/user/team_delta.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
     global $xml;
31 31
     $user = BoincUser::lookup_id($delta->userid);
32 32
     $when = time_str($delta->timestamp);
33
-    $what = $delta->joining?"joined":"quit";
33
+    $what = $delta->joining ? "joined" : "quit";
34 34
     if ($xml) {
35 35
         echo "    <action>
36 36
         <id>$user->id</id>
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     } else {
44 44
         echo "<tr>
45 45
            <td>$when</td>
46
-           <td>",user_links($user, BADGE_HEIGHT_MEDIUM)," (ID $user->id)</td>
46
+           <td>", user_links($user, BADGE_HEIGHT_MEDIUM), " (ID $user->id)</td>
47 47
            <td>$what</td>
48 48
            <td>$delta->total_credit</td>
49 49
            </tr>
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
     );
83 83
 }
84 84
 $deltas = BoincTeamDelta::enum("teamid=$teamid order by timestamp");
85
-foreach($deltas as $delta) {
85
+foreach ($deltas as $delta) {
86 86
     show_delta($delta);
87 87
 }
88 88
 if ($xml) {
Please login to merge, or discard this patch.
html/user/cert_team.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -34,10 +34,10 @@
 block discarded – undo
34 34
 
35 35
 $border = get_str("border", true);
36 36
 
37
-if ($border=="no") {
37
+if ($border == "no") {
38 38
     $border = 0;
39 39
 } else {
40
-    $border=8;
40
+    $border = 8;
41 41
 }
42 42
 
43 43
 $credit = credit_string($team->total_credit, false);
Please login to merge, or discard this patch.
html/user/server_status.php 2 patches
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
         $avg = round($app->info->avg, 2);
172 172
         $min = round($app->info->min, 2);
173 173
         $max = round($app->info->max, 2);
174
-        $x = $max?"$avg ($min - $max)":"---";
174
+        $x = $max ? "$avg ($min - $max)" : "---";
175 175
         $u = $app->info->users;
176 176
         echo "<tr>
177 177
             <td>$app->user_friendly_name</td>
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
         $cmd = trim($cmd);
245 245
         $x = explode(" ", $cmd);
246 246
         $prog = $x[0];
247
-        $pidname = $prog . '.pid';
247
+        $pidname = $prog.'.pid';
248 248
     }
249 249
     $path = "../../pid_$host/$pidname";
250 250
     if (is_file($path)) {
@@ -285,12 +285,12 @@  discard block
 block discarded – undo
285 285
     }
286 286
     $master_host = $u["host"];
287 287
     if ($config->www_host) {
288
-        $web_host = trim((string) $config->www_host);
288
+        $web_host = trim((string)$config->www_host);
289 289
     } else {
290 290
         $web_host = $main_host;
291 291
     }
292 292
     if ($config->sched_host) {
293
-        $sched_host = trim((string) $config->sched_host);
293
+        $sched_host = trim((string)$config->sched_host);
294 294
     } else {
295 295
         $sched_host = $main_host;
296 296
     }
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
 
301 301
     // the upload and download servers are sort of daemons too
302 302
     //
303
-    $url = trim((string) $config->download_url);
303
+    $url = trim((string)$config->download_url);
304 304
     $u = parse_url($url);
305 305
     $h = $u["host"];
306 306
     if ($h == $master_host) {
@@ -312,14 +312,14 @@  discard block
 block discarded – undo
312 312
     } else {
313 313
         $have_remote = true;
314 314
     }
315
-    $url = trim((string) $config->upload_url);
315
+    $url = trim((string)$config->upload_url);
316 316
     $u = parse_url($url);
317 317
     $h = $u["host"];
318 318
     if ($h == $master_host) {
319 319
         $y = new StdClass;
320 320
         $y->cmd = "Upload server";
321 321
         $y->host = $h;
322
-        $y->status = !file_exists("../../stop_upload");;
322
+        $y->status = !file_exists("../../stop_upload"); ;
323 323
         $local_daemons[] = $y;
324 324
     } else {
325 325
         $have_remote = true;
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
         $y = new StdClass;
332 332
         $y->cmd = "Scheduler";
333 333
         $y->host = $sched_host;
334
-        $y->status = !file_exists("../../stop_sched");;
334
+        $y->status = !file_exists("../../stop_sched"); ;
335 335
         $local_daemons[] = $y;
336 336
     } else {
337 337
         $have_remote = true;
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
             $disabled_daemons[] = $x;
348 348
             continue;
349 349
         }
350
-        $host = $d->host?(string)$d->host:$main_host;
350
+        $host = $d->host ? (string)$d->host : $main_host;
351 351
         if ($host != $web_host) {
352 352
             $have_remote = true;
353 353
             continue;
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -251,7 +251,7 @@
 block discarded – undo
251 251
         $pid = file_get_contents($path);
252 252
         if ($pid) {
253 253
             $pid = trim($pid);
254
-            $out = Array();
254
+            $out = array();
255 255
             exec("ps -ww $pid", $out);
256 256
             foreach ($out as $y) {
257 257
                 if (strstr($y, (string)$pid)) return 1;
Please login to merge, or discard this patch.
html/user/team_lookup.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 if ($format == 'xml') {
77 77
     echo "<teams>\n";
78 78
     $total = 0;
79
-    foreach($teams as $team) {
79
+    foreach ($teams as $team) {
80 80
         show_team_xml($team);
81 81
         $total++;
82 82
         if ($total == 100) break;
@@ -91,13 +91,13 @@  discard block
 block discarded – undo
91 91
     echo "<p>";
92 92
     echo tra("You may view these teams' members, statistics, and information.");
93 93
     echo "<ul>";
94
-    foreach($teams as $team) {
94
+    foreach ($teams as $team) {
95 95
         echo "<li>";
96 96
         echo "<a href=team_display.php?teamid=$team->id>";
97 97
         echo "$team->name</a></li>";
98 98
     }
99 99
     echo "</ul>";
100
-    if (count($teams)==100) {
100
+    if (count($teams) == 100) {
101 101
         echo
102 102
             tra("More than 100 teams match your search. The first 100 are shown.")
103 103
             ."<br>
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,8 @@
 block discarded – undo
52 52
     echo "<teams>\n";
53 53
     $total = 0;
54 54
     foreach ($team_id_array as $team_id) {
55
-        if (is_numeric($team_id)) { //make sure only numbers get through
55
+        if (is_numeric($team_id)) {
56
+//make sure only numbers get through
56 57
             $team = BoincTeam::lookup_id($team_id);
57 58
             if ($team) {
58 59
                 show_team_xml($team);
Please login to merge, or discard this patch.
html/user/forum_banishment_vote.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -47,13 +47,13 @@  discard block
 block discarded – undo
47 47
 start_table();
48 48
 row1(tra("Banishment Vote"));
49 49
 
50
-if (get_str('action')=="start") {
50
+if (get_str('action') == "start") {
51 51
     if (!$user) {
52 52
         error_page(tra("No user with this ID found."));
53 53
     }
54 54
     BoincForumPrefs::lookup($user);
55 55
     $x = $user->prefs->banished_until;
56
-    if ($x>time()) {
56
+    if ($x > time()) {
57 57
         error_page(tra("User is already banished"));
58 58
     }
59 59
     //display input that selects reason
@@ -77,10 +77,10 @@  discard block
 block discarded – undo
77 77
     "",
78 78
     "<input class=\"btn btn-default\" type=\"submit\" name=\"submit\" value=\"".tra("Proceed with vote")."\">"
79 79
 );
80
-} elseif (get_str('action')=="yes") {
81
-    vote_yes($config,$logged_in_user,$user);
82
-} elseif (get_str('action')=="no") {
83
-    vote_no($config,$logged_in_user,$user);
80
+} elseif (get_str('action') == "yes") {
81
+    vote_yes($config, $logged_in_user, $user);
82
+} elseif (get_str('action') == "no") {
83
+    vote_no($config, $logged_in_user, $user);
84 84
 } else {
85 85
     error_page("Unknown action");
86 86
 }
Please login to merge, or discard this patch.
html/user/donation_ipn.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -30,8 +30,8 @@  discard block
 block discarded – undo
30 30
 // post back to PayPal system to validate
31 31
 $header .= "POST /cgi-bin/webscr HTTP/1.0\r\n";
32 32
 $header .= "Content-Type: application/x-www-form-urlencoded\r\n";
33
-$header .= "Content-Length: " . strlen($req) . "\r\n\r\n";
34
-$fp = fsockopen ('www.paypal.com', 80, $errno, $errstr, 30);
33
+$header .= "Content-Length: ".strlen($req)."\r\n\r\n";
34
+$fp = fsockopen('www.paypal.com', 80, $errno, $errstr, 30);
35 35
 
36 36
 // assign posted variables to local variables
37 37
 $item_name = $_POST['item_name'];
@@ -50,11 +50,11 @@  discard block
 block discarded – undo
50 50
 if (!$fp) {
51 51
     // HTTP ERROR, might want to do additional handling here
52 52
 } else {
53
-    fputs ($fp, $header . $req);
53
+    fputs($fp, $header.$req);
54 54
     while (!feof($fp)) {
55
-        $res = fgets ($fp, 1024);
56
-        if (strcmp ($res, "VERIFIED") == 0) {
57
-            $item_array = explode("_",$item_number);
55
+        $res = fgets($fp, 1024);
56
+        if (strcmp($res, "VERIFIED") == 0) {
57
+            $item_array = explode("_", $item_number);
58 58
             $payment_id = abs($item_array[0]);
59 59
             $order_time = abs($item_array[1]);
60 60
             $result = _mysql_query("SELECT * FROM donation_paypal WHERE order_time = '$order_time' AND id = '$payment_id' AND processed = '0'");
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
             }
70 70
         }
71 71
     }
72
-    fclose ($fp);
72
+    fclose($fp);
73 73
 }
74 74
 
75 75
 ?>
Please login to merge, or discard this patch.
html/user/pm.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
             array(tra("Subject"), tra("Sender and date"), tra("Message")),
80 80
             array('style="width: 12em;"', 'style="width: 10em;"', "")
81 81
         );
82
-        foreach($msgs as $msg) {
82
+        foreach ($msgs as $msg) {
83 83
             $sender = BoincUser::lookup_id($msg->senderid);
84 84
             if (!$sender) {
85 85
                 $msg->delete();
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
     $msgs = BoincPrivateMessage::enum(
311 311
         "userid=$logged_in_user->id"
312 312
     );
313
-    foreach($msgs as $msg) {
313
+    foreach ($msgs as $msg) {
314 314
         $x = "pm_select_$msg->id";
315 315
         if (post_str($x, true)) {
316 316
             $msg = BoincPrivateMessage::lookup_id($msg->id);
@@ -365,5 +365,5 @@  discard block
 block discarded – undo
365 365
     error_page(tra("Unknown action"));
366 366
 }
367 367
 
368
-$cvs_version_tracker[]="\$Id: pm.php 14077 2007-11-03 04:26:47Z davea $";
368
+$cvs_version_tracker[] = "\$Id: pm.php 14077 2007-11-03 04:26:47Z davea $";
369 369
 ?>
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -234,7 +234,8 @@  discard block
 block discarded – undo
234 234
 
235 235
     foreach ($users as $username) {
236 236
         $user = explode(" ", $username);
237
-        if (is_numeric($user[0])) { // user ID is given
237
+        if (is_numeric($user[0])) {
238
+// user ID is given
238 239
             $userid = $user[0];
239 240
             $user = BoincUser::lookup_id($userid);
240 241
             if ($user == null) {
@@ -244,7 +245,8 @@  discard block
 block discarded – undo
244 245
             $users = BoincUser::lookup_name($username);
245 246
             if (count($users) == 0) {
246 247
                 pm_form($replyto, $userid, tra("Could not find user with username %1", $username));
247
-            } elseif (count($users) > 1) { // Non-unique username
248
+            } elseif (count($users) > 1) {
249
+// Non-unique username
248 250
                 pm_form($replyto, $userid, tra("%1 is not a unique username; you will have to use user ID", $username));
249 251
             }
250 252
             $user = $users[0];
Please login to merge, or discard this patch.
html/user/set_language.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 $languages = get_supported_languages();
23 23
 $lang = sanitize_tags(get_str("lang", true));
24 24
 
25
-if (!in_array($lang, $languages) && $lang!="auto" && $lang!="en") {
25
+if (!in_array($lang, $languages) && $lang != "auto" && $lang != "en") {
26 26
     echo "Language $lang is not supported";
27 27
 } else {
28 28
     send_cookie('lang', $lang, true);
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
 $lang = sanitize_tags(get_str("lang", true));
24 24
 
25 25
 if (!in_array($lang, $languages) && $lang!="auto" && $lang!="en") {
26
-    echo "Language $lang is not supported";
26
+    echo "language $lang is not supported";
27 27
 } else {
28 28
     send_cookie('lang', $lang, true);
29 29
     header('Location: index.php');
Please login to merge, or discard this patch.
html/user/results.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -37,11 +37,11 @@  discard block
 block discarded – undo
37 37
 $userid = get_int("userid", true);
38 38
 $offset = get_int("offset", true);
39 39
 $appid = get_int("appid", true);
40
-if (!$offset) $offset=0;
40
+if (!$offset) $offset = 0;
41 41
 $state = get_int("state", true);
42
-if (!$state) $state=0;
42
+if (!$state) $state = 0;
43 43
 $show_names = get_int("show_names", true);
44
-if (!$show_names) $show_names=0;
44
+if (!$show_names) $show_names = 0;
45 45
 
46 46
 $s = $state_name[$state];
47 47
 if ($appid) {
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
     $clause = "hostid=$hostid";
58 58
     page_head(tra("$s tasks for computer %1", $host->id));
59 59
     $show_host_link = false;
60
-} else if ($userid){
60
+} else if ($userid) {
61 61
     $user = get_logged_in_user();
62 62
     if ($userid != $user->id) {
63 63
         error_page(tra("No access"));
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
     error_page(tra("Missing user ID or host ID"));
70 70
 }
71 71
 
72
-$clause2 = $clause. $state_clause[$state];
72
+$clause2 = $clause.$state_clause[$state];
73 73
 if ($appid) {
74 74
     $clause2 .= ' AND appid='.$appid;
75 75
 }
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
 } else {
80 80
     $order_clause = "order by sent_time desc";
81 81
 }
82
-$query = "$clause2 $order_clause limit $offset,".($results_per_page+1);
82
+$query = "$clause2 $order_clause limit $offset,".($results_per_page + 1);
83 83
 $results = BoincResult::enum($query);
84 84
 
85 85
 $info = new StdClass;
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
     $clause = "hostid=$hostid";
58 58
     page_head(tra("$s tasks for computer %1", $host->id));
59 59
     $show_host_link = false;
60
-} else if ($userid){
60
+} else if ($userid) {
61 61
     $user = get_logged_in_user();
62 62
     if ($userid != $user->id) {
63 63
         error_page(tra("No access"));
Please login to merge, or discard this patch.