BOINC / boinc

html/ops/submit_retire.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -166,7 +166,7 @@
     foreach ($batches as $batch) {
         $n = BoincWorkunit::count("batch=$batch->id");
         if ($n == 0) {
-            echo "Batch $batch->id has no jobs\n";
+            echo "batch $batch->id has no jobs\n";
             retire_batch($batch);
         }
     }

html/user/buda_submit.php

Spacing +7 added lines, -7 removed lines

@@ -96,7 +96,7 @@ 
 //
 function unzip_batch_file($user, $batch_file) {
     @mkdir("../../buda_batches");
-    for ($i=0; $i<1000; $i++) {
+    for ($i = 0; $i < 1000; $i++) {
         $batch_dir = "../../buda_batches/$i";
         $batch_dir_name = $i;
         $ret = @mkdir($batch_dir);
@@ -147,7 +147,7 @@ 
         }
         $job_files = [];
         $cmdline = '';
-        foreach(scandir("$batch_dir/$fname") as $f2) {
+        foreach (scandir("$batch_dir/$fname") as $f2) {
             if ($f2[0] == '.') continue;
             if ($f2 == 'cmdline') {
                 $cmdline = trim(file_get_contents("$batch_dir/$fname/cmdline"));
@@ -201,7 +201,7 @@ 
 function stage_input_files($batch_dir, $batch_desc, $batch_id) {
     $n = count($batch_desc->shared_files);
     $batch_desc->shared_files_phys_names = [];
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $path = sprintf('%s/%s', $batch_dir, $batch_desc->shared_files[$i]);
         [$md5, $size] = $batch_desc->shared_file_infos[$i];
         $phys_name = sprintf('batch_%d_%s', $batch_id, $md5);
@@ -211,7 +211,7 @@ 
     foreach ($batch_desc->jobs as $job) {
         $n = count($batch_desc->unshared_files);
         $job->phys_names = [];
-        for ($i=0; $i<$n; $i++) {
+        for ($i = 0; $i < $n; $i++) {
             $path = sprintf('%s/%s/%s',
                 $batch_dir, $job->dir, $batch_desc->unshared_files[$i]
             );
@@ -250,7 +250,7 @@ 
         $job_cmds .= "$job_cmd\n";
     }
     $wrapper_cmdline = sprintf('"%s %s"',
-        $wrapper_verbose?'--verbose':'',
+        $wrapper_verbose ? '--verbose' : '',
         $cmdline
     );
     $cmd = sprintf(
@@ -301,7 +301,7 @@ 
     if ($max_runtime_days <= 0) error_page('bad runtime limit');
     if ($max_runtime_days > 100) error_page('bad runtime limit');
 
-    $max_fpops = $max_runtime_days * AVG_CPU_FPOPS * 86400;
+    $max_fpops = $max_runtime_days*AVG_CPU_FPOPS*86400;
 
     $exp_runtime_days = get_str('exp_runtime_days');
     if (!is_numeric($exp_runtime_days)) error_page('bad expected runtime');
@@ -311,7 +311,7 @@ 
     if ($exp_runtime_days > $max_runtime_days) {
         error_page('exp must be < max runtime');
     }
-    $exp_fpops = $exp_runtime_days * AVG_CPU_FPOPS * 86400;
+    $exp_fpops = $exp_runtime_days*AVG_CPU_FPOPS*86400;
 
     $app_desc = get_buda_app_desc($app);
 

html/ops/batch_stats.php

Spacing +5 added lines, -5 removed lines

@@ -126,7 +126,7 @@ 
     BoincHost::update_aux("error_rate=0");
     $ltts = [];
     foreach ($hosts as $id=>$x) {
-        $avg = $x->ntt_sum / $x->ntt_n;
+        $avg = $x->ntt_sum/$x->ntt_n;
         if ($avg < 1) {
             $ltts[] = $id;
         }
@@ -150,7 +150,7 @@ 
             $nfast = 0;
             foreach ($hlist as $id=>$count) {
                 $x = $hosts[$id];
-                $avg = $x->ntt_sum / $x->ntt_n;
+                $avg = $x->ntt_sum/$x->ntt_n;
                 if ($avg < 1) {
                     $nfast++;
                 }
@@ -165,7 +165,7 @@ 
         }
 
         $app->update(
-            sprintf('n_size_classes=%d', $accel?1:0)
+            sprintf('n_size_classes=%d', $accel ? 1 : 0)
         );
     }
 }
@@ -186,14 +186,14 @@ 
     foreach ($as as $a) {
         $apps[$a->id] = [];
     }
-    $start = time()-30*86400;
+    $start = time() - 30*86400;
     $batches = BoincBatch::enum(
         sprintf(
             'create_time>%d and state in (%d, %d)',
             $start, BATCH_STATE_IN_PROGRESS, BATCH_STATE_COMPLETE
         )
     );
-    foreach($batches as $batch) {
+    foreach ($batches as $batch) {
         do_batch($batch);
     }
     update_db();

html/user/submit_stats.php

Spacing +6 added lines, -6 removed lines

@@ -238,18 +238,18 @@ 
     }
     $n = 100;
     $count = [];
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $count[$i] = 0;
     }
     $range = $max - $min;
     foreach ($x as $f) {
-        $d = intval($n*($f-$min)/$range);
-        if ($d >= $n) $d = $n-1;
+        $d = intval($n*($f - $min)/$range);
+        if ($d >= $n) $d = $n - 1;
         $count[$d] += 1;
     }
     $data = [];
-    for ($i=0; $i<$n; $i++) {
-        $data[] = [$min+($i*$range)/$n, $count[$i]];
+    for ($i = 0; $i < $n; $i++) {
+        $data[] = [$min + ($i*$range)/$n, $count[$i]];
     }
     if ($flops) {
         graph($data, 'runtime', 'Job runtime (hours)', 'job count');
@@ -314,7 +314,7 @@ 
 
 $batch = BoincBatch::lookup_id(get_int('batch_id'));
 if (!$batch) error_page('no batch');
-switch(get_str('action')) {
+switch (get_str('action')) {
 case 'err_host':
     err_host($batch);
     break;

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -217,7 +217,7 @@ 
             )
         );
     } else {
-        page_head("Batch $batch->id turnaround times");
+        page_head("batch $batch->id turnaround times");
         echo "<p>Turnaround times of completed jobs.<p>";
         $results = BoincResult::enum_fields(
             '(received_time-sent_time)/3600 as val',
@@ -265,7 +265,7 @@ 
 }
 
 function batch_graphs($batch) {
-    page_head("Batch $batch->id job times");
+    page_head("batch $batch->id job times");
     echo "
         <script type=\"text/javascript\" src=\"https://www.gstatic.com/charts/loader.js\"></script>
     ";
@@ -295,7 +295,7 @@ 
         }
     }
     arsort($x);
-    page_head("Batch $batch->id: completed jobs grouped by host");
+    page_head("batch $batch->id: completed jobs grouped by host");
     text_start();
     start_table();
     table_header('Host', 'OS', '# jobs');

html/inc/db_conn.inc

Spacing +9 added lines, -9 removed lines

@@ -22,12 +22,12 @@ 
 // Intended to be subclassed (e.g., BoincDb, BossaDb)
 //
 class DbConn {
-    var $db_conn;       // a mysqli object
-    var $db_name;       // the DB name
+    var $db_conn; // a mysqli object
+    var $db_name; // the DB name
 
     function init_conn($user, $passwd, $host, $name) {
         $x = explode(":", $host);
-        if (sizeof($x)>1) {
+        if (sizeof($x) > 1) {
             $host = $x[0];
             $port = $x[1];
         } else {
@@ -35,7 +35,7 @@ 
         }
         try {
             $this->db_conn = @new mysqli($host, $user, $passwd, $name, $port);
-        } catch(Exception $e) {
+        } catch (Exception $e) {
             return false;
         }
         if (mysqli_connect_error()) {
@@ -136,7 +136,7 @@ 
         return $this->enum_general($classname, $query);
     }
 
-    function enum($table, $classname, $where_clause=null, $order_clause=null) {
+    function enum($table, $classname, $where_clause = null, $order_clause = null) {
         return self::enum_fields(
             $table, $classname, '*', $where_clause, $order_clause
         );
@@ -146,7 +146,7 @@ 
         $query = "update DBNAME.$table set $clause where id=$obj->id";
         return $this->do_query($query);
     }
-    function update_aux($table, $clause, $where='') {
+    function update_aux($table, $clause, $where = '') {
         if ($where) $where = " where $where";
         $query = "update DBNAME.$table set $clause $where";
         return $this->do_query($query);
@@ -182,15 +182,15 @@ 
         if ($x) return (double)$x->$field;
         return false;
     }
-    function count($table, $clause="TRUE") {
+    function count($table, $clause = "TRUE") {
         $query = "select count(*) as total from DBNAME.$table where $clause";
         return $this->get_int($query, 'total');
     }
-    function sum($table, $field, $clause="") {
+    function sum($table, $field, $clause = "") {
         $query = "select sum($field) as total from DBNAME.$table $clause";
         return $this->get_double($query, 'total');
     }
-    function max($table, $field, $clause="") {
+    function max($table, $field, $clause = "") {
         $query = "select max($field) as total from DBNAME.$table $clause";
         return $this->get_double($query, 'total');
     }

html/inc/util_basic.inc

Spacing +7 added lines, -7 removed lines

@@ -56,10 +56,10 @@ 
     return file_exists("$d/stop_sched");
 }
 
-function xml_error($num=-1, $msg=null, $file=null, $line=null) {
+function xml_error($num = -1, $msg = null, $file = null, $line = null) {
     global $xml_outer_tag;
     if (!$msg) {
-        switch($num) {
+        switch ($num) {
         case -112: $msg = "Invalid XML"; break;
         case -136: $msg = "Not found"; break;
         case -137: $msg = "Name or email address is not unique"; break;
@@ -104,7 +104,7 @@ 
 // If it's a single-tag element, and it's present, just return the tag
 //
 function parse_element($xml, $tag) {
-    $closetag = "</" . substr($tag,1);
+    $closetag = "</".substr($tag, 1);
     $x = strstr($xml, $tag);
     if ($x) {
         if (strstr($tag, "/>")) return $tag;
@@ -120,8 +120,8 @@ 
 
 function parse_next_element($xml, $tag, &$cursor) {
     $element = null;
-    $closetag = "</" . substr($tag,1);
-    $pos = substr($xml,$cursor);
+    $closetag = "</".substr($tag, 1);
+    $pos = substr($xml, $cursor);
     $x = strstr($pos, $tag);
     if ($x) {
         if (strstr($tag, "/>")) return $tag;
@@ -203,7 +203,7 @@ 
 
 function time_str($x) {
     if ($x == 0) return "---";
-    return gmdate('j M Y, G:i:s', (int)$x) . " UTC";
+    return gmdate('j M Y, G:i:s', (int)$x)." UTC";
 }
 
 function local_time_str($x) {
@@ -241,7 +241,7 @@ 
 // ALSO: allow spaces.
 //
 function is_valid_filename($x) {
-    if (strlen($x)>255) return false;
+    if (strlen($x) > 255) return false;
     // \w means A-Za-z0-9_
     return preg_match('/^[\w\-. ]+$/', $x);
 }

html/inc/host.inc

Spacing +17 added lines, -17 removed lines

@@ -32,12 +32,12 @@ 
 
 function sched_log_name($x) {
     if ($x == 0) return "NO_SUCH_LOG";
-    return gmdate('Y-m-d_H/Y-m-d_H:i', $x) . ".txt";
+    return gmdate('Y-m-d_H/Y-m-d_H:i', $x).".txt";
 }
 
 function sched_log_link($x) {
     if (file_exists("sched_logs")) {
-        return "<a href=\"../sched_logs/" . sched_log_name($x) . "\">" . time_str($x) . "</a>";
+        return "<a href=\"../sched_logs/".sched_log_name($x)."\">".time_str($x)."</a>";
     } else {
         return time_str($x);
     }
@@ -45,7 +45,7 @@ 
 
 function location_form($host) {
     $none = "selected";
-    $h=$w=$s=$m="";
+    $h = $w = $s = $m = "";
     if ($host->venue == "home") $h = "selected";
     if ($host->venue == "work") $w = "selected";
     if ($host->venue == "school") $s = "selected";
@@ -99,7 +99,7 @@ 
             row2(tra("Product name"), $host->product_name);
         }
         $x = $host->timezone/3600;
-        if ($x >= 0) $x="+$x";
+        if ($x >= 0) $x = "+$x";
         row2(tra("Local Standard Time"), tra("UTC %1 hours", $x));
     } else {
         $owner = BoincUser::lookup_id($host->userid);
@@ -185,7 +185,7 @@ 
         }
         if (defined('BATCH_ACCEL') && BATCH_ACCEL) {
             row2('Low turnaround time?',
-                $host->error_rate?'yes':'no'
+                $host->error_rate ? 'yes' : 'no'
             );
         }
     }
@@ -261,8 +261,8 @@ 
     return sprintf(
         'Virtualbox %s<br>HW acceleration: %s<br>Enabled: %s',
         $v->version,
-        $v->hw_accel?'yes':'no',
-        $v->hw_accel_enabled?'yes':'no'
+        $v->hw_accel ? 'yes' : 'no',
+        $v->hw_accel_enabled ? 'yes' : 'no'
     );
 }
 
@@ -270,7 +270,7 @@ 
     if (empty($misc->docker)) return '---';
     $d = $misc->docker;
     $x = sprintf('%s version %s',
-        $d->type==1?"Docker":"Podman",
+        $d->type == 1 ? "Docker" : "Podman",
         $d->version
     );
     if (!empty($d->wsl_distro)) {
@@ -471,14 +471,14 @@ 
     if ($pos1 === false) return $x;
     $pos2 = strpos($model, ']');
     if ($pos2 === false) return $x;
-    $a = substr($model, $pos1+1, $pos2-$pos1-1);
+    $a = substr($model, $pos1 + 1, $pos2 - $pos1 - 1);
     $y = explode(" ", $a);
     if (count($y) == 0) return $x;
     if ($y[0] == "Family") {
         $x->info = $a;
     } else {
         $x->arch = $y[0];
-        $x->info = substr($a, strlen($y[0])+1);
+        $x->info = substr($a, strlen($y[0]) + 1);
     }
     return $x;
 }
@@ -567,7 +567,7 @@ 
     $avg_time = 0;
 
     $results = BoincResult::enum("hostid=$hostid order by received_time");
-    foreach($results as $result) {
+    foreach ($results as $result) {
         if ($result->granted_credit <= 0) continue;
         $total += $result->granted_credit;
 
@@ -660,7 +660,7 @@ 
 
 function link_url($sort, $rev, $show_all) {
     global $userid;
-    $x = $userid ? "&userid=$userid":"";
+    $x = $userid ? "&userid=$userid" : "";
     return "hosts_user.php?sort=$sort&rev=$rev&show_all=$show_all$x";
 }
 
@@ -734,7 +734,7 @@ 
 }
 
 function show_user_hosts($userid, $private, $show_all, $sort, $rev) {
-    $desc = false;  // whether the sort order's default is decreasing
+    $desc = false; // whether the sort order's default is decreasing
     switch ($sort) {
     case "total_credit": $sort_clause = "total_credit"; $desc = true; break;
     case "expavg_credit": $sort_clause = "expavg_credit"; $desc = true; break;
@@ -756,7 +756,7 @@ 
     more_or_less($sort, $rev, $show_all);
 
     $now = time();
-    $old_hosts=0;
+    $old_hosts = 0;
     $i = 1;
     $hosts = BoincHost::enum("userid=$userid order by $sort_clause limit 100");
     $any_product_name = false;
@@ -768,9 +768,9 @@ 
     }
     user_host_table_start($private, $sort, $rev, $show_all, $any_product_name);
     foreach ($hosts as $host) {
-        $is_old=false;
+        $is_old = false;
         if (($now - $host->rpc_time) > 30*86400) {
-            $is_old=true;
+            $is_old = true;
             $old_hosts++;
         }
         if (!$show_all && $is_old) continue;
@@ -779,7 +779,7 @@ 
     }
     end_table();
 
-    if ($old_hosts>0) {
+    if ($old_hosts > 0) {
         more_or_less($sort, $rev, $show_all);
     }
 

html/ops/hostinfo.php

Spacing +2 added lines, -2 removed lines

@@ -45,8 +45,8 @@
     $v = new StdClass;
     $v->version = $x[1];
     if (count($x) >= 4) {
-        $v->hw_accel = $x[2]?true:false;
-        $v->hw_accel_enabled = $x[3]?true:false;
+        $v->hw_accel = $x[2] ?true:false;
+        $v->hw_accel_enabled = $x[3] ?true:false;
     }
     return $v;
 }

html/ops/batch_accel.php

Braces +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 // accelerate batches if at least this frac done
 // can be set in project.inc
 //
-if (!defined('BATCH_ACCEL_MIN_FRAC_DONE')){
+if (!defined('BATCH_ACCEL_MIN_FRAC_DONE')) {
     define('BATCH_ACCEL_MIN_FRAC_DONE', .85);
 }
 

Spacing +3 added lines, -3 removed lines

@@ -29,7 +29,7 @@ 
 // accelerate batches if at least this frac done
 // can be set in project.inc
 //
-if (!defined('BATCH_ACCEL_MIN_FRAC_DONE')){
+if (!defined('BATCH_ACCEL_MIN_FRAC_DONE')) {
     define('BATCH_ACCEL_MIN_FRAC_DONE', .85);
 }
 
@@ -73,7 +73,7 @@ 
                         break;
                     case RESULT_SERVER_STATE_IN_PROGRESS:
                         $age = $now - $r->sent_time;
-                        if ($age<$batch->expire_time) {
+                        if ($age < $batch->expire_time) {
                             echo "   have recent in-progress result\n";
                             $make_another_result = false;
                         }
@@ -85,7 +85,7 @@ 
             if ($make_another_result) {
                 echo "   creating another instance\n";
                 $query[] = sprintf(
-                    'target_nresults=%d', $wu->target_nresults+1
+                    'target_nresults=%d', $wu->target_nresults + 1
                 );
                 $query[] = sprintf(
                     'transition_time=%f', $now