BOINC / boinc

html/ops/manage_special_users.php

Indentation +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
     WHERE CONVERT(special_user, DECIMAL) > 0 and prefs.userid=user.id"
 );
 for ($i=1; $i<=_mysql_num_rows($result); $i++){
-	$foo = _mysql_fetch_object($result);
+    $foo = _mysql_fetch_object($result);
     echo "<form action=\"manage_special_users_action.php\" method=\"POST\">\n";
     echo "<input type=\"hidden\" name=\"userid\" value=\"$foo->userid\"
         <tr><td>$foo->name ($foo->id)</td>

Braces +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
     FROM forum_preferences as prefs, user
     WHERE CONVERT(special_user, DECIMAL) > 0 and prefs.userid=user.id"
 );
-for ($i=1; $i<=_mysql_num_rows($result); $i++){
+for ($i=1; $i<=_mysql_num_rows($result); $i++) {
 	$foo = _mysql_fetch_object($result);
     echo "<form action=\"manage_special_users_action.php\" method=\"POST\">\n";
     echo "<input type=\"hidden\" name=\"userid\" value=\"$foo->userid\"

Spacing +5 added lines, -5 removed lines

@@ -27,8 +27,8 @@ 
 row1("Current special users", '9');
 
 echo "<tr><td>User</td>";
-for ($i=0; $i<S_NFLAGS; $i++) {
-    echo "<td width=\"15\">" . $special_user_bitfield[$i] . "</td>\n";
+for ($i = 0; $i < S_NFLAGS; $i++) {
+    echo "<td width=\"15\">".$special_user_bitfield[$i]."</td>\n";
 }
 echo "</tr>";
 
@@ -37,13 +37,13 @@ 
     FROM forum_preferences as prefs, user
     WHERE CONVERT(special_user, DECIMAL) > 0 and prefs.userid=user.id"
 );
-for ($i=1; $i<=_mysql_num_rows($result); $i++){
+for ($i = 1; $i <= _mysql_num_rows($result); $i++) {
 	$foo = _mysql_fetch_object($result);
     echo "<form action=\"manage_special_users_action.php\" method=\"POST\">\n";
     echo "<input type=\"hidden\" name=\"userid\" value=\"$foo->userid\"
         <tr><td>$foo->name ($foo->id)</td>
     ";
-    for ($j=0; $j<S_NFLAGS; $j++) {
+    for ($j = 0; $j < S_NFLAGS; $j++) {
         $bit = substr($foo->special_user, $j, 1);
         echo "<td><input type=\"checkbox\" name=\"role".$j."\" value=\"1\"";
         if ($bit == 1) {
@@ -58,7 +58,7 @@ 
 echo "<tr><form action=\"manage_special_users_action.php\" method=\"POST\">\n";
 echo "<td>Add UserID:<input type=\"text\" name=\"userid\" size=\"6\"></td>";
 
-for ($j=0; $j<S_NFLAGS; $j++) {
+for ($j = 0; $j < S_NFLAGS; $j++) {
     echo "<td><input type=\"checkbox\" name=\"role".$j."\" value=\"1\"";
     echo "></td>\n";
 }

html/ops/grant_credit.php

Spacing +5 added lines, -5 removed lines

@@ -49,7 +49,7 @@ 
 }
 
 function grant_credits_for_wu($wuid) {
-    $max_credit=300;
+    $max_credit = 300;
     $ndone = 0;
     $query_r = _mysql_query("select * from result where granted_credit=0 and claimed_credit>0 and workunitid=$wuid");
  
@@ -66,8 +66,8 @@ 
         $user    = _mysql_fetch_object($query_u);
 
         $credit = $result->claimed_credit;
-        if ($credit>$max_credit) {
-            $credit=$max_credit;
+        if ($credit > $max_credit) {
+            $credit = $max_credit;
             echo " WARNING: USER $user->name ($userid) CLAIMED $result->claimed_credit CREDITS (getting $credit)!";
         }
         $user->total_credit += $credit;
@@ -106,8 +106,8 @@ 
 }
 
 function grant_credits_for_cancelled() {
-    $ngranted=0;
-    $query_w  = _mysql_query("select * from workunit where error_mask!=0");
+    $ngranted = 0;
+    $query_w = _mysql_query("select * from workunit where error_mask!=0");
     while (($workunit = _mysql_fetch_object($query_w))) {
         // echo "Starting WU $workunit->id\n";
         $ngranted += grant_credits_for_wu($workunit->id);

Braces +1 added lines, -2 removed lines

@@ -41,8 +41,7 @@
 function testquery($argstring) {
     if (0) {
         echo "WOULD DO: $argstring\n";
-    }
-    else {
+    } else {
         _mysql_query($argstring);
     }
     return;

html/ops/news_convert.php

Spacing +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
     $content = str_replace("\n", " ", $content);
     $content = _mysql_escape_string($content);
 
-    $thread_id  = BoincThread::insert("(forum, owner, title, create_time, timestamp, replies) values ($forum_id, $user->id, '$title', $when, $when, 0)");
+    $thread_id = BoincThread::insert("(forum, owner, title, create_time, timestamp, replies) values ($forum_id, $user->id, '$title', $when, $when, 0)");
     if (!$thread_id) {
         echo "thread insert failed\n";
         echo "title: [$title]\n";

html/ops/remind.php

Spacing +4 added lines, -4 removed lines

@@ -82,7 +82,7 @@ 
 $globals->userid = 0;
 $globals->count = -1;
 
-for ($i=1; $i<$argc; $i++) {
+for ($i = 1; $i < $argc; $i++) {
     if ($argv[$i] == "--failed") {
         $globals->do_failed = true;
     } elseif ($argv[$i] == "--lapsed") {
@@ -189,7 +189,7 @@ 
         number_format($user->total_credit, 0),
         opt_out_url($user),
         $user->id,
-        floor ((time() - last_rpc_time($user)) / 86400),
+        floor((time() - last_rpc_time($user))/86400),
     );
     return preg_replace($pat, $rep, $template);
 }
@@ -240,7 +240,7 @@ 
     $result = _mysql_query($query);
     $t = 0;
     while ($r = _mysql_fetch_object($result)) {
-        if ($r->email_type !=2 && $r->email_type != 3) continue;
+        if ($r->email_type != 2 && $r->email_type != 3) continue;
         if ($r->time_sent > $t) $t = $r->time_sent;
 
     }
@@ -268,7 +268,7 @@ 
     if ($globals->explain) {
         $x = (time() - $user->create_time)/86400;
         $t = last_rpc_time($user);
-        $show_lapsed_interval = (time()-$t)/86400;
+        $show_lapsed_interval = (time() - $t)/86400;
         echo "user $user->id ($user->email_addr) was created $x days ago\n";
         echo "  total_credit: $user->total_credit; last RPC $show_lapsed_interval days ago\n";
         echo "  sending $do_type email\n";

html/inc/recaptchalib.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
 
 function boinc_recaptcha_get_html($publickey) {
     if ($publickey) {
-        return '<div class="g-recaptcha" data-sitekey="' . $publickey . '"></div>';
+        return '<div class="g-recaptcha" data-sitekey="'.$publickey.'"></div>';
     } else {
         return '';
     }

html/inc/forum_db.inc

Indentation +1 added lines, -1 removed lines

@@ -164,7 +164,7 @@
         $user->prefs = $prefs;
     }
     function privilege($specialbit) {
-         return (substr($this->special_user, $specialbit,1)==1);
+            return (substr($this->special_user, $specialbit,1)==1);
     }
     function update($clause) {
         $db = BoincDb::get();

Braces +1 added lines, -1 removed lines

@@ -215,7 +215,7 @@
         //
         $fl = BoincForumLogging::lookup(0, 0);
         if ($fl) {
-            if ($fl->timestamp<time()-MAX_FORUM_LOGGING_TIME){
+            if ($fl->timestamp<time()-MAX_FORUM_LOGGING_TIME) {
                 BoincForumLogging::delete_aux("timestamp<'".(time()-MAX_FORUM_LOGGING_TIME)."' and userid != 0");
                 BoincForumLogging::replace(0, 0, time());
             }

Spacing +12 added lines, -12 removed lines

@@ -27,7 +27,7 @@ 
         $db = BoincDb::get();
         return $db->lookup('category', 'BoincCategory', $clause);
     }
-    static function enum($clause=null) {
+    static function enum($clause = null) {
         $db = BoincDb::get();
         return $db->enum('category', 'BoincCategory', $clause);
     }
@@ -78,7 +78,7 @@ 
         $db = BoincDb::get();
         return $db->update($this, 'thread', $clause);
     }
-    static function enum($clause="") {
+    static function enum($clause = "") {
         $db = BoincDb::get();
         return $db->enum('thread', 'BoincThread', $clause);
     }
@@ -142,7 +142,7 @@ 
         $db = BoincDb::get();
         $ret = $db->insert('forum_preferences', $clause);
     }
-    static function lookup(&$user, $nocache=false) {
+    static function lookup(&$user, $nocache = false) {
         if (!$user) return;
         if (isset($user->prefs)) return;
         if (!$nocache && isset(self::$cache[$user->id])) {
@@ -164,7 +164,7 @@ 
         $user->prefs = $prefs;
     }
     function privilege($specialbit) {
-         return (substr($this->special_user, $specialbit,1)==1);
+         return (substr($this->special_user, $specialbit, 1) == 1);
     }
     function update($clause) {
         $db = BoincDb::get();
@@ -175,7 +175,7 @@ 
         $db = BoincDb::get();
         return $db->delete_aux('forum_preferences', "userid=$this->userid");
     }
-    static function enum($clause=null) {
+    static function enum($clause = null) {
         $db = BoincDb::get();
         return $db->enum('forum_preferences', 'BoincForumPrefs', $clause);
     }
@@ -215,8 +215,8 @@ 
         //
         $fl = BoincForumLogging::lookup(0, 0);
         if ($fl) {
-            if ($fl->timestamp<time()-MAX_FORUM_LOGGING_TIME){
-                BoincForumLogging::delete_aux("timestamp<'".(time()-MAX_FORUM_LOGGING_TIME)."' and userid != 0");
+            if ($fl->timestamp < time() - MAX_FORUM_LOGGING_TIME) {
+                BoincForumLogging::delete_aux("timestamp<'".(time() - MAX_FORUM_LOGGING_TIME)."' and userid != 0");
                 BoincForumLogging::replace(0, 0, time());
             }
         } else {
@@ -326,10 +326,10 @@ 
     }
 }
 
-define ('NOTIFY_FRIEND_REQ', 1);
-define ('NOTIFY_FRIEND_ACCEPT', 2);
-define ('NOTIFY_PM', 3);
-define ('NOTIFY_SUBSCRIBED_THREAD', 4);
-define ('NOTIFY_SUBSCRIBED_FORUM', 5);
+define('NOTIFY_FRIEND_REQ', 1);
+define('NOTIFY_FRIEND_ACCEPT', 2);
+define('NOTIFY_PM', 3);
+define('NOTIFY_SUBSCRIBED_THREAD', 4);
+define('NOTIFY_SUBSCRIBED_FORUM', 5);
 
 ?>

html/inc/credit.inc

Spacing +3 added lines, -3 removed lines

@@ -24,13 +24,13 @@
 function update_average($now, $work_start_time, $work, &$avg, &$avg_time) {
     if ($avg_time) {
         $diff = $now - $avg_time;
-        if ($diff <0) $diff = 0;
+        if ($diff < 0) $diff = 0;
         $diff_days = $diff/86400;
         $weight = exp(-$diff*M_LN2/CREDIT_HALF_LIFE);
         $avg *= $weight;
 
-        if ((1.0-$weight)>0.000001) {
-            $avg += (1.0-$weight)*($work/$diff_days);
+        if ((1.0 - $weight) > 0.000001) {
+            $avg += (1.0 - $weight)*($work/$diff_days);
         }
         else {
             $avg += M_LN2*$work*86400/CREDIT_HALF_LIFE;

Braces +1 added lines, -2 removed lines

@@ -31,8 +31,7 @@
 
         if ((1.0-$weight)>0.000001) {
             $avg += (1.0-$weight)*($work/$diff_days);
-        }
-        else {
+        } else {
             $avg += M_LN2*$work*86400/CREDIT_HALF_LIFE;
         }
     } else if ($work) {

html/inc/util_ops.inc

Indentation +2 added lines, -2 removed lines

@@ -62,7 +62,7 @@ 
 
 function print_text_field($text,$name,$value) {
     echo "$text <input type=\"text\" size=\"10\" name=\"$name\" value=\"$value\">\n"
-         . "<p>\n";
+            . "<p>\n";
 }
 
 function row($x, $y) {
@@ -378,7 +378,7 @@ 
         $db->do_query($q4);
         return 2;
     } else if (!$db->do_query($q3)) {
-      echo "MySQL command '$q3' failed:<br/>unable to cancel workunits and trigger transitioner.<br>\n";
+        echo "MySQL command '$q3' failed:<br/>unable to cancel workunits and trigger transitioner.<br>\n";
         $db->do_query($q4);
         return 3;
     }

Spacing +10 added lines, -10 removed lines

@@ -46,21 +46,21 @@ 
 
 // TODO: get rid of all the following
 
-function print_checkbox($text,$name,$checked) {
+function print_checkbox($text, $name, $checked) {
     echo "<input type=\"checkbox\" name=\"$name\""
-        . (strlen($checked) ? " checked=\"checked\"" : "") . ">"
+        . (strlen($checked) ? " checked=\"checked\"" : "").">"
         . "$text\n"
         . "<p>\n";
 }
 
-function print_radio_button($text,$name,$value,$checked) {
+function print_radio_button($text, $name, $value, $checked) {
     echo "<input type=\"radio\" name=\"$name\" value=\"$value\""
-        . (strlen($checked) ? " checked=\"checked\"" : "") . ">"
+        . (strlen($checked) ? " checked=\"checked\"" : "").">"
         . "$text\n"
         . "<br>\n";
 }
 
-function print_text_field($text,$name,$value) {
+function print_text_field($text, $name, $value) {
     echo "$text <input type=\"text\" size=\"10\" name=\"$name\" value=\"$value\">\n"
          . "<p>\n";
 }
@@ -91,7 +91,7 @@ 
     if ($host == null) {
         $host = "localhost";
     }
-    $in = fopen("php://stdin","r");
+    $in = fopen("php://stdin", "r");
     print "Database username (default: owner of mysqld process): ";
     $user = rtrim(fgets($in, 80));
     print "Database password (if any): ";
@@ -103,7 +103,7 @@ 
     }
 }
 
-function print_login_form_ops($next_url='') {
+function print_login_form_ops($next_url = '') {
     if ($next_url == '') $next_url = $_SERVER['REQUEST_URI'];
     start_table();
     echo "
@@ -200,7 +200,7 @@ 
 // return a list of the current, non-deprecated ones
 //
 function current_versions($avs) {
-    foreach($avs as $av) {
+    foreach ($avs as $av) {
         foreach ($avs as $av2) {
             if ($av->id == $av2->id) continue;
             if ($av->platformid == $av2->platformid && $av->plan_class == $av2->plan_class && $av->version_num > $av2->version_num) {
@@ -209,7 +209,7 @@ 
         }
     }
     $x = array();
-    foreach($avs as $av) {
+    foreach ($avs as $av) {
         if (!$av->deprecated) $x[] = $av;
     }
     return $x;
@@ -321,7 +321,7 @@ 
 //
 function unassign_badges($is_user, $item, $badges, $k) {
     $list = null;
-    for ($i=0; $i<count($badges); $i++) {
+    for ($i = 0; $i < count($badges); $i++) {
         if ($i == $k) continue;
         $badge = $badges[$i];
         if ($list) {

html/inc/uotd.inc

Spacing +15 added lines, -15 removed lines

@@ -98,11 +98,11 @@ 
         $u->email_addr = UOTD_ADMIN_EMAIL;
         $u->name = "UOTD admin";
         send_email($u,
-            PROJECT . ": User of the Day pool is running low!",
+            PROJECT.": User of the Day pool is running low!",
             "The pool of approved candidates for User of the Day has".
-            " reached your assigned threshold: there are now only " . $result->num_rows . " approved users.\n\n".
+            " reached your assigned threshold: there are now only ".$result->num_rows." approved users.\n\n".
             "To approve more candidates for User of the Day,".
-            " go to the " . PROJECT . " administration page and click \"Screen user profiles\""
+            " go to the ".PROJECT." administration page and click \"Screen user profiles\""
         );
     }
 
@@ -147,10 +147,10 @@ 
     $profile->update("uotd_time = ".time());
 
     send_email($user,
-        "You're the " . PROJECT . " user of the day!",
+        "You're the ".PROJECT." user of the day!",
         "Congratulations!\n\nYou've been chosen as the "
-        . PROJECT . " user of the day!
-        Your profile will be featured on the " . PROJECT . " website for the next 24 hours."
+        . PROJECT." user of the day!
+        Your profile will be featured on the " . PROJECT." website for the next 24 hours."
     );
     echo "Chose user $user->id as UOTD\n";
 
@@ -161,7 +161,7 @@ 
 // To override this with your own policy, create a similar function in
 // your own project.inc called uotd_candidates_query()
 //
-function default_uotd_candidates_query(){
+function default_uotd_candidates_query() {
     $query = "SELECT * FROM profile,user WHERE profile.userid=user.id ";
     $query .= " AND verification=1 ";
     $query .= " AND expavg_credit>1 ";
@@ -173,8 +173,8 @@ 
 // get a list of profiles that have been 'approved' for UOTD,
 // using a project-specific query if supplied in project.inc
 //
-function count_uotd_candidates(){
-    $n = -1;                    // negative value returned on error
+function count_uotd_candidates() {
+    $n = -1; // negative value returned on error
     if (function_exists('uotd_candidates_query')) {
         $query = uotd_candidates_query();
     } else {
@@ -183,7 +183,7 @@ 
     
     $db = BoincDb::get();
     $result = $db->do_query($query);
-    if($result) {
+    if ($result) {
         $n = $result->num_rows;
     }
     $result->free();
@@ -195,15 +195,15 @@ 
 //
 function generate_uotd_gadget($profile, $user) {
     $x = "<font size='2'>\n";
-    $gadget =  PROFILE_PATH."uotd_gadget.html";
-    if( $h = fopen($gadget, "w") ){
-        $age = time()-$profile->uotd_time;
+    $gadget = PROFILE_PATH."uotd_gadget.html";
+    if ($h = fopen($gadget, "w")) {
+        $age = time() - $profile->uotd_time;
         echo "age: $age";
-        if($age <= 86400+3600) { // allow for slop
+        if ($age <= 86400 + 3600) { // allow for slop
             $x .= uotd_thumbnail($profile, $user);
             $x .= user_links($user, BADGE_HEIGHT_MEDIUM);
             $resp = sanitize_tags(output_transform($profile->response1));
-            $x .= "&nbsp;&nbsp;". sub_sentence($resp, ' ', 250, true);
+            $x .= "&nbsp;&nbsp;".sub_sentence($resp, ' ', 250, true);
         }
         else {
             $x .= "<font color='fuscia'>

Braces +6 added lines, -6 removed lines

@@ -161,7 +161,7 @@ 
 // To override this with your own policy, create a similar function in
 // your own project.inc called uotd_candidates_query()
 //
-function default_uotd_candidates_query(){
+function default_uotd_candidates_query() {
     $query = "SELECT * FROM profile,user WHERE profile.userid=user.id ";
     $query .= " AND verification=1 ";
     $query .= " AND expavg_credit>1 ";
@@ -173,7 +173,7 @@ 
 // get a list of profiles that have been 'approved' for UOTD,
 // using a project-specific query if supplied in project.inc
 //
-function count_uotd_candidates(){
+function count_uotd_candidates() {
     $n = -1;                    // negative value returned on error
     if (function_exists('uotd_candidates_query')) {
         $query = uotd_candidates_query();
@@ -196,16 +196,16 @@ 
 function generate_uotd_gadget($profile, $user) {
     $x = "<font size='2'>\n";
     $gadget =  PROFILE_PATH."uotd_gadget.html";
-    if( $h = fopen($gadget, "w") ){
+    if( $h = fopen($gadget, "w") ) {
         $age = time()-$profile->uotd_time;
         echo "age: $age";
-        if($age <= 86400+3600) { // allow for slop
+        if($age <= 86400+3600) {
+// allow for slop
             $x .= uotd_thumbnail($profile, $user);
             $x .= user_links($user, BADGE_HEIGHT_MEDIUM);
             $resp = sanitize_tags(output_transform($profile->response1));
             $x .= "&nbsp;&nbsp;". sub_sentence($resp, ' ', 250, true);
-        }
-        else {
+        } else {
             $x .= "<font color='fuscia'>
                 There is no User of the Day today.
                 Only volunteers who have created a Profile