BOINC / boinc

html/user/sandbox.php

Spacing +1 added lines, -1 removed lines

@@ -169,7 +169,7 @@
     $notice = "";
     $dir = sandbox_dir($user);
     $count = count($_FILES['new_file']['tmp_name']);
-    for ($i=0; $i<$count; $i++) {
+    for ($i = 0; $i < $count; $i++) {
         $tmp_name = $_FILES['new_file']['tmp_name'][$i];
         if (!is_uploaded_file($tmp_name)) {
             error_page("$tmp_name is not uploaded file");

html/inc/sandbox.inc

Spacing +4 added lines, -4 removed lines

@@ -91,7 +91,7 @@ 
 // return list of files matching given pattern,
 // in the format used for form_select() and form_select_multiple()
 //
-function sandbox_select_items($user, $pattern=null) {
+function sandbox_select_items($user, $pattern = null) {
     $sbfiles = sandbox_file_names($user);
     $sbitems = [];
     foreach ($sbfiles as $f) {
@@ -112,7 +112,7 @@ 
     }
     $files = sandbox_file_names($user);
     foreach ($files as $f) {
-        if ($regexp && !preg_match("/$regexp/",$f)) continue;
+        if ($regexp && !preg_match("/$regexp/", $f)) continue;
         $x .= "<option value=\"$f\">$f</option>\n";
     }
     $x .= "</select>\n";
@@ -160,8 +160,8 @@ 
             '%s <a href="%s&sort_field=%s&sort_rev=%d">%s</a>',
             $title,
             $url, $sort_field,
-            $sort_rev?0:1,
-            $sort_rev?'&uarr;':'&darr;'
+            $sort_rev ? 0 : 1,
+            $sort_rev ? '&uarr;' : '&darr;'
         );
     } else {
         return sprintf(

html/user/buda_submit.php

Spacing +5 added lines, -5 removed lines

@@ -61,7 +61,7 @@ 
 //
 function unzip_batch_file($user, $batch_file) {
     @mkdir("../../buda_batches");
-    for ($i=0; $i<1000; $i++) {
+    for ($i = 0; $i < 1000; $i++) {
         $batch_dir = "../../buda_batches/$i";
         $batch_dir_name = $i;
         $ret = @mkdir($batch_dir);
@@ -112,7 +112,7 @@ 
         }
         $job_files = [];
         $cmdline = '';
-        foreach(scandir("$batch_dir/$fname") as $f2) {
+        foreach (scandir("$batch_dir/$fname") as $f2) {
             if ($f2[0] == '.') continue;
             if ($f2 == 'cmdline') {
                 $cmdline = trim(file_get_contents("$batch_dir/$fname/cmdline"));
@@ -162,7 +162,7 @@ 
 function stage_input_files($batch_dir, $batch_desc, $batch_id) {
     $n = count($batch_desc->shared_files);
     $batch_desc->shared_files_phys_names = [];
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $path = sprintf('%s/%s', $batch_dir, $batch_desc->shared_files[$i]);
         [$md5, $size] = $batch_desc->shared_file_infos[$i];
         $phys_name = sprintf('batch_%d_%s', $batch_id, $md5);
@@ -172,7 +172,7 @@ 
     foreach ($batch_desc->jobs as $job) {
         $n = count($batch_desc->unshared_files);
         $job->phys_names = [];
-        for ($i=0; $i<$n; $i++) {
+        for ($i = 0; $i < $n; $i++) {
             $path = sprintf('%s/%s/%s',
                 $batch_dir, $job->dir, $batch_desc->unshared_files[$i]
             );
@@ -220,7 +220,7 @@ 
     }
     $cw_cmdline = sprintf('"--dockerfile %s %s %s"',
         $variant_desc->dockerfile,
-        $wrapper_verbose?'--verbose':'',
+        $wrapper_verbose ? '--verbose' : '',
         $cmdline
     );
     $cmd = sprintf(

html/user/buda.php

Spacing +3 added lines, -3 removed lines

@@ -32,7 +32,7 @@ 
 // show list of BUDA apps and variants,
 // w/ buttons for adding and deleting
 //
-function app_list($notice=null) {
+function app_list($notice = null) {
     global $buda_root;
     if (!is_dir($buda_root)) {
         mkdir($buda_root);
@@ -96,7 +96,7 @@ 
     $dir = "$buda_root/$app/$variant";
     start_table();
     table_header('name', 'size', 'md5');
-    foreach(scandir($dir) as $f) {
+    foreach (scandir($dir) as $f) {
         if ($f[0] == '.') continue;
         [$md5, $size] = parse_info_file("$dir/.md5/$f");
         table_row(
@@ -172,7 +172,7 @@ 
     //
     $x = "<input_template>\n";
     $ninfiles = 1 + count($variant_desc->input_file_names) + count($variant_desc->app_files);
-    for ($i=0; $i<$ninfiles; $i++) {
+    for ($i = 0; $i < $ninfiles; $i++) {
         $x .= "   <file_info>\n      <no_delete/>\n   </file_info>\n";
     }
     $x .= "   <workunit>\n";

html/inc/prefs_project.inc

Spacing +19 added lines, -19 removed lines

@@ -70,7 +70,7 @@ 
 }
 
 if ($app_types->cpu) {
-    $project_pref_descs[] = new PREF_BOOL (
+    $project_pref_descs[] = new PREF_BOOL(
         tra("Allow CPU-only tasks"),
         "Request CPU-only tasks from this project.",
         "no_cpu",
@@ -79,7 +79,7 @@ 
     );
 }
 if ($app_types->ati) {
-    $project_pref_descs[] = new PREF_BOOL (
+    $project_pref_descs[] = new PREF_BOOL(
         tra("Use AMD GPU"),
         "Request AMD GPU tasks from this project.",
         "no_ati",
@@ -88,7 +88,7 @@ 
     );
 }
 if ($app_types->cuda) {
-    $project_pref_descs[] = new PREF_BOOL (
+    $project_pref_descs[] = new PREF_BOOL(
         tra("Use NVIDIA GPU"),
         "Request NVIDIA GPU tasks from this project.",
         "no_cuda",
@@ -97,7 +97,7 @@ 
     );
 }
 if ($app_types->intel_gpu) {
-    $project_pref_descs[] = new PREF_BOOL (
+    $project_pref_descs[] = new PREF_BOOL(
         tra("Use Intel GPU"),
         "Request Intel GPU tasks from this project.",
         "no_intel_gpu",
@@ -106,7 +106,7 @@ 
     );
 }
 if ($app_types->apple_gpu) {
-    $project_pref_descs[] = new PREF_BOOL (
+    $project_pref_descs[] = new PREF_BOOL(
         tra("Use Apple GPU"),
         "Request Apple GPU tasks from this project.",
         "no_apple_gpu",
@@ -131,7 +131,7 @@ 
     $x = "";
 }
 
-$privacy_pref_descs = array (
+$privacy_pref_descs = array(
     new PREF_BOOL(
         tra("Is it OK for %1 and your team (if any) to email you?", PROJECT).$x,
         "",
@@ -179,7 +179,7 @@ 
     global $in_project_specific;
     global $venue_name;
 
-    switch($name) {
+    switch ($name) {
     case "venue":
         $venue_name = $attrs["name"];
         $top_parse_result = $parse_result;
@@ -191,7 +191,7 @@ 
         break;
     default:
         if ($in_project_specific) {
-            $text= $text."<$name>";
+            $text = $text."<$name>";
         } else {
             $text = "";
         }
@@ -206,12 +206,12 @@ 
     global $venue_name;
     global $project_pref_descs;
 
-    foreach($project_pref_descs as $p) {
+    foreach ($project_pref_descs as $p) {
         if ($p->xml_parse($parse_result, $name, $text)) {
             return;
         }
     }
-    switch($name) {
+    switch ($name) {
     case "venue":
         $top_parse_result->$venue_name = $parse_result;
         $parse_result = $top_parse_result;
@@ -255,7 +255,7 @@ 
     return $parse_result;
 }
 
-function prefs_show_project($prefs, $columns=false) {
+function prefs_show_project($prefs, $columns = false) {
     global $project_pref_descs;
     if ($columns) {
         foreach ($project_pref_descs as $p) {
@@ -294,7 +294,7 @@ 
     }
 }
 
-function prefs_show_project_specific($prefs, $columns=false) {
+function prefs_show_project_specific($prefs, $columns = false) {
     if ($columns) {
         $project_specific_prefs = project_specific_prefs_parse($prefs->project_specific);
         $project_specific_prefs->home = isset($prefs->home) ? project_specific_prefs_parse($prefs->home->project_specific) : "";
@@ -306,10 +306,10 @@ 
     project_specific_prefs_show($project_specific_prefs, $columns);
 }
 
-function print_prefs_display_project($user, $columns=false) {
+function print_prefs_display_project($user, $columns = false) {
     $project_prefs = prefs_parse_project($user->project_prefs);
 
-    $switch_link = " <font size=\"-1\"><a href=prefs.php?subset=project&cols=". (int)!$columns .">".tra("(Switch View)")."</a></font>";
+    $switch_link = " <font size=\"-1\"><a href=prefs.php?subset=project&cols=".(int)!$columns.">".tra("(Switch View)")."</a></font>";
     if ($columns) {
         start_table();
         row_heading(tra("Combined preferences").$switch_link);
@@ -360,14 +360,14 @@ 
     }
 }
 
-function prefs_form_project($prefs, $error=false) {
+function prefs_form_project($prefs, $error = false) {
     global $project_pref_descs;
     foreach ($project_pref_descs as $p) {
         $p->show_form_row($prefs, $error);
     }
 }
 
-function prefs_form_project_specific($prefs_xml, $error=false) {
+function prefs_form_project_specific($prefs_xml, $error = false) {
     $prefs = project_specific_prefs_parse($prefs_xml);
     project_specific_prefs_edit($prefs, $error);
 }
@@ -415,7 +415,7 @@ 
 
 // given a prefs structure, return the corresponding XML string
 //
-function project_prefs_make_xml($prefs, $primary=true) {
+function project_prefs_make_xml($prefs, $primary = true) {
     global $project_pref_descs;
     $xml = "";
     if ($primary) {
@@ -450,8 +450,8 @@ 
 //
 function project_prefs_update(&$user, $prefs) {
     $prefs_xml = BoincDb::escape_string(project_prefs_make_xml($prefs));
-    $send_email = $user->send_email?1:0;
-    $show_hosts = $user->show_hosts?1:0;
+    $send_email = $user->send_email ? 1 : 0;
+    $show_hosts = $user->show_hosts ? 1 : 0;
     $retval = $user->update("project_prefs='$prefs_xml', send_email=$send_email, show_hosts=$show_hosts");
     if (!$retval) {
         return 1;

html/ops/cancel_wu_action.php

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
 $wuid2 = get_int('wuid2');
 $unsent_only = get_str('unsent_only', true);
 
-if ($wuid1<1 || $wuid2<$wuid1) {
+if ($wuid1 < 1 || $wuid2 < $wuid1) {
     admin_error_page(
         "<h2>Workunit IDs fail to satisfy the conditions:<p> 0 < ID1 <= ID2"
     );

html/ops/profile_screen_action.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 db_init();
 
 admin_page_head("screen profile action");
-for ($i=0; $i<$n; $i++) {
+for ($i = 0; $i < $n; $i++) {
     $y = "user".$i;
     $val = $_GET[$y];
     $x = "userid".$i;

html/ops/manage_user.php

Spacing +23 added lines, -23 removed lines

@@ -39,8 +39,8 @@ 
 
 // Delete a user if they have no credit, results, or posts
 //
-function possibly_delete_user($user){
-    if ($user->total_credit > 0.0){
+function possibly_delete_user($user) {
+    if ($user->total_credit > 0.0) {
         admin_error_page("Cannot delete user: User has credit.");
     }
 
@@ -56,7 +56,7 @@ 
         admin_error_page("Cannot delete user: User has forum posts.");
     }
 
-    if ($user->teamid){
+    if ($user->teamid) {
         user_quit_team($user);
     }
     delete_user($user);
@@ -67,8 +67,8 @@ 
 function handle_special_user($user) {
     global $special_user_bitfield;
     $Nbf = sizeof($special_user_bitfield);
-    $bits="";
-    for ($i=0; $i<$Nbf; $i++) {
+    $bits = "";
+    for ($i = 0; $i < $Nbf; $i++) {
         $key = "special_user_$i";
         if (array_key_exists($key, $_POST) && $_POST[$key]) {
             $bits .= "1";
@@ -94,35 +94,35 @@ 
         );
     } else {
         if (is_numeric($dt)) {
-            $t = $dt>0 ? time()+$dt : 0;
+            $t = $dt > 0 ? time() + $dt : 0;
             $q = "UPDATE forum_preferences SET banished_until=$t WHERE userid=$user->id";
             _mysql_query($q);
 
             // put a timestamp in wiki to trigger re-validation of credentials
 
-            if (function_exists('touch_wiki_user')){
+            if (function_exists('touch_wiki_user')) {
                 touch_wiki_user($user);
             }
 
             // Send suspension e-mail to user and administrators
 
-            if ($dt>0) {
-                $subject = PROJECT." posting privileges suspended for ". $user->name;
+            if ($dt > 0) {
+                $subject = PROJECT." posting privileges suspended for ".$user->name;
                 $body = "
-Forum posting privileges for the " .PROJECT. " user \"".$user->name."\"
-have been suspended for " .time_diff($dt). " by ".$g_logged_in_user->name.".
+Forum posting privileges for the " .PROJECT." user \"".$user->name."\"
+have been suspended for " .time_diff($dt)." by ".$g_logged_in_user->name.".
 The reason given was:
 
 $reason
 
-The suspension will end at " .time_str($t)."\n";
+The suspension will end at ".time_str($t)."\n";
             } else {
-                $subject = PROJECT." user ". $user->name. " unsuspended";
+                $subject = PROJECT." user ".$user->name." unsuspended";
                 $body = "
-Forum posting privileges for the " .PROJECT. " user \"".$user->name."\"
+Forum posting privileges for the " .PROJECT." user \"".$user->name."\"
 have been restored by ".$g_logged_in_user->name."\n";
                 if ($reason) {
-                    $body.="The reason given was:\n\n   $reason\n";
+                    $body .= "The reason given was:\n\n   $reason\n";
                 }
             }
 
@@ -186,13 +186,13 @@ 
     row1("Special User Status");
 
     echo "<tr>\n";
-    for ($i=0; $i<$Nbf; $i++) {
+    for ($i = 0; $i < $Nbf; $i++) {
         $bit = substr($user->prefs->special_user, $i, 1);
         echo "<tr><td><input type='checkbox'' name='special_user_".$i."' value='1'";
         if ($bit == 1) {
             echo " checked='checked'";
         }
-        echo ">". $special_user_bitfield[$i] ."</td></tr>\n";
+        echo ">".$special_user_bitfield[$i]."</td></tr>\n";
     }
     echo "</tr>";
 
@@ -217,10 +217,10 @@ 
     if ($user->prefs->banished_until) {
         $dt = $user->prefs->banished_until - time();
         if ($dt > 0) {
-            $x = " Suspended until " . time_str($user->prefs->banished_until)
-                ."<br/> (Expires in " . time_diff($dt) .")" ;
+            $x = " Suspended until ".time_str($user->prefs->banished_until)
+                ."<br/> (Expires in ".time_diff($dt).")";
         } else {
-            $x = " last suspended " . time_str($user->prefs->banished_until);
+            $x = " last suspended ".time_str($user->prefs->banished_until);
         }
         row1($x);
     } else {
@@ -238,11 +238,11 @@ 
     ";
     echo "
         <input type='radio' name='suspend_for' value='172800'> 48 hours  <br/>
-        <input type='radio' name='suspend_for' value='",86400*7,"'> 1 week  <br/>
-        <input type='radio' name='suspend_for' value='",86400*14,"'> 2 weeks  <br/>
+        <input type='radio' name='suspend_for' value='",86400*7, "'> 1 week  <br/>
+        <input type='radio' name='suspend_for' value='",86400*14, "'> 2 weeks  <br/>
     ";
 
-    if ($dt>0) {
+    if ($dt > 0) {
         echo "
             <input type='radio' name='suspend_for' value='-1'>  <b>unsuspend</b>   <br/>";
     }

html/ops/index.php

Spacing +2 added lines, -2 removed lines

@@ -155,7 +155,7 @@ 
 $apps = BoincApp::enum("");
 foreach ($apps as $app) {
     if (in_array($app->id, $show_only)
-       || ( in_array("all", $show_only)
+       || (in_array("all", $show_only)
           && (!$app->deprecated || $show_deprecated)
     )) {
 
@@ -163,7 +163,7 @@ 
             <b>Results for <tt>$app->name</tt>:</b>
             <ul>
 ";
-        for ($i=0; $i<2; $i++) {
+        for ($i = 0; $i < 2; $i++) {
             if ($i) {
                 $secs = 7*86400;
                 $period = "&nbsp;&nbsp;&nbsp;7 days";