BOINC / boinc

html/user/openid_login.php

Spacing +3 added lines, -3 removed lines

@@ -16,7 +16,7 @@ 
 // You should have received a copy of the GNU Lesser General Public License
 // along with BOINC.  If not, see <http://www.gnu.org/licenses/>.
 
-NOT FINISHED.   DON'T USE
+NOT FINISHED.DON'T USE
 
 require 'openid.php';
 include_once("../inc/boinc_db.inc");
@@ -26,14 +26,14 @@ 
 
 function show_error($str) {
     page_head("Can't create account");
-    echo "$str<br>\n";
+    echo "$str < br > \n";
     page_tail();
     exit();
 }
 
 try {
     $openid = new LightOpenID;
-    echo "<pre>";
+    echo " < pre > ";
     if(!$openid->mode) {
         if(isset($_POST['openid_identifier'])) {
             $openid->identity = $_POST['openid_identifier'];

html/user/prefs_edit.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
 $subset = sanitize_tags(get_str("subset"));
 $venue = sanitize_tags(get_str("venue", true));
 $columns = get_int("cols", true);
-$c = $columns?"&cols=$columns":"";
+$c = $columns ? "&cols=$columns" : "";
 check_subset($subset);
 if ($action) {
     check_tokens($user->authenticator);

html/inc/util_basic.inc

Spacing +6 added lines, -6 removed lines

@@ -56,10 +56,10 @@ 
     return file_exists("$d/stop_sched");
 }
 
-function xml_error($num=-1, $msg=null, $file=null, $line=null) {
+function xml_error($num = -1, $msg = null, $file = null, $line = null) {
     global $xml_outer_tag;
     if (!$msg) {
-        switch($num) {
+        switch ($num) {
         case -112: $msg = "Invalid XML"; break;
         case -136: $msg = "Not found"; break;
         case -137: $msg = "Name or email address is not unique"; break;
@@ -105,7 +105,7 @@ 
 // If it's a single-tag element, and it's present, just return the tag
 //
 function parse_element($xml, $tag) {
-    $closetag = "</" . substr($tag,1);
+    $closetag = "</".substr($tag, 1);
     $x = strstr($xml, $tag);
     if ($x) {
         if (strstr($tag, "/>")) return $tag;
@@ -121,8 +121,8 @@ 
 
 function parse_next_element($xml, $tag, &$cursor) {
     $element = null;
-    $closetag = "</" . substr($tag,1);
-    $pos = substr($xml,$cursor);
+    $closetag = "</".substr($tag, 1);
+    $pos = substr($xml, $cursor);
     $x = strstr($pos, $tag);
     if ($x) {
         if (strstr($tag, "/>")) return $tag;
@@ -222,7 +222,7 @@ 
 // whose OSs may have such restrictions.
 //
 function is_valid_filename($x) {
-    if (strlen($x)>255) return false;
+    if (strlen($x) > 255) return false;
     // \w means A-Za-z0-9_
     return preg_match('/^[\w\-.]+$/', $x);
 }

html/user/forum_thread_vote.php

Spacing +1 added lines, -1 removed lines

@@ -30,6 +30,6 @@
 if (!$thread) error_page('No such thread');
 $logged_in_user = get_logged_in_user();
 
-$posts = get_thread_posts($threadid, 0,true);
+$posts = get_thread_posts($threadid, 0, true);
 header("Location: forum_rate.php?choice=p&post=".$posts[0]->id);
 ?>

html/user/forum_moderate_post.php

Spacing +5 added lines, -5 removed lines

@@ -50,7 +50,7 @@ 
 start_table();
 
 $get_reason = true;
-if (get_str('action')=="hide") {
+if (get_str('action') == "hide") {
     //display input that selects reason
     echo "<input type=hidden name=action value=hide>";
     row1(tra("Hide post"));
@@ -67,12 +67,12 @@ 
             )
         )
     );
-} elseif (get_str('action')=="move") {
+} elseif (get_str('action') == "move") {
     row1(tra("Move post"));
     echo "<input type=hidden name=action value=move>";
     row2(tra("Destination thread ID:"), "<input name=\"threadid\">");
     // TODO: display where to move the post as a dropdown instead of having to get ID
-} elseif (get_str('action')=="banish_user") {
+} elseif (get_str('action') == "banish_user") {
     $userid = get_int('userid');
     $user = BoincUser::lookup_id($userid);
     if (!$user) {
@@ -80,7 +80,7 @@ 
     }
     BoincForumPrefs::lookup($user);
     $x = $user->prefs->banished_until;
-    if ($x>time()) {
+    if ($x > time()) {
         error_page(tra("User is already banished"));
     }
     row1(tra("Banish user"));
@@ -98,7 +98,7 @@ 
     echo "<input type=\"hidden\" name=\"id\" value=\"".$postid."\">\n";
     echo "<input type=\"hidden\" name=\"userid\" value=\"".$userid."\">\n";
     echo "<input type=\"hidden\" name=\"confirmed\" value=\"yes\">\n";
-} elseif (get_str('action')=="delete") {
+} elseif (get_str('action') == "delete") {
     echo "<input type=hidden name=action value=delete>";
     row2(
         "Are you sure want to delete this post?  This cannot be undone.",

html/user/job_file.php

Switch Indentation +14 added lines, -14 removed lines

@@ -80,20 +80,20 @@
 
 function upload_error_description($errno) {
     switch ($errno) {
-        case UPLOAD_ERR_INI_SIZE:
-            return "The uploaded file exceeds upload_max_filesize of php.ini."; break;
-        case UPLOAD_ERR_FORM_SIZE:
-            return "The uploaded file exceeds the MAX_FILE_SIZE specified in the HTML form."; break;
-        case UPLOAD_ERR_PARTIAL:
-            return "The uploaded file was only partially uploaded."; break;
-        case UPLOAD_ERR_NO_FILE:
-            return "No file was uploaded."; break;
-        case UPLOAD_ERR_NO_TMP_DIR:
-            return "Missing a temporary folder."; break;
-        case UPLOAD_ERR_CANT_WRITE:
-            return "Failed to write file to disk."; break;
-        case UPLOAD_ERR_EXTENSION:
-            return "A PHP extension stopped the file upload."; break;
+    case UPLOAD_ERR_INI_SIZE:
+        return "The uploaded file exceeds upload_max_filesize of php.ini."; break;
+    case UPLOAD_ERR_FORM_SIZE:
+        return "The uploaded file exceeds the MAX_FILE_SIZE specified in the HTML form."; break;
+    case UPLOAD_ERR_PARTIAL:
+        return "The uploaded file was only partially uploaded."; break;
+    case UPLOAD_ERR_NO_FILE:
+        return "No file was uploaded."; break;
+    case UPLOAD_ERR_NO_TMP_DIR:
+        return "Missing a temporary folder."; break;
+    case UPLOAD_ERR_CANT_WRITE:
+        return "Failed to write file to disk."; break;
+    case UPLOAD_ERR_EXTENSION:
+        return "A PHP extension stopped the file upload."; break;
     }
 }
 

html/inc/pm.inc

Spacing +11 added lines, -11 removed lines

@@ -51,7 +51,7 @@ 
     return $x;
 }
 
-function pm_team_form($user, $teamid, $error=null) {
+function pm_team_form($user, $teamid, $error = null) {
     global $bbcode_html, $bbcode_js;
     $team = BoincTeam::lookup_id($teamid);
     if (!$team) {
@@ -61,7 +61,7 @@ 
         error_page("not admin");
     }
 
-    page_head(tra("Send message to team"),'','','', $bbcode_js);
+    page_head(tra("Send message to team"), '', '', '', $bbcode_js);
 
     $subject = post_str("subject", true);
     $content = post_str("content", true);
@@ -113,7 +113,7 @@ 
 function pm_form_page($replyto, $userid, $error = null) {
     global $bbcode_html, $bbcode_js;
     global $g_logged_in_user;
-    page_head(tra("Send private message"),'','','', $bbcode_js);
+    page_head(tra("Send private message"), '', '', '', $bbcode_js);
 
     if (post_str("preview", true) == tra("Preview")) {
         $content = post_str("content", true);
@@ -137,7 +137,7 @@ 
         if (!$user) {
             error_page("Sender no longer exists");
         }
-        $writeto = UNIQUE_USER_NAME?$user->name:$userid." (".$user->name.")";
+        $writeto = UNIQUE_USER_NAME ? $user->name : $userid." (".$user->name.")";
         $subject = $message->subject;
         if (substr($subject, 0, 3) != "re:") {
             $subject = "re: ".$subject;
@@ -156,15 +156,15 @@ 
                 time_str($user->prefs->banished_until)
             );
         }
-        $writeto = UNIQUE_USER_NAME?$user->name:$userid." (".$user->name.")";
+        $writeto = UNIQUE_USER_NAME ? $user->name : $userid." (".$user->name.")";
     } else {
         $writeto = sanitize_tags(post_str("to", true));
         $subject = post_str("subject", true);
         $content = post_str("content", true);
     }
 
-    $content = $content?htmlspecialchars($content):'';
-    $subject = $subject?htmlspecialchars($subject):'';
+    $content = $content ?htmlspecialchars($content) : '';
+    $subject = $subject ?htmlspecialchars($subject) : '';
 
     if ($error != null) {
         echo "<p class=\"text-danger\">".$error."</p>\n";
@@ -220,7 +220,7 @@ 
 function send_pm_notification_email(
     $logged_in_user, $to_user, $subject, $content
 ) {
-    $message  = "
+    $message = "
 You have received a new private message at ".PROJECT.".
 
 From: $logged_in_user->name (ID $logged_in_user->id)
@@ -250,7 +250,7 @@ 
     $pm = BoincPrivateMessage::lookup_id($notify->opaque);
     $from_user = BoincUser::lookup_id($pm->senderid);
     if (!$pm || !$from_user) return null;
-    return "<a href=pm.php>".tra("Private message%1 from %2, subject:" , "</a>", $from_user->name )." $pm->subject";
+    return "<a href=pm.php>".tra("Private message%1 from %2, subject:", "</a>", $from_user->name)." $pm->subject";
 }
 
 function pm_send_msg($from_user, $to_user, $subject, $content, $send_email) {
@@ -314,11 +314,11 @@ 
 
 function pm_email_remind($user) {
     if (!$user->prefs->pm_notification) {
-        return "<br><small>" .
+        return "<br><small>".
             tra(
                 "For email notification, %1 edit community prefs %2",
                 '<a href="edit_forum_preferences_form.php">', '</a>'
-            ) .
+            ).
             "</small>"
         ;
     }

html/inc/host.inc

Spacing +20 added lines, -20 removed lines

@@ -32,12 +32,12 @@ 
 
 function sched_log_name($x) {
     if ($x == 0) return "NO_SUCH_LOG";
-    return gmdate('Y-m-d_H/Y-m-d_H:i', $x) . ".txt";
+    return gmdate('Y-m-d_H/Y-m-d_H:i', $x).".txt";
 }
 
 function sched_log_link($x) {
     if (file_exists("sched_logs")) {
-        return "<a href=\"../sched_logs/" . sched_log_name($x) . "\">" . time_str($x) . "</a>";
+        return "<a href=\"../sched_logs/".sched_log_name($x)."\">".time_str($x)."</a>";
     } else {
         return time_str($x);
     }
@@ -45,7 +45,7 @@ 
 
 function location_form($host) {
     $none = "selected";
-    $h=$w=$s=$m="";
+    $h = $w = $s = $m = "";
     if ($host->venue == "home") $h = "selected";
     if ($host->venue == "work") $w = "selected";
     if ($host->venue == "school") $s = "selected";
@@ -99,7 +99,7 @@ 
             row2(tra("Product name"), $host->product_name);
         }
         $x = $host->timezone/3600;
-        if ($x >= 0) $x="+$x";
+        if ($x >= 0) $x = "+$x";
         row2(tra("Local Standard Time"), tra("UTC %1 hours", $x));
     } else {
         $owner = BoincUser::lookup_id($host->userid);
@@ -293,20 +293,20 @@ 
 // Older clients may have the old-style serialnum in the DB
 // despite the server being upgraded.
 //
-function vbox_desc($parsed_ser){
+function vbox_desc($parsed_ser) {
     if (empty($parsed_ser['vbox'])) return '---';
     $f = $parsed_ser['vbox'];
     $desc = sprintf('Virtualbox (%s) %s',
         $f[1], tra("installed")
     );
-    if (sizeof($f)<=2){
+    if (sizeof($f) <= 2) {
         return $desc;
     }
-    if ($f[2]=="1" and $f[3]=="1") {
+    if ($f[2] == "1" and $f[3] == "1") {
         return $desc.tra(", CPU has hardware virtualization support and it is enabled");
-    } elseif ($f[2]=="1" and $f[3]=="0") {
+    } elseif ($f[2] == "1" and $f[3] == "0") {
         return $desc.tra(", CPU has hardware virtualization support but it is disabled");
-    } elseif ($f[2]=="0") {
+    } elseif ($f[2] == "0") {
         return $desc.tra(", CPU does not have hardware virtualization support");
     }
     return $desc;
@@ -331,13 +331,13 @@ 
 
 // return a human-readable version of the GPU info
 //
-function gpu_desc($parsed_ser, $detail=true) {
+function gpu_desc($parsed_ser, $detail = true) {
     $str = "";
     foreach ($parsed_ser as $d) {
         if (!is_gpu_type($d[0])) continue;
         if (count($d) < 4) continue;
         if ($str) $str .= "<p>";
-        if ($d[2]!="" && $d[2]!="1") $str .= "[".$d[2]."] ";
+        if ($d[2] != "" && $d[2] != "1") $str .= "[".$d[2]."] ";
         if ($d[0] == "CUDA") {
             $str .= "NVIDIA";
         } else if ($d[0] == "CAL") {
@@ -543,14 +543,14 @@ 
     if ($pos1 === false) return $x;
     $pos2 = strpos($model, ']');
     if ($pos2 === false) return $x;
-    $a = substr($model, $pos1+1, $pos2-$pos1-1);
+    $a = substr($model, $pos1 + 1, $pos2 - $pos1 - 1);
     $y = explode(" ", $a);
     if (count($y) == 0) return $x;
     if ($y[0] == "Family") {
         $x->info = $a;
     } else {
         $x->arch = $y[0];
-        $x->info = substr($a, strlen($y[0])+1);
+        $x->info = substr($a, strlen($y[0]) + 1);
     }
     return $x;
 }
@@ -639,7 +639,7 @@ 
     $avg_time = 0;
 
     $results = BoincResult::enum("hostid=$hostid order by received_time");
-    foreach($results as $result) {
+    foreach ($results as $result) {
         if ($result->granted_credit <= 0) continue;
         $total += $result->granted_credit;
 
@@ -732,7 +732,7 @@ 
 
 function link_url($sort, $rev, $show_all) {
     global $userid;
-    $x = $userid ? "&userid=$userid":"";
+    $x = $userid ? "&userid=$userid" : "";
     return "hosts_user.php?sort=$sort&rev=$rev&show_all=$show_all$x";
 }
 
@@ -806,7 +806,7 @@ 
 }
 
 function show_user_hosts($userid, $private, $show_all, $sort, $rev) {
-    $desc = false;  // whether the sort order's default is decreasing
+    $desc = false; // whether the sort order's default is decreasing
     switch ($sort) {
     case "total_credit": $sort_clause = "total_credit"; $desc = true; break;
     case "expavg_credit": $sort_clause = "expavg_credit"; $desc = true; break;
@@ -829,7 +829,7 @@ 
     more_or_less($sort, $rev, $show_all);
 
     $now = time();
-    $old_hosts=0;
+    $old_hosts = 0;
     $i = 1;
     $hosts = BoincHost::enum("userid=$userid order by $sort_clause");
     $any_product_name = false;
@@ -841,9 +841,9 @@ 
     }
     user_host_table_start($private, $sort, $rev, $show_all, $any_product_name);
     foreach ($hosts as $host) {
-        $is_old=false;
+        $is_old = false;
         if (($now - $host->rpc_time) > 30*86400) {
-            $is_old=true;
+            $is_old = true;
             $old_hosts++;
         }
         if (!$show_all && $is_old) continue;
@@ -852,7 +852,7 @@ 
     }
     end_table();
 
-    if ($old_hosts>0) {
+    if ($old_hosts > 0) {
         more_or_less($sort, $rev, $show_all);
     }
 

Braces +2 added lines, -2 removed lines

@@ -293,13 +293,13 @@
 // Older clients may have the old-style serialnum in the DB
 // despite the server being upgraded.
 //
-function vbox_desc($parsed_ser){
+function vbox_desc($parsed_ser) {
     if (empty($parsed_ser['vbox'])) return '---';
     $f = $parsed_ser['vbox'];
     $desc = sprintf('Virtualbox (%s) %s',
         $f[1], tra("installed")
     );
-    if (sizeof($f)<=2){
+    if (sizeof($f)<=2) {
         return $desc;
     }
     if ($f[2]=="1" and $f[3]=="1") {

html/user/buda.php

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -198,7 +198,7 @@ 
     form_input_hidden('app', $app);
     form_input_hidden('action', 'variant_action');
     form_input_text("Plan class$pc", 'variant');
-    form_select("Dockerfile$sb", 'dockerfile', $sbitems);
+    form_select("dockerfile$sb", 'dockerfile', $sbitems);
     form_select2_multi("Application files$sb", 'app_files', $sbitems, null);
     form_input_text(
         'Input file names<br><small>Space-separated</small>',
@@ -383,7 +383,7 @@ 
     // Note: we don't currently allow indirect file access.
     // If we did, we'd need to create job.toml to mount project dir
 
-    app_list("Variant $variant added for app $app.");
+    app_list("variant $variant added for app $app.");
 }
 
 function variant_delete() {
@@ -410,7 +410,7 @@ 
         if ($ret) {
             error_page("delete failed");
         }
-        $notice = "Variant $variant of app $app removed.";
+        $notice = "variant $variant of app $app removed.";
         app_list($notice);
     } else {
         page_head("Confirm");
@@ -440,7 +440,7 @@ 
         if ($ret) {
             error_page('delete failed');
         }
-        $notice = "App $app removed.";
+        $notice = "app $app removed.";
         app_list($notice);
     } else {
         page_head('Confirm');
@@ -505,7 +505,7 @@ 
         }
         $dir = "$buda_root/$name";
         if (file_exists($dir)) {
-            error_page("App $name already exists.");
+            error_page("app $name already exists.");
         }
         mkdir($dir);
         $desc->user_id = $user->id;

Spacing +9 added lines, -9 removed lines

@@ -54,7 +54,7 @@ 
 // show list of BUDA apps and variants,
 // w/ buttons for adding and deleting
 //
-function app_list($notice=null) {
+function app_list($notice = null) {
     global $buda_root;
     if (!is_dir($buda_root)) {
         mkdir($buda_root);
@@ -256,7 +256,7 @@ 
     //
     $x = "<input_template>\n";
     $ninfiles = 1 + count($variant_desc->input_file_names) + count($variant_desc->app_files);
-    for ($i=0; $i<$ninfiles; $i++) {
+    for ($i = 0; $i < $ninfiles; $i++) {
         $x .= "   <file_info>\n      <sticky/>\n      <no_delete/>\n      <executable/>\n   </file_info>\n";
     }
     $x .= "   <workunit>\n";
@@ -286,7 +286,7 @@ 
     );
 
     $x .= sprintf("      <max_delay>%f</max_delay>\n",
-        $variant_desc->max_delay_days * 86400.
+        $variant_desc->max_delay_days*86400.
     );
 
     $x .= "   </workunit>\n<input_template>\n";
@@ -476,8 +476,8 @@ 
     }
 }
 
-function app_form($desc=null) {
-    page_head_select2($desc?"Edit BUDA app $desc->name":'Create BUDA app');
+function app_form($desc = null) {
+    page_head_select2($desc ? "Edit BUDA app $desc->name" : 'Create BUDA app');
     form_start('buda.php');
     form_input_hidden('action', 'app_action');
     if ($desc) {
@@ -488,22 +488,22 @@ 
         form_input_text('Internal name<br><small>No spaces</small>', 'name');
     }
     form_input_text('User-visible name', 'long_name',
-        $desc?$desc->long_name:null
+        $desc ? $desc->long_name : null
     );
     form_input_textarea(
         'Description<br><small>... of what the app does and of the research goals</small>',
         'description',
-        $desc?$desc->description:null
+        $desc ? $desc->description : null
     );
     form_select2_multi('Science keywords',
         'sci_kw',
         keyword_select_options(KW_CATEGORY_SCIENCE),
-        $desc?$desc->sci_kw:null
+        $desc ? $desc->sci_kw : null
     );
     form_input_text(
         'URL of web page describing app',
         'url',
-        !empty($desc->url)?$desc->url:''
+        !empty($desc->url) ? $desc->url : ''
     );
     // don't include location keywords;
     // various people may submit jobs to this app