BCRM / www

src/BCRM/WebBundle/Controller/EventController.php

Unused Use Statements -1 removed lines

@@ -18,7 +18,6 @@
 use BCRM\BackendBundle\Service\Event\UnregisterCommand;
 use BCRM\WebBundle\Content\ContentReader;
 use BCRM\WebBundle\Form\EventRegisterModel;
-use BCRM\WebBundle\Form\EventRegisterType;
 use BCRM\WebBundle\Form\EventUnregisterType;
 use Carbon\Carbon;
 use Dothiv\Bundle\MoneyFormatBundle\Service\MoneyFormatServiceInterface;

src/BCRM/WebBundle/Controller/StatsController.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 
 namespace BCRM\WebBundle\Controller;
 
-use BCRM\BackendBundle\Entity\Event\Event;
 use BCRM\BackendBundle\Entity\Event\EventRepository;
 use BCRM\BackendBundle\Entity\Event\Registration;
 use BCRM\BackendBundle\Entity\Event\Ticket;

Spacing +5 added lines, -5 removed lines

@@ -123,7 +123,7 @@ 
      */
     protected function getCheckinsPerDay(array $tickets, $day)
     {
-        return array_reduce($tickets, function ($count, Ticket $ticket) use ($day) {
+        return array_reduce($tickets, function($count, Ticket $ticket) use ($day) {
             return $count + ($ticket->getType() === Registration::TYPE_NORMAL && $ticket->isCheckedIn() && $ticket->getDay() == $day ? 1 : 0);
         }, 0);
     }
@@ -140,10 +140,10 @@ 
     protected function getUniqueDayCheckins(array $tickets, $day, $both = false)
     {
         $otherDayCheckins = array_map(
-            function (Ticket $ticket) {
+            function(Ticket $ticket) {
                 return $ticket->getEmail();
             },
-            array_filter($tickets, function (Ticket $ticket) use ($day) {
+            array_filter($tickets, function(Ticket $ticket) use ($day) {
                 return
                     $ticket->getType() === Registration::TYPE_NORMAL
                     && $ticket->isCheckedIn()
@@ -151,7 +151,7 @@ 
             })
         );
 
-        return array_reduce($tickets, function ($count, Ticket $ticket) use ($otherDayCheckins, $day, $both) {
+        return array_reduce($tickets, function($count, Ticket $ticket) use ($otherDayCheckins, $day, $both) {
             return $count + (
             $ticket->getType() === Registration::TYPE_NORMAL
             && $ticket->isCheckedIn()
@@ -163,7 +163,7 @@ 
 
     protected function getNoShows(array $tickets, $day)
     {
-        return array_reduce($tickets, function ($count, Ticket $ticket) use ($day) {
+        return array_reduce($tickets, function($count, Ticket $ticket) use ($day) {
             return $count + (
             $ticket->getType() === Registration::TYPE_NORMAL
             && !$ticket->isCheckedIn()

src/BCRM/BackendBundle/Command/MailChimpUpdateParticipantsListCommand.php

Spacing +1 added lines, -1 removed lines

@@ -105,7 +105,7 @@
      */
     protected function toBatch(ArrayCollection $emails, $deep = true)
     {
-        return $emails->map(function ($email) use($deep) {
+        return $emails->map(function($email) use($deep) {
             return array(
                 'email'      => $deep ? array('email' => $email) : $email,
                 'email_type' => 'html'

Braces +3 added lines, -1 removed lines

@@ -61,7 +61,9 @@
         foreach ($ticketRepo->getTicketsForEvent($eventRepo->getNextEvent()->getOrThrow(
             new BadMethodCallException('No event.')
         )) as $ticket) {
-            if ($participants->contains(strtolower($ticket->getEmail()))) continue;
+            if ($participants->contains(strtolower($ticket->getEmail()))) {
+                continue;
+            }
             $participants->add(strtolower($ticket->getEmail()));
         }
 

src/BCRM/BackendBundle/Content/TwigLoader.php

Braces +3 added lines, -1 removed lines

@@ -33,7 +33,9 @@
 
     protected function getFile($name)
     {
-        if (!preg_match('/^bcrm_content:(.+)/', $name, $match)) throw new Twig_Error_Loader(sprintf('Unknown template: %s', $name));
+        if (!preg_match('/^bcrm_content:(.+)/', $name, $match)) {
+            throw new Twig_Error_Loader(sprintf('Unknown template: %s', $name));
+        }
         return $match[1];
     }
 

src/BCRM/BackendBundle/Service/Payment.php

Spacing +2 added lines, -2 removed lines

@@ -100,11 +100,11 @@
             $event->payment                  = $payment;
             $payment->setPayload(new ArrayCollection($data));
             $this->eventMessageBus->publish($event);
-            Option::fromValue($this->logger)->map(function (LoggerInterface $logger) use ($payment) {
+            Option::fromValue($this->logger)->map(function(LoggerInterface $logger) use ($payment) {
                 $logger->info(sprintf('Payment "%s" is verified.', $payment->getId()), array($payment));
             });
         } else {
-            Option::fromValue($this->logger)->map(function (LoggerInterface $logger) use ($payment) {
+            Option::fromValue($this->logger)->map(function(LoggerInterface $logger) use ($payment) {
                 $logger->alert(sprintf('Payment "%s" could not be verified.', $payment->getId()), array($payment));
             });
         }

Braces +3 added lines, -1 removed lines

@@ -84,7 +84,9 @@
 
         $data = array();
         foreach (explode("\n", $res) as $line) {
-            if (!strpos($line, '=')) continue;
+            if (!strpos($line, '=')) {
+                continue;
+            }
             list($key, $value) = explode('=', $line);
             $data[$key] = $value;
         }

src/BCRM/BackendBundle/Service/Ticket.php

Spacing +2 added lines, -2 removed lines

@@ -86,7 +86,7 @@ 
     {
         $payment      = $event->payment;
         $registration = $event->registration;
-        Option::fromValue($this->logger)->map(function (LoggerInterface $logger) use ($registration, $payment) {
+        Option::fromValue($this->logger)->map(function(LoggerInterface $logger) use ($registration, $payment) {
             $logger->alert(sprintf('Registration "%s" has been paid with payment "%s".', $registration->getId(), $payment->getId()));
         });
         foreach ($this->ticketRepo->getTicketsForEmail(
@@ -98,7 +98,7 @@ 
             $updateCommand->id    = $ticket->getId();
             $updateCommand->data  = array('payment' => $payment);
             $this->commandBus->handle($updateCommand);
-            Option::fromValue($this->logger)->map(function (LoggerInterface $logger) use ($payment, $ticket) {
+            Option::fromValue($this->logger)->map(function(LoggerInterface $logger) use ($payment, $ticket) {
                 $logger->alert(sprintf('Assigning payment "%s" to ticket "%s"', $payment->getId(), $ticket->getCode()));
             });
         }

src/BCRM/WebBundle/Controller/WebController.php

Braces +3 added lines, -1 removed lines

@@ -131,7 +131,9 @@
         }
 
         $p = $this->reader->getPage($path . '.md');
-        if ($p->isHidden()) throw new NotFoundHttpException();
+        if ($p->isHidden()) {
+            throw new NotFoundHttpException();
+        }
 
         return $this->renderer->renderResponse('BCRMWebBundle:Web:page.html.twig', array(
             'page'     => $p,

Spacing +6 added lines, -6 removed lines

@@ -114,7 +114,7 @@ 
     public function pageAction(Request $request, $path)
     {
         try {
-            $pageInfo = $this->reader->getInfo($path . '.md');
+            $pageInfo = $this->reader->getInfo($path.'.md');
         } catch (FileNotFoundException $e) {
             throw new NotFoundHttpException();
         }
@@ -122,7 +122,7 @@ 
         $response->setETag($pageInfo->getEtag());
         $lastModified = $pageInfo->getLastModified();
         if ($this->assetsVersion - $pageInfo->getLastModified()->getTimestamp() > 0) {
-            $lastModified = new \DateTime('@' . $this->assetsVersion);
+            $lastModified = new \DateTime('@'.$this->assetsVersion);
         }
         $response->setLastModified($lastModified);
         $response->setPublic();
@@ -130,7 +130,7 @@ 
             return $response;
         }
 
-        $p = $this->reader->getPage($path . '.md');
+        $p = $this->reader->getPage($path.'.md');
         if ($p->isHidden()) throw new NotFoundHttpException();
 
         return $this->renderer->renderResponse('BCRMWebBundle:Web:page.html.twig', array(
@@ -150,12 +150,12 @@ 
      */
     public function contentAction(Request $request, $path)
     {
-        $pageInfo = $this->reader->getInfo($path . '.md');
+        $pageInfo = $this->reader->getInfo($path.'.md');
         $response = new Response();
         $response->setETag($pageInfo->getEtag());
         $lastModified = $pageInfo->getLastModified();
         if ($this->assetsVersion - $pageInfo->getLastModified()->getTimestamp() > 0) {
-            $lastModified = new \DateTime('@' . $this->assetsVersion);
+            $lastModified = new \DateTime('@'.$this->assetsVersion);
         }
         $response->setLastModified($lastModified);
         $response->setPublic();
@@ -163,7 +163,7 @@ 
             return $response;
         }
 
-        $p = $this->reader->getPage($path . '.md');
+        $p = $this->reader->getPage($path.'.md');
         $response->setContent($p->getContent());
         return $response;
     }

src/BCRM/WebBundle/Tests/Functional/ConciergeControllerTest.php

Spacing +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
         $ticket = $em->getRepository('BCRMBackendBundle:Event\Ticket')->findOneBy(array('code' => 'WOOT'));
         $this->assertEquals(false, $ticket->isCheckedIn());
 
-        $client   = static::createClient(array(), array(
+        $client = static::createClient(array(), array(
             'PHP_AUTH_USER' => 'concierge',
             'PHP_AUTH_PW'   => 'letmein',
         ));
@@ -172,7 +172,7 @@ 
      */
     public function theTicketSearchApiShouldWork()
     {
-        $client    = static::createClient(array(), array(
+        $client = static::createClient(array(), array(
             'PHP_AUTH_USER' => 'concierge',
             'PHP_AUTH_PW'   => 'letmein',
         ));

src/BCRM/WebBundle/Tests/Functional/StatsControllerTest.php

Braces +6 added lines, -2 removed lines

@@ -67,8 +67,12 @@
 
     protected function createTicket($day, $checkedIn = null, $email = null)
     {
-        if ($email === null) $email = sprintf('stats.doe.198%s@domain.com', $this->ticketCounter);
-        if ($checkedIn === null) $checkedIn = true;
+        if ($email === null) {
+            $email = sprintf('stats.doe.198%s@domain.com', $this->ticketCounter);
+        }
+        if ($checkedIn === null) {
+            $checkedIn = true;
+        }
         $client    = static::createClient();
         $container = $client->getContainer();
 

Doc Comments +3 added lines

@@ -66,6 +66,9 @@
 
     protected $ticketCounter = 1;
 
+    /**
+     * @param false $checkedIn
+     */
     protected function createTicket($day, $checkedIn = null, $email = null)
     {
         if ($email === null) $email = sprintf('stats.doe.198%s@domain.com', $this->ticketCounter);

Unused Use Statements -3 removed lines

@@ -7,11 +7,8 @@
 
 namespace BCRM\WebBundle\Tests\Functional;
 
-use BCRM\BackendBundle\Entity\Event\Registration;
 use BCRM\BackendBundle\Entity\Event\Ticket;
 use BCRM\BackendBundle\Entity\Payment;
-use Symfony\Component\BrowserKit\Cookie;
-use Symfony\Component\DependencyInjection\ContainerInterface;
 
 class StatsControllerTest extends Base
 {

Spacing +2 added lines, -2 removed lines

@@ -79,8 +79,8 @@
             ->getManager();
 
         // Create a payment
-        $txId = sha1('someid' . $email);
-        $payment  = $em->getRepository('BCRMBackendBundle:Payment')->findOneByTxId($txId);
+        $txId = sha1('someid'.$email);
+        $payment = $em->getRepository('BCRMBackendBundle:Payment')->findOneByTxId($txId);
         if (!$payment) {
             $payment = new Payment();
             $payment->setTransactionId($txId);