EventControllerTest::payRegistration() - Code Metrics - BCRM/www - Measure and Improve Code Quality continuously with Scrutinizer

EventControllerTest::payRegistration() A
last analyzed 2016-11-21 12:30 UTC

↳ Parent: EventControllerTest
Complexity

Conditions	1
Paths	1
Size

Total Lines	51
Code Lines	37
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
dl	0
loc	51
rs	9.4109
c	0
b	0
f	0
cc	1
eloc	37
nc	1
nop	1
How to fix Long Method

<?php

/**
 * @author    Markus Tacker <[email protected]>
 * @copyright 2013-2016 Verein zur Förderung der Netzkultur im Rhein-Main-Gebiet e.V. | http://netzkultur-rheinmain.de/
 */

namespace BCRM\WebBundle\Tests\Functional;

use BCRM\BackendBundle\Command\SendPayRegistrationMailCommand;
use BCRM\BackendBundle\Command\SendTicketsMailCommand;
use BCRM\BackendBundle\Entity\Event\Ticket;
use BCRM\BackendBundle\Entity\Event\Registration;
use BCRM\BackendBundle\Entity\Event\Unregistration;
use BCRM\BackendBundle\Command\SendConfirmUnregistrationMailCommand;
use BCRM\BackendBundle\Command\CreateTicketsCommand;
use BCRM\BackendBundle\Command\ProcessUnregistrationsCommand;
use BCRM\BackendBundle\Entity\Payment;
use BCRM\BackendBundle\Service\Payment\PayRegistrationCommand;
use Symfony\Component\DependencyInjection\ContainerInterface;

class EventControllerTest extends Base
{
    /**
     * The setUpBeforeClass() and tearDownAfterClass() template methods are called before the first test of the test
     * case class is run and after the last test of the test case class is run, respectively.
     */
    public static function setUpBeforeClass()
    {
        static::resetDatabase();
    }

    /**
     * @test
     * @group functional
     */
    public function eventRegistration()
    {
        $email   = '[email protected]';
        $client  = static::createClient();
        $crawler = $client->request('GET', '/anmeldung');

        $form                                    = $crawler->selectButton('event_register[save]')->form();
        $form['event_register[name]']            = 'John Doe';
        $form['event_register[email]']           = $email;
        $form['event_register[days]']            = 3;
        $form['event_register[donationEur]']     = '12,34';
        $form['event_register[payment]']         = 'paypal';
        $form['event_register[food]']            = 'default';
        $form['event_register[tags]']            = '#foo #bar #bcrm13';
        $form['event_register[twitter]']         = '@somebody';
        $form['event_register[participantList]'] = '1';
        $client->submit($form);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $response = $client->getResponse();
        $this->assertEquals(302, $response->getStatusCode());
        $this->assertTrue($response->isRedirect('/anmeldung/check'), sprintf('Unexpected redirect to %s', $response->headers->get('Location')));

        $crawler                                   = $client->followRedirect();
        $form                                      = $crawler->selectButton('event_register_review[save]')->form();
        $form['event_register_review[norefund]']   = '1';
        $form['event_register_review[autocancel]'] = '1';
        $client->submit($form);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $response = $client->getResponse();
        $this->assertEquals(302, $response->getStatusCode());
        $this->assertTrue($response->isRedirect('/anmeldung/ok'), sprintf('Unexpected redirect to %s', $response->headers->get('Location')));
        return $email;
    }

    /**
     * @test
     * @group   functional
     * @depends eventRegistration
     */
    public function createTickets($email)
    {
        $client    = static::createClient();
        $container = $client->getContainer();

        $this->createTicketsCommand($container);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
        $this->sendTicketsCommand($container); // Tickets should not be sent, because not yet paid for
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
        $this->sendPayTicketCommand($container); // but a payment notification should be sent
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        /* @var $em \Doctrine\Common\Persistence\ObjectManager */
        $em = $container
            ->get('doctrine')
            ->getManager();

        /* @var $tickets Ticket[] */
        $tickets = $em->getRepository('BCRMBackendBundle:Event\Ticket')->findAll();
        $this->assertEquals(2, count($tickets));
        $this->assertEquals($email, $tickets[0]->getEmail());
        $this->assertEquals($email, $tickets[1]->getEmail());
        $days = array(
            $tickets[0]->getDay(),
            $tickets[1]->getDay()
        );
        $this->assertTrue(in_array(Ticket::DAY_SATURDAY, $days));
        $this->assertTrue(in_array(Ticket::DAY_SUNDAY, $days));
        $this->assertEquals(1, $tickets[0]->getEvent()->getId());
        $this->assertEquals(1, $tickets[1]->getEvent()->getId());
        $this->assertNull($tickets[0]->getPayment());
        $this->assertNull($tickets[1]->getPayment());
        $this->assertFalse($tickets[0]->isNotified());
        $this->assertFalse($tickets[1]->isNotified());

        /** @var Registration[] $registration */
        $registration = $em->getRepository('BCRMBackendBundle:Event\Registration')->findOneByEmail($email);

        $this->assertTrue($registration->isPaymentNotified());


        return $email;
    }

    /**
     * @test
     * @group   functional
     * @depends createTickets
     */
    public function payRegistration($email)
    {
        $client    = static::createClient();
        $container = $client->getContainer();
        /* @var $em \Doctrine\Common\Persistence\ObjectManager */
        $em = $container
            ->get('doctrine')
            ->getManager();
        /** @var Registration $registration */
        $registration = $em->getRepository('BCRMBackendBundle:Event\Registration')->findOneByEmail($email);

        $this->assertEquals('paypal', $registration->getPaymentMethod());
        $this->assertNull($registration->getPayment());

        $client = static::createClient();
        $client->request('GET', '/anmeldung/' . $registration->getUuid() . '/payment');
        $response = $client->getResponse();
        $this->assertEquals(200, $response->getStatusCode());
        preg_match('/data-number="([^"]+)"/', $response->getContent(), $registrationUuidMatch);
        preg_match('/data-amount="([^"]+)"/', $response->getContent(), $registrationAmountMatch);
        $this->assertEquals($registration->getUuid(), $registrationUuidMatch[1]);
        $this->assertEquals(sprintf('%.2f', ceil((2000 + 1234) * 1.019 + 35) / 100), $registrationAmountMatch[1]);

        // Add payment
        $payment = new Payment();
        $payment->setMethod('cash');
        $payment->setTransactionId($email);
        $em->persist($payment);
        $em->flush();

        $command               = new PayRegistrationCommand();
        $command->registration = $registration;
        $command->payment      = $payment;
        /** @var \LiteCQRS\Bus\CommandBus $commandBus */
        $commandBus = $container->get('command_bus');
        $commandBus->handle($command);
        $registration = $em->getRepository('BCRMBackendBundle:Event\Registration')->findOneByEmail($email);

        $this->assertEquals($payment, $registration->getPayment());

        // Send tickets
        $this->sendTicketsCommand($container);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        /* @var $tickets Ticket[] */
        $tickets = $em->getRepository('BCRMBackendBundle:Event\Ticket')->findAll();
        $this->assertEquals(2, count($tickets));
        $this->assertEquals($payment, $tickets[0]->getPayment());
        $this->assertEquals($payment, $tickets[1]->getPayment());
        $this->assertTrue($tickets[0]->isNotified());
        $this->assertTrue($tickets[1]->isNotified());

        return $email;
    }

    protected function createTicketsCommand(ContainerInterface $container)
    {
        $this->runCommand($container, new CreateTicketsCommand(), 'bcrm:tickets:create');
    }

    protected function sendTicketsCommand(ContainerInterface $container)
    {
        $this->runCommand($container, new SendTicketsMailCommand(), 'bcrm:tickets:send');
    }

    protected function sendPayTicketCommand(ContainerInterface $container)
    {
        $this->runCommand($container, new SendPayRegistrationMailCommand(), 'bcrm:registration:pay');
    }

    /**
     * @test
     * @group   functional
     * @depends payRegistration
     */
    public function eventUnregistration($email)
    {
        $client  = static::createClient();
        $crawler = $client->request('GET', '/stornierung');

        $form                            = $crawler->selectButton('event_unregister[save]')->form();
        $form['event_unregister[email]'] = $email;
        $form['event_unregister[days]']  = 3;
        $client->submit($form);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $response = $client->getResponse();
        $this->assertEquals(302, $response->getStatusCode());
        $this->assertTrue($response->isRedirect('/stornierung/ok'), sprintf('Unexpected redirect to %s', $response->headers->get('Location')));
        return $email;
    }

    /**
     * @test
     * @group   functional
     * @depends eventUnregistration
     */
    public function confirmEventUnregistration($email)
    {
        $client    = static::createClient();
        $container = $client->getContainer();

        $this->confirmUnregistrationCommand($container);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        /* @var $em \Doctrine\Common\Persistence\ObjectManager */
        $em = $container
            ->get('doctrine')
            ->getManager();

        /* @var $registration Registration */
        $registration = $em->getRepository('BCRMBackendBundle:Event\Unregistration')->findOneBy(array(
            'email' => $email
        ));

        // Confirm
        $client->request('GET', sprintf('/stornierung/bestaetigen/%d/%s', $registration->getId(), $registration->getConfirmationKey()));

        $response = $client->getResponse();
        $this->assertEquals(302, $response->getStatusCode());
        $this->assertTrue($response->isRedirect('/stornierung/aktiviert'), sprintf('Unexpected redirect to %s', $response->headers->get('Location')));
        return $email;
    }

    protected function confirmUnregistrationCommand(ContainerInterface $container)
    {
        $this->runCommand($container, new SendConfirmUnregistrationMailCommand(), 'bcrm:unregistration:confirm');
    }

    /**
     * @test
     * @group   functional
     * @depends confirmEventUnregistration
     */
    public function removeTickets($email)
    {
        $client    = static::createClient();
        $container = $client->getContainer();

        $this->processUnregistrationsCommand($container);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        /* @var $em \Doctrine\Common\Persistence\ObjectManager */
        $em = $container
            ->get('doctrine')
            ->getManager();

        /* @var $registration Registration */
        $registration = $em->getRepository('BCRMBackendBundle:Event\Registration')->findOneById(2);

        $this->assertEquals(0, $registration->getSaturday());
        $this->assertEquals(0, $registration->getSunday());

        /* @var $tickets Ticket[] */
        $tickets = $em->getRepository('BCRMBackendBundle:Event\Ticket')->findAll();
        $this->assertEquals(0, count($tickets));
        return $email;
    }

    protected function processUnregistrationsCommand(ContainerInterface $container)
    {
        $this->runCommand($container, new ProcessUnregistrationsCommand(), 'bcrm:tickets:process-unregistrations');
    }

    /**
     * @test
     * @group   functional
     * @depends removeTickets
     */
    public function thereShouldBeNoMoreTicketsThanCapacity()
    {
        $client    = static::createClient();
        $container = $client->getContainer();
        /* @var $em \Doctrine\Common\Persistence\ObjectManager */
        $em = $container
            ->get('doctrine')
            ->getManager();

        $this->assertEquals(0, count($em->getRepository('BCRMBackendBundle:Event\Ticket')->findAll()));

        $event = $em->getRepository('BCRMBackendBundle:Event\Event')->findAll()[0];

        // Create registrations
        for ($i = 1; $i <= 5; $i++) {
            $email        = 'john.doe.198' . $i . '@domain.com';
            $registration = new Registration();
            $registration->setName($i);
            $registration->setEvent($event);
            $registration->setEmail($email);
            $registration->setSaturday(true);
            $registration->setUuid($email);
            $payment = new Payment();
            $payment->setMethod('cash');
            $payment->setTransactionId($email);
            $em->persist($payment);
            $registration->setPayment($payment);
            $em->persist($registration);
        }
        $em->flush();

        $this->createTicketsCommand($container);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        $tickets = $em->getRepository('BCRMBackendBundle:Event\Ticket')->findBy(array(
            'event' => $event,
            'day'   => Ticket::DAY_SATURDAY,
        ));
        $this->assertEquals(3, count($tickets));
        $this->assertInArray('[email protected]', array_map(function (Ticket $t) {
            return $t->getEmail();
        }, $tickets));

        // Unregister Tickets
        $unregistration = new Unregistration();
        $unregistration->setEvent($event);
        $unregistration->setEmail('[email protected]');
        $unregistration->setConfirmed(true);
        $unregistration->setSaturday(true);
        $em->persist($unregistration);
        $em->flush();

        $this->processUnregistrationsCommand($container);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        $this->assertEquals(2, count($em->getRepository('BCRMBackendBundle:Event\Ticket')->findBy(array(
            'event' => $event,
            'day'   => Ticket::DAY_SATURDAY,
        ))));

        $this->createTicketsCommand($container);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        $tickets = $em->getRepository('BCRMBackendBundle:Event\Ticket')->findBy(array(
            'event' => $event,
            'day'   => Ticket::DAY_SATURDAY,
        ));
        $this->assertEquals(3, count($tickets));
        $this->assertNotInArray('[email protected]', array_map(function (Ticket $t) {
            return $t->getEmail();
        }, $tickets));
    }

    /**
     * @test
     * @group   functional
     * @depends thereShouldBeNoMoreTicketsThanCapacity
     */
    public function cancelTicketLink()
    {
        $client    = static::createClient();
        $container = $client->getContainer();
        /* @var $em \Doctrine\Common\Persistence\ObjectManager */
        $em     = $container
            ->get('doctrine')
            ->getManager();
        $ticket = $em->getRepository('BCRMBackendBundle:Event\Ticket')->findOneBy(array('day' => 1));

        // Confirm
        $crawler = $client->request('GET', sprintf('/stornierung/%d/%s', $ticket->getId(), $ticket->getCode()));
        $form    = $crawler->selectButton('cancel_confirm')->form();
        $client->submit($form);
        $response = $client->getResponse();
        $this->assertEquals(302, $response->getStatusCode());
        $this->assertTrue($response->isRedirect('/stornierung/aktiviert'), sprintf('Unexpected redirect to %s', $response->headers->get('Location')));

        $this->processUnregistrationsCommand($container);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        $this->assertEquals(2, count($em->getRepository('BCRMBackendBundle:Event\Ticket')->findAll()));
    }

    /**
     * Test for https://github.com/BCRM/www/issues/1
     *
     * @test
     * @group functional
     */
    public function tagsShouldAllowUmlauts()
    {
        $email   = '[email protected]';
        $client  = static::createClient();
        $crawler = $client->request('GET', '/anmeldung');

        $form                                    = $crawler->selectButton('event_register[save]')->form();
        $form['event_register[name]']            = 'John Doe';
        $form['event_register[email]']           = $email;
        $form['event_register[days]']            = 3;
        $form['event_register[payment]']         = 'paypal';
        $form['event_register[food]']            = 'default';
        $form['event_register[tags]']            = '#zauberwürfel #bar #bcrm13';
        $form['event_register[twitter]']         = '@somebody';
        $form['event_register[participantList]'] = '1';
        $client->submit($form);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $response = $client->getResponse();
        $this->assertEquals(302, $response->getStatusCode());
        $this->assertTrue($response->isRedirect('/anmeldung/check'), sprintf('Unexpected redirect to %s', $response->headers->get('Location')));
        return $email;
    }
}

1			<?php
2
3			/**
4			* @author Markus Tacker <[email protected]>
5			* @copyright 2013-2016 Verein zur Förderung der Netzkultur im Rhein-Main-Gebiet e.V. \| http://netzkultur-rheinmain.de/
6			*/
7
8			namespace BCRM\WebBundle\Tests\Functional;
9
10			use BCRM\BackendBundle\Command\SendPayRegistrationMailCommand;
11			use BCRM\BackendBundle\Command\SendTicketsMailCommand;
12			use BCRM\BackendBundle\Entity\Event\Ticket;
13			use BCRM\BackendBundle\Entity\Event\Registration;
14			use BCRM\BackendBundle\Entity\Event\Unregistration;
15			use BCRM\BackendBundle\Command\SendConfirmUnregistrationMailCommand;
16			use BCRM\BackendBundle\Command\CreateTicketsCommand;
17			use BCRM\BackendBundle\Command\ProcessUnregistrationsCommand;
18			use BCRM\BackendBundle\Entity\Payment;
19			use BCRM\BackendBundle\Service\Payment\PayRegistrationCommand;
20			use Symfony\Component\DependencyInjection\ContainerInterface;
21
22			class EventControllerTest extends Base
23			{
24			/**
25			* The setUpBeforeClass() and tearDownAfterClass() template methods are called before the first test of the test
26			* case class is run and after the last test of the test case class is run, respectively.
27			*/
28			public static function setUpBeforeClass()
29			{
30			static::resetDatabase();
31			}
32
33			/**
34			* @test
35			* @group functional
36			*/
37			public function eventRegistration()
38			{
39			$email = '[email protected]';
40			$client = static::createClient();
BCRM / www

EventControllerTest::payRegistration() A last analyzed 2016-11-21 12:30 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

EventControllerTest::payRegistration() A
last analyzed 2016-11-21 12:30 UTC
