ConciergeController - Code Metrics - BCRM/www - Measure and Improve Code Quality continuously with Scrutinizer

ConciergeController B
last analyzed 2016-11-21 12:30 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	148
Duplicated Lines	8.78 %

Coupling/Cohesion

Components	1
Dependencies	16

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	11
c	1
b	0
f	0
lcom	1
cbo	16
dl	13
loc	148
rs	8.4614

5 Methods

Rating	Name	Duplication	Size	Complexity
B	createTicketAction()	0	60	5
A	manualCheckinAction()	0	5	1
B	searchTicketAction()	0	28	2
A	__construct()	13	13	1
A	indexAction()	0	15	2

How to fix Duplicated Code

<?php

/**
 * @author    Markus Tacker <[email protected]>
 * @copyright 2013-2016 Verein zur Förderung der Netzkultur im Rhein-Main-Gebiet e.V. | http://netzkultur-rheinmain.de/
 */

namespace BCRM\WebBundle\Controller;

use BCRM\BackendBundle\Entity\Event\Event;
use BCRM\BackendBundle\Entity\Event\EventRepository;
use BCRM\BackendBundle\Entity\Event\Registration;
use BCRM\BackendBundle\Entity\Event\Ticket;
use BCRM\BackendBundle\Entity\Event\TicketRepository;
use BCRM\BackendBundle\Service\Concierge\CheckinCommand;
use BCRM\BackendBundle\Service\Concierge\PayRegistrationConciergeCommand;
use BCRM\BackendBundle\Service\Event\CreateTicketCommand;
use BCRM\BackendBundle\Service\Event\RegisterCommand;
use BCRM\WebBundle\Content\ContentReader;
use BCRM\WebBundle\Exception\AccesDeniedHttpException;
use BCRM\WebBundle\Exception\BadRequestException;
use BCRM\WebBundle\Form\TicketType;
use Carbon\Carbon;
use LiteCQRS\Bus\CommandBus;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\Form\FormFactoryInterface;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\Session\Flash\FlashBagInterface;
use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\Routing\RouterInterface;
use Symfony\Component\Validator\Constraints\DateTime;
use Symfony\Component\Security\Core\Util\SecureRandom;

/**
 * Dashboard for the event concierge.
 */
class ConciergeController
{
    public function __construct(

        EventRepository $eventRepo,
        TicketRepository $ticketRepo,
        CommandBus $commandBus,
        FormFactoryInterface $formFactory,
        RouterInterface $router)
    {
        $this->eventRepo   = $eventRepo;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->ticketRepo  = $ticketRepo;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->commandBus  = $commandBus;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->formFactory = $formFactory;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->router      = $router;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Dashboard index
     *
     * @Template()
     */
    public function indexAction()
    {
        /* @var $event Event */
        $event = $this->eventRepo->getNextEvent()->getOrThrow(new AccesDeniedHttpException('No event.'));

        $stats = array();
        foreach (array(Ticket::DAY_SATURDAY, Ticket::DAY_SUNDAY) as $day) {
            $stats[$day] = array(
                'tickets'  => $this->ticketRepo->getTicketCountForEvent($event, $day),
                'checkins' => $this->ticketRepo->getCheckinCountForEvent($event, $day),
            );
        }
        $data = array('stats' => $stats);
        return $data;
    }

    /**
     * Concierges must be able to create Tickets manually.
     *
     * @Template()
     */
    public function createTicketAction(Request $request)
    {
        $event        = $this->eventRepo->getNextEvent()->getOrThrow(new AccessDeniedHttpException('No event.'));
        $registration = new Registration();
        $registration->setEvent($event);
        $generator = new SecureRandom();
        $registration->setUuid(sha1($generator->nextBytes(16)));
        $form = $this->formFactory->create(new TicketType(), $registration, array('action' => $request->getPathInfo()));
        $form->handleRequest($request);
        if ($form->isValid()) {
            /* @var Registration $formData */
            $formData                  = $form->getData();
            $registerCommand           = new RegisterCommand();
            $registerCommand->event    = $event;
            $registerCommand->email    = $formData->getEmail();
            $registerCommand->name     = $formData->getName();
            $registerCommand->twitter  = $formData->getTwitter();
            $registerCommand->saturday = $formData->getSaturday();
            $registerCommand->sunday   = $formData->getSunday();
            $registerCommand->tags     = $formData->getTags();
            $registerCommand->type     = $formData->getType();
            $registerCommand->uuid     = $formData->getUuid();
            $registerCommand->payment  = 'concierge';
            $this->commandBus->handle($registerCommand);

            // Create tickets
            /* @var FlashBagInterface $fb */
            $fb = $request->getSession()->getFlashBag();
            foreach (
                array(
                    Ticket::DAY_SATURDAY => $formData->getSaturday(),
                    Ticket::DAY_SUNDAY   => $formData->getSunday(),
                ) as $day => $want) {
                if (!$want) continue;
                $ticketCommand               = new CreateTicketCommand();
                $ticketCommand->day          = $day;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
                $ticketCommand->event        = $event;
                $ticketCommand->registration = $registration;
                $this->commandBus->handle($ticketCommand);
                $fb->add(
                    'info',
                    sprintf(
                        'Ticket für %s / %s angelegt.',
                        $registration->getEmail(),
                        $day == Ticket::DAY_SATURDAY ? 'Samstag' : 'Sonntag'
                    )
                );
            }

            // Create payment
            $paymentCommand = new PayRegistrationConciergeCommand();
            $paymentCommand->uuid = $registerCommand->uuid;
            $this->commandBus->handle($paymentCommand);

            return new RedirectResponse($this->router->generate('bcrmweb_concierge_index'));
        }
        return array(
            'form' => $form->createView(),
        );
    }

    /**
     * Allows the concierge to checkin attendees which did not bring their ticket,
     *
     * @Template()
     */
    public function manualCheckinAction()
    {
        $event = $this->eventRepo->getNextEvent()->getOrThrow(new AccessDeniedHttpException('No event.'));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        return array();
    }

    /**
     * Search for tickets
     *
     * @param Request $request
     */
    public function searchTicketAction(Request $request)
    {
        $event = $this->eventRepo->getNextEvent()->getOrThrow(new AccessDeniedHttpException('No event.'));
        // Do not allow checkins on the wrong day
        /* @var $event Event */
        $now   = new Carbon();
        $start = Carbon::createFromTimestamp($event->getStart()->getTimestamp());
        $start->setTime(0, 0, 0);
        $end = clone $start;
        $end->setTime(23, 59, 59);
        $day = $now->between($start, $end) ? Ticket::DAY_SATURDAY : Ticket::DAY_SUNDAY;

        $tickets  = array_map(function (Ticket $ticket) {
            return array(
                'code'      => $ticket->getCode(),
                'email'     => $ticket->getEmail(),
                'name'      => $ticket->getName(),
                'checkedIn' => $ticket->isCheckedIn(),
                'day'       => $ticket->getDay(),
                'id'        => $ticket->getId(),
            );
        }, $this->ticketRepo->searchTickets($event, $day, $request->get('q')));
        $data     = array('items' => $tickets);
        $response = new Response(json_encode($data));
        $response->setCharset('utf-8');
        $response->headers->set('Content-Type', 'application/json');
        return $response;
    }
}


1		<?php
2
3		/**
4		* @author Markus Tacker <[email protected]>
5		* @copyright 2013-2016 Verein zur Förderung der Netzkultur im Rhein-Main-Gebiet e.V. \| http://netzkultur-rheinmain.de/
6		*/
7
8		namespace BCRM\WebBundle\Controller;
9
10		use BCRM\BackendBundle\Entity\Event\Event;
11		use BCRM\BackendBundle\Entity\Event\EventRepository;
12		use BCRM\BackendBundle\Entity\Event\Registration;
13		use BCRM\BackendBundle\Entity\Event\Ticket;
14		use BCRM\BackendBundle\Entity\Event\TicketRepository;
15		use BCRM\BackendBundle\Service\Concierge\CheckinCommand;
16		use BCRM\BackendBundle\Service\Concierge\PayRegistrationConciergeCommand;
17		use BCRM\BackendBundle\Service\Event\CreateTicketCommand;
18		use BCRM\BackendBundle\Service\Event\RegisterCommand;
19		use BCRM\WebBundle\Content\ContentReader;
20		use BCRM\WebBundle\Exception\AccesDeniedHttpException;
21		use BCRM\WebBundle\Exception\BadRequestException;
22		use BCRM\WebBundle\Form\TicketType;
23		use Carbon\Carbon;
24		use LiteCQRS\Bus\CommandBus;
25		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
26		use Symfony\Component\Form\FormFactoryInterface;
27		use Symfony\Component\HttpFoundation\RedirectResponse;
28		use Symfony\Component\HttpFoundation\Request;
29		use Symfony\Component\HttpFoundation\Response;
30		use Symfony\Component\HttpFoundation\Session\Flash\FlashBagInterface;
31		use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
32		use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
33		use Symfony\Component\Routing\RouterInterface;
34		use Symfony\Component\Validator\Constraints\DateTime;
35		use Symfony\Component\Security\Core\Util\SecureRandom;
36
37		/**
38		* Dashboard for the event concierge.
39		*/
40		class ConciergeController
41		{
42	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2015-11-21 15:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		EventRepository $eventRepo,
44		TicketRepository $ticketRepo,
45		CommandBus $commandBus,
46		FormFactoryInterface $formFactory,
47		RouterInterface $router)
48		{
49		$this->eventRepo = $eventRepo;
		0 ignored issues – show Bug introduced 2015-11-21 15:50 UTC by Report Bug Copy Issue Report The property `eventRepo` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
50		$this->ticketRepo = $ticketRepo;
		0 ignored issues – show Bug introduced 2015-11-21 15:50 UTC by Report Bug Copy Issue Report The property `ticketRepo` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
51		$this->commandBus = $commandBus;
		0 ignored issues – show Bug introduced 2015-11-21 15:50 UTC by Report Bug Copy Issue Report The property `commandBus` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
52		$this->formFactory = $formFactory;
		0 ignored issues – show Bug introduced 2015-11-21 15:50 UTC by Report Bug Copy Issue Report The property `formFactory` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
53		$this->router = $router;
		0 ignored issues – show Bug introduced 2015-11-21 15:50 UTC by Report Bug Copy Issue Report The property `router` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
54		}
55
56		/**
57		* Dashboard index
58		*
59		* @Template()
60		*/
61		public function indexAction()
62		{
63		/* @var $event Event */
64		$event = $this->eventRepo->getNextEvent()->getOrThrow(new AccesDeniedHttpException('No event.'));
65
66		$stats = array();
67		foreach (array(Ticket::DAY_SATURDAY, Ticket::DAY_SUNDAY) as $day) {
68		$stats[$day] = array(
69		'tickets' => $this->ticketRepo->getTicketCountForEvent($event, $day),
70		'checkins' => $this->ticketRepo->getCheckinCountForEvent($event, $day),
71		);
72		}
73		$data = array('stats' => $stats);
74		return $data;
75		}
76
77		/**
78		* Concierges must be able to create Tickets manually.
79		*
80		* @Template()
81		*/
82		public function createTicketAction(Request $request)
83		{
84		$event = $this->eventRepo->getNextEvent()->getOrThrow(new AccessDeniedHttpException('No event.'));
85		$registration = new Registration();
86		$registration->setEvent($event);
87		$generator = new SecureRandom();
88		$registration->setUuid(sha1($generator->nextBytes(16)));
89		$form = $this->formFactory->create(new TicketType(), $registration, array('action' => $request->getPathInfo()));
90		$form->handleRequest($request);
91		if ($form->isValid()) {
92		/* @var Registration $formData */
93		$formData = $form->getData();
94		$registerCommand = new RegisterCommand();
95		$registerCommand->event = $event;
96		$registerCommand->email = $formData->getEmail();
97		$registerCommand->name = $formData->getName();
98		$registerCommand->twitter = $formData->getTwitter();
99		$registerCommand->saturday = $formData->getSaturday();
100		$registerCommand->sunday = $formData->getSunday();
101		$registerCommand->tags = $formData->getTags();
102		$registerCommand->type = $formData->getType();
103		$registerCommand->uuid = $formData->getUuid();
104		$registerCommand->payment = 'concierge';
105		$this->commandBus->handle($registerCommand);
106
107		// Create tickets
108		/* @var FlashBagInterface $fb */
109		$fb = $request->getSession()->getFlashBag();
110		foreach (
111		array(
112		Ticket::DAY_SATURDAY => $formData->getSaturday(),
113		Ticket::DAY_SUNDAY => $formData->getSunday(),
114		) as $day => $want) {
115		if (!$want) continue;
116		$ticketCommand = new CreateTicketCommand();
117		$ticketCommand->day = $day;
		0 ignored issues – show Documentation Bug introduced 2015-11-21 15:50 UTC by Report Bug Copy Issue Report It seems like `$day` can also be of type `string`. However, the property `$day` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
118		$ticketCommand->event = $event;
119		$ticketCommand->registration = $registration;
120		$this->commandBus->handle($ticketCommand);
121		$fb->add(
122		'info',
123		sprintf(
124		'Ticket für %s / %s angelegt.',
125		$registration->getEmail(),
126		$day == Ticket::DAY_SATURDAY ? 'Samstag' : 'Sonntag'
127		)
128		);
129		}
130
131		// Create payment
132		$paymentCommand = new PayRegistrationConciergeCommand();
133		$paymentCommand->uuid = $registerCommand->uuid;
134		$this->commandBus->handle($paymentCommand);
135
136		return new RedirectResponse($this->router->generate('bcrmweb_concierge_index'));
137		}
138		return array(
139		'form' => $form->createView(),
140		);
141		}
142
143		/**
144		* Allows the concierge to checkin attendees which did not bring their ticket,
145		*
146		* @Template()
147		*/
148		public function manualCheckinAction()
149		{
150		$event = $this->eventRepo->getNextEvent()->getOrThrow(new AccessDeniedHttpException('No event.'));
		0 ignored issues – show Unused Code introduced 2015-11-21 15:50 UTC by Report Bug Copy Issue Report `$event` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
151		return array();
152		}
153
154		/**
155		* Search for tickets
156		*
157		* @param Request $request
158		*/
159		public function searchTicketAction(Request $request)
160		{
161		$event = $this->eventRepo->getNextEvent()->getOrThrow(new AccessDeniedHttpException('No event.'));
162		// Do not allow checkins on the wrong day
163		/* @var $event Event */
164		$now = new Carbon();
165		$start = Carbon::createFromTimestamp($event->getStart()->getTimestamp());
166		$start->setTime(0, 0, 0);
167		$end = clone $start;
168		$end->setTime(23, 59, 59);
169		$day = $now->between($start, $end) ? Ticket::DAY_SATURDAY : Ticket::DAY_SUNDAY;
170
171		$tickets = array_map(function (Ticket $ticket) {
172		return array(
173		'code' => $ticket->getCode(),
174		'email' => $ticket->getEmail(),
175		'name' => $ticket->getName(),
176		'checkedIn' => $ticket->isCheckedIn(),
177		'day' => $ticket->getDay(),
178		'id' => $ticket->getId(),
179		);
180		}, $this->ticketRepo->searchTickets($event, $day, $request->get('q')));
181		$data = array('items' => $tickets);
182		$response = new Response(json_encode($data));
183		$response->setCharset('utf-8');
184		$response->headers->set('Content-Type', 'application/json');
185		return $response;
186		}
187		}
188

BCRM / www

ConciergeController B last analyzed 2016-11-21 12:30 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

ConciergeController B
last analyzed 2016-11-21 12:30 UTC