TranslationRelation::match() - Code Metrics - Inspection of "Merge pull request #5 from BBS-Lab/fix-queries" - BBS-Lab/nova-translation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b9cb31...17909b )

unknown

created 2020-03-10 18:17 UTC

TranslationRelation::match() A

↳ Parent: TranslationRelation

Complexity

Conditions	4
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.6333
c	0
b	0
f	0
cc	4
nc	3
nop	3

<?php

namespace BBSLab\NovaTranslation\Models;

use Illuminate\Database\Eloquent\Collection;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\Relation;
use Illuminate\Database\Query\Builder;
use Illuminate\Support\Facades\DB;

class TranslationRelation extends Relation
{
    /**
     * @var \BBSLab\NovaTranslation\Models\Translation|\Illuminate\Database\Eloquent\Builder
     */
    protected $query;

    /**
     * @var \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable
     */
    protected $parent;

    /**
     * @var \BBSLab\NovaTranslation\Models\Translation
     */
    protected $related;

    public function __construct(Model $parent)
    {
        parent::__construct(Translation::query(), $parent);
    }

    /**
     * {@inheritdoc}
     */
    public function addConstraints()
    {
        if (static::$constraints) {
            $this->query
                ->whereExists(function (Builder $query) {

                    $query->select(DB::raw(1))
                        ->from('translations as original')
                        ->whereRaw('original.translation_id = translations.translation_id')
                        ->where('original.translatable_id', '=', $this->parent->getKey())
                        ->where('original.translatable_type', '=', get_class($this->parent));
                })
                ->where('translatable_type', '=', get_class($this->parent))
                ->where('translatable_id', '<>', $this->parent->getKey());
        }
    }

    /**
     * {@inheritdoc}
     */
    public function addEagerConstraints(array $models)
    {
        $ids = collect($models)->pluck($this->parent->getKeyName());

        $this->query
            ->whereExists(function (Builder $query) use ($ids) {

                $query->select(DB::raw(1))
                    ->from('translations as original')
                    ->whereRaw('translations.translation_id = original.translation_id')
                    ->whereIn('original.translatable_id', $ids)
                    ->where('original.translatable_type', '=', get_class($this->parent));
            })
            ->where('translatable_type', '=', get_class($this->parent))
            ->whereNotIn('translatable_id', $ids);
    }

    /**
     * {@inheritdoc}
     */
    public function initRelation(array $models, $relation)
    {
        foreach ($models as $model) {
            /** @var \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable $model */
            $model->setRelation($relation, $this->related->newCollection());
        }

        return $models;
    }

    /**
     * {@inheritdoc}
     */
    public function match(array $models, Collection $results, $relation)
    {
        if ($results->isEmpty()) {
            return $models;
        }

        foreach ($models as $model) {
            /** @var \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable $model */
            $model->setRelation(
                $relation,
                $results->filter(function (Translation $translation) use ($model) {
                    return $translation->translation_id === $model->translation->translation_id
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                        && $translation->translatable_id !== $model->getKey();
                })
            );
        }

        return $models;
    }

    /**
     * {@inheritdoc}
     */
    public function getResults()
    {
        return ! is_null($this->getParent()->getKey())
            ? $this->query->get()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            : $this->related->newCollection();
    }
}


1		<?php
2
3		namespace BBSLab\NovaTranslation\Models;
4
5		use Illuminate\Database\Eloquent\Collection;
6		use Illuminate\Database\Eloquent\Model;
7		use Illuminate\Database\Eloquent\Relations\Relation;
8		use Illuminate\Database\Query\Builder;
9		use Illuminate\Support\Facades\DB;
10
11		class TranslationRelation extends Relation
12		{
13		/**
14		* @var \BBSLab\NovaTranslation\Models\Translation\|\Illuminate\Database\Eloquent\Builder
15		*/
16		protected $query;
17
18		/**
19		* @var \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable
20		*/
21		protected $parent;
22
23		/**
24		* @var \BBSLab\NovaTranslation\Models\Translation
25		*/
26		protected $related;
27
28		public function __construct(Model $parent)
29		{
30		parent::__construct(Translation::query(), $parent);
31		}
32
33		/**
34		* {@inheritdoc}
35		*/
36		public function addConstraints()
37		{
38		if (static::$constraints) {
39		$this->query
40	View Code Duplication	->whereExists(function (Builder $query) {
		0 ignored issues – show Duplication introduced 2020-03-10 16:40 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
41		$query->select(DB::raw(1))
42		->from('translations as original')
43		->whereRaw('original.translation_id = translations.translation_id')
44		->where('original.translatable_id', '=', $this->parent->getKey())
45		->where('original.translatable_type', '=', get_class($this->parent));
46		})
47		->where('translatable_type', '=', get_class($this->parent))
48		->where('translatable_id', '<>', $this->parent->getKey());
49		}
50		}
51
52		/**
53		* {@inheritdoc}
54		*/
55		public function addEagerConstraints(array $models)
56		{
57		$ids = collect($models)->pluck($this->parent->getKeyName());
58
59		$this->query
60	View Code Duplication	->whereExists(function (Builder $query) use ($ids) {
		0 ignored issues – show Duplication introduced 2020-03-10 16:40 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61		$query->select(DB::raw(1))
62		->from('translations as original')
63		->whereRaw('translations.translation_id = original.translation_id')
64		->whereIn('original.translatable_id', $ids)
65		->where('original.translatable_type', '=', get_class($this->parent));
66		})
67		->where('translatable_type', '=', get_class($this->parent))
68		->whereNotIn('translatable_id', $ids);
69		}
70
71		/**
72		* {@inheritdoc}
73		*/
74		public function initRelation(array $models, $relation)
75		{
76		foreach ($models as $model) {
77		/** @var \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable $model */
78		$model->setRelation($relation, $this->related->newCollection());
79		}
80
81		return $models;
82		}
83
84		/**
85		* {@inheritdoc}
86		*/
87		public function match(array $models, Collection $results, $relation)
88		{
89		if ($results->isEmpty()) {
90		return $models;
91		}
92
93		foreach ($models as $model) {
94		/** @var \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable $model */
95		$model->setRelation(
96		$relation,
97		$results->filter(function (Translation $translation) use ($model) {
98		return $translation->translation_id === $model->translation->translation_id
		0 ignored issues – show Bug introduced 2020-03-10 16:40 UTC by Report Bug Copy Issue Report Accessing `translation` on the interface `BBSLab\NovaTranslation\M...ontracts\IsTranslatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
99		&& $translation->translatable_id !== $model->getKey();
100		})
101		);
102		}
103
104		return $models;
105		}
106
107		/**
108		* {@inheritdoc}
109		*/
110		public function getResults()
111		{
112		return ! is_null($this->getParent()->getKey())
113		? $this->query->get()
		0 ignored issues – show Bug introduced 2020-03-10 16:40 UTC by Report Bug Copy Issue Report The method `get` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `BBSLab\NovaTranslation\Models\Translation`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
114		: $this->related->newCollection();
115		}
116		}
117

BBS-Lab / nova-translation

Push — master ( b9cb31...17909b )

TranslationRelation::match() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like