TranslatableObserver::deleted() - Code Metrics - Inspection of "Merge pull request #3 from BBS-Lab/refacto-observe..." - BBS-Lab/nova-translation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ca46fd...1d0b8e )

unknown

created 2020-02-04 16:20 UTC

TranslatableObserver::deleted() A

↳ Parent: TranslatableObserver

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	23
rs	9.552
c	0
b	0
f	0
cc	3
nc	3
nop	1

<?php

namespace BBSLab\NovaTranslation\Models\Observers;

use BBSLab\NovaTranslation\Models\Contracts\IsTranslatable;
use BBSLab\NovaTranslation\Models\Locale;
use BBSLab\NovaTranslation\Models\Translation;
use BBSLab\NovaTranslation\NovaTranslation;

class TranslatableObserver
{
    /**
     * Handle the Translatable "created" event.
     *
     * @param  \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable  $translatable
     * @return void
     * @throws \Exception
     */
    public function created(IsTranslatable $translatable)
    {
        $translation = $translatable->upsertTranslationEntry(
            ($currentLocale = NovaTranslation::currentLocale())->getKey(),
            0
        );

        if (! in_array(get_class($translatable), NovaTranslation::translatableModels())) {
            return;
        }

        $attributes = $translatable->only(
            $translatable->getOnCreateTranslatable()
        );

        $translatable::withoutEvents(function () use ($translatable, $translation, $currentLocale, $attributes) {
            NovaTranslation::otherLocales($currentLocale)->each(function (Locale $locale) use (
                $translatable, $translation, $attributes
            ) {
                /** @var \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable $model */
                $model = $translatable->query()->create($attributes);
                $model->upsertTranslationEntry($locale->getkey(), $translation->translation_id);
            });
        });
    }

    /**
     * Handle the Translatable "updated" event.
     *
     * @param  \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable  $translatable
     * @return void
     */
    public function updated(IsTranslatable $translatable)
    {
        $attributes = $translatable->only(
            $translatable->getNonTranslatable()
        );

        $translatable::withoutEvents(function () use ($translatable, $attributes) {
            $translatable->translations()->each(function ($model) use ($translatable, $attributes) {
                /** @var \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable $model */
                $model->update($attributes);
            });
        });
    }

    /**
     * Handle the Translatable "deleted" event.
     *
     * @param  \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable  $translatable
     * @return void
     */
    public function deleted(IsTranslatable $translatable)
    {
        Translation::query()
            ->where('translatable_id', '=', $translatable->translation->translatable_id)
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            ->where('translatable_type', '=', $translatable->translation->translatable_type)
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            ->where('translation_id', '=', $translatable->translation->translation_id)
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            ->where('locale_id', '=', $translatable->translation->locale_id)
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            ->delete();

        if (! in_array(get_class($translatable), NovaTranslation::translatableModels())) {
            return;
        }

        // Prevent deleted translation to delete other translations again.
        if ($translatable->deleting_translation) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return;
        }

        $translatable->translations()->each(function (IsTranslatable $translatable) {
            $translatable->deleting_translation = true;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $translatable->delete();
        });
    }
}


1			<?php
2
3			namespace BBSLab\NovaTranslation\Models\Observers;
4
5			use BBSLab\NovaTranslation\Models\Contracts\IsTranslatable;
6			use BBSLab\NovaTranslation\Models\Locale;
7			use BBSLab\NovaTranslation\Models\Translation;
8			use BBSLab\NovaTranslation\NovaTranslation;
9
10			class TranslatableObserver
11			{
12			/**
13			* Handle the Translatable "created" event.
14			*
15			* @param \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable $translatable
16			* @return void
17			* @throws \Exception
18			*/
19			public function created(IsTranslatable $translatable)
20			{
21			$translation = $translatable->upsertTranslationEntry(
22			($currentLocale = NovaTranslation::currentLocale())->getKey(),
23			0
24			);
25
26			if (! in_array(get_class($translatable), NovaTranslation::translatableModels())) {
27			return;
28			}
29
30			$attributes = $translatable->only(
31			$translatable->getOnCreateTranslatable()
32			);
33
34			$translatable::withoutEvents(function () use ($translatable, $translation, $currentLocale, $attributes) {
35			NovaTranslation::otherLocales($currentLocale)->each(function (Locale $locale) use (
36			$translatable, $translation, $attributes
37			) {
38			/** @var \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable $model */
39			$model = $translatable->query()->create($attributes);
40			$model->upsertTranslationEntry($locale->getkey(), $translation->translation_id);
41			});
42			});
43			}
44
45			/**
46			* Handle the Translatable "updated" event.
47			*
48			* @param \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable $translatable
49			* @return void
50			*/
51			public function updated(IsTranslatable $translatable)
52			{
53			$attributes = $translatable->only(
54			$translatable->getNonTranslatable()
55			);
56
57			$translatable::withoutEvents(function () use ($translatable, $attributes) {
58			$translatable->translations()->each(function ($model) use ($translatable, $attributes) {
59			/** @var \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable $model */
60			$model->update($attributes);
61			});
62			});
63			}
64
65			/**
66			* Handle the Translatable "deleted" event.
67			*
68			* @param \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable $translatable
69			* @return void
70			*/
71			public function deleted(IsTranslatable $translatable)
72			{
73			Translation::query()
74			->where('translatable_id', '=', $translatable->translation->translatable_id)
			0 ignored issues – show Bug introduced 2020-02-04 09:08 UTC by Report Bug Copy Issue Report Accessing `translation` on the interface `BBSLab\NovaTranslation\M...ontracts\IsTranslatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
75			->where('translatable_type', '=', $translatable->translation->translatable_type)
			0 ignored issues – show Bug introduced 2020-02-04 09:08 UTC by Report Bug Copy Issue Report Accessing `translation` on the interface `BBSLab\NovaTranslation\M...ontracts\IsTranslatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
76			->where('translation_id', '=', $translatable->translation->translation_id)
			0 ignored issues – show Bug introduced 2020-02-04 09:08 UTC by Report Bug Copy Issue Report Accessing `translation` on the interface `BBSLab\NovaTranslation\M...ontracts\IsTranslatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
77			->where('locale_id', '=', $translatable->translation->locale_id)
			0 ignored issues – show Bug introduced 2020-02-04 09:08 UTC by Report Bug Copy Issue Report Accessing `translation` on the interface `BBSLab\NovaTranslation\M...ontracts\IsTranslatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
78			->delete();
79
80			if (! in_array(get_class($translatable), NovaTranslation::translatableModels())) {
81			return;
82			}
83
84			// Prevent deleted translation to delete other translations again.
85			if ($translatable->deleting_translation) {
			0 ignored issues – show Bug introduced 2020-02-04 15:59 UTC by Report Bug Copy Issue Report Accessing `deleting_translation` on the interface `BBSLab\NovaTranslation\M...ontracts\IsTranslatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
86			return;
87			}
88
89			$translatable->translations()->each(function (IsTranslatable $translatable) {
90			$translatable->deleting_translation = true;
			0 ignored issues – show Bug introduced 2020-02-04 15:59 UTC by Report Bug Copy Issue Report Accessing `deleting_translation` on the interface `BBSLab\NovaTranslation\M...ontracts\IsTranslatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
91			$translatable->delete();
92			});
93			}
94			}
95

BBS-Lab / nova-translation

Push — master ( ca46fd...1d0b8e )

TranslatableObserver::deleted() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like