Translation::resolve() - Code Metrics - BBS-Lab/nova-translation - Measure and Improve Code Quality continuously with Scrutinizer

Translation::resolve() A
last analyzed 2021-05-06 12:44 UTC

↳ Parent: Translation

Complexity

Conditions	2
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	2
nc	1
nop	2

<?php

namespace BBSLab\NovaTranslation\Fields;

use BBSLab\NovaTranslation\Models\Contracts\IsTranslatable;
use BBSLab\NovaTranslation\Models\Locale;
use BBSLab\NovaTranslation\Models\Translation as TranslationModel;
use BBSLab\NovaTranslation\NovaTranslation;
use BBSLab\NovaTranslation\NovaTranslationServiceProvider;
use Laravel\Nova\Fields\Field;

class Translation extends Field
{
    /**
     * The field's component.
     *
     * @var string
     */
    public $component = 'nova-translation-field';

    public function __construct($name, $attribute = null, callable $resolveCallback = null)
    {
        $name = trans(NovaTranslationServiceProvider::PACKAGE_ID.'::lang.field');
        $attribute = 'translation';

        parent::__construct($name, $attribute, $resolveCallback);

        $this->withMeta([
            'locales' => $this->locales(),
        ]);
    }

    /**
     * {@inheritdoc}
     */
    public function resolve($resource, $attribute = null)
    {
        $this->withMeta([
            'translations' => $resource instanceof IsTranslatable ? $this->translations($resource) : [],
        ]);

        parent::resolve($resource, $attribute);
    }

    /**
     * Return all indexed locales.
     *
     * @return array
     * @throws \Exception
     */
    protected function locales()
    {
        return NovaTranslation::locales()->mapWithKeys(function (Locale $locale) {
            return [$locale->getKey() => $locale->toArray()];
        })->toArray();
    }

    /**
     * Return translations entries for given translatable model.
     *
     * @param  \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable  $resource
     * @return array
     */
    protected function translations(IsTranslatable $resource)
    {
        return $resource->translations->mapWithKeys(function (TranslationModel $translation) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return [
                $translation->locale_id => $translation->toArray(),
            ];
        })->toArray();
    }
}


1			<?php
2
3			namespace BBSLab\NovaTranslation\Fields;
4
5			use BBSLab\NovaTranslation\Models\Contracts\IsTranslatable;
6			use BBSLab\NovaTranslation\Models\Locale;
7			use BBSLab\NovaTranslation\Models\Translation as TranslationModel;
8			use BBSLab\NovaTranslation\NovaTranslation;
9			use BBSLab\NovaTranslation\NovaTranslationServiceProvider;
10			use Laravel\Nova\Fields\Field;
11
12			class Translation extends Field
13			{
14			/**
15			* The field's component.
16			*
17			* @var string
18			*/
19			public $component = 'nova-translation-field';
20
21			public function __construct($name, $attribute = null, callable $resolveCallback = null)
22			{
23			$name = trans(NovaTranslationServiceProvider::PACKAGE_ID.'::lang.field');
24			$attribute = 'translation';
25
26			parent::__construct($name, $attribute, $resolveCallback);
27
28			$this->withMeta([
29			'locales' => $this->locales(),
30			]);
31			}
32
33			/**
34			* {@inheritdoc}
35			*/
36			public function resolve($resource, $attribute = null)
37			{
38			$this->withMeta([
39			'translations' => $resource instanceof IsTranslatable ? $this->translations($resource) : [],
40			]);
41
42			parent::resolve($resource, $attribute);
43			}
44
45			/**
46			* Return all indexed locales.
47			*
48			* @return array
49			* @throws \Exception
50			*/
51			protected function locales()
52			{
53			return NovaTranslation::locales()->mapWithKeys(function (Locale $locale) {
54			return [$locale->getKey() => $locale->toArray()];
55			})->toArray();
56			}
57
58			/**
59			* Return translations entries for given translatable model.
60			*
61			* @param \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable $resource
62			* @return array
63			*/
64			protected function translations(IsTranslatable $resource)
65			{
66			return $resource->translations->mapWithKeys(function (TranslationModel $translation) {
			0 ignored issues – show Bug introduced 2020-03-10 16:40 UTC by Report Bug Copy Issue Report Accessing `translations` on the interface `BBSLab\NovaTranslation\M...ontracts\IsTranslatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
67			return [
68			$translation->locale_id => $translation->toArray(),
69			];
70			})->toArray();
71			}
72			}
73

BBS-Lab / nova-translation

Translation::resolve() A last analyzed 2021-05-06 12:44 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

Translation::resolve() A
last analyzed 2021-05-06 12:44 UTC