BBSLab\NovaTranslation\Models\TranslationRelation

Complexity

Total Complexity

12

Size/Duplication

Total Lines	106
Duplicated Lines	13.21 %

Coupling/Cohesion

Components	2
Dependencies	7

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	addConstraints()	7	15	2
A	addEagerConstraints()	7	15	1
A	initRelation()	0	9	2
A	match()	0	19	4
A	getResults()	0	6	2

<?php

namespace BBSLab\NovaTranslation\Models;

use Illuminate\Database\Eloquent\Collection;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\Relation;
use Illuminate\Database\Query\Builder;
use Illuminate\Support\Facades\DB;

class TranslationRelation extends Relation
{
    /**
     * @var \BBSLab\NovaTranslation\Models\Translation|\Illuminate\Database\Eloquent\Builder
     */
    protected $query;

    /**
     * @var \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable
     */
    protected $parent;

    /**
     * @var \BBSLab\NovaTranslation\Models\Translation
     */
    protected $related;

    public function __construct(Model $parent)
    {
        parent::__construct(Translation::query(), $parent);
    }

    /**
     * {@inheritdoc}
     */
    public function addConstraints()
    {
        if (static::$constraints) {
            $this->query

The method where does only exist in Illuminate\Database\Eloquent\Builder, but not in BBSLab\NovaTranslation\Models\Translation.

                ->where('translatable_id', '<>', $this->parent->getKey())
                ->where('translatable_type', '=', get_class($this->parent))
                ->whereExists(function (Builder $query) {

This code seems to be duplicated across your project.

                    $query->select(DB::raw(1))
                        ->from('translations as original')
                        ->whereRaw('original.translation_id = translations.translation_id')
                        ->where('original.translatable_id', '=', $this->parent->getKey())
                        ->where('original.translatable_type', '=', get_class($this->parent));
                });
        }
    }

    /**
     * {@inheritdoc}
     */
    public function addEagerConstraints(array $models)
    {
        $ids = collect($models)->pluck($this->parent->getKeyName());

        $this->query
            ->whereNotIn('translatable_id', $ids)
            ->where('translatable_type', '=', get_class($this->parent))
            ->whereExists(function (Builder $query) use ($ids) {

This code seems to be duplicated across your project.

                $query->select(DB::raw(1))
                    ->from('translations as original')
                    ->whereRaw('translations.translation_id = original.translation_id')
                    ->whereIn('original.translatable_id', $ids)
                    ->where('original.translatable_type', '=', get_class($this->parent));
            });
    }

    /**
     * {@inheritdoc}
     */
    public function initRelation(array $models, $relation)
    {
        foreach ($models as $model) {
            /** @var \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable $model */
            $model->setRelation($relation, $this->related->newCollection());
        }

        return $models;
    }

    /**
     * {@inheritdoc}
     */
    public function match(array $models, Collection $results, $relation)
    {
        if ($results->isEmpty()) {
            return $models;
        }

        foreach ($models as $model) {
            /** @var \BBSLab\NovaTranslation\Models\Contracts\IsTranslatable $model */
            $model->setRelation(
                $relation,
                $results->filter(function (Translation $translation) use ($model) {
                    return $translation->translation_id === $model->translation->translation_id

Accessing translation on the interface BBSLab\NovaTranslation\Models\Contracts\IsTranslatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                        && $translation->translatable_id !== $model->getKey();
                })
            );
        }

        return $models;
    }

    /**
     * {@inheritdoc}
     */
    public function getResults()
    {
        return ! is_null($this->getParent()->getKey())
            ? $this->query->get()

The method get does only exist in Illuminate\Database\Eloquent\Builder, but not in BBSLab\NovaTranslation\Models\Translation.

            : $this->related->newCollection();
    }
}