HasRoles::getOverridePermissionCacheKey() - Code Metrics - Inspection of "Store canOverridePermission in cache." - BBS-Lab/nova-permission - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 45adcc...2dccbe )

by Mikaël

created 2019-11-20 17:59 UTC

HasRoles::getOverridePermissionCacheKey() A

↳ Parent: HasRoles

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace BBSLab\NovaPermission\Traits;

use BBSLab\NovaPermission\Contracts\HasAuthorizations;
use Illuminate\Support\Str;
use Spatie\Permission\PermissionRegistrar;
use Spatie\Permission\Traits\HasRoles as BaseTrait;

trait HasRoles
{
    use BaseTrait;

    public function getOverridePermissionCacheTags(): array
    {
        return ['nova-permission', 'can-override'];
    }

    public function getOverridePermissionCacheKey(): string
    {
        return implode(':', [
            'nova-permission',
            'can-override',
            'user:'.$this->getKey(),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        ]);
    }

    public function canOverridePermission(): bool
    {
        /** @var \Illuminate\Contracts\Cache\Factory $cacheManager */
        $cacheManager = app('cache');

        $cache = method_exists($cacheManager->store(), 'tags')
            ? $cacheManager->store()->tags($this->getOverridePermissionCacheTags())

            : $cacheManager->store();

        $key = $this->getOverridePermissionCacheKey();

        return $cache->remember($key, PermissionRegistrar::$cacheExpirationTime, function () {
            $guard = config('nova.guard') ?? config('auth.defaults.guard');

            return $this->roles()
                ->where('guard_name', '=', $guard)
                ->where('override_permission', '=', true)
                ->exists();
        });
    }

    public function hasPermissionToOnModel($permission, $model = null, $guardName = null): bool
    {
        if (empty($model) || ! $model instanceof HasAuthorizations) {
            return $this->can($permission);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        $key = implode(':', [
            'nova-permission',
            'authorization',
            class_basename($model),
            $model->getKey(),

            Str::snake($permission)
        ]);

        /** @var \Illuminate\Contracts\Cache\Factory $cacheManager */
        $cacheManager = app('cache');

        $authorization = $cacheManager->store()
            ->remember($key, PermissionRegistrar::$cacheExpirationTime, function () use ($permission, $model, $guardName) {
                return $model->authorizations()
                    ->where('name', '=', $permission)
                    ->where('guand_name', '=', $guardName ?? $this->getDefaultGuardName())
                    ->first();
            });

        return ! empty($authorization)
            ? $this->hasPermissionTo($authorization)
            : $this->can($permission);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace BBSLab\NovaPermission\Traits;
4
5			use BBSLab\NovaPermission\Contracts\HasAuthorizations;
6			use Illuminate\Support\Str;
7			use Spatie\Permission\PermissionRegistrar;
8			use Spatie\Permission\Traits\HasRoles as BaseTrait;
9
10			trait HasRoles
11			{
12			use BaseTrait;
13
14			public function getOverridePermissionCacheTags(): array
15			{
16			return ['nova-permission', 'can-override'];
17			}
18
19			public function getOverridePermissionCacheKey(): string
20			{
21			return implode(':', [
22			'nova-permission',
23			'can-override',
24			'user:'.$this->getKey(),
			0 ignored issues – show Bug introduced 2019-11-20 18:08 UTC by Report Bug Copy Issue Report It seems like `getKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25			]);
26			}
27
28			public function canOverridePermission(): bool
29			{
30			/** @var \Illuminate\Contracts\Cache\Factory $cacheManager */
31			$cacheManager = app('cache');
32
33			$cache = method_exists($cacheManager->store(), 'tags')
34			? $cacheManager->store()->tags($this->getOverridePermissionCacheTags())
			0 ignored issues – show Bug introduced 2019-11-20 18:08 UTC by Report Bug Copy Issue Report The method `tags()` does not seem to exist on `object<Illuminate\Contracts\Cache\Repository>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
35			: $cacheManager->store();
36
37			$key = $this->getOverridePermissionCacheKey();
38
39			return $cache->remember($key, PermissionRegistrar::$cacheExpirationTime, function () {
40			$guard = config('nova.guard') ?? config('auth.defaults.guard');
41
42			return $this->roles()
43			->where('guard_name', '=', $guard)
44			->where('override_permission', '=', true)
45			->exists();
46			});
47			}
48
49			public function hasPermissionToOnModel($permission, $model = null, $guardName = null): bool
50			{
51			if (empty($model) \|\| ! $model instanceof HasAuthorizations) {
52			return $this->can($permission);
			0 ignored issues – show Bug introduced 2019-11-20 18:08 UTC by Report Bug Copy Issue Report It seems like `can()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
53			}
54
55			$key = implode(':', [
56			'nova-permission',
57			'authorization',
58			class_basename($model),
59			$model->getKey(),
			0 ignored issues – show Bug introduced 2019-11-20 18:08 UTC by Report Bug Copy Issue Report The method `getKey()` does not seem to exist on `object<BBSLab\NovaPermis...acts\HasAuthorizations>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
60			Str::snake($permission)
61			]);
62
63			/** @var \Illuminate\Contracts\Cache\Factory $cacheManager */
64			$cacheManager = app('cache');
65
66			$authorization = $cacheManager->store()
67			->remember($key, PermissionRegistrar::$cacheExpirationTime, function () use ($permission, $model, $guardName) {
68			return $model->authorizations()
69			->where('name', '=', $permission)
70			->where('guand_name', '=', $guardName ?? $this->getDefaultGuardName())
71			->first();
72			});
73
74			return ! empty($authorization)
75			? $this->hasPermissionTo($authorization)
76			: $this->can($permission);
			0 ignored issues – show Bug introduced 2019-11-20 18:08 UTC by Report Bug Copy Issue Report It seems like `can()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
77			}
78			}
79

BBS-Lab / nova-permission

Push — master ( 45adcc...2dccbe )

HasRoles::getOverridePermissionCacheKey() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like