Stopwatch::read() - Code Metrics - Inspection of "Improve tests with symfony phpunit bridge time() m..." - Ayesh/php-timer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aa3e12...c47ebf )

by Ayesh

created 2018-01-13 06:05 UTC

Stopwatch::read() A

↳ Parent: Stopwatch

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	0

<?php


namespace Ayesh\PHP_Timer;

class Stopwatch {
  private $accrued = 0;
  private $timestamp;
  private $running = false;

  public function __construct() {
    $this->start();
  }

  private function getTimestamp(): float {
    return microtime(true);
  }

  private function accrue(): void {
    $this->accrued = $this->read();
$answer = 42;

$correct = false;

$correct = (bool) $answer;
  }

  public function start(): void {
    if ($this->running) {
      return;
    }

    $this->accrue();
    $this->running = true;
    $this->timestamp = $this->getTimestamp();
  }

  public function read(): float {
    if ($this->running) {
      return $this->accrued + ($this->getTimestamp() - $this->timestamp);
    }
    return $this->accrued;
  }

  public function stop(): float {
    $this->accrue();
    $this->running = false;
    return $this->read();
  }
}


1			<?php
2
3
4			namespace Ayesh\PHP_Timer;
5
6			class Stopwatch {
7			private $accrued = 0;
8			private $timestamp;
9			private $running = false;
10
11			public function __construct() {
12			$this->start();
13			}
14
15			private function getTimestamp(): float {
16			return microtime(true);
17			}
18
19			private function accrue(): void {
20			$this->accrued = $this->read();
			0 ignored issues – show Documentation Bug introduced 2018-01-13 06:07 UTC by Report Bug Copy Issue Report The property `$accrued` was declared of type `integer`, but `$this->read()` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
21			}
22
23			public function start(): void {
24			if ($this->running) {
25			return;
26			}
27
28			$this->accrue();
29			$this->running = true;
30			$this->timestamp = $this->getTimestamp();
31			}
32
33			public function read(): float {
34			if ($this->running) {
35			return $this->accrued + ($this->getTimestamp() - $this->timestamp);
36			}
37			return $this->accrued;
38			}
39
40			public function stop(): float {
41			$this->accrue();
42			$this->running = false;
43			return $this->read();
44			}
45			}
46

Ayesh / php-timer

GitHub Access Token became invalid

Push — master ( aa3e12...c47ebf )

Stopwatch::read() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like