Issues in html-tax-rules-edit.php (master) - Issues in master - AyeCode/invoicing - Measure and Improve Code Quality continuously with Scrutinizer

Issues (850)

Security Analysis 4 potential vulnerabilities

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection (1)

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection (2)

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting (1)

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/admin/views/html-tax-rules-edit.php (1 issue)

Labels

Bug 1

Severity

Minor 1

<?php
/**
 * Displays the tax rules table.
 *
 */

defined( 'ABSPATH' ) || exit;

$dummy_rule = array(
    'key'               => 'TAX_RULE_KEY',
	'label'             => __( 'New Tax Rule', 'invoicing' ),
	'tax_base'          => wpinv_get_option( 'tax_base', 'billing' ),
    'same_country_rule' => wpinv_get_option( 'vat_same_country_rule', 'vat_too' ),
);

wp_nonce_field( 'wpinv_tax_rules', 'wpinv_tax_rules_nonce' );

?>
<div class="table-responsive">
    <table id="wpinv-tax-rules" class="widefat fixed table">
        <caption><?php echo esc_html_e( 'You can use this section to create or edit your tax rules', 'invoicing' ); ?></caption>
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

        <thead>
            <tr class="table-light">

                <th scope="col" class="border-bottom border-top">
                    <?php esc_html_e( 'Unique Key', 'invoicing' ); ?>
                </th>

                <th scope="col" class="border-bottom border-top">
                    <?php esc_html_e( 'Label', 'invoicing' ); ?>
                </th>

                <th scope="col" class="border-bottom border-top">
                    <?php esc_html_e( 'Calculate tax based on', 'invoicing' ); ?>
                </th>

                <!-- <th scope="col" class="border-bottom border-top">
                    <?php esc_html_e( 'Same country rule', 'invoicing' ); ?>
                    <?php getpaid_get_help_tip( __( 'What should happen if a customer is from the same country as your business?.', 'invoicing' ), 'position-static', true ); ?>
                </th> -->

                <th scope="col" class="border-bottom border-top" style="width:32px">&nbsp;</th>

            </tr>
        </thead>

        <tbody>
            <?php foreach ( GetPaid_Tax::get_all_tax_rules() as $tax_rule ) : ?>
                <?php include plugin_dir_path( __FILE__ ) . 'html-tax-rule-edit.php'; ?>
            <?php endforeach; ?>
        </tbody>

        <tfoot>
            <tr class="table-light">
                <td colspan="4" class="border-top">

                    <button type="button" class="button button-secondary wpinv_add_tax_rule" aria-label="<?php esc_attr_e( 'Add Tax Rule', 'invoicing' ); ?>">
                        <span><?php esc_html_e( 'Add Tax Rule', 'invoicing' ); ?></span>
                    </button>

                </td>
            </tr>
        </tfoot>
    </table>
</div>

<script type="text/html" id="tmpl-wpinv-tax-rule-row">
    <?php $tax_rule = $dummy_rule; ?>
    <?php include plugin_dir_path( __FILE__ ) . 'html-tax-rule-edit.php'; ?>
</script>



1			<?php
2			/**
3			* Displays the tax rules table.
4			*
5			*/
6
7			defined( 'ABSPATH' ) \|\| exit;
8
9			$dummy_rule = array(
10			'key' => 'TAX_RULE_KEY',
11			'label' => __( 'New Tax Rule', 'invoicing' ),
12			'tax_base' => wpinv_get_option( 'tax_base', 'billing' ),
13			'same_country_rule' => wpinv_get_option( 'vat_same_country_rule', 'vat_too' ),
14			);
15
16			wp_nonce_field( 'wpinv_tax_rules', 'wpinv_tax_rules_nonce' );
17
18			?>
19			<div class="table-responsive">
20			<table id="wpinv-tax-rules" class="widefat fixed table">
21			<caption><?php echo esc_html_e( 'You can use this section to create or edit your tax rules', 'invoicing' ); ?></caption>
			0 ignored issues – show Bug introduced 2022-04-06 09:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `esc_html_e('You can use ...ax rules', 'invoicing')` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
22
23			<thead>
24			<tr class="table-light">
25
26			<th scope="col" class="border-bottom border-top">
27			<?php esc_html_e( 'Unique Key', 'invoicing' ); ?>
28			</th>
29
30			<th scope="col" class="border-bottom border-top">
31			<?php esc_html_e( 'Label', 'invoicing' ); ?>
32			</th>
33
34			<th scope="col" class="border-bottom border-top">
35			<?php esc_html_e( 'Calculate tax based on', 'invoicing' ); ?>
36			</th>
37
38			<!-- <th scope="col" class="border-bottom border-top">
39			<?php esc_html_e( 'Same country rule', 'invoicing' ); ?>
40			<?php getpaid_get_help_tip( __( 'What should happen if a customer is from the same country as your business?.', 'invoicing' ), 'position-static', true ); ?>
41			</th> -->
42
43			<th scope="col" class="border-bottom border-top" style="width:32px"> </th>
44
45			</tr>
46			</thead>
47
48			<tbody>
49			<?php foreach ( GetPaid_Tax::get_all_tax_rules() as $tax_rule ) : ?>
50			<?php include plugin_dir_path( __FILE__ ) . 'html-tax-rule-edit.php'; ?>
51			<?php endforeach; ?>
52			</tbody>
53
54			<tfoot>
55			<tr class="table-light">
56			<td colspan="4" class="border-top">
57
58			<button type="button" class="button button-secondary wpinv_add_tax_rule" aria-label="<?php esc_attr_e( 'Add Tax Rule', 'invoicing' ); ?>">
59			<span><?php esc_html_e( 'Add Tax Rule', 'invoicing' ); ?></span>
60			</button>
61
62			</td>
63			</tr>
64			</tfoot>
65			</table>
66			</div>
67
68			<script type="text/html" id="tmpl-wpinv-tax-rule-row">
69			<?php $tax_rule = $dummy_rule; ?>
70			<?php include plugin_dir_path( __FILE__ ) . 'html-tax-rule-edit.php'; ?>
71			</script>
72
73

AyeCode / invoicing

Issues (850)

Security Analysis 4 potential vulnerabilities

includes/admin/views/html-tax-rules-edit.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like