Issues in class-wpinv-users.php (master) - Issues in master - AyeCode/invoicing - Measure and Improve Code Quality continuously with Scrutinizer

Issues (850)

Security Analysis 4 potential vulnerabilities

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection (1)

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection (2)

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting (1)

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/admin/class-wpinv-users.php (1 issue)

Labels

Unused Code 1

Severity

Minor 1

<?php
/**
 * Contains functions related to Invoicing users.
 *
 * @since 1.0.0
 * @package Invoicing
 */

// MUST have WordPress.
if ( ! defined( 'WPINC' ) ) {
    exit;
}

class WPInv_Admin_Users {
    private static $instance;

    public static function run() {
        if ( ! isset( self::$instance ) && ! ( self::$instance instanceof WPInv_Admin_Users ) ) {
            self::$instance = new WPInv_Admin_Users();
        }

        return self::$instance;
    }

    public function __construct() {
        add_filter( 'manage_users_columns', array( $this, 'wpinv_add_user_column' ) );
        add_filter( 'manage_users_custom_column', array( $this, 'wpinv_user_column_content' ), 10, 3 );
    }

    /**
     * Adds a new backend user column.
     *
     * @param $column
     *
     * @return mixed
     */
    public function wpinv_add_user_column( $column ) {
        $column['wpinvoicing'] = __( 'Invoicing', 'invoicing' );
        return $column;
    }

    /**
     * Add the backend user column content.
     *
     * @param $val
     * @param $column_name
     * @param $user_id
     *
     * @return string
     */
    public function wpinv_user_column_content( $val, $column_name, $user_id ) {
        switch ( $column_name ) {
            case 'wpinvoicing':
                return $this->get_user_invoices( $user_id );
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            default:
        }
        return $val;
    }

    /**
     * Get the backend user invoices.
     *
     * @param $user_id
     *
     * @return string
     */
    public function get_user_invoices( $user_id ) {
        $output = '';
        $wp_query_args = array(
            'post_type'      => 'wpi_invoice',
            'post_status'    => array( 'wpi-pending', 'publish', 'wpi-processing', 'wpi-onhold', 'wpi-refunded', 'wpi-cancelled', 'wpi-failed', 'wpi-renewal' ),
            'posts_per_page' => -1,
            'fields'         => 'ids',
            'author'         => $user_id,
        );

        $wp_query_args = apply_filters( 'wpinv_get_user_invoices_args', $wp_query_args, $user_id );

        $invoices = new WP_Query( $wp_query_args );
        $count = absint( $invoices->found_posts );

        if ( empty( $count ) ) {
            $output .= __( 'No Invoice(s)', 'invoicing' );
        } else {
            $link_url = admin_url( 'edit.php?post_type=wpi_invoice&author=' . absint( $user_id ) );
            $link_text = sprintf( __( 'Invoices ( %d )', 'invoicing' ), $count );
            $output .= "<a href='$link_url' >$link_text</a>";
        }

        return apply_filters( 'wpinv_user_invoice_content', $output, $user_id );
    }

}


1			<?php
2			/**
3			* Contains functions related to Invoicing users.
4			*
5			* @since 1.0.0
6			* @package Invoicing
7			*/
8
9			// MUST have WordPress.
10			if ( ! defined( 'WPINC' ) ) {
11			exit;
12			}
13
14			class WPInv_Admin_Users {
15			private static $instance;
16
17			public static function run() {
18			if ( ! isset( self::$instance ) && ! ( self::$instance instanceof WPInv_Admin_Users ) ) {
19			self::$instance = new WPInv_Admin_Users();
20			}
21
22			return self::$instance;
23			}
24
25			public function __construct() {
26			add_filter( 'manage_users_columns', array( $this, 'wpinv_add_user_column' ) );
27			add_filter( 'manage_users_custom_column', array( $this, 'wpinv_user_column_content' ), 10, 3 );
28			}
29
30			/**
31			* Adds a new backend user column.
32			*
33			* @param $column
34			*
35			* @return mixed
36			*/
37			public function wpinv_add_user_column( $column ) {
38			$column['wpinvoicing'] = __( 'Invoicing', 'invoicing' );
39			return $column;
40			}
41
42			/**
43			* Add the backend user column content.
44			*
45			* @param $val
46			* @param $column_name
47			* @param $user_id
48			*
49			* @return string
50			*/
51			public function wpinv_user_column_content( $val, $column_name, $user_id ) {
52			switch ( $column_name ) {
53			case 'wpinvoicing':
54			return $this->get_user_invoices( $user_id );
55			break;
			0 ignored issues – show Unused Code introduced 2020-01-24 13:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
56			default:
57			}
58			return $val;
59			}
60
61			/**
62			* Get the backend user invoices.
63			*
64			* @param $user_id
65			*
66			* @return string
67			*/
68			public function get_user_invoices( $user_id ) {
69			$output = '';
70			$wp_query_args = array(
71			'post_type' => 'wpi_invoice',
72			'post_status' => array( 'wpi-pending', 'publish', 'wpi-processing', 'wpi-onhold', 'wpi-refunded', 'wpi-cancelled', 'wpi-failed', 'wpi-renewal' ),
73			'posts_per_page' => -1,
74			'fields' => 'ids',
75			'author' => $user_id,
76			);
77
78			$wp_query_args = apply_filters( 'wpinv_get_user_invoices_args', $wp_query_args, $user_id );
79
80			$invoices = new WP_Query( $wp_query_args );
81			$count = absint( $invoices->found_posts );
82
83			if ( empty( $count ) ) {
84			$output .= __( 'No Invoice(s)', 'invoicing' );
85			} else {
86			$link_url = admin_url( 'edit.php?post_type=wpi_invoice&author=' . absint( $user_id ) );
87			$link_text = sprintf( __( 'Invoices ( %d )', 'invoicing' ), $count );
88			$output .= "<a href='$link_url' >$link_text</a>";
89			}
90
91			return apply_filters( 'wpinv_user_invoice_content', $output, $user_id );
92			}
93
94			}
95

AyeCode / invoicing

Issues (850)

Security Analysis 4 potential vulnerabilities

includes/admin/class-wpinv-users.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like