WPInv_Recurring_Admin::add_submenu() - Code Metrics - Inspection of "create item & create invoice changes" - AyeCode/invoicing - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#47)

by Kiran

created 2017-08-03 14:10 UTC

WPInv_Recurring_Admin::add_submenu() A

↳ Parent: WPInv_Recurring_Admin

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	9
nc	1
nop	0
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0

<?php
if ( ! defined( 'ABSPATH' ) ) {
    exit; // Exit if accessed directly
}

class WPInv_Recurring_Admin {
    
    /**
     * Get started
     */
    function __construct() {

        self::actions();
        self::filters();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
    }

     /**
     * Add actions
     *
     * @since  1.0.0
     * @return void
     */
    private function actions() {
        add_action( 'admin_menu', array( $this, 'add_submenu' ), 11 );

        // Register styles
        add_action( 'wp_enqueue_scripts', array( $this, 'enqueue_styles' ) );

        // Register scripts
        add_action( 'wp_enqueue_scripts', array( $this, 'enqueue_scripts' ) );
    }

    /**
     * Add filters
     *
     * @since  1.0.0
     * @return void
     */
    private function filters() {
    }
    
    public function add_submenu() {
        global $wpi_subscriptions_page;
        
        $wpi_subscriptions_page = add_submenu_page( 
            'wpinv', 
            __( 'Subscriptions', 'invoicing' ), 
            __( 'Subscriptions', 'invoicing' ), 
            'manage_options', 
            'wpinv-subscriptions', 
            array( $this, 'subscriptions_page' ) 
        );
    }
    
    public function subscriptions_page() {
        wpinv_recurring_subscriptions_list();
    }

    /**
     * Load frontend styles
     *
     * @since  1.0.0
     * @return bool
     */
    public function enqueue_styles() {
    }

    /**
     * Load frontend javascript files
     *
     * @since  1.0.0
     * @return bool
     */
    public function enqueue_scripts() {
    }
}

new WPInv_Recurring_Admin();

1			<?php
2			if ( ! defined( 'ABSPATH' ) ) {
3			exit; // Exit if accessed directly
4			}
5
6			class WPInv_Recurring_Admin {
7
8			/**
9			* Get started
10			*/
11			function __construct() {
			0 ignored issues – show Best Practice introduced 2017-08-03 14:14 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
12			self::actions();
13			self::filters();
			0 ignored issues – show Unused Code introduced 2017-08-03 14:14 UTC by Report Bug Copy Issue Report The call to the method `WPInv_Recurring_Admin::filters()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
14			}
15
16			/**
17			* Add actions
18			*
19			* @since 1.0.0
20			* @return void
21			*/
22			private function actions() {
23			add_action( 'admin_menu', array( $this, 'add_submenu' ), 11 );
24
25			// Register styles
26			add_action( 'wp_enqueue_scripts', array( $this, 'enqueue_styles' ) );
27
28			// Register scripts
29			add_action( 'wp_enqueue_scripts', array( $this, 'enqueue_scripts' ) );
30			}
31
32			/**
33			* Add filters
34			*
35			* @since 1.0.0
36			* @return void
37			*/
38			private function filters() {
39			}
40
41			public function add_submenu() {
42			global $wpi_subscriptions_page;
43
44			$wpi_subscriptions_page = add_submenu_page(
45			'wpinv',
46			__( 'Subscriptions', 'invoicing' ),
47			__( 'Subscriptions', 'invoicing' ),
48			'manage_options',
49			'wpinv-subscriptions',
50			array( $this, 'subscriptions_page' )
51			);
52			}
53
54			public function subscriptions_page() {
55			wpinv_recurring_subscriptions_list();
56			}
57
58			/**
59			* Load frontend styles
60			*
61			* @since 1.0.0
62			* @return bool
63			*/
64			public function enqueue_styles() {
65			}
66
67			/**
68			* Load frontend javascript files
69			*
70			* @since 1.0.0
71			* @return bool
72			*/
73			public function enqueue_scripts() {
74			}
75			}
76
77			new WPInv_Recurring_Admin();

AyeCode / invoicing

Pull Request — master (#47)

WPInv_Recurring_Admin::add_submenu() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like