WPInv_Meta_Box_Details::subscriptions()

Complexity

Conditions	12
Paths	14

Size

Total Lines	52
Code Lines	47

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function subscriptions( $post ) {
        $invoice = wpinv_get_invoice( $post->ID );

        if ( ! empty( $invoice ) && $invoice->is_recurring() && $invoice->is_parent() ) {
            $subscription = wpinv_get_subscription( $invoice );

            if ( empty( $subscription ) ) {
                ?>
                <p class="wpi-meta-row"><?php echo wp_sprintf( __( 'New Subscription will be created when customer will checkout and pay the invoice. Go to: %sSubscriptions%s', 'invoicing' ), '<a href="' . admin_url( 'admin.php?page=wpinv-subscriptions' ).'">', '</a>' ); ?></p>
                <?php
                return;
            }
            $frequency = WPInv_Subscriptions::wpinv_get_pretty_subscription_frequency( $subscription->period, $subscription->frequency );

It seems like $subscription->frequency can also be of type WP_Error; however, parameter $frequency_count of WPInv_Subscriptions::wpinv_get_pretty_subscription_frequency() does only seem to accept integer, maybe add an additional type check?

The property frequency does not exist on WPInv_Subscription. Since you implemented __get, consider adding a @property annotation.

            $billing = wpinv_price(wpinv_format_amount( $subscription->recurring_amount ), wpinv_get_invoice_currency_code( $subscription->parent_payment_id ) ) . ' / ' . $frequency;
            $initial = wpinv_price(wpinv_format_amount( $subscription->initial_amount ), wpinv_get_invoice_currency_code( $subscription->parent_payment_id ) );
            $payments = $subscription->get_child_payments();
            ?>
            <p class="wpi-meta-row wpi-sub-label <?php echo 'status-' . $subscription->status; ?>"><?php _e('Recurring Payment', 'invoicing'); ?></p>
            <?php if ( ! empty( $subscription ) && ! empty( $subscription->id ) ) { ?>
                <p class="wpi-meta-row wpi-sub-id">
                    <label><?php _e( 'Subscription ID:', 'invoicing' ); ?> </label><a href="<?php echo esc_url( admin_url( 'admin.php?page=wpinv-subscriptions&id=' . $subscription->id ) ); ?>" title="<?php esc_attr_e( 'View or edit subscription', 'invoicing' ); ?>" target="_blank"><?php echo $subscription->id; ?></a></p>
            <?php } ?>
            <p class="wpi-meta-row wpi-bill-cycle">
                <label><?php _e( 'Billing Cycle:', 'invoicing'); ?> </label><?php printf( _x( '%s then %s', 'Initial subscription amount then billing cycle and amount', 'invoicing' ), $initial, $billing ); ?>
            </p>
            <p class="wpi-meta-row wpi-billed-times">
                <label><?php _e( 'Times Billed:', 'invoicing' ); ?> </label><?php echo $subscription->get_times_billed() . ' / ' . ( ( $subscription->bill_times == 0 ) ? 'Until Cancelled' : $subscription->bill_times ); ?>
            </p>
            <p class="wpi-meta-row wpi-start-date">
                <label><?php _e( 'Start Date:', 'invoicing' ); ?> </label><?php echo date_i18n( get_option( 'date_format' ), strtotime( $subscription->created, current_time( 'timestamp' ) ) ); ?>

It seems like get_option('date_format') can also be of type false; however, parameter $format of date_i18n() does only seem to accept string, maybe add an additional type check?

            </p>
            <p class="wpi-meta-row wpi-end-date">
                <label><?php echo ( 'trialling' == $subscription->status ? __( 'Trialling Until:', 'invoicing' ) : __( 'Expiration Date:', 'invoicing' ) ); ?> </label><?php echo date_i18n( get_option( 'date_format' ), strtotime( $subscription->expiration, current_time( 'timestamp' ) ) ); ?>
            </p>
            <?php if ( $subscription->status ) { ?>
                <p class="wpi-meta-row wpi-sub-status">
                    <label><?php _e( 'Subscription Status:', 'invoicing'); ?> </label><?php echo $subscription->get_status_label(); ?>
                </p>
            <?php } ?>
            <?php if ( !empty( $payments ) ) { ?>
                <p><strong><?php _e( 'Renewal Payments:', 'invoicing' ); ?></strong></p>
                <ul id="wpi-sub-payments">
                <?php foreach ( $payments as $payment ) {
                    $invoice_id = $payment->ID;
                    ?>
                    <li>
                        <a href="<?php echo esc_url( get_edit_post_link( $invoice_id ) ); ?>"><?php echo wpinv_get_invoice_number( $invoice_id ); ?></a>&nbsp;&ndash;&nbsp;
                        <span><?php echo wpinv_get_invoice_date( $invoice_id ); ?>&nbsp;&ndash;&nbsp;</span>
                        <span><?php echo wpinv_payment_total( $invoice_id, true ); ?></span>
                    </li>
                <?php } ?>
                </ul>
            <?php }