Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
4 | class DokuWikiInstaller extends BaseInstaller |
||
5 | { |
||
6 | protected $locations = array( |
||
7 | 'plugin' => 'lib/plugins/{$name}/', |
||
8 | 'template' => 'lib/tpl/{$name}/', |
||
9 | ); |
||
10 | |||
11 | /** |
||
12 | * Format package name. |
||
13 | * |
||
14 | * For package type dokuwiki-plugin, cut off a trailing '-plugin', |
||
15 | * or leading dokuwiki_ if present. |
||
16 | * |
||
17 | * For package type dokuwiki-template, cut off a trailing '-template' if present. |
||
18 | * |
||
19 | */ |
||
20 | public function inflectPackageVars($vars) |
||
33 | |||
34 | View Code Duplication | protected function inflectPluginVars($vars) |
|
41 | |||
42 | View Code Duplication | protected function inflectTemplateVars($vars) |
|
49 | |||
50 | } |
||
51 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.