AyeCode /
invoicing
| Conditions | 2 |
| Paths | 2 |
| Total Lines | 78 |
| Code Lines | 33 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 14 | public static function output ( $post ) { |
||
| 15 | $success_page = get_post_meta( $post->ID, 'wpinv_success_page', true ); |
||
| 16 | $success_page = empty( $success_page ) ? wpinv_get_success_page_uri() : $success_page |
||
| 17 | ?> |
||
| 18 | |||
| 19 | <div id="wpinv-form-builder" style="display: flex; flex-flow: wrap;"> |
||
| 20 | |||
| 21 | <div class="wpinv-form-builder-left bsui" style="flex: 0 0 320px;"> |
||
| 22 | <ul class="wpinv-form-builder-tabs nav nav-tabs"> |
||
| 23 | <li class='nav-item' v-if="active_tab!='new_item'"> |
||
| 24 | <a @click.prevent="active_tab='new_item'" class="nav-link p-3" :class="{ 'active': active_tab=='new_item' }" href="#"><?php _e( 'Add new element', 'invoicing' ); ?></a> |
||
| 25 | </li> |
||
| 26 | <li class='nav-item' v-if='false'> |
||
| 27 | <a @click.prevent="active_tab='edit_item'" class="nav-link p-3" :class="{ 'active': active_tab=='edit_item' }" href="#"><?php _e( 'Edit element', 'invoicing' ); ?></a> |
||
| 28 | </li> |
||
| 29 | <li class='nav-item' v-if='false'> |
||
| 30 | <a @click.prevent="active_tab='settings'" class="nav-link p-3" :class="{ 'active': active_tab=='settings' }" href="#"><?php _e( 'Settings', 'invoicing' ); ?></a> |
||
| 31 | </li> |
||
| 32 | </ul> |
||
| 33 | |||
| 34 | <div class="wpinv-form-builder-tab-content bsui" style="margin-top: 16px;"> |
||
| 35 | <div class="wpinv-form-builder-tab-pane" v-if="active_tab=='new_item'"> |
||
| 36 | <div class="wpinv-form-builder-add-field-types"> |
||
| 37 | <small class='form-text text-muted'><?php _e( 'Add an element by dragging it to the payment form.', 'invoicing' ); ?></small> |
||
| 38 | <draggable class="section mt-2" style="display: flex; flex-flow: wrap; justify-content: space-between;" v-model="elements" :group="{ name: 'fields', pull: 'clone', put: false }" :sort="false" :clone="addDraggedField" tag="ul" filter=".wpinv-undraggable"> |
||
| 39 | <li v-for="element in elements" style="width: 49%; background-color: #fafafa; margin-bottom: 9px; cursor: move; border: 1px solid #eeeeee;" @click.prevent="addField(element)"> |
||
| 40 | <button class="button btn" style="width: 100%; cursor: move;"> |
||
| 41 | <span v-if="element.icon" class="dashicons dashicon-" :class="'dashicon-' + element.icon"></span> |
||
| 42 | {{element.name}} |
||
| 43 | </button> |
||
| 44 | </li> |
||
| 45 | </draggable> |
||
| 46 | |||
| 47 | </div> |
||
| 48 | </div> |
||
| 49 | |||
| 50 | <div class="wpinv-form-builder-tab-pane bsui" v-if="active_tab=='edit_item'" style="font-size: 16px;"> |
||
| 51 | <div class="wpinv-form-builder-edit-field-wrapper"> |
||
| 52 | <?php do_action( 'wpinv_payment_form_edit_element_template', 'active_form_element', $post ); ?> |
||
| 53 | <div> |
||
| 54 | <button type="button" class="button button-link button-link-delete" @click.prevent="removeField(active_form_element)"><?php _e( 'Delete Field', 'invoicing' ); ?></button> |
||
| 55 | </div> |
||
| 56 | </div> |
||
| 57 | </div> |
||
| 58 | |||
| 59 | <div class="wpinv-form-builder-tab-pane bsui" v-if="active_tab=='settings'"> |
||
| 60 | <div class="wpinv-form-builder-settings-wrapper"> |
||
| 61 | |||
| 62 | <div class='form-group'> |
||
| 63 | <label for="wpi-success-page"><?php _e( 'Success Page', 'invoicing' ); ?></label> |
||
| 64 | <input placeholder="https://" id='wpi-success-page' value="<?php echo esc_url( $success_page ); ?>" class='form-control' type='text'> |
||
|
Bug
introduced
by
|
|||
| 65 | <small class='form-text text-muted'><?php _e( 'Where should we redirect users after successfuly completing their payment?', 'invoicing' ); ?></small> |
||
| 66 | </div> |
||
| 67 | |||
| 68 | </div> |
||
| 69 | </div> |
||
| 70 | |||
| 71 | </div> |
||
| 72 | </div> |
||
| 73 | |||
| 74 | <div class="wpinv-form-builder-right" style="flex: 1; padding-top: 40px;border-left: 1px solid #ddd;padding-left: 20px;min-height: 520px;margin-left: 10px;"> |
||
| 75 | |||
| 76 | <small class='form-text text-muted' v-if='form_elements.length'><?php _e( 'Click on any element to edit or delete it.', 'invoicing' ); ?></small> |
||
| 77 | <p class='form-text text-muted' v-if='! form_elements.length'><?php _e( 'This form is empty. Add new elements by dragging them from the right.', 'invoicing' ); ?></p> |
||
| 78 | |||
| 79 | <draggable class="section bsui" v-model="form_elements" @add="highlightLastDroppedField" group="fields" tag="div" style="min-height: 100%; font-size: 16px;"> |
||
| 80 | <div v-for="form_element in form_elements" class="wpinv-form-builder-element-preview" :class="{ active: active_form_element==form_element && active_tab=='edit_item' }" @click="active_tab = 'edit_item'; active_form_element = form_element"> |
||
| 81 | <?php do_action( 'wpinv_payment_form_render_element_template', 'form_element', $post ); ?> |
||
| 82 | </div> |
||
| 83 | </draggable> |
||
| 84 | </div> |
||
| 85 | |||
| 86 | <textarea style="display:none;" name="wpinv_form_elements" v-model="elementString"></textarea> |
||
| 87 | <textarea style="display:none;" name="wpinv_form_items" v-model="itemString"></textarea> |
||
| 88 | </div> |
||
| 89 | |||
| 90 | <?php wp_nonce_field( 'wpinv_save_payment_form', 'wpinv_save_payment_form' ) ;?> |
||
| 91 | |||
| 92 | <?php |
||
| 189 |
Loading history...