AyeCode_UI_Settings::get_settings()

Complexity

Conditions	6
Paths	8

Size

Total Lines	45
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
		public function get_settings() {

			$db_settings = get_option( 'ayecode-ui-settings' );

            // Maybe show default version notice
			$site_install_date = new DateTime( self::get_site_install_date() );

The method AyeCode_UI_Settings::get_site_install_date() is not static, but was called statically.

It seems like self::get_site_install_date() can also be of type false; however, parameter $datetime of DateTime::__construct() does only seem to accept string, maybe add an additional type check?

			$switch_over_date = new DateTime("2024-02-01");
			if ( empty( $db_settings ) && $site_install_date < $switch_over_date ) {
				add_action( 'admin_notices', array( $this, 'show_admin_version_notice' ) );
			}

			$js_default = 'core-popper';
			$js_default_backend = $js_default;

			// maybe set defaults (if no settings set)
			if(empty($db_settings)){
				$active_theme = strtolower( get_template() ); // active parent theme.
				$theme_js_settings = self::theme_js_settings();

The method AyeCode_UI_Settings::theme_js_settings() is not static, but was called statically.

				if(isset($theme_js_settings[$active_theme])){
					$js_default = $theme_js_settings[$active_theme];
					$js_default_backend = isset($theme_js_settings[$active_theme."_backend"]) ? $theme_js_settings[$active_theme."_backend"] : $js_default;
				}
			}

			/**
			 * Filter the default settings.
			 */
			$defaults = apply_filters( 'ayecode-ui-default-settings', array(
				'css'            => 'compatibility', // core, compatibility
				'js'             => $js_default, // js to load, core-popper, popper
				'html_font_size' => '16', // js to load, core-popper, popper
				'css_backend'    => 'compatibility', // core, compatibility
				'js_backend'     => $js_default_backend, // js to load, core-popper, popper
				'disable_admin'  => '', // URL snippets to disable loading on admin
                'bs_ver'         => '5', // The default bootstrap version to sue by default
			), $db_settings );

			$settings = wp_parse_args( $db_settings, $defaults );

			/**
			 * Filter the Bootstrap settings.
			 *
			 * @todo if we add this filer people might use it and then it defeats the purpose of this class :/
			 */
			return $this->settings = apply_filters( 'ayecode-ui-settings', $settings, $db_settings, $defaults );
		}
}