SyncServiceTest::tearDown() - Code Metrics - Inspection of "Finished unit tests, 100% coverage!" - AxaliaN/toggl-jira - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions
Push — master ( 4f9353...7eeb29 )

by Michel
created 2018-04-03 20:04 UTC
SyncServiceTest::tearDown() A

↳ Parent: SyncServiceTest
Complexity

Conditions	2
Paths	2
Size

Total Lines	4
Code Lines	2
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	2
eloc	2
nc	2
nop	0
<?php
declare(strict_types=1);

namespace TogglJiraTest\Service;

use AJT\Toggl\TogglClient;
use DateTimeImmutable;
use Mockery\Exception;
use Mockery\MockInterface;
use PHPUnit\Framework\TestCase;
use Psr\Log\LoggerInterface;
use TogglJira\Entity\WorkLogEntry;
use TogglJira\Hydrator\WorkLogHydrator;
use TogglJira\Jira\Api;
use TogglJira\Service\SyncService;

class SyncServiceTest extends TestCase
{
    /**
     * @var MockInterface
     */
    private $apiMock;

    /**
     * @var MockInterface
     */
    private $togglClientMock;

    /**
     * @var MockInterface
     */
    private $hydratorMock;

    /**
     * @var MockInterface
     */
    private $loggerMock;

    /**
     * @var SyncService
     */
    private $service;

    /**
     * @return void
     */
    public function setUp(): void
    {
       \ Mockery::getConfiguration()->allowMockingNonExistentMethods(true);

        $this->apiMock = \Mockery::mock(Api::class);
        $this->apiMock = \Mockery::mock(/** @scrutinizer ignore-type */ Api::class);
        $this->togglClientMock = \Mockery::mock(TogglClient::class);
        $this->hydratorMock = \Mockery::mock(WorkLogHydrator::class);
        $this->loggerMock = \Mockery::mock(LoggerInterface::class);

        $this->service = new SyncService($this->apiMock, $this->togglClientMock, $this->hydratorMock, 'D-Va');
        $this->service = new SyncService($this->apiMock, /** @scrutinizer ignore-type */ $this->togglClientMock, $this->hydratorMock, 'D-Va');

        $this->service->setLogger($this->loggerMock);
        $this->service->setLogger(/** @scrutinizer ignore-type */ $this->loggerMock);
    }

    /**
     * @return void
     * @throws \Exception
     */
    public function testSync(): void
    {
        $dateTime = '2017-04-15T23:35:00+02:00';

        $timeEntries = [
            [
                'description' => 'SLR-76 Soldier 76',
                'duration' => 76,
                'comment' => 'Soldier 76, reporting for duty',
                'at' => '2018-02-15'
            ],
            [
                'description' => 'DVA-76 D-Va',
                'duration' => 42,
                'comment' => 'Nerf this!',
                'at' => '2018-02-15'
            ],
        ];

        $this->togglClientMock->shouldReceive('getTimeEntries')
        $this->togglClientMock->shouldReceive(/** @scrutinizer ignore-type */ 'getTimeEntries')
            ->with(['start_date' => $dateTime])
            ->andReturn($timeEntries);

        $workLogEntry = new WorkLogEntry();
        $workLogEntry->setIssueID('SLR-76');
        $workLogEntry->setSpentOn(new DateTimeImmutable($dateTime));
        $workLogEntry->setComment('SLR-76');
        $workLogEntry->setTimeSpent(76);

        $this->hydratorMock->shouldReceive('hydrate')->andReturn($workLogEntry);
        $this->hydratorMock->shouldReceive('hydrate')->andReturn(/** @scrutinizer ignore-type */ $workLogEntry);

        $this->apiMock->shouldReceive('addWorkLogEntry')->with(
            $workLogEntry->getIssueID(),
            /** @scrutinizer ignore-type */ $workLogEntry->getIssueID(),
            $workLogEntry->getTimeSpent(),
            /** @scrutinizer ignore-type */ $workLogEntry->getTimeSpent(),
            'D-Va',
            $workLogEntry->getComment(),
            $dateTime
        );

        $this->loggerMock
            ->shouldReceive('info')
            ->with("Found time entry for user story {$workLogEntry->getIssueID()}");

        $this->loggerMock
            ->shouldReceive('info')
            ->with("Added worklog entry for issue {$workLogEntry->getIssueID()}");

        $this->loggerMock->shouldReceive('info')->with('All done for today, time to go home!');

        $this->service->sync($dateTime);
    }

    /**
     * @return void
     * @throws \Exception
     */
    public function testExceptionOnTogglError(): void
    {
        $dateTime = '2017-04-15T23:35:00+02:00';

        $this->togglClientMock->shouldReceive('getTimeEntries')
        $this->togglClientMock->shouldReceive(/** @scrutinizer ignore-type */ 'getTimeEntries')
            ->with(['start_date' => $dateTime])
            ->andThrow(\Exception::class, 'Nerf this!');

        $this->loggerMock->shouldReceive('error')
            ->with('Failed to get time entries from Toggl: Nerf this!', \Mockery::any());
            ->with('Failed to get time entries from Toggl: Nerf this!', /** @scrutinizer ignore-type */ \Mockery::any());

        $this->service->sync($dateTime);
    }

    /**
     * @return void
     * @throws \Exception
     */
    public function testSyncWithInvalidTimeEntries(): void
    {
        $dateTime = '2017-04-15T23:35:00+02:00';

        $timeEntries = [
            [
                'description' => 'SLR76 Soldier 76',
                'duration' => 76,
                'comment' => 'Soldier 76, not reporting for duty',
                'at' => '2018-02-15'
            ],
            [
                'description' => 'SLR-76 Soldier 76',
                'duration' => -1,
                'comment' => 'Soldier 76, not reporting for duty',
                'at' => '2018-02-15'
            ],
        ];

        $this->togglClientMock->shouldReceive('getTimeEntries')
        $this->togglClientMock->shouldReceive(/** @scrutinizer ignore-type */ 'getTimeEntries')
            ->with(['start_date' => $dateTime])
            ->andReturn($timeEntries);

        $this->loggerMock->shouldReceive('warning'
        )->with('Could not parse issue string, cannot link to Jira');
        )->with(/** @scrutinizer ignore-type */ 'Could not parse issue string, cannot link to Jira');

        $this->loggerMock->shouldReceive('info')
            ->with('0 seconds, or timer still running for SLR-76, skipping');

        $this->loggerMock->shouldReceive('info')->with('All done for today, time to go home!');

        $this->service->sync($dateTime);
    }

    /**
     * @return void
     * @throws \Exception
     */
    public function testSyncJiraException(): void
    {
        $dateTime = '2017-04-15T23:35:00+02:00';

        $timeEntries = [
            [
                'description' => 'SLR-76 Soldier 76',
                'duration' => 76,
                'comment' => 'Soldier 76, reporting for duty',
                'at' => '2018-02-15'
            ],
            [
                'description' => 'DVA-76 D-Va',
                'duration' => 42,
                'comment' => 'Nerf this!',
                'at' => '2018-02-15'
            ],
        ];

        $this->togglClientMock->shouldReceive('getTimeEntries')
        $this->togglClientMock->shouldReceive(/** @scrutinizer ignore-type */ 'getTimeEntries')
            ->with(['start_date' => $dateTime])
            ->andReturn($timeEntries);

        $workLogEntry = new WorkLogEntry();
        $workLogEntry->setIssueID('SLR-76');
        $workLogEntry->setSpentOn(new DateTimeImmutable($dateTime));
        $workLogEntry->setComment('SLR-76');
        $workLogEntry->setTimeSpent(76);

        $this->hydratorMock->shouldReceive('hydrate')->andReturn($workLogEntry);
        $this->hydratorMock->shouldReceive('hydrate')->andReturn(/** @scrutinizer ignore-type */ $workLogEntry);

        $this->apiMock->shouldReceive('addWorkLogEntry')->with(
            $workLogEntry->getIssueID(),
            /** @scrutinizer ignore-type */ $workLogEntry->getIssueID(),
            $workLogEntry->getTimeSpent(),
            /** @scrutinizer ignore-type */ $workLogEntry->getTimeSpent(),
            'D-Va',
            $workLogEntry->getComment(),
            $dateTime
        )->andThrow(\Exception::class, 'Nerf this!');

        $this->loggerMock
            ->shouldReceive('info')
            ->with("Found time entry for user story {$workLogEntry->getIssueID()}");

        $this->loggerMock
            ->shouldReceive('error')
            ->with("Could not add worklog entry: Nerf this!", \Mockery::any());
            ->with("Could not add worklog entry: Nerf this!", /** @scrutinizer ignore-type */ \Mockery::any());

        $this->loggerMock->shouldReceive('info')->with('All done for today, time to go home!');

        $this->service->sync($dateTime);
    }

    public function tearDown()/* The :void return type declaration that should be here would cause a BC issue */
    {
        if ($container = \Mockery::getContainer()) {
            $this->addToAssertionCount($container->mockery_getExpectationCount());
        }
    }
}
AxaliaN / toggl-jira

Push — master ( 4f9353...7eeb29 )

SyncServiceTest::tearDown() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
