Issues (34)

src/Message/PurchaseResponse.php (2 issues)

Labels
Severity
1
<?php
2
3
namespace Omnipay\Redsys\Message;
4
5
use Omnipay\Common\Message\AbstractResponse;
0 ignored issues
show
This use statement conflicts with another class in this namespace, Omnipay\Redsys\Message\AbstractResponse. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
6
use Omnipay\Common\Message\RedirectResponseInterface;
7
8
/**
9
 * Redsys Purchase Response.
10
 */
11
class PurchaseResponse extends AbstractResponse implements RedirectResponseInterface
12
{
13 2
    public function isSuccessful()
14
    {
15 2
        return false;
16
    }
17
18 2
    public function isRedirect()
19
    {
20 2
        return true;
21
    }
22
23 2
    public function getRedirectUrl()
24
    {
25 2
        return $this->getRequest()->getEndpoint();
0 ignored issues
show
The method getEndpoint() does not exist on Omnipay\Common\Message\RequestInterface. It seems like you code against a sub-type of Omnipay\Common\Message\RequestInterface such as Omnipay\Redsys\Message\AbstractRequest. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

25
        return $this->getRequest()->/** @scrutinizer ignore-call */ getEndpoint();
Loading history...
26
    }
27
28 1
    public function getRedirectMethod()
29
    {
30 1
        return 'POST';
31
    }
32
33 1
    public function getRedirectData()
34
    {
35 1
        return $this->data;
36
    }
37
}
38