Omnipay\Redsys\Message\RefundRequest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getData()	0	37	2
A	sendData()	0	49	2

<?php

namespace Omnipay\Redsys\Message;

use SimpleXMLElement;

/**
 * Redsys Webservice Purchase Request.
 */
class RefundRequest extends AbstractRequest
{
    use WebserviceTrait;

    /** @var CatalogInterface */

The type Omnipay\Redsys\Message\CatalogInterface was not found. Maybe you did not declare it correctly or list all dependencies?

    protected $redsysMessages;

    public function getData()
    {
        $this->validate('merchantId', 'terminalId', 'amount', 'currency', 'transactionId');

        $data = [
            'DS_MERCHANT_AMOUNT' => $this->getAmountInteger(),
            'DS_MERCHANT_ORDER' => $this->getTransactionId(),
            'DS_MERCHANT_MERCHANTCODE' => $this->getMerchantId(),
            'DS_MERCHANT_TERMINAL' => $this->getTerminalId(),
            'DS_MERCHANT_CURRENCY' => $this->getCurrencyNumeric(),  // uses ISO-4217 codes
            'DS_MERCHANT_TRANSACTIONTYPE' => '3',                          // Refund

50% of this comment could be valid code. Did you maybe forget this after debugging?

            // undocumented fields
            // 'DS_MERCHANT_MERCHANTDATA'     => $this->getMerchantData(),
            // 'DS_MERCHANT_MERCHANTNAME'     => $this->getMerchantName(),
            // 'DS_MERCHANT_CONSUMERLANGUAGE' => $this->getConsumerLanguage(),
        ];

        $request = new SimpleXMLElement('<REQUEST/>');
        $requestData = $request->addChild('DATOSENTRADA');
        foreach ($data as $tag => $value) {
            $requestData->addChild($tag, $value);
        }

        $security = new Security();

        $request->addChild('DS_SIGNATUREVERSION', Security::VERSION);
        $request->addChild('DS_SIGNATURE', $security->createSignature(
            $requestData->asXML(),

It seems like $requestData->asXML() can also be of type true; however, parameter $message of Omnipay\Redsys\Message\Security::createSignature() does only seem to accept string, maybe add an additional type check?

            $data['DS_MERCHANT_ORDER'],
            $this->getHmacKey()
        ));

        // keep data as nested array for method signature compatibility
        return [
            'DATOSENTRADA' => $data,
            'DS_SIGNATUREVERSION' => (string) $request->DS_SIGNATUREVERSION,
            'DS_SIGNATURE' => (string) $request->DS_SIGNATURE,
        ];
    }

    /**
     * Send the data.
     *
     * Uses its own SOAP wrapper instead of PHP's SoapClient
     */
    public function sendData($data)
    {
        // re-create the XML
        $request = new SimpleXMLElement('<REQUEST/>');
        $requestData = $request->addChild('DATOSENTRADA');
        foreach ($data['DATOSENTRADA'] as $tag => $value) {
            $requestData->addChild($tag, $value);
        }
        $request->addChild('DS_SIGNATUREVERSION', $data['DS_SIGNATUREVERSION']);
        $request->addChild('DS_SIGNATURE', $data['DS_SIGNATURE']);

        // wrap in SOAP envelope
        $requestEnvelope = "<soapenv:Envelope xmlns:soapenv='http://schemas.xmlsoap.org/soap/envelope/'>
              <soapenv:Header/>
              <soapenv:Body>
                <impl:trataPeticion xmlns:impl='http://webservice.sis.sermepa.es'>
                  <impl:datosEntrada>
                    ".htmlspecialchars($request->asXML()).'

It seems like $request->asXML() can also be of type true; however, parameter $string of htmlspecialchars() does only seem to accept string, maybe add an additional type check?

                  </impl:datosEntrada>
                </impl:trataPeticion>
              </soapenv:Body>
            </soapenv:Envelope>';

        // send the actual SOAP request
        $httpResponse = $this->httpClient->request(
            'POST',
            $this->getEndpoint(),
            ['SOAPAction' => 'trataPeticion'],
            $requestEnvelope
        );

        // unwrap httpResponse into actual data as SimpleXMLElement tree
        $responseEnvelope = simplexml_load_string($httpResponse->getBody()->getContents());
        $responseData = new SimpleXMLElement(htmlspecialchars_decode(
            $responseEnvelope->children('http://schemas.xmlsoap.org/soap/envelope/')
            ->Body->children('http://webservice.sis.sermepa.es')
            ->trataPeticionResponse
            ->trataPeticionReturn
        ));

        // remove any reflected request data (this happens on SIS errors, and includes card number)

36% of this comment could be valid code. Did you maybe forget this after debugging?

        // if (isset($responseData->RECIBIDO)) {
        //     unset($responseData->RECIBIDO);
        // }

        // convert to nested arrays (drop the 'true' to use simple objects)
        $responseData = json_decode(json_encode($responseData), true);

        return $this->response = new RefundResponse($this, $responseData);
    }
}