business-hours.php ➔ jetpack_business_hours_get_default_days() - Code Metrics - Inspection of "Cleanup README" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — remove/dashboard-polyfills ( 7299d9...0dc126 )

by Jon

created 2019-04-09 21:01 UTC

business-hours.php ➔ jetpack_business_hours_get_default_days() B

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	57
rs	8.9381
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * Business Hours Block.
 *
 * @since 7.1.0
 *
 * @package Jetpack
 */

jetpack_register_block(
	'jetpack/business-hours',
	array( 'render_callback' => 'jetpack_business_hours_render' )
);

/**
 * Get's default days / hours to render a business hour block with no data provided.
 *
 * @return array
 */
function jetpack_business_hours_get_default_days() {
	return array(
		array(
			'name'  => 'Sun',
			'hours' => array(),
		),
		array(
			'name'  => 'Mon',
			'hours' => array(
				array(
					'opening' => '09:00',
					'closing' => '17:00',
				),
			),
		),
		array(
			'name'  => 'Tue',
			'hours' => array(
				array(
					'opening' => '09:00',
					'closing' => '17:00',
				),
			),
		),
		array(
			'name'  => 'Wed',
			'hours' => array(
				array(
					'opening' => '09:00',
					'closing' => '17:00',
				),
			),
		),
		array(
			'name'  => 'Thu',
			'hours' => array(
				array(
					'opening' => '09:00',
					'closing' => '17:00',
				),
			),
		),
		array(
			'name'  => 'Fri',
			'hours' => array(
				array(
					'opening' => '09:00',
					'closing' => '17:00',
				),
			),
		),
		array(
			'name'  => 'Sat',
			'hours' => array(),
		),
	);
}

/**
 * Dynamic rendering of the block.
 *
 * @param array $attributes Array containing the business hours block attributes.
 *
 * @return string
 */
function jetpack_business_hours_render( $attributes ) {
	global $wp_locale;

	if ( empty( $attributes['days'] ) || ! is_array( $attributes['days'] ) ) {
		$attributes['days'] = jetpack_business_hours_get_default_days();
	}

	$start_of_week = (int) get_option( 'start_of_week', 0 );
	$time_format   = get_option( 'time_format' );
	$content       = sprintf(
		'<dl class="jetpack-business-hours %s">',
		! empty( $attributes['className'] ) ? esc_attr( $attributes['className'] ) : ''
	);

	$days = array( 'Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat' );

	if ( $start_of_week ) {
		$chunk1             = array_slice( $attributes['days'], 0, $start_of_week );
		$chunk2             = array_slice( $attributes['days'], $start_of_week );
		$attributes['days'] = array_merge( $chunk2, $chunk1 );
	}

	foreach ( $attributes['days'] as $day ) {
		$content   .= '<dt class="' . esc_attr( $day['name'] ) . '">' .
					ucfirst( $wp_locale->get_weekday( array_search( $day['name'], $days, true ) ) ) .
					'</dt>';
		$content   .= '<dd class="' . esc_attr( $day['name'] ) . '">';
		$days_hours = '';

		foreach ( $day['hours'] as $hour ) {
			$opening = strtotime( $hour['opening'] );
			$closing = strtotime( $hour['closing'] );
			if ( ! $opening || ! $closing ) {
				continue;
			}
			$days_hours .= sprintf(
				/* Translators: Business opening hours info. */
				_x( 'From %1$s to %2$s', 'from business opening hour to closing hour', 'jetpack' ),
				date( $time_format, $opening ),
				date( $time_format, $closing )
			);
			$days_hours .= '<br />';
		}

		if ( empty( $days_hours ) ) {
			$days_hours = esc_html__( 'Closed', 'jetpack' );
		}
		$content .= $days_hours;
		$content .= '</dd>';
	}

	$content .= '</dl>';

	/**
	 * Allows folks to filter the HTML content for the Business Hours block
	 *
	 * @since 7.1.0
	 *
	 * @param string $content The default HTML content set by `jetpack_business_hours_render`
	 * @param array $attributes Attributes generated in the block editor for the Business Hours block
	 */
	return apply_filters( 'jetpack_business_hours_content', $content, $attributes );
}


1			<?php
2			/**
3			* Business Hours Block.
4			*
5			* @since 7.1.0
6			*
7			* @package Jetpack
8			*/
9
10			jetpack_register_block(
11			'jetpack/business-hours',
12			array( 'render_callback' => 'jetpack_business_hours_render' )
13			);
14
15			/**
16			* Get's default days / hours to render a business hour block with no data provided.
17			*
18			* @return array
19			*/
20			function jetpack_business_hours_get_default_days() {
21			return array(
22			array(
23			'name' => 'Sun',
24			'hours' => array(),
25			),
26			array(
27			'name' => 'Mon',
28			'hours' => array(
29			array(
30			'opening' => '09:00',
31			'closing' => '17:00',
32			),
33			),
34			),
35			array(
36			'name' => 'Tue',
37			'hours' => array(
38			array(
39			'opening' => '09:00',
40			'closing' => '17:00',
41			),
42			),
43			),
44			array(
45			'name' => 'Wed',
46			'hours' => array(
47			array(
48			'opening' => '09:00',
49			'closing' => '17:00',
50			),
51			),
52			),
53			array(
54			'name' => 'Thu',
55			'hours' => array(
56			array(
57			'opening' => '09:00',
58			'closing' => '17:00',
59			),
60			),
61			),
62			array(
63			'name' => 'Fri',
64			'hours' => array(
65			array(
66			'opening' => '09:00',
67			'closing' => '17:00',
68			),
69			),
70			),
71			array(
72			'name' => 'Sat',
73			'hours' => array(),
74			),
75			);
76			}
77
78			/**
79			* Dynamic rendering of the block.
80			*
81			* @param array $attributes Array containing the business hours block attributes.
82			*
83			* @return string
84			*/
85			function jetpack_business_hours_render( $attributes ) {
86			global $wp_locale;
87
88			if ( empty( $attributes['days'] ) \|\| ! is_array( $attributes['days'] ) ) {
89			$attributes['days'] = jetpack_business_hours_get_default_days();
90			}
91
92			$start_of_week = (int) get_option( 'start_of_week', 0 );
93			$time_format = get_option( 'time_format' );
94			$content = sprintf(
95			'<dl class="jetpack-business-hours %s">',
96			! empty( $attributes['className'] ) ? esc_attr( $attributes['className'] ) : ''
97			);
98
99			$days = array( 'Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat' );
100
101			if ( $start_of_week ) {
102			$chunk1 = array_slice( $attributes['days'], 0, $start_of_week );
103			$chunk2 = array_slice( $attributes['days'], $start_of_week );
104			$attributes['days'] = array_merge( $chunk2, $chunk1 );
105			}
106
107			foreach ( $attributes['days'] as $day ) {
108			$content .= '<dt class="' . esc_attr( $day['name'] ) . '">' .
109			ucfirst( $wp_locale->get_weekday( array_search( $day['name'], $days, true ) ) ) .
110			'</dt>';
111			$content .= '<dd class="' . esc_attr( $day['name'] ) . '">';
112			$days_hours = '';
113
114			foreach ( $day['hours'] as $hour ) {
115			$opening = strtotime( $hour['opening'] );
116			$closing = strtotime( $hour['closing'] );
117			if ( ! $opening \|\| ! $closing ) {
118			continue;
119			}
120			$days_hours .= sprintf(
121			/* Translators: Business opening hours info. */
122			_x( 'From %1$s to %2$s', 'from business opening hour to closing hour', 'jetpack' ),
123			date( $time_format, $opening ),
124			date( $time_format, $closing )
125			);
126			$days_hours .= '<br />';
127			}
128
129			if ( empty( $days_hours ) ) {
130			$days_hours = esc_html__( 'Closed', 'jetpack' );
131			}
132			$content .= $days_hours;
133			$content .= '</dd>';
134			}
135
136			$content .= '</dl>';
137
138			/**
139			* Allows folks to filter the HTML content for the Business Hours block
140			*
141			* @since 7.1.0
142			*
143			* @param string $content The default HTML content set by `jetpack_business_hours_render`
144			* @param array $attributes Attributes generated in the block editor for the Business Hours block
145			*/
146			return apply_filters( 'jetpack_business_hours_content', $content, $attributes );
147			}
148

Automattic / jetpack

Push — remove/dashboard-polyfills ( 7299d9...0dc126 )

business-hours.php ➔ jetpack_business_hours_get_default_days() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like