Issues in class.jetpack-client-server.php - New Issues - Inspection of "Translate Widget: only accept layout values betwee..." - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — update/google-translate-layout ( 38cf64...f54e3d )

by Jeremy

created 2017-09-21 16:33 UTC

class.jetpack-client-server.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Client = Plugin
 * Client Server = API Methods the Plugin must respond to
 */
class Jetpack_Client_Server {

	/**
	 * Authorizations
	 */
	function client_authorize() {
		$data              = stripslashes_deep( $_GET );
		$data['auth_type'] = 'client';
		$role              = Jetpack::translate_current_user_to_role();
		$redirect          = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';

		check_admin_referer( "jetpack-authorize_{$role}_{$redirect}" );

		$result = $this->authorize( $data );
		if ( is_wp_error( $result ) ) {
			Jetpack::state( 'error', $result->get_error_code() );
			JetpackTracking::record_user_event( 'jpc_client_authorize_fail', array(
				'error_code' => $result->get_error_code(),
				'error_message' => $result->get_error_message()
			) );
		} else {
			/**
			 * Fires after the Jetpack client is authorized to communicate with WordPress.com.
			 *
			 * @since 4.2.0
			 *
			 * @param int Jetpack Blog ID.
			 */
			do_action( 'jetpack_client_authorized', Jetpack_Options::get_option( 'id' ) );
		}

		if ( wp_validate_redirect( $redirect ) ) {
			// Exit happens below in $this->do_exit()
			wp_safe_redirect( $redirect );
		} else {
			// Exit happens below in $this->do_exit()
			wp_safe_redirect( Jetpack::admin_url() );
		}

		JetpackTracking::record_user_event( 'jpc_client_authorize_success' );

		$this->do_exit();
	}

	function authorize( $data = array() ) {
		$redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';

		$jetpack_unique_connection = Jetpack_Options::get_option( 'unique_connection' );
		// Checking if site has been active/connected previously before recording unique connection
		if ( ! $jetpack_unique_connection ) {
			// jetpack_unique_connection option has never been set
			$jetpack_unique_connection = array(
				'connected'     => 0,
				'disconnected'  => 0,
				'version'       => '3.6.1',
			);

			update_option( 'jetpack_unique_connection', $jetpack_unique_connection );

			//track unique connection
			$jetpack = $this->get_jetpack();;

			$jetpack->stat( 'connections', 'unique-connection' );
			$jetpack->do_stats( 'server_side' );
		}

		// increment number of times connected
		$jetpack_unique_connection['connected'] += 1;
		Jetpack_Options::update_option( 'unique_connection', $jetpack_unique_connection );

		$role = Jetpack::translate_current_user_to_role();

		if ( ! $role ) {
			return new Jetpack_Error( 'no_role', 'Invalid request.', 400 );
		}

		$cap = Jetpack::translate_role_to_cap( $role );
		if ( ! $cap ) {
			return new Jetpack_Error( 'no_cap', 'Invalid request.', 400 );
		}

		if ( ! empty( $data['error'] ) ) {
			return new Jetpack_Error( $data['error'], 'Error included in the request.', 400 );
		}

		if ( ! isset( $data['state'] ) ) {
			return new Jetpack_Error( 'no_state', 'Request must include state.', 400 );
		}

		if ( ! ctype_digit( $data['state'] ) ) {
			return new Jetpack_Error( $data['error'], 'State must be an integer.', 400 );
		}

		$current_user_id = get_current_user_id();
		if ( $current_user_id != $data['state'] ) {
			return new Jetpack_Error( 'wrong_state', 'State does not match current user.', 400 );
		}

		if ( empty( $data['code'] ) ) {
			return new Jetpack_Error( 'no_code', 'Request must include an authorization code.', 400 );
		}

		$token = $this->get_token( $data );

		if ( is_wp_error( $token ) ) {
			$code = $token->get_error_code();
			if ( empty( $code ) ) {
				$code = 'invalid_token';
			}
			return new Jetpack_Error( $code, $token->get_error_message(), 400 );
		}

		if ( ! $token ) {
			return new Jetpack_Error( 'no_token', 'Error generating token.', 400 );
		}

		$is_master_user = ! Jetpack::is_active();

		Jetpack::update_user_token( $current_user_id, sprintf( '%s.%d', $token, $current_user_id ), $is_master_user );

		if ( ! $is_master_user ) {
			Jetpack::state( 'message', 'linked' );
			// Don't activate anything since we are just connecting a user.
			return 'linked';
		}

		$redirect_on_activation_error = ( 'client' === $data['auth_type'] ) ? true : false;
		if ( $active_modules = Jetpack_Options::get_option( 'active_modules' ) ) {
			Jetpack::delete_active_modules();

			Jetpack::activate_default_modules( 999, 1, $active_modules, $redirect_on_activation_error, false );
		} else {
			Jetpack::activate_default_modules( false, false, array(), $redirect_on_activation_error, false );
		}

		// If redirect_uri is SSO, ensure SSO module is enabled
		parse_str( parse_url( $data['redirect_uri'], PHP_URL_QUERY ), $redirect_options );
		/** This filter is documented in class.jetpack-cli.php */
		if ( isset( $redirect_options['action'] ) && 'jetpack-sso' === $redirect_options['action'] && apply_filters( 'jetpack_start_enable_sso', true ) ) {
			Jetpack::activate_module( 'sso', false, false );
		}

		// Since this is a fresh connection, be sure to clear out IDC options
		Jetpack_IDC::clear_all_idc_options();

		// Start nonce cleaner
		wp_clear_scheduled_hook( 'jetpack_clean_nonces' );
		wp_schedule_event( time(), 'hourly', 'jetpack_clean_nonces' );

		Jetpack::state( 'message', 'authorized' );
		return 'authorized';
	}

	public static function deactivate_plugin( $probable_file, $probable_title ) {
		include_once( ABSPATH . 'wp-admin/includes/plugin.php' );
		if ( is_plugin_active( $probable_file ) ) {
			deactivate_plugins( $probable_file );
			return 1;
		} else {
			// If the plugin is not in the usual place, try looking through all active plugins.
			$active_plugins = Jetpack::get_active_plugins();
			foreach ( $active_plugins as $plugin ) {
				$data = get_plugin_data( WP_PLUGIN_DIR . '/' . $plugin );
				if ( $data['Name'] == $probable_title ) {
					deactivate_plugins( $plugin );
					return 1;
				}
			}
		}

		return 0;
	}

	/**
	 * @return object|WP_Error
	 */
	function get_token( $data ) {
		$role = Jetpack::translate_current_user_to_role();

		if ( ! $role ) {
			return new Jetpack_Error( 'role', __( 'An administrator for this blog must set up the Jetpack connection.', 'jetpack' ) );
		}

		$client_secret = Jetpack_Data::get_access_token();
		if ( ! $client_secret ) {
			return new Jetpack_Error( 'client_secret', __( 'You need to register your Jetpack before connecting it.', 'jetpack' ) );
		}

		$redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';
		$redirect_uri = ( 'calypso' === $data['auth_type'] )
			? $data['redirect_uri']
			: add_query_arg( array(
				'action' => 'authorize',
				'_wpnonce' => wp_create_nonce( "jetpack-authorize_{$role}_{$redirect}" ),
				'redirect' => $redirect ? urlencode( $redirect ) : false,
			), menu_page_url( 'jetpack', false ) );

		// inject identity for analytics
		$tracks_identity = jetpack_tracks_get_identity( get_current_user_id() );

		$body = array(
			'client_id' => Jetpack_Options::get_option( 'id' ),
			'client_secret' => $client_secret->secret,
			'grant_type' => 'authorization_code',
			'code' => $data['code'],
			'redirect_uri' => $redirect_uri,
			'_ui' => $tracks_identity['_ui'],
			'_ut' => $tracks_identity['_ut'],
		);

		$args = array(
			'method' => 'POST',
			'body' => $body,
			'headers' => array(
				'Accept' => 'application/json',
			),
		);
		$response = Jetpack_Client::_wp_remote_request( Jetpack::fix_url_for_bad_hosts( Jetpack::api_url( 'token' ) ), $args );

		if ( is_wp_error( $response ) ) {
			return new Jetpack_Error( 'token_http_request_failed', $response->get_error_message() );
		}

		$code = wp_remote_retrieve_response_code( $response );
		$entity = wp_remote_retrieve_body( $response );

		if ( $entity ) {
			$json = json_decode( $entity );
		} else {
			$json = false;
		}

		if ( 200 != $code || ! empty( $json->error ) ) {
			if ( empty( $json->error ) ) {
				return new Jetpack_Error( 'unknown', '', $code );
			}

			$error_description = isset( $json->error_description ) ? sprintf( __( 'Error Details: %s', 'jetpack' ), (string) $json->error_description ) : '';

			return new Jetpack_Error( (string) $json->error, $error_description, $code );
		}

		if ( empty( $json->access_token ) || ! is_scalar( $json->access_token ) ) {
			return new Jetpack_Error( 'access_token', '', $code );
		}

		if ( empty( $json->token_type ) || 'X_JETPACK' != strtoupper( $json->token_type ) ) {
			return new Jetpack_Error( 'token_type', '', $code );
		}

		if ( empty( $json->scope ) ) {
			return new Jetpack_Error( 'scope', 'No Scope', $code );
		}

		@list( $role, $hmac ) = explode( ':', $json->scope );
		if ( empty( $role ) || empty( $hmac ) ) {
			return new Jetpack_Error( 'scope', 'Malformed Scope', $code );
		}

		if ( Jetpack::sign_role( $role ) !== $json->scope ) {
			return new Jetpack_Error( 'scope', 'Invalid Scope', $code );
		}

		if ( ! $cap = Jetpack::translate_role_to_cap( $role ) ) {
			return new Jetpack_Error( 'scope', 'No Cap', $code );
		}

		if ( ! current_user_can( $cap ) ) {
			return new Jetpack_Error( 'scope', 'current_user_cannot', $code );
		}

		/**
		 * Fires after user has successfully received an auth token.
		 *
		 * @since 3.9.0
		 */
		do_action( 'jetpack_user_authorized' );

		return (string) $json->access_token;
	}

	public function get_jetpack() {
		return Jetpack::init();
	}

	public function do_exit() {
		exit;

	}
}


1		<?php
2
3		/**
4		* Client = Plugin
5		* Client Server = API Methods the Plugin must respond to
6		*/
7		class Jetpack_Client_Server {
8
9		/**
10		* Authorizations
11		*/
12		function client_authorize() {
13		$data = stripslashes_deep( $_GET );
14		$data['auth_type'] = 'client';
15		$role = Jetpack::translate_current_user_to_role();
16		$redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';
17
18		check_admin_referer( "jetpack-authorize_{$role}_{$redirect}" );
19
20		$result = $this->authorize( $data );
21		if ( is_wp_error( $result ) ) {
22		Jetpack::state( 'error', $result->get_error_code() );
23		JetpackTracking::record_user_event( 'jpc_client_authorize_fail', array(
24		'error_code' => $result->get_error_code(),
25		'error_message' => $result->get_error_message()
26		) );
27		} else {
28		/**
29		* Fires after the Jetpack client is authorized to communicate with WordPress.com.
30		*
31		* @since 4.2.0
32		*
33		* @param int Jetpack Blog ID.
34		*/
35		do_action( 'jetpack_client_authorized', Jetpack_Options::get_option( 'id' ) );
36		}
37
38		if ( wp_validate_redirect( $redirect ) ) {
39		// Exit happens below in $this->do_exit()
40		wp_safe_redirect( $redirect );
41		} else {
42		// Exit happens below in $this->do_exit()
43		wp_safe_redirect( Jetpack::admin_url() );
44		}
45
46		JetpackTracking::record_user_event( 'jpc_client_authorize_success' );
47
48		$this->do_exit();
49		}
50
51		function authorize( $data = array() ) {
52		$redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';
53
54		$jetpack_unique_connection = Jetpack_Options::get_option( 'unique_connection' );
55		// Checking if site has been active/connected previously before recording unique connection
56		if ( ! $jetpack_unique_connection ) {
57		// jetpack_unique_connection option has never been set
58		$jetpack_unique_connection = array(
59		'connected' => 0,
60		'disconnected' => 0,
61		'version' => '3.6.1',
62		);
63
64		update_option( 'jetpack_unique_connection', $jetpack_unique_connection );
65
66		//track unique connection
67		$jetpack = $this->get_jetpack();;
68
69		$jetpack->stat( 'connections', 'unique-connection' );
70		$jetpack->do_stats( 'server_side' );
71		}
72
73		// increment number of times connected
74		$jetpack_unique_connection['connected'] += 1;
75		Jetpack_Options::update_option( 'unique_connection', $jetpack_unique_connection );
76
77		$role = Jetpack::translate_current_user_to_role();
78
79		if ( ! $role ) {
80		return new Jetpack_Error( 'no_role', 'Invalid request.', 400 );
81		}
82
83		$cap = Jetpack::translate_role_to_cap( $role );
84		if ( ! $cap ) {
85		return new Jetpack_Error( 'no_cap', 'Invalid request.', 400 );
86		}
87
88		if ( ! empty( $data['error'] ) ) {
89		return new Jetpack_Error( $data['error'], 'Error included in the request.', 400 );
90		}
91
92		if ( ! isset( $data['state'] ) ) {
93		return new Jetpack_Error( 'no_state', 'Request must include state.', 400 );
94		}
95
96		if ( ! ctype_digit( $data['state'] ) ) {
97		return new Jetpack_Error( $data['error'], 'State must be an integer.', 400 );
98		}
99
100		$current_user_id = get_current_user_id();
101		if ( $current_user_id != $data['state'] ) {
102		return new Jetpack_Error( 'wrong_state', 'State does not match current user.', 400 );
103		}
104
105		if ( empty( $data['code'] ) ) {
106		return new Jetpack_Error( 'no_code', 'Request must include an authorization code.', 400 );
107		}
108
109		$token = $this->get_token( $data );
110
111		if ( is_wp_error( $token ) ) {
112		$code = $token->get_error_code();
113		if ( empty( $code ) ) {
114		$code = 'invalid_token';
115		}
116		return new Jetpack_Error( $code, $token->get_error_message(), 400 );
117		}
118
119		if ( ! $token ) {
120		return new Jetpack_Error( 'no_token', 'Error generating token.', 400 );
121		}
122
123		$is_master_user = ! Jetpack::is_active();
124
125		Jetpack::update_user_token( $current_user_id, sprintf( '%s.%d', $token, $current_user_id ), $is_master_user );
126
127		if ( ! $is_master_user ) {
128		Jetpack::state( 'message', 'linked' );
129		// Don't activate anything since we are just connecting a user.
130		return 'linked';
131		}
132
133		$redirect_on_activation_error = ( 'client' === $data['auth_type'] ) ? true : false;
134	View Code Duplication	if ( $active_modules = Jetpack_Options::get_option( 'active_modules' ) ) {
135		Jetpack::delete_active_modules();
136
137		Jetpack::activate_default_modules( 999, 1, $active_modules, $redirect_on_activation_error, false );
138		} else {
139		Jetpack::activate_default_modules( false, false, array(), $redirect_on_activation_error, false );
140		}
141
142		// If redirect_uri is SSO, ensure SSO module is enabled
143		parse_str( parse_url( $data['redirect_uri'], PHP_URL_QUERY ), $redirect_options );
144		/** This filter is documented in class.jetpack-cli.php */
145		if ( isset( $redirect_options['action'] ) && 'jetpack-sso' === $redirect_options['action'] && apply_filters( 'jetpack_start_enable_sso', true ) ) {
146		Jetpack::activate_module( 'sso', false, false );
147		}
148
149		// Since this is a fresh connection, be sure to clear out IDC options
150		Jetpack_IDC::clear_all_idc_options();
151
152		// Start nonce cleaner
153		wp_clear_scheduled_hook( 'jetpack_clean_nonces' );
154		wp_schedule_event( time(), 'hourly', 'jetpack_clean_nonces' );
155
156		Jetpack::state( 'message', 'authorized' );
157		return 'authorized';
158		}
159
160		public static function deactivate_plugin( $probable_file, $probable_title ) {
161		include_once( ABSPATH . 'wp-admin/includes/plugin.php' );
162		if ( is_plugin_active( $probable_file ) ) {
163		deactivate_plugins( $probable_file );
164		return 1;
165		} else {
166		// If the plugin is not in the usual place, try looking through all active plugins.
167		$active_plugins = Jetpack::get_active_plugins();
168		foreach ( $active_plugins as $plugin ) {
169		$data = get_plugin_data( WP_PLUGIN_DIR . '/' . $plugin );
170		if ( $data['Name'] == $probable_title ) {
171		deactivate_plugins( $plugin );
172		return 1;
173		}
174		}
175		}
176
177		return 0;
178		}
179
180		/**
181		* @return object\|WP_Error
182		*/
183		function get_token( $data ) {
184		$role = Jetpack::translate_current_user_to_role();
185
186		if ( ! $role ) {
187		return new Jetpack_Error( 'role', __( 'An administrator for this blog must set up the Jetpack connection.', 'jetpack' ) );
188		}
189
190		$client_secret = Jetpack_Data::get_access_token();
191		if ( ! $client_secret ) {
192		return new Jetpack_Error( 'client_secret', __( 'You need to register your Jetpack before connecting it.', 'jetpack' ) );
193		}
194
195		$redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';
196		$redirect_uri = ( 'calypso' === $data['auth_type'] )
197		? $data['redirect_uri']
198		: add_query_arg( array(
199		'action' => 'authorize',
200		'_wpnonce' => wp_create_nonce( "jetpack-authorize_{$role}_{$redirect}" ),
201		'redirect' => $redirect ? urlencode( $redirect ) : false,
202		), menu_page_url( 'jetpack', false ) );
203
204		// inject identity for analytics
205		$tracks_identity = jetpack_tracks_get_identity( get_current_user_id() );
206
207		$body = array(
208		'client_id' => Jetpack_Options::get_option( 'id' ),
209		'client_secret' => $client_secret->secret,
210		'grant_type' => 'authorization_code',
211		'code' => $data['code'],
212		'redirect_uri' => $redirect_uri,
213		'_ui' => $tracks_identity['_ui'],
214		'_ut' => $tracks_identity['_ut'],
215		);
216
217		$args = array(
218		'method' => 'POST',
219		'body' => $body,
220		'headers' => array(
221		'Accept' => 'application/json',
222		),
223		);
224		$response = Jetpack_Client::_wp_remote_request( Jetpack::fix_url_for_bad_hosts( Jetpack::api_url( 'token' ) ), $args );
225
226		if ( is_wp_error( $response ) ) {
227		return new Jetpack_Error( 'token_http_request_failed', $response->get_error_message() );
228		}
229
230		$code = wp_remote_retrieve_response_code( $response );
231		$entity = wp_remote_retrieve_body( $response );
232
233		if ( $entity ) {
234		$json = json_decode( $entity );
235		} else {
236		$json = false;
237		}
238
239		if ( 200 != $code \|\| ! empty( $json->error ) ) {
240		if ( empty( $json->error ) ) {
241		return new Jetpack_Error( 'unknown', '', $code );
242		}
243
244		$error_description = isset( $json->error_description ) ? sprintf( __( 'Error Details: %s', 'jetpack' ), (string) $json->error_description ) : '';
245
246		return new Jetpack_Error( (string) $json->error, $error_description, $code );
247		}
248
249		if ( empty( $json->access_token ) \|\| ! is_scalar( $json->access_token ) ) {
250		return new Jetpack_Error( 'access_token', '', $code );
251		}
252
253		if ( empty( $json->token_type ) \|\| 'X_JETPACK' != strtoupper( $json->token_type ) ) {
254		return new Jetpack_Error( 'token_type', '', $code );
255		}
256
257		if ( empty( $json->scope ) ) {
258		return new Jetpack_Error( 'scope', 'No Scope', $code );
259		}
260
261		@list( $role, $hmac ) = explode( ':', $json->scope );
262		if ( empty( $role ) \|\| empty( $hmac ) ) {
263		return new Jetpack_Error( 'scope', 'Malformed Scope', $code );
264		}
265
266		if ( Jetpack::sign_role( $role ) !== $json->scope ) {
267		return new Jetpack_Error( 'scope', 'Invalid Scope', $code );
268		}
269
270		if ( ! $cap = Jetpack::translate_role_to_cap( $role ) ) {
271		return new Jetpack_Error( 'scope', 'No Cap', $code );
272		}
273
274		if ( ! current_user_can( $cap ) ) {
275		return new Jetpack_Error( 'scope', 'current_user_cannot', $code );
276		}
277
278		/**
279		* Fires after user has successfully received an auth token.
280		*
281		* @since 3.9.0
282		*/
283		do_action( 'jetpack_user_authorized' );
284
285		return (string) $json->access_token;
286		}
287
288		public function get_jetpack() {
289		return Jetpack::init();
290		}
291
292		public function do_exit() {
293		exit;
		0 ignored issues – show Coding Style Compatibility introduced 2017-07-31 16:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `do_exit()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
294		}
295		}
296

Automattic / jetpack

Push — update/google-translate-layout ( 38cf64...f54e3d )

class.jetpack-client-server.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like