Jetpack_Photon_Static_Assets_CDN::cdnize_assets() - Code Metrics - Inspection of "Adding support for alt text to Jetpack_PostImages" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — postimages-alt-text-support ( 51cea9...ae9db9 )

unknown

created 2019-02-22 12:44 UTC

Jetpack_Photon_Static_Assets_CDN::cdnize_assets() B

↳ Parent: Jetpack_Photon_Static_Assets_CDN

Complexity

Conditions	11
Paths	4

Size

Total Lines

Duplication

Lines	20
Ratio	42.55 %

Importance

Changes

Metric	Value
cc	11
nc	4
nop	0
dl	20
loc	47
rs	7.3166
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 * Module Name: Asset CDN
 * Module Description: Serve static assets from our servers
 * Sort Order: 26
 * Recommendation Order: 1
 * First Introduced: 6.6
 * Requires Connection: No
 * Auto Activate: No
 * Module Tags: Photos and Videos, Appearance, Recommended
 * Feature: Recommended, Appearance
 * Additional Search Queries: photon, image, cdn, performance, speed, assets
 */

$GLOBALS['concatenate_scripts'] = false;

Jetpack::dns_prefetch( array(
	'//c0.wp.com',
) );

class Jetpack_Photon_Static_Assets_CDN {
	const CDN = 'https://c0.wp.com/';

	/**
	 * Sets up action handlers needed for Jetpack CDN.
	 */
	public static function go() {
		add_action( 'wp_print_scripts', array( __CLASS__, 'cdnize_assets' ) );
		add_action( 'wp_print_styles', array( __CLASS__, 'cdnize_assets' ) );
		add_action( 'admin_print_scripts', array( __CLASS__, 'cdnize_assets' ) );
		add_action( 'admin_print_styles', array( __CLASS__, 'cdnize_assets' ) );
		add_action( 'wp_footer', array( __CLASS__, 'cdnize_assets' ) );
		add_filter( 'load_script_textdomain_relative_path', array( __CLASS__, 'fix_script_relative_path' ), 10, 2 );
	}

	/**
	 * Sets up CDN URLs for assets that are enqueued by the WordPress Core.
	 */
	public static function cdnize_assets() {
		global $wp_scripts, $wp_styles, $wp_version;

		/**
		 * Filters Jetpack CDN's Core version number and locale. Can be used to override the values
		 * that Jetpack uses to retrieve assets. Expects the values to be returned in an array.
		 *
		 * @module photon-cdn
		 *
		 * @since 6.6.0
		 *
		 * @param array $values array( $version  = core assets version, i.e. 4.9.8, $locale = desired locale )
		 */
		list( $version, $locale ) = apply_filters(
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
			'jetpack_cdn_core_version_and_locale',
			array( $wp_version, get_locale() )
		);

		if ( self::is_public_version( $version ) ) {
			$site_url = trailingslashit( site_url() );
			foreach ( $wp_scripts->registered as $handle => $thing ) {
				if ( wp_startswith( $thing->src, self::CDN ) ) {
					continue;
				}
				$src = ltrim( str_replace( $site_url, '', $thing->src ), '/' );
				if ( self::is_js_or_css_file( $src ) && in_array( substr( $src, 0, 9 ), array( 'wp-admin/', 'wp-includ' ) ) ) {
					$wp_scripts->registered[ $handle ]->src = sprintf( self::CDN . 'c/%1$s/%2$s', $version, $src );
					$wp_scripts->registered[ $handle ]->ver = null;
				}
			}
			foreach ( $wp_styles->registered as $handle => $thing ) {
				if ( wp_startswith( $thing->src, self::CDN ) ) {
					continue;
				}
				$src = ltrim( str_replace( $site_url, '', $thing->src ), '/' );
				if ( self::is_js_or_css_file( $src ) && in_array( substr( $src, 0, 9 ), array( 'wp-admin/', 'wp-includ' ) ) ) {
					$wp_styles->registered[ $handle ]->src = sprintf( self::CDN . 'c/%1$s/%2$s', $version, $src );
					$wp_styles->registered[ $handle ]->ver = null;
				}
			}
		}

		self::cdnize_plugin_assets( 'jetpack', JETPACK__VERSION );
		if ( class_exists( 'WooCommerce' ) ) {
			self::cdnize_plugin_assets( 'woocommerce', WC_VERSION );
		}
	}

	/**
	 * Ensure use of the correct relative path when determining the JavaScript file names.
	 *
	 * @param string $relative The relative path of the script. False if it could not be determined.
	 * @param string $src      The full source url of the script.
	 * @return string The expected relative path for the CDN-ed URL.
	 */
	public static function fix_script_relative_path( $relative, $src ) {
		return substr( $src, 1 + strpos( $src, '/wp-includes/' ) );
	}

	/**
	 * Sets up CDN URLs for supported plugin assets.
	 *
	 * @param String $plugin_slug plugin slug string.
	 * @param String $current_version plugin version string.
	 * @return null|bool
	 */
	public static function cdnize_plugin_assets( $plugin_slug, $current_version ) {
		global $wp_scripts, $wp_styles;

		/**
		 * Filters Jetpack CDN's plugin slug and version number. Can be used to override the values
		 * that Jetpack uses to retrieve assets. For example, when testing a development version of Jetpack
		 * the assets are not yet published, so you may need to override the version value to either
		 * trunk, or the latest available version. Expects the values to be returned in an array.
		 *
		 * @module photon-cdn
		 *
		 * @since 6.6.0
		 *
		 * @param array $values array( $slug = the plugin repository slug, i.e. jetpack, $version = the plugin version, i.e. 6.6 )
		 */
		list( $plugin_slug, $current_version ) = apply_filters(
			'jetpack_cdn_plugin_slug_and_version',
			array( $plugin_slug, $current_version )
		);

		$assets               = self::get_plugin_assets( $plugin_slug, $current_version );
		$plugin_directory_url = plugins_url() . '/' . $plugin_slug . '/';

		if ( is_wp_error( $assets ) || ! is_array( $assets ) ) {
			return false;
		}

		foreach ( $wp_scripts->registered as $handle => $thing ) {
			if ( wp_startswith( $thing->src, self::CDN ) ) {
				continue;
			}
			if ( wp_startswith( $thing->src, $plugin_directory_url ) ) {
				$local_path = substr( $thing->src, strlen( $plugin_directory_url ) );
				if ( in_array( $local_path, $assets, true ) ) {
					$wp_scripts->registered[ $handle ]->src = sprintf( self::CDN . 'p/%1$s/%2$s/%3$s', $plugin_slug, $current_version, $local_path );
					$wp_scripts->registered[ $handle ]->ver = null;
				}
			}
		}
		foreach ( $wp_styles->registered as $handle => $thing ) {
			if ( wp_startswith( $thing->src, self::CDN ) ) {
				continue;
			}
			if ( wp_startswith( $thing->src, $plugin_directory_url ) ) {
				$local_path = substr( $thing->src, strlen( $plugin_directory_url ) );
				if ( in_array( $local_path, $assets, true ) ) {
					$wp_styles->registered[ $handle ]->src = sprintf( self::CDN . 'p/%1$s/%2$s/%3$s', $plugin_slug, $current_version, $local_path );
					$wp_styles->registered[ $handle ]->ver = null;
				}
			}
		}
	}

	/**
	 * Returns cdn-able assets for a given plugin.
	 *
	 * @param string $plugin plugin slug string.
	 * @param string $version plugin version number string.
	 * @return array|bool Will return false if not a public version.
	 */
	public static function get_plugin_assets( $plugin, $version ) {
		if ( 'jetpack' === $plugin && JETPACK__VERSION === $version ) {
			if ( ! self::is_public_version( $version ) ) {
				return false;
			}

			$assets = array(); // The variable will be redefined in the included file.

			include JETPACK__PLUGIN_DIR . 'modules/photon-cdn/jetpack-manifest.php';
			return $assets;
		}

		/**
		 * Used for other plugins to provide their bundled assets via filter to
		 * prevent the need of storing them in an option or an external api request
		 * to w.org.
		 *
		 * @module photon-cdn
		 *
		 * @since 6.6.0
		 *
		 * @param array $assets The assets array for the plugin.
		 * @param string $version The version of the plugin being requested.
		 */
		$assets = apply_filters( "jetpack_cdn_plugin_assets-{$plugin}", null, $version );
		if ( is_array( $assets ) ) {
			return $assets;
		}

		if ( ! self::is_public_version( $version ) ) {
			return false;
		}

		$cache = Jetpack_Options::get_option( 'static_asset_cdn_files', array() );
		if ( isset( $cache[ $plugin ][ $version ] ) ) {
			if ( is_array( $cache[ $plugin ][ $version ] ) ) {
				return $cache[ $plugin ][ $version ];
			}
			if ( is_numeric( $cache[ $plugin ][ $version ] ) ) {
				// Cache an empty result for up to 24h.
				if ( intval( $cache[ $plugin ][ $version ] ) + DAY_IN_SECONDS > time() ) {
					return array();
				}
			}
		}

		$url = sprintf( 'http://downloads.wordpress.org/plugin-checksums/%s/%s.json', $plugin, $version );

		if ( wp_http_supports( array( 'ssl' ) ) ) {
			$url = set_url_scheme( $url, 'https' );
		}

		$response = wp_remote_get( $url );

		$body = trim( wp_remote_retrieve_body( $response ) );
		$body = json_decode( $body, true );

		$return = time();
		if ( is_array( $body ) ) {
			$return = array_filter( array_keys( $body['files'] ), array( __CLASS__, 'is_js_or_css_file' ) );
		}

		$cache[ $plugin ]             = array();
		$cache[ $plugin ][ $version ] = $return;
		Jetpack_Options::update_option( 'static_asset_cdn_files', $cache, true );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		return $return;
	}

	/**
	 * Checks a path whether it is a JS or CSS file.
	 *
	 * @param String $path file path.
	 * @return Boolean whether the file is a JS or CSS.
	 */
	public static function is_js_or_css_file( $path ) {
		return ( false === strpos( $path, '?' ) ) && in_array( substr( $path, -3 ), array( 'css', '.js' ), true );
	}

	/**
	 * Checks whether the version string indicates a production version.
	 *
	 * @param String  $version the version string.
	 * @param Boolean $include_beta_and_rc whether to count beta and RC versions as production.
	 * @return Boolean
	 */
	public static function is_public_version( $version, $include_beta_and_rc = false ) {
		if ( preg_match( '/^\d+(\.\d+)+$/', $version ) ) {
			// matches `1` `1.2` `1.2.3`.
			return true;
		} elseif ( $include_beta_and_rc && preg_match( '/^\d+(\.\d+)+(-(beta|rc|pressable)\d?)$/i', $version ) ) {
			// matches `1.2.3` `1.2.3-beta` `1.2.3-pressable` `1.2.3-beta1` `1.2.3-rc` `1.2.3-rc2`.
			return true;
		}
		// unrecognized version.
		return false;
	}
}
/**
 * Allow plugins to short-circuit the Asset CDN, even when the module is on.
 *
 * @module photon-cdn
 *
 * @since 6.7.0
 *
 * @param false bool Should the Asset CDN be blocked? False by default.
 */
if ( true !== apply_filters( 'jetpack_force_disable_site_accelerator', false ) ) {
	Jetpack_Photon_Static_Assets_CDN::go();
}


1		<?php
2		/**
3		* Module Name: Asset CDN
4		* Module Description: Serve static assets from our servers
5		* Sort Order: 26
6		* Recommendation Order: 1
7		* First Introduced: 6.6
8		* Requires Connection: No
9		* Auto Activate: No
10		* Module Tags: Photos and Videos, Appearance, Recommended
11		* Feature: Recommended, Appearance
12		* Additional Search Queries: photon, image, cdn, performance, speed, assets
13		*/
14
15		$GLOBALS['concatenate_scripts'] = false;
16
17		Jetpack::dns_prefetch( array(
18		'//c0.wp.com',
19		) );
20
21		class Jetpack_Photon_Static_Assets_CDN {
22		const CDN = 'https://c0.wp.com/';
23
24		/**
25		* Sets up action handlers needed for Jetpack CDN.
26		*/
27		public static function go() {
28		add_action( 'wp_print_scripts', array( __CLASS__, 'cdnize_assets' ) );
29		add_action( 'wp_print_styles', array( __CLASS__, 'cdnize_assets' ) );
30		add_action( 'admin_print_scripts', array( __CLASS__, 'cdnize_assets' ) );
31		add_action( 'admin_print_styles', array( __CLASS__, 'cdnize_assets' ) );
32		add_action( 'wp_footer', array( __CLASS__, 'cdnize_assets' ) );
33		add_filter( 'load_script_textdomain_relative_path', array( __CLASS__, 'fix_script_relative_path' ), 10, 2 );
34		}
35
36		/**
37		* Sets up CDN URLs for assets that are enqueued by the WordPress Core.
38		*/
39		public static function cdnize_assets() {
40		global $wp_scripts, $wp_styles, $wp_version;
41
42		/**
43		* Filters Jetpack CDN's Core version number and locale. Can be used to override the values
44		* that Jetpack uses to retrieve assets. Expects the values to be returned in an array.
45		*
46		* @module photon-cdn
47		*
48		* @since 6.6.0
49		*
50		* @param array $values array( $version = core assets version, i.e. 4.9.8, $locale = desired locale )
51		*/
52		list( $version, $locale ) = apply_filters(
		0 ignored issues – show Unused Code introduced 2018-09-14 12:47 UTC by Report Bug Copy Issue Report The assignment to `$locale` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
53		'jetpack_cdn_core_version_and_locale',
54		array( $wp_version, get_locale() )
55		);
56
57		if ( self::is_public_version( $version ) ) {
58		$site_url = trailingslashit( site_url() );
59	View Code Duplication	foreach ( $wp_scripts->registered as $handle => $thing ) {
60		if ( wp_startswith( $thing->src, self::CDN ) ) {
61		continue;
62		}
63		$src = ltrim( str_replace( $site_url, '', $thing->src ), '/' );
64		if ( self::is_js_or_css_file( $src ) && in_array( substr( $src, 0, 9 ), array( 'wp-admin/', 'wp-includ' ) ) ) {
65		$wp_scripts->registered[ $handle ]->src = sprintf( self::CDN . 'c/%1$s/%2$s', $version, $src );
66		$wp_scripts->registered[ $handle ]->ver = null;
67		}
68		}
69	View Code Duplication	foreach ( $wp_styles->registered as $handle => $thing ) {
70		if ( wp_startswith( $thing->src, self::CDN ) ) {
71		continue;
72		}
73		$src = ltrim( str_replace( $site_url, '', $thing->src ), '/' );
74		if ( self::is_js_or_css_file( $src ) && in_array( substr( $src, 0, 9 ), array( 'wp-admin/', 'wp-includ' ) ) ) {
75		$wp_styles->registered[ $handle ]->src = sprintf( self::CDN . 'c/%1$s/%2$s', $version, $src );
76		$wp_styles->registered[ $handle ]->ver = null;
77		}
78		}
79		}
80
81		self::cdnize_plugin_assets( 'jetpack', JETPACK__VERSION );
82		if ( class_exists( 'WooCommerce' ) ) {
83		self::cdnize_plugin_assets( 'woocommerce', WC_VERSION );
84		}
85		}
86
87		/**
88		* Ensure use of the correct relative path when determining the JavaScript file names.
89		*
90		* @param string $relative The relative path of the script. False if it could not be determined.
91		* @param string $src The full source url of the script.
92		* @return string The expected relative path for the CDN-ed URL.
93		*/
94		public static function fix_script_relative_path( $relative, $src ) {
95		return substr( $src, 1 + strpos( $src, '/wp-includes/' ) );
96		}
97
98		/**
99		* Sets up CDN URLs for supported plugin assets.
100		*
101		* @param String $plugin_slug plugin slug string.
102		* @param String $current_version plugin version string.
103		* @return null\|bool
104		*/
105		public static function cdnize_plugin_assets( $plugin_slug, $current_version ) {
106		global $wp_scripts, $wp_styles;
107
108		/**
109		* Filters Jetpack CDN's plugin slug and version number. Can be used to override the values
110		* that Jetpack uses to retrieve assets. For example, when testing a development version of Jetpack
111		* the assets are not yet published, so you may need to override the version value to either
112		* trunk, or the latest available version. Expects the values to be returned in an array.
113		*
114		* @module photon-cdn
115		*
116		* @since 6.6.0
117		*
118		* @param array $values array( $slug = the plugin repository slug, i.e. jetpack, $version = the plugin version, i.e. 6.6 )
119		*/
120		list( $plugin_slug, $current_version ) = apply_filters(
121		'jetpack_cdn_plugin_slug_and_version',
122		array( $plugin_slug, $current_version )
123		);
124
125		$assets = self::get_plugin_assets( $plugin_slug, $current_version );
126		$plugin_directory_url = plugins_url() . '/' . $plugin_slug . '/';
127
128		if ( is_wp_error( $assets ) \|\| ! is_array( $assets ) ) {
129		return false;
130		}
131
132	View Code Duplication	foreach ( $wp_scripts->registered as $handle => $thing ) {
133		if ( wp_startswith( $thing->src, self::CDN ) ) {
134		continue;
135		}
136		if ( wp_startswith( $thing->src, $plugin_directory_url ) ) {
137		$local_path = substr( $thing->src, strlen( $plugin_directory_url ) );
138		if ( in_array( $local_path, $assets, true ) ) {
139		$wp_scripts->registered[ $handle ]->src = sprintf( self::CDN . 'p/%1$s/%2$s/%3$s', $plugin_slug, $current_version, $local_path );
140		$wp_scripts->registered[ $handle ]->ver = null;
141		}
142		}
143		}
144	View Code Duplication	foreach ( $wp_styles->registered as $handle => $thing ) {
145		if ( wp_startswith( $thing->src, self::CDN ) ) {
146		continue;
147		}
148		if ( wp_startswith( $thing->src, $plugin_directory_url ) ) {
149		$local_path = substr( $thing->src, strlen( $plugin_directory_url ) );
150		if ( in_array( $local_path, $assets, true ) ) {
151		$wp_styles->registered[ $handle ]->src = sprintf( self::CDN . 'p/%1$s/%2$s/%3$s', $plugin_slug, $current_version, $local_path );
152		$wp_styles->registered[ $handle ]->ver = null;
153		}
154		}
155		}
156		}
157
158		/**
159		* Returns cdn-able assets for a given plugin.
160		*
161		* @param string $plugin plugin slug string.
162		* @param string $version plugin version number string.
163		* @return array\|bool Will return false if not a public version.
164		*/
165		public static function get_plugin_assets( $plugin, $version ) {
166		if ( 'jetpack' === $plugin && JETPACK__VERSION === $version ) {
167		if ( ! self::is_public_version( $version ) ) {
168		return false;
169		}
170
171		$assets = array(); // The variable will be redefined in the included file.
172
173		include JETPACK__PLUGIN_DIR . 'modules/photon-cdn/jetpack-manifest.php';
174		return $assets;
175		}
176
177		/**
178		* Used for other plugins to provide their bundled assets via filter to
179		* prevent the need of storing them in an option or an external api request
180		* to w.org.
181		*
182		* @module photon-cdn
183		*
184		* @since 6.6.0
185		*
186		* @param array $assets The assets array for the plugin.
187		* @param string $version The version of the plugin being requested.
188		*/
189		$assets = apply_filters( "jetpack_cdn_plugin_assets-{$plugin}", null, $version );
190		if ( is_array( $assets ) ) {
191		return $assets;
192		}
193
194		if ( ! self::is_public_version( $version ) ) {
195		return false;
196		}
197
198		$cache = Jetpack_Options::get_option( 'static_asset_cdn_files', array() );
199		if ( isset( $cache[ $plugin ][ $version ] ) ) {
200		if ( is_array( $cache[ $plugin ][ $version ] ) ) {
201		return $cache[ $plugin ][ $version ];
202		}
203		if ( is_numeric( $cache[ $plugin ][ $version ] ) ) {
204		// Cache an empty result for up to 24h.
205		if ( intval( $cache[ $plugin ][ $version ] ) + DAY_IN_SECONDS > time() ) {
206		return array();
207		}
208		}
209		}
210
211		$url = sprintf( 'http://downloads.wordpress.org/plugin-checksums/%s/%s.json', $plugin, $version );
212
213		if ( wp_http_supports( array( 'ssl' ) ) ) {
214		$url = set_url_scheme( $url, 'https' );
215		}
216
217		$response = wp_remote_get( $url );
218
219		$body = trim( wp_remote_retrieve_body( $response ) );
220		$body = json_decode( $body, true );
221
222		$return = time();
223		if ( is_array( $body ) ) {
224		$return = array_filter( array_keys( $body['files'] ), array( __CLASS__, 'is_js_or_css_file' ) );
225		}
226
227		$cache[ $plugin ] = array();
228		$cache[ $plugin ][ $version ] = $return;
229		Jetpack_Options::update_option( 'static_asset_cdn_files', $cache, true );
		0 ignored issues – show Documentation introduced 2018-09-11 17:04 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
230
231		return $return;
232		}
233
234		/**
235		* Checks a path whether it is a JS or CSS file.
236		*
237		* @param String $path file path.
238		* @return Boolean whether the file is a JS or CSS.
239		*/
240		public static function is_js_or_css_file( $path ) {
241		return ( false === strpos( $path, '?' ) ) && in_array( substr( $path, -3 ), array( 'css', '.js' ), true );
242		}
243
244		/**
245		* Checks whether the version string indicates a production version.
246		*
247		* @param String $version the version string.
248		* @param Boolean $include_beta_and_rc whether to count beta and RC versions as production.
249		* @return Boolean
250		*/
251		public static function is_public_version( $version, $include_beta_and_rc = false ) {
252		if ( preg_match( '/^\d+(\.\d+)+$/', $version ) ) {
253		// matches `1` `1.2` `1.2.3`.
254		return true;
255		} elseif ( $include_beta_and_rc && preg_match( '/^\d+(\.\d+)+(-(beta\|rc\|pressable)\d?)$/i', $version ) ) {
256		// matches `1.2.3` `1.2.3-beta` `1.2.3-pressable` `1.2.3-beta1` `1.2.3-rc` `1.2.3-rc2`.
257		return true;
258		}
259		// unrecognized version.
260		return false;
261		}
262		}
263		/**
264		* Allow plugins to short-circuit the Asset CDN, even when the module is on.
265		*
266		* @module photon-cdn
267		*
268		* @since 6.7.0
269		*
270		* @param false bool Should the Asset CDN be blocked? False by default.
271		*/
272		if ( true !== apply_filters( 'jetpack_force_disable_site_accelerator', false ) ) {
273		Jetpack_Photon_Static_Assets_CDN::go();
274		}
275

Automattic / jetpack

Push — postimages-alt-text-support ( 51cea9...ae9db9 )

Jetpack_Photon_Static_Assets_CDN::cdnize_assets() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like