Automattic /
jetpack
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Jetpack_Gutenberg often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Jetpack_Gutenberg, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 30 | class Jetpack_Gutenberg { |
||
| 31 | |||
| 32 | /** |
||
| 33 | * Array of blocks we will be registering. |
||
| 34 | * |
||
| 35 | * @var array $blocks Array of blocks we will be registering. |
||
| 36 | */ |
||
| 37 | private static $jetpack_blocks = array(); |
||
| 38 | private static $blocks_index = array(); |
||
| 39 | /** |
||
| 40 | * Add a block to the list of blocks to be registered. |
||
| 41 | * |
||
| 42 | * @param string $type Slug of the block. |
||
| 43 | * @param array $args Arguments that are passed into the register_block_type. |
||
| 44 | */ |
||
| 45 | public static function add_block( $type, $args, $availability ) { |
||
| 48 | |||
| 49 | /** |
||
| 50 | * Register all Jetpack blocks available. |
||
| 51 | * |
||
| 52 | * @return void|WP_Block_Type|false The registered block type on success, or false on failure. |
||
| 53 | */ |
||
| 54 | public static function load_blocks() { |
||
| 80 | |||
| 81 | /** |
||
| 82 | * Checks for a given .json file in the `_inc/blocks` folder. |
||
| 83 | * |
||
| 84 | * @param $preset The name of the .json file to look for. |
||
| 85 | * |
||
| 86 | * @return bool True if the file is found. |
||
| 87 | */ |
||
| 88 | public static function preset_exists( $preset ) { |
||
| 91 | |||
| 92 | /** |
||
| 93 | * Decodes JSON loaded from a preset file in `_inc/blocks` |
||
| 94 | * |
||
| 95 | * @param $preset The name of the .json file to load. |
||
| 96 | * |
||
| 97 | * @return mixed Returns an object if the file is present, or false if a valid .json file is not present. |
||
| 98 | */ |
||
| 99 | public static function get_preset( $preset ) { |
||
| 102 | |||
| 103 | /** |
||
| 104 | * Filters the results of `apply_filter( 'jetpack_set_available_blocks', array() )` |
||
| 105 | * using the merged contents of `_inc/blocks/blocks-manifest.json` ( $preset_blocks ) |
||
| 106 | * and self::$jetpack_blocks ( $internal_blocks ) |
||
| 107 | * |
||
| 108 | * @param $blocks The default list. |
||
| 109 | * |
||
| 110 | * @return array A list of blocks: eg [ 'publicize', 'markdown' ] |
||
| 111 | */ |
||
| 112 | public static function jetpack_set_available_blocks( $blocks ) { |
||
| 124 | |||
| 125 | /** |
||
| 126 | * @return array A list of block-availability information, eg: [ "publicize" => ["available" => true ], "markdown" => [ "available" => false, "unavailable_reason" => 'missing_module' ] ] |
||
| 127 | */ |
||
| 128 | public static function get_block_availability() { |
||
| 162 | |||
| 163 | /** |
||
| 164 | * Check if Gutenberg editor is available |
||
| 165 | * |
||
| 166 | * @since 6.7.0 |
||
| 167 | * |
||
| 168 | * @return bool |
||
| 169 | */ |
||
| 170 | public static function is_gutenberg_available() { |
||
| 173 | |||
| 174 | /** |
||
| 175 | * Check whether conditions indicate Gutenberg blocks should be loaded |
||
| 176 | * |
||
| 177 | * Loading blocks is enabled by default and may be disabled via filter: |
||
| 178 | * add_filter( 'jetpack_gutenberg', '__return_false' ); |
||
| 179 | * |
||
| 180 | * @since 6.7.0 |
||
| 181 | * |
||
| 182 | * @return bool |
||
| 183 | */ |
||
| 184 | public static function should_load_blocks() { |
||
| 198 | |||
| 199 | /** |
||
| 200 | * Only enqueue block assets when needed. |
||
| 201 | * |
||
| 202 | * @param string $type slug of the block. |
||
| 203 | * @param array $script_dependencies An array of view-side Javascript dependencies to be enqueued. |
||
| 204 | * |
||
| 205 | * @return void |
||
| 206 | */ |
||
| 207 | public static function load_assets_as_required( $type, $script_dependencies = array() ) { |
||
| 225 | |||
| 226 | /** |
||
| 227 | * Check if an asset exists for a block. |
||
| 228 | * |
||
| 229 | * @param string $file Path of the file we are looking for. |
||
| 230 | * |
||
| 231 | * @return bool $block_has_asset Does the file exist. |
||
| 232 | */ |
||
| 233 | public static function block_has_asset( $file ) { |
||
| 236 | |||
| 237 | /** |
||
| 238 | * Get the version number to use when loading the file. Allows us to bypass cache when developing. |
||
| 239 | * |
||
| 240 | * @param string $file Path of the file we are looking for. |
||
| 241 | * |
||
| 242 | * @return string $script_version Version number. |
||
| 243 | */ |
||
| 244 | public static function get_asset_version( $file ) { |
||
| 249 | |||
| 250 | /** |
||
| 251 | * Load Gutenberg editor assets |
||
| 252 | * |
||
| 253 | * @since 6.7.0 |
||
| 254 | * |
||
| 255 | * @return void |
||
| 256 | */ |
||
| 257 | public static function enqueue_block_editor_assets() { |
||
| 316 | } |
||
| 317 |
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function.
Consider the following example. The parameter
$italyis not defined by the methodfinale(...).The most likely cause is that the parameter was removed, but the annotation was not.