Completed
Push — add/compat-wpmdb ( a6e86a...35619b )
by Jeremy
27:50 queued 18:11
created

Jetpack_Sync_Actions   C

Complexity

Total Complexity 69

Size/Duplication

Total Lines 352
Duplicated Lines 15.34 %

Coupling/Cohesion

Components 2
Dependencies 6

Importance

Changes 0
Metric Value
dl 54
loc 352
rs 5.6445
c 0
b 0
f 0
wmc 69
lcom 2
cbo 6

18 Methods

Rating   Name   Duplication   Size   Complexity  
A set_is_importing_true() 0 3 1
B send_data() 0 24 2
B sync_allowed() 0 4 5
A prevent_publicize_blacklisted_posts() 0 7 2
A minute_cron_schedule() 0 9 2
A do_full_sync() 0 9 2
B schedule_full_sync() 0 21 5
A unschedule_all_full_syncs() 0 9 4
A is_scheduled_full_sync() 0 14 4
D init() 0 85 15
B schedule_initial_sync() 0 28 4
C do_cron_sync() 27 27 7
C do_cron_full_sync() 27 27 7
A initialize_listener() 0 4 1
A initialize_sender() 0 7 1
A sanitize_filtered_sync_cron_schedule() 0 11 2
A maybe_schedule_sync_cron() 0 15 4
A init_sync_cron_jobs() 0 21 1

How to fix   Duplicated Code    Complexity   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

Complex Class

 Tip:   Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Jetpack_Sync_Actions often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Jetpack_Sync_Actions, and based on these observations, apply Extract Interface, too.

1
<?php
2
require_once dirname( __FILE__ ) . '/class.jetpack-sync-settings.php';
3
4
/**
5
 * The role of this class is to hook the Sync subsystem into WordPress - when to listen for actions,
6
 * when to send, when to perform a full sync, etc.
7
 *
8
 * It also binds the action to send data to WPCOM to Jetpack's XMLRPC client object.
9
 */
10
class Jetpack_Sync_Actions {
11
	static $sender = null;
0 ignored issues
show
Coding Style introduced by
The visibility should be declared for property $sender.

The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using

class A {
    var $property;
}

the property is implicitly global.

To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2.

Loading history...
12
	static $listener = null;
0 ignored issues
show
Coding Style introduced by
The visibility should be declared for property $listener.

The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using

class A {
    var $property;
}

the property is implicitly global.

To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2.

Loading history...
13
	const INITIAL_SYNC_MULTISITE_INTERVAL = 10;
14
	const DEFAULT_SYNC_CRON_INTERVAL = '1min';
15
16
	static function init() {
17
18
		// Add a custom "every minute" cron schedule
19
		add_filter( 'cron_schedules', array( __CLASS__, 'minute_cron_schedule' ) );
20
21
		// On jetpack authorization, schedule a full sync
22
		add_action( 'jetpack_client_authorized', array( __CLASS__, 'schedule_full_sync' ), 10, 0 );
23
24
		// When importing via cron, do not sync
25
		add_action( 'wp_cron_importer_hook', array( __CLASS__, 'set_is_importing_true' ), 1 );
26
27
		// Sync connected user role changes to .com
28
		require_once dirname( __FILE__ ) . '/class.jetpack-sync-users.php';
29
30
		// everything below this point should only happen if we're a valid sync site
31
		if ( ! self::sync_allowed() ) {
32
			return;
33
		}
34
35
		// publicize filter to prevent publicizing blacklisted post types
36
		add_filter( 'publicize_should_publicize_published_post', array( __CLASS__, 'prevent_publicize_blacklisted_posts' ), 10, 2 );
37
38
		// cron hooks
39
		add_action( 'jetpack_sync_full', array( __CLASS__, 'do_full_sync' ), 10, 1 );
40
		add_action( 'jetpack_sync_cron', array( __CLASS__, 'do_cron_sync' ) );
41
		add_action( 'jetpack_sync_full_cron', array( __CLASS__, 'do_cron_full_sync' ) );
42
43
		self::init_sync_cron_jobs();
44
45
		/**
46
		 * Fires on every request before default loading sync listener code.
47
		 * Return false to not load sync listener code that monitors common
48
		 * WP actions to be serialized.
49
		 *
50
		 * By default this returns true for cron jobs, non-GET-requests, or requests where the
51
		 * user is logged-in.
52
		 *
53
		 * @since 4.2.0
54
		 *
55
		 * @param bool should we load sync listener code for this request
56
		 */
57
		if ( apply_filters( 'jetpack_sync_listener_should_load',
58
			(
59
				( isset( $_SERVER["REQUEST_METHOD"] ) && 'GET' !== $_SERVER['REQUEST_METHOD'] )
60
				||
61
				is_user_logged_in()
62
				||
63
				defined( 'PHPUNIT_JETPACK_TESTSUITE' )
64
				||
65
				defined( 'DOING_CRON' ) && DOING_CRON
66
			)
67
		) ) {
68
			self::initialize_listener();
69
		}
70
71
		/**
72
		 * Fires on every request before default loading sync sender code.
73
		 * Return false to not load sync sender code that serializes pending
74
		 * data and sends it to WPCOM for processing.
75
		 *
76
		 * By default this returns true for cron jobs, POST requests, admin requests, or requests
77
		 * by users who can manage_options.
78
		 *
79
		 * @since 4.2.0
80
		 *
81
		 * @param bool should we load sync sender code for this request
82
		 */
83
		if ( apply_filters( 'jetpack_sync_sender_should_load',
84
			(
85
				( isset( $_SERVER["REQUEST_METHOD"] ) && 'POST' === $_SERVER['REQUEST_METHOD'] )
86
				||
87
				current_user_can( 'manage_options' )
88
				||
89
				is_admin()
90
				||
91
				defined( 'PHPUNIT_JETPACK_TESTSUITE' )
92
				||
93
				defined( 'DOING_CRON' ) && DOING_CRON
94
			)
95
		) ) {
96
			self::initialize_sender();
97
			add_action( 'shutdown', array( self::$sender, 'do_sync' ) );
98
		}
99
100
	}
101
102
	static function sync_allowed() {
103
		return ( ! Jetpack_Sync_Settings::get_setting( 'disable' ) && Jetpack::is_active() && ! ( Jetpack::is_development_mode() || Jetpack::is_staging_site() ) )
104
			   || defined( 'PHPUNIT_JETPACK_TESTSUITE' );
105
	}
106
107
	static function prevent_publicize_blacklisted_posts( $should_publicize, $post ) {
108
		if ( in_array( $post->post_type, Jetpack_Sync_Settings::get_setting( 'post_types_blacklist' ) ) ) {
109
			return false;
110
		}
111
112
		return $should_publicize;
113
	}
114
115
	static function set_is_importing_true() {
116
		Jetpack_Sync_Settings::set_importing( true );
117
	}
118
119
	static function send_data( $data, $codec_name, $sent_timestamp, $queue_id ) {
120
		Jetpack::load_xml_rpc_client();
121
122
		$url = add_query_arg( array(
123
			'sync'      => '1', // add an extra parameter to the URL so we can tell it's a sync action
124
			'codec'     => $codec_name, // send the name of the codec used to encode the data
125
			'timestamp' => $sent_timestamp, // send current server time so we can compensate for clock differences
126
			'queue'     => $queue_id, // sync or full_sync
127
		), Jetpack::xmlrpc_api_url() );
128
129
		$rpc = new Jetpack_IXR_Client( array(
130
			'url'     => $url,
131
			'user_id' => JETPACK_MASTER_USER,
132
			'timeout' => 30,
133
		) );
134
135
		$result = $rpc->query( 'jetpack.syncActions', $data );
136
137
		if ( ! $result ) {
138
			return $rpc->get_jetpack_error();
139
		}
140
141
		return $rpc->getResponse();
142
	}
143
144
	static function schedule_initial_sync( $new_version = null, $old_version = null ) {
145
		$initial_sync_config = array(
146
			'options' => true,
147
			'network_options' => true,
148
			'functions' => true,
149
			'constants' => true,
150
		);
151
152
		if ( $old_version && ( version_compare( $old_version, '4.2', '<' ) ) ) {
153
			$initial_sync_config['users'] = 'initial';
154
		}
155
156
		// we need this function call here because we have to run this function
157
		// reeeeally early in init, before WP_CRON_LOCK_TIMEOUT is defined.
158
		wp_functionality_constants();
159
160
		if ( is_multisite() ) {
161
			// stagger initial syncs for multisite blogs so they don't all pile on top of each other
162
			$time_offset = ( rand() / getrandmax() ) * self::INITIAL_SYNC_MULTISITE_INTERVAL * get_blog_count();
163
		} else {
164
			$time_offset = 1;
165
		}
166
167
		self::schedule_full_sync(
168
			$initial_sync_config,
169
			$time_offset
170
		);
171
	}
172
173
	static function schedule_full_sync( $modules = null, $time_offset = 1 ) {
174
		if ( ! self::sync_allowed() ) {
175
			return false;
176
		}
177
178
		if ( self::is_scheduled_full_sync() ) {
179
			self::unschedule_all_full_syncs();
180
		}
181
182
		if ( $modules ) {
183
			wp_schedule_single_event( time() + $time_offset, 'jetpack_sync_full', array( $modules ) );
184
		} else {
185
			wp_schedule_single_event( time() + $time_offset, 'jetpack_sync_full' );
186
		}
187
188
		if ( $time_offset === 1 ) {
189
			spawn_cron();
190
		}
191
192
		return true;
193
	}
194
195
	static function unschedule_all_full_syncs() {
196
		foreach ( _get_cron_array() as $timestamp => $cron ) {
197
			if ( ! empty( $cron['jetpack_sync_full'] ) ) {
198
				foreach( $cron['jetpack_sync_full'] as $key => $config ) {
199
					wp_unschedule_event( $timestamp, 'jetpack_sync_full', $config['args'] );
200
				}
201
			}
202
		}
203
	}
204
205
	static function is_scheduled_full_sync( $modules = null ) {
206
		if ( is_null( $modules ) ) {
207
			$crons = _get_cron_array();
208
209
			foreach ( $crons as $timestamp => $cron ) {
210
				if ( ! empty( $cron['jetpack_sync_full'] ) ) {
211
					return true;
212
				}
213
			}
214
			return false;
215
		}
216
217
		return !! wp_next_scheduled( 'jetpack_sync_full', array( $modules ) );
218
	}
219
220
	static function do_full_sync( $modules = null ) {
221
		if ( ! self::sync_allowed() ) {
222
			return;
223
		}
224
225
		self::initialize_listener();
226
		Jetpack_Sync_Modules::get_module( 'full-sync' )->start( $modules );
227
		self::do_cron_full_sync(); // immediately run a cron full sync, which sends pending data
228
	}
229
230
	static function minute_cron_schedule( $schedules ) {
231
		if( ! isset( $schedules["1min"] ) ) {
232
			$schedules["1min"] = array(
233
				'interval' => 60,
234
				'display' => __( 'Every minute' )
235
			);
236
		}
237
		return $schedules;
238
	}
239
240
	// try to send actions until we run out of things to send,
241
	// or have to wait more than 15s before sending again,
242
	// or we hit a lock or some other sending issue
243 View Code Duplication
	static function do_cron_sync() {
244
		if ( ! self::sync_allowed() ) {
245
			return;
246
		}
247
248
		self::initialize_sender();
249
250
		// remove shutdown hook - no need to sync twice
251
		if ( has_action( 'shutdown', array( self::$sender, 'do_sync' ) ) ) {
252
			remove_action( 'shutdown', array( self::$sender, 'do_sync' ) );
253
		}
254
255
		do {
256
			$next_sync_time = self::$sender->get_next_sync_time( 'sync' );
257
258
			if ( $next_sync_time ) {
259
				$delay = $next_sync_time - time() + 1;
260
				if ( $delay > 15 ) {
261
					break;
262
				} elseif ( $delay > 0 ) {
263
					sleep( $delay );
264
				}
265
			}
266
267
			$result = self::$sender->do_sync();
268
		} while ( $result );
269
	}
270
271 View Code Duplication
	static function do_cron_full_sync() {
272
		if ( ! self::sync_allowed() ) {
273
			return;
274
		}
275
276
		self::initialize_sender();
277
278
		// remove shutdown hook - no need to sync twice
279
		if ( has_action( 'shutdown', array( self::$sender, 'do_sync' ) ) ) {
280
			remove_action( 'shutdown', array( self::$sender, 'do_sync' ) );
281
		}
282
283
		do {
284
			$next_sync_time = self::$sender->get_next_sync_time( 'full_sync' );
285
286
			if ( $next_sync_time ) {
287
				$delay = $next_sync_time - time() + 1;
288
				if ( $delay > 15 ) {
289
					break;
290
				} elseif ( $delay > 0 ) {
291
					sleep( $delay );
292
				}
293
			}
294
295
			$result = self::$sender->do_full_sync();
296
		} while ( $result );
297
	}
298
299
	static function initialize_listener() {
300
		require_once dirname( __FILE__ ) . '/class.jetpack-sync-listener.php';
301
		self::$listener = Jetpack_Sync_Listener::get_instance();
302
	}
303
304
	static function initialize_sender() {
305
		require_once dirname( __FILE__ ) . '/class.jetpack-sync-sender.php';
306
		self::$sender = Jetpack_Sync_Sender::get_instance();
307
308
		// bind the sending process
309
		add_filter( 'jetpack_sync_send_data', array( __CLASS__, 'send_data' ), 10, 4 );
310
	}
311
312
	static function sanitize_filtered_sync_cron_schedule( $schedule ) {
313
		$schedule = sanitize_key( $schedule );
314
		$schedules = wp_get_schedules();
315
316
		// Make sure that the schedule has actually been registered using the `cron_intervals` filter.
317
		if ( isset( $schedules[ $schedule ] ) ) {
318
			return $schedule;
319
		}
320
321
		return self::DEFAULT_SYNC_CRON_INTERVAL;
322
	}
323
324
	static function maybe_schedule_sync_cron( $schedule, $hook ) {
325
		if ( ! $hook ) {
326
			return;
327
		}
328
		$schedule = self::sanitize_filtered_sync_cron_schedule( $schedule );
329
330
		if ( ! wp_next_scheduled( $hook ) ) {
331
			// Schedule a job to send pending queue items once a minute
332
			wp_schedule_event( time(), $schedule, $hook );
333
		} else if ( $schedule != wp_get_schedule( $hook ) ) {
334
			// If the schedule has changed, update the schedule
335
			wp_clear_scheduled_hook( $hook );
336
			wp_schedule_event( time(), $schedule, $hook );
337
		}
338
	}
339
340
	static function init_sync_cron_jobs() {
341
		/**
342
		 * Allows overriding of the default incremental sync cron schedule which defaults to once per minute.
343
		 *
344
		 * @since 4.4.0
345
		 *
346
		 * @param string self::DEFAULT_SYNC_CRON_INTERVAL
347
		 */
348
		$incremental_sync_cron_schedule = apply_filters( 'jetpack_sync_incremental_sync_interval', self::DEFAULT_SYNC_CRON_INTERVAL );
349
		self::maybe_schedule_sync_cron( $incremental_sync_cron_schedule, 'jetpack_sync_cron' );
350
351
		/**
352
		 * Allows overriding of the full sync cron schedule which defaults to once per minute.
353
		 *
354
		 * @since 4.4.0
355
		 *
356
		 * @param string self::DEFAULT_SYNC_CRON_INTERVAL
357
		 */
358
		$full_sync_cron_schedule = apply_filters( 'jetpack_sync_full_sync_interval', self::DEFAULT_SYNC_CRON_INTERVAL );
359
		self::maybe_schedule_sync_cron( $full_sync_cron_schedule, 'jetpack_sync_full_cron' );
360
	}
361
}
362
363
/**
364
 * If the site is using alternate cron, we need to init the listener and sender before cron
365
 * runs. So, we init at a priority of 9.
366
 * 
367
 * If the site is using a regular cron job, we init at a priority of 90 which gives plugins a chance
368
 * to add filters before we initialize.
369
 */
370
if ( defined( 'ALTERNATE_WP_CRON' ) && ALTERNATE_WP_CRON ) {
371
	add_action( 'init', array( 'Jetpack_Sync_Actions', 'init' ), 9 );
372
} else {
373
	add_action( 'init', array( 'Jetpack_Sync_Actions', 'init' ), 90 );
374
}
375
376
// We need to define this here so that it's hooked before `updating_jetpack_version` is called
377
add_action( 'updating_jetpack_version', array( 'Jetpack_Sync_Actions', 'schedule_initial_sync' ), 10, 2 );
378