Complex classes like Module often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Module, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
20 | abstract class Module { |
||
21 | /** |
||
22 | * Number of items per chunk when grouping objects for performance reasons. |
||
23 | * |
||
24 | * @access public |
||
25 | * |
||
26 | * @var int |
||
27 | */ |
||
28 | const ARRAY_CHUNK_SIZE = 10; |
||
29 | |||
30 | /** |
||
31 | * Sync module name. |
||
32 | * |
||
33 | * @access public |
||
34 | * |
||
35 | * @return string |
||
36 | */ |
||
37 | abstract public function name(); |
||
38 | |||
39 | /** |
||
40 | * The id field in the database. |
||
41 | * |
||
42 | * @access public |
||
43 | * |
||
44 | * @return string |
||
45 | */ |
||
46 | public function id_field() { |
||
49 | |||
50 | /** |
||
51 | * The table in the database. |
||
52 | * |
||
53 | * @access public |
||
54 | * |
||
55 | * @return string|bool |
||
56 | */ |
||
57 | public function table_name() { |
||
60 | |||
61 | // phpcs:disable VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
62 | |||
63 | /** |
||
64 | * Retrieve a sync object by its ID. |
||
65 | * |
||
66 | * @access public |
||
67 | * |
||
68 | * @param string $object_type Type of the sync object. |
||
69 | * @param int $id ID of the sync object. |
||
70 | * @return mixed Object, or false if the object is invalid. |
||
71 | */ |
||
72 | public function get_object_by_id( $object_type, $id ) { |
||
75 | |||
76 | /** |
||
77 | * Initialize callables action listeners. |
||
78 | * Override these to set up listeners and set/reset data/defaults. |
||
79 | * |
||
80 | * @access public |
||
81 | * |
||
82 | * @param callable $callable Action handler callable. |
||
83 | */ |
||
84 | public function init_listeners( $callable ) { |
||
86 | |||
87 | /** |
||
88 | * Initialize module action listeners for full sync. |
||
89 | * |
||
90 | * @access public |
||
91 | * |
||
92 | * @param callable $callable Action handler callable. |
||
93 | */ |
||
94 | public function init_full_sync_listeners( $callable ) { |
||
96 | |||
97 | /** |
||
98 | * Initialize the module in the sender. |
||
99 | * |
||
100 | * @access public |
||
101 | */ |
||
102 | public function init_before_send() { |
||
104 | |||
105 | /** |
||
106 | * Set module defaults. |
||
107 | * |
||
108 | * @access public |
||
109 | */ |
||
110 | public function set_defaults() { |
||
112 | |||
113 | /** |
||
114 | * Perform module cleanup. |
||
115 | * Usually triggered when uninstalling the plugin. |
||
116 | * |
||
117 | * @access public |
||
118 | */ |
||
119 | public function reset_data() { |
||
121 | |||
122 | /** |
||
123 | * Enqueue the module actions for full sync. |
||
124 | * |
||
125 | * @access public |
||
126 | * |
||
127 | * @param array $config Full sync configuration for this sync module. |
||
128 | * @param int $max_items_to_enqueue Maximum number of items to enqueue. |
||
129 | * @param boolean $state True if full sync has finished enqueueing this module, false otherwise. |
||
130 | * @return array Number of actions enqueued, and next module state. |
||
131 | */ |
||
132 | public function enqueue_full_sync_actions( $config, $max_items_to_enqueue, $state ) { |
||
136 | |||
137 | /** |
||
138 | * Retrieve an estimated number of actions that will be enqueued. |
||
139 | * |
||
140 | * @access public |
||
141 | * |
||
142 | * @param array $config Full sync configuration for this sync module. |
||
143 | * @return array Number of items yet to be enqueued. |
||
144 | */ |
||
145 | public function estimate_full_sync_actions( $config ) { |
||
149 | |||
150 | // phpcs:enable VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
151 | |||
152 | /** |
||
153 | * Retrieve the actions that will be sent for this module during a full sync. |
||
154 | * |
||
155 | * @access public |
||
156 | * |
||
157 | * @return array Full sync actions of this module. |
||
158 | */ |
||
159 | public function get_full_sync_actions() { |
||
162 | |||
163 | /** |
||
164 | * Get the number of actions that we care about. |
||
165 | * |
||
166 | * @access protected |
||
167 | * |
||
168 | * @param array $action_names Action names we're interested in. |
||
169 | * @param array $actions_to_count Unfiltered list of actions we want to count. |
||
170 | * @return array Number of actions that we're interested in. |
||
171 | */ |
||
172 | protected function count_actions( $action_names, $actions_to_count ) { |
||
175 | |||
176 | /** |
||
177 | * Calculate the checksum of one or more values. |
||
178 | * |
||
179 | * @access protected |
||
180 | * |
||
181 | * @param mixed $values Values to calculate checksum for. |
||
182 | * @return int The checksum. |
||
183 | */ |
||
184 | protected function get_check_sum( $values ) { |
||
187 | |||
188 | /** |
||
189 | * Whether a particular checksum in a set of checksums is valid. |
||
190 | * |
||
191 | * @access protected |
||
192 | * |
||
193 | * @param array $sums_to_check Array of checksums. |
||
194 | * @param string $name Name of the checksum. |
||
195 | * @param int $new_sum Checksum to compare against. |
||
196 | * @return boolean Whether the checksum is valid. |
||
197 | */ |
||
198 | protected function still_valid_checksum( $sums_to_check, $name, $new_sum ) { |
||
205 | |||
206 | /** |
||
207 | * Enqueue all items of a sync type as an action. |
||
208 | * |
||
209 | * @access protected |
||
210 | * |
||
211 | * @param string $action_name Name of the action. |
||
212 | * @param string $table_name Name of the database table. |
||
213 | * @param string $id_field Name of the ID field in the database. |
||
214 | * @param string $where_sql The SQL WHERE clause to filter to the desired items. |
||
215 | * @param int $max_items_to_enqueue Maximum number of items to enqueue in the same time. |
||
216 | * @param boolean $state Whether enqueueing has finished. |
||
217 | * @return array Array, containing the number of chunks and TRUE, indicating enqueueing has finished. |
||
218 | */ |
||
219 | protected function enqueue_all_ids_as_action( $action_name, $table_name, $id_field, $where_sql, $max_items_to_enqueue, $state ) { |
||
265 | |||
266 | /** |
||
267 | * Given the Module Full Sync Configuration and Status return the next chunk of items to send. |
||
268 | * |
||
269 | * @param array $config This module Full Sync configuration. |
||
270 | * @param array $status This module Full Sync status. |
||
271 | * @param int $chunk_size Chunk size. |
||
272 | * |
||
273 | * @return array|object|null |
||
274 | */ |
||
275 | public function get_next_chunk( $config, $status, $chunk_size ) { |
||
288 | |||
289 | /** |
||
290 | * Return the initial last sent object. |
||
291 | * |
||
292 | * @return string|array initial status. |
||
293 | */ |
||
294 | public function get_initial_last_sent() { |
||
297 | |||
298 | /** |
||
299 | * Immediately send all items of a sync type as an action. |
||
300 | * |
||
301 | * @access protected |
||
302 | * |
||
303 | * @param string $config Full sync configuration for this module. |
||
304 | * @param array $status the current module full sync status. |
||
305 | * @param float $send_until timestamp until we want this request to send full sync events. |
||
306 | * |
||
307 | * @return array Status, the module full sync status updated. |
||
308 | */ |
||
309 | public function send_full_sync_actions( $config, $status, $send_until ) { |
||
341 | |||
342 | |||
343 | /** |
||
344 | * Immediately sends a single item without firing or enqueuing it |
||
345 | * |
||
346 | * @param string $action_name The action. |
||
347 | * @param array $data The data associated with the action. |
||
348 | */ |
||
349 | public function send_action( $action_name, $data = null ) { |
||
353 | |||
354 | /** |
||
355 | * Retrieve chunk IDs with previous interval end. |
||
356 | * |
||
357 | * @access protected |
||
358 | * |
||
359 | * @param array $chunks All remaining items. |
||
360 | * @param int $previous_interval_end The last item from the previous interval. |
||
361 | * @return array Chunk IDs with the previous interval end. |
||
362 | */ |
||
363 | protected function get_chunks_with_preceding_end( $chunks, $previous_interval_end ) { |
||
375 | |||
376 | /** |
||
377 | * Get metadata of a particular object type within the designated meta key whitelist. |
||
378 | * |
||
379 | * @access protected |
||
380 | * |
||
381 | * @todo Refactor to use $wpdb->prepare() on the SQL query. |
||
382 | * |
||
383 | * @param array $ids Object IDs. |
||
384 | * @param string $meta_type Meta type. |
||
385 | * @param array $meta_key_whitelist Meta key whitelist. |
||
386 | * @return array Unserialized meta values. |
||
387 | */ |
||
388 | protected function get_metadata( $ids, $meta_type, $meta_key_whitelist ) { |
||
409 | |||
410 | /** |
||
411 | * Initialize listeners for the particular meta type. |
||
412 | * |
||
413 | * @access public |
||
414 | * |
||
415 | * @param string $meta_type Meta type. |
||
416 | * @param callable $callable Action handler callable. |
||
417 | */ |
||
418 | public function init_listeners_for_meta_type( $meta_type, $callable ) { |
||
423 | |||
424 | /** |
||
425 | * Initialize meta whitelist handler for the particular meta type. |
||
426 | * |
||
427 | * @access public |
||
428 | * |
||
429 | * @param string $meta_type Meta type. |
||
430 | * @param callable $whitelist_handler Action handler callable. |
||
431 | */ |
||
432 | public function init_meta_whitelist_handler( $meta_type, $whitelist_handler ) { |
||
437 | |||
438 | /** |
||
439 | * Retrieve the term relationships for the specified object IDs. |
||
440 | * |
||
441 | * @access protected |
||
442 | * |
||
443 | * @todo This feels too specific to be in the abstract sync Module class. Move it? |
||
444 | * |
||
445 | * @param array $ids Object IDs. |
||
446 | * @return array Term relationships - object ID and term taxonomy ID pairs. |
||
447 | */ |
||
448 | protected function get_term_relationships( $ids ) { |
||
454 | |||
455 | /** |
||
456 | * Unserialize the value of a meta object, if necessary. |
||
457 | * |
||
458 | * @access public |
||
459 | * |
||
460 | * @param object $meta Meta object. |
||
461 | * @return object Meta object with possibly unserialized value. |
||
462 | */ |
||
463 | public function unserialize_meta( $meta ) { |
||
467 | |||
468 | /** |
||
469 | * Retrieve a set of objects by their IDs. |
||
470 | * |
||
471 | * @access public |
||
472 | * |
||
473 | * @param string $object_type Object type. |
||
474 | * @param array $ids Object IDs. |
||
475 | * @return array Array of objects. |
||
476 | */ |
||
477 | public function get_objects_by_id( $object_type, $ids ) { |
||
494 | |||
495 | /** |
||
496 | * Gets a list of minimum and maximum object ids for each batch based on the given batch size. |
||
497 | * |
||
498 | * @access public |
||
499 | * |
||
500 | * @param int $batch_size The batch size for objects. |
||
501 | * @param string|bool $where_sql The sql where clause minus 'WHERE', or false if no where clause is needed. |
||
502 | * |
||
503 | * @return array|bool An array of min and max ids for each batch. FALSE if no table can be found. |
||
504 | */ |
||
505 | public function get_min_max_object_ids_for_batches( $batch_size, $where_sql = false ) { |
||
553 | |||
554 | /** |
||
555 | * Return Total number of objects. |
||
556 | * |
||
557 | * @param array $config Full Sync config. |
||
558 | * |
||
559 | * @return int total |
||
560 | */ |
||
561 | public function total( $config ) { |
||
569 | |||
570 | /** |
||
571 | * Retrieve the WHERE SQL clause based on the module config. |
||
572 | * |
||
573 | * @access public |
||
574 | * |
||
575 | * @param array $config Full sync configuration for this sync module. |
||
576 | * @return string WHERE SQL clause, or `null` if no comments are specified in the module config. |
||
577 | */ |
||
578 | public function get_where_sql( $config ) { |
||
581 | |||
582 | } |
||
583 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: