The expression $post_id of type integer|null is loosely compared to false; this is ambiguous if the integer can be zero. You might want to explicitly use === null instead.
In PHP, under loose comparison (like ==, or !=, or switch conditions),
values of different types might be equal.
For integer values, zero is a special case, in particular the following
results might be unexpected:
0==false// true0==null// true123==false// false123==null// false// It is often better to use strict comparison0===false// false0===null// false
Loading history...
37
$post_id = $geo->get_post_id();
38
}
39
40
$meta_values = $geo->get_meta_values( $post_id );
41
42
if ( ! $meta_values['is_public'] || ! $meta_values['is_populated'] ) {
43
return null;
44
}
45
46
return array(
47
'latitude' => $meta_values['latitude'],
48
'longitude' => $meta_values['longitude'],
49
'label' => $meta_values['label']
50
);
51
}
52
53
/**
54
* Display the label HTML for the geo-location information associated with the supplied
55
* post ID.
56
*
57
* If you do not supply a value for $post_id, the global $post will be used, if
58
* available.
59
*
60
* @param integer|null $post_id
61
*
62
* @return void
63
*/
64
function jetpack_geo_display_location( $post_id = null ) {
65
echo jetpack_geo_get_location( $post_id );
66
}
67
68
/**
69
* Return the label HTML for the geo-location information associated with the supplied
70
* post ID.
71
*
72
* If you do not supply a value for $post_id, the global $post will be used, if
73
* available.
74
*
75
* @param integer|null $post_id
76
*
77
* @return string
78
*/
79
function jetpack_geo_get_location( $post_id = null ) {
Automattic /
jetpack
Brad Griffith
In PHP, under loose comparison (like
==, or!=, orswitchconditions), values of different types might be equal.For
integervalues, zero is a special case, in particular the following results might be unexpected: