Jetpack_Sync_Module_Themes - Code Metrics - Inspection of "New build" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master-stable ( ea10e6...53f101 )

unknown

created 2017-05-03 16:35 UTC

Jetpack_Sync_Module_Themes B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	281
Duplicated Lines	2.49 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	7
loc	281
rs	8.3999
c	0
b	0
f	0
wmc	46
lcom	1
cbo	2

16 Methods

Rating	Name	Duplication	Size	Complexity
A	name()	0	3	1
A	init_listeners()	0	17	1
B	detect_theme_deletion()	0	25	5
C	check_upgrader()	7	42	7
A	init_full_sync_listeners()	0	3	1
A	sync_theme_support()	0	11	1
A	enqueue_full_sync_actions()	0	13	1
A	estimate_full_sync_actions()	0	3	1
A	init_before_send()	0	3	1
A	get_full_sync_actions()	0	3	1
A	expand_theme_data()	0	3	1
A	sync_add_widgets_to_sidebar()	0	20	3
B	sync_remove_widgets_from_sidebar()	0	28	5
B	sync_widgets_reordered()	0	22	4
C	sync_sidebar_widgets_actions()	0	50	10
A	get_theme_support_info()	0	18	3

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Jetpack_Sync_Module_Themes often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Jetpack_Sync_Module_Themes, and based on these observations, apply Extract Interface, too.

<?php

class Jetpack_Sync_Module_Themes extends Jetpack_Sync_Module {
	function name() {
		return 'themes';
	}

	public function init_listeners( $callable ) {
		add_action( 'switch_theme', array( $this, 'sync_theme_support' ) );
		add_action( 'jetpack_sync_current_theme_support', $callable );
		add_action( 'upgrader_process_complete', array( $this, 'check_upgrader'), 10, 2 );
		add_action( 'jetpack_installed_theme', $callable, 10, 2 );
		add_action( 'jetpack_updated_theme', $callable, 10, 2 );
		add_action( 'delete_site_transient_update_themes', array( $this, 'detect_theme_deletion') );
		add_action( 'jetpack_deleted_theme', $callable );

		// Sidebar updates.
		add_action( 'update_option_sidebars_widgets', array( $this, 'sync_sidebar_widgets_actions' ), 10, 2 );
		add_action( 'jetpack_widget_added', $callable, 10, 2 );
		add_action( 'jetpack_widget_removed', $callable, 10, 2 );
		add_action( 'jetpack_widget_moved_to_inactive', $callable );
		add_action( 'jetpack_cleared_inactive_widgets', $callable );
		add_action( 'jetpack_widget_reordered', $callable );
	}

	public function detect_theme_deletion() {
		$backtrace = debug_backtrace();
		$delete_theme_call = null;
		foreach ( $backtrace as $call ) {
			if ( isset( $call['function'] ) && 'delete_theme' === $call['function'] ) {
				$delete_theme_call = $call;
				break;
			}
		}
		if ( empty( $delete_theme_call ) ) {
			return;
		}

		$slug = $delete_theme_call['args'][0];

		/**
		 * Signals to the sync listener that a theme was deleted and a sync action
		 * reflecting the deletion and theme slug should be sent
		 *
		 * @since 5.0.0
		 *
		 * @param string $slug Theme slug
		 */
		do_action( 'jetpack_deleted_theme', $slug );
	}

	public function check_upgrader( $upgrader, $details) {
		if ( ! isset( $details['type'] ) ||
			'theme' !== $details['type'] ||
			is_wp_error( $upgrader->skin->result ) ||
			! method_exists( $upgrader, 'theme_info' )
		) {
			return;
		}

		$theme = $upgrader->theme_info();
		$theme_info = array(
			'name' => $theme->get( 'Name' ),
			'version' => $theme->get( 'Version' ),
			'uri' => $theme->get( 'ThemeURI' ),
		);

		if ( 'install' === $details['action'] ) {
			/**
			 * Signals to the sync listener that a theme was installed and a sync action
			 * reflecting the installation and the theme info should be sent
			 *
			 * @since 4.9.0
			 *
			 * @param string $theme->theme_root Text domain of the theme
			 * @param mixed $theme_info Array of abbreviated theme info
			 */
			do_action( 'jetpack_installed_theme', $theme->stylesheet, $theme_info );
		}

		if ( 'update' === $details['action'] ) {
			/**
			 * Signals to the sync listener that a theme was updated and a sync action
			 * reflecting the update and the theme info should be sent
			 *
			 * @since 4.9.0
			 *
			 * @param string $theme->theme_root Text domain of the theme
			 * @param mixed $theme_info Array of abbreviated theme info
			 */
			do_action( 'jetpack_updated_theme', $theme->stylesheet, $theme_info );
		}
	}

	public function init_full_sync_listeners( $callable ) {
		add_action( 'jetpack_full_sync_theme_data', $callable );
	}

	public function sync_theme_support() {
		/**
		 * Fires when the client needs to sync theme support info
		 * Only sends theme support attributes whitelisted in Jetpack_Sync_Defaults::$default_theme_support_whitelist
		 *
		 * @since 4.2.0
		 *
		 * @param object the theme support hash
		 */
		do_action( 'jetpack_sync_current_theme_support' , $this->get_theme_support_info() );
	}

	public function enqueue_full_sync_actions( $config, $max_items_to_enqueue, $state ) {
		/**
		 * Tells the client to sync all theme data to the server
		 *
		 * @since 4.2.0
		 *
		 * @param boolean Whether to expand theme data (should always be true)
		 */
		do_action( 'jetpack_full_sync_theme_data', true );

		// The number of actions enqueued, and next module state (true == done)
		return array( 1, true );
	}

	public function estimate_full_sync_actions( $config ) {
		return 1;
	}
	
	public function init_before_send() {
		add_filter( 'jetpack_sync_before_send_jetpack_full_sync_theme_data', array( $this, 'expand_theme_data' ) );
	}

	function get_full_sync_actions() {
		return array( 'jetpack_full_sync_theme_data' );
	}

	function expand_theme_data() {
		return array( $this->get_theme_support_info() );
	}

	function sync_add_widgets_to_sidebar( $new_widgets, $old_widgets, $sidebar ) {
		$added_widgets = array_diff( $new_widgets, $old_widgets );
		if ( empty( $added_widgets ) ) {
			return array();
		}
		$moved_to_sidebar = array();
		foreach ( $added_widgets as $added_widget ) {
			$moved_to_sidebar[] = $added_widget;
			/**
			 * Helps Sync log that a widget got added
			 *
			 * @since 4.9.0
			 *
			 * @param string $sidebar, Sidebar id got changed
			 * @param string $added_widget, Widget id got added
			 */
			do_action( 'jetpack_widget_added', $sidebar, $added_widget );
		}
		return $moved_to_sidebar;
	}

	function sync_remove_widgets_from_sidebar( $new_widgets, $old_widgets, $sidebar, $inactive_widgets  ) {
		$removed_widgets = array_diff( $old_widgets, $new_widgets );

		if ( empty( $removed_widgets ) ) {
			return array();
		}

		$moved_to_inactive = array();

		foreach( $removed_widgets as $removed_widget ) {
			// Lets check if we didn't move the widget to in_active_widgets
			if ( isset( $inactive_widgets ) && ! in_array( $removed_widget, $inactive_widgets ) ) {
				/**
				 * Helps Sync log that a widgte got removed
				 *
				 * @since 4.9.0
				 *
				 * @param string $sidebar, Sidebar id got changed
				 * @param string $removed_widget, Widget id got removed
				 */
				do_action( 'jetpack_widget_removed', $sidebar, $removed_widget );
			} else {
				$moved_to_inactive[] = $removed_widget;
			}
		}
		return $moved_to_inactive;

	}

	function sync_widgets_reordered( $new_widgets, $old_widgets, $sidebar ) {
		$added_widgets = array_diff( $new_widgets, $old_widgets );
		if ( ! empty( $added_widgets ) ) {
			return;
		}
		$removed_widgets = array_diff( $old_widgets, $new_widgets );
		if ( ! empty( $removed_widgets ) ) {
			return;
		}

		if ( serialize( $old_widgets ) !== serialize( $new_widgets ) ) {
			/**
			 * Helps Sync log that a sidebar id got reordered
			 *
			 * @since 4.9.0
			 *
			 * @param string $sidebar, Sidebar id got changed
			 */
			do_action( 'jetpack_widget_reordered', $sidebar );
		}

	}

	function sync_sidebar_widgets_actions( $old_value, $new_value ) {

		// Don't really know how to deal with different array_values yet.
		if ( $old_value['array_version'] !== 3 || $new_value['array_version'] !== 3 ) {
			return;
		}

		$moved_to_inactive = array();
		$moved_to_sidebar = array();

		foreach ( $new_value as $sidebar => $new_widgets ) {
			if ( in_array( $sidebar, array( 'array_version', 'wp_inactive_widgets' ) ) ) {
				continue;
			}
			$old_widgets = isset( $old_value[ $sidebar ] )
				? $old_value[ $sidebar ]
				: array();

			$moved_to_inactive_recently = $this->sync_remove_widgets_from_sidebar( $new_widgets, $old_widgets, $sidebar, $new_value['wp_inactive_widgets'] );
			$moved_to_inactive = array_merge( $moved_to_inactive, $moved_to_inactive_recently );


			$moved_to_sidebar_recently = $this->sync_add_widgets_to_sidebar( $new_widgets, $old_widgets, $sidebar );
			$moved_to_sidebar = array_merge( $moved_to_sidebar, $moved_to_sidebar_recently );

			$this->sync_widgets_reordered( $new_widgets, $old_widgets, $sidebar );

		}

		// Treat inactive sidebar a bit differently
		if ( ! empty( $moved_to_inactive ) ) {
			/**
			 * Helps Sync log that a widgets IDs got moved to in active
			 *
			 * @since 4.9.0
			 *
			 * @param array $sidebar, Sidebar id got changed
			 */
			do_action( 'jetpack_widget_moved_to_inactive', $moved_to_inactive );
		} elseif ( empty( $moved_to_sidebar ) &&
		           empty( $new_value['wp_inactive_widgets']) &&
		           ! empty( $old_value['wp_inactive_widgets'] ) ) {
			/**
			 * Helps Sync log that a got cleared from inactive.
			 *
			 * @since 4.9.0
			 */
			do_action( 'jetpack_cleared_inactive_widgets' );
		} 
	}

	private function get_theme_support_info() {
		global $_wp_theme_features;

		$theme_support = array();

		foreach ( Jetpack_Sync_Defaults::$default_theme_support_whitelist as $theme_feature ) {

			$has_support = current_theme_supports( $theme_feature );
			if ( $has_support ) {
				$theme_support[ $theme_feature ] = $_wp_theme_features[ $theme_feature ];
			}
		}

		$theme = wp_get_theme();
		$theme_support['name'] = $theme->name;
		$theme_support['version'] =  $theme->version;

		return $theme_support;
	}
}


1		<?php
2
3		class Jetpack_Sync_Module_Themes extends Jetpack_Sync_Module {
4		function name() {
5		return 'themes';
6		}
7
8		public function init_listeners( $callable ) {
9		add_action( 'switch_theme', array( $this, 'sync_theme_support' ) );
10		add_action( 'jetpack_sync_current_theme_support', $callable );
11		add_action( 'upgrader_process_complete', array( $this, 'check_upgrader'), 10, 2 );
12		add_action( 'jetpack_installed_theme', $callable, 10, 2 );
13		add_action( 'jetpack_updated_theme', $callable, 10, 2 );
14		add_action( 'delete_site_transient_update_themes', array( $this, 'detect_theme_deletion') );
15		add_action( 'jetpack_deleted_theme', $callable );
16
17		// Sidebar updates.
18		add_action( 'update_option_sidebars_widgets', array( $this, 'sync_sidebar_widgets_actions' ), 10, 2 );
19		add_action( 'jetpack_widget_added', $callable, 10, 2 );
20		add_action( 'jetpack_widget_removed', $callable, 10, 2 );
21		add_action( 'jetpack_widget_moved_to_inactive', $callable );
22		add_action( 'jetpack_cleared_inactive_widgets', $callable );
23		add_action( 'jetpack_widget_reordered', $callable );
24		}
25
26		public function detect_theme_deletion() {
27		$backtrace = debug_backtrace();
28		$delete_theme_call = null;
29		foreach ( $backtrace as $call ) {
30		if ( isset( $call['function'] ) && 'delete_theme' === $call['function'] ) {
31		$delete_theme_call = $call;
32		break;
33		}
34		}
35		if ( empty( $delete_theme_call ) ) {
36		return;
37		}
38
39		$slug = $delete_theme_call['args'][0];
40
41		/**
42		* Signals to the sync listener that a theme was deleted and a sync action
43		* reflecting the deletion and theme slug should be sent
44		*
45		* @since 5.0.0
46		*
47		* @param string $slug Theme slug
48		*/
49		do_action( 'jetpack_deleted_theme', $slug );
50		}
51
52		public function check_upgrader( $upgrader, $details) {
53	View Code Duplication	if ( ! isset( $details['type'] ) \|\|
54		'theme' !== $details['type'] \|\|
55		is_wp_error( $upgrader->skin->result ) \|\|
56		! method_exists( $upgrader, 'theme_info' )
57		) {
58		return;
59		}
60
61		$theme = $upgrader->theme_info();
62		$theme_info = array(
63		'name' => $theme->get( 'Name' ),
64		'version' => $theme->get( 'Version' ),
65		'uri' => $theme->get( 'ThemeURI' ),
66		);
67
68		if ( 'install' === $details['action'] ) {
69		/**
70		* Signals to the sync listener that a theme was installed and a sync action
71		* reflecting the installation and the theme info should be sent
72		*
73		* @since 4.9.0
74		*
75		* @param string $theme->theme_root Text domain of the theme
76		* @param mixed $theme_info Array of abbreviated theme info
77		*/
78		do_action( 'jetpack_installed_theme', $theme->stylesheet, $theme_info );
79		}
80
81		if ( 'update' === $details['action'] ) {
82		/**
83		* Signals to the sync listener that a theme was updated and a sync action
84		* reflecting the update and the theme info should be sent
85		*
86		* @since 4.9.0
87		*
88		* @param string $theme->theme_root Text domain of the theme
89		* @param mixed $theme_info Array of abbreviated theme info
90		*/
91		do_action( 'jetpack_updated_theme', $theme->stylesheet, $theme_info );
92		}
93		}
94
95		public function init_full_sync_listeners( $callable ) {
96		add_action( 'jetpack_full_sync_theme_data', $callable );
97		}
98
99		public function sync_theme_support() {
100		/**
101		* Fires when the client needs to sync theme support info
102		* Only sends theme support attributes whitelisted in Jetpack_Sync_Defaults::$default_theme_support_whitelist
103		*
104		* @since 4.2.0
105		*
106		* @param object the theme support hash
107		*/
108		do_action( 'jetpack_sync_current_theme_support' , $this->get_theme_support_info() );
109		}
110
111		public function enqueue_full_sync_actions( $config, $max_items_to_enqueue, $state ) {
112		/**
113		* Tells the client to sync all theme data to the server
114		*
115		* @since 4.2.0
116		*
117		* @param boolean Whether to expand theme data (should always be true)
118		*/
119		do_action( 'jetpack_full_sync_theme_data', true );
120
121		// The number of actions enqueued, and next module state (true == done)
122		return array( 1, true );
123		}
124
125		public function estimate_full_sync_actions( $config ) {
126		return 1;
127		}
128
129		public function init_before_send() {
130		add_filter( 'jetpack_sync_before_send_jetpack_full_sync_theme_data', array( $this, 'expand_theme_data' ) );
131		}
132
133		function get_full_sync_actions() {
134		return array( 'jetpack_full_sync_theme_data' );
135		}
136
137		function expand_theme_data() {
138		return array( $this->get_theme_support_info() );
139		}
140
141		function sync_add_widgets_to_sidebar( $new_widgets, $old_widgets, $sidebar ) {
142		$added_widgets = array_diff( $new_widgets, $old_widgets );
143		if ( empty( $added_widgets ) ) {
144		return array();
145		}
146		$moved_to_sidebar = array();
147		foreach ( $added_widgets as $added_widget ) {
148		$moved_to_sidebar[] = $added_widget;
149		/**
150		* Helps Sync log that a widget got added
151		*
152		* @since 4.9.0
153		*
154		* @param string $sidebar, Sidebar id got changed
155		* @param string $added_widget, Widget id got added
156		*/
157		do_action( 'jetpack_widget_added', $sidebar, $added_widget );
158		}
159		return $moved_to_sidebar;
160		}
161
162		function sync_remove_widgets_from_sidebar( $new_widgets, $old_widgets, $sidebar, $inactive_widgets ) {
163		$removed_widgets = array_diff( $old_widgets, $new_widgets );
164
165		if ( empty( $removed_widgets ) ) {
166		return array();
167		}
168
169		$moved_to_inactive = array();
170
171		foreach( $removed_widgets as $removed_widget ) {
172		// Lets check if we didn't move the widget to in_active_widgets
173		if ( isset( $inactive_widgets ) && ! in_array( $removed_widget, $inactive_widgets ) ) {
174		/**
175		* Helps Sync log that a widgte got removed
176		*
177		* @since 4.9.0
178		*
179		* @param string $sidebar, Sidebar id got changed
180		* @param string $removed_widget, Widget id got removed
181		*/
182		do_action( 'jetpack_widget_removed', $sidebar, $removed_widget );
183		} else {
184		$moved_to_inactive[] = $removed_widget;
185		}
186		}
187		return $moved_to_inactive;
188
189		}
190
191		function sync_widgets_reordered( $new_widgets, $old_widgets, $sidebar ) {
192		$added_widgets = array_diff( $new_widgets, $old_widgets );
193		if ( ! empty( $added_widgets ) ) {
194		return;
195		}
196		$removed_widgets = array_diff( $old_widgets, $new_widgets );
197		if ( ! empty( $removed_widgets ) ) {
198		return;
199		}
200
201		if ( serialize( $old_widgets ) !== serialize( $new_widgets ) ) {
202		/**
203		* Helps Sync log that a sidebar id got reordered
204		*
205		* @since 4.9.0
206		*
207		* @param string $sidebar, Sidebar id got changed
208		*/
209		do_action( 'jetpack_widget_reordered', $sidebar );
210		}
211
212		}
213
214		function sync_sidebar_widgets_actions( $old_value, $new_value ) {
215
216		// Don't really know how to deal with different array_values yet.
217		if ( $old_value['array_version'] !== 3 \|\| $new_value['array_version'] !== 3 ) {
218		return;
219		}
220
221		$moved_to_inactive = array();
222		$moved_to_sidebar = array();
223
224		foreach ( $new_value as $sidebar => $new_widgets ) {
225		if ( in_array( $sidebar, array( 'array_version', 'wp_inactive_widgets' ) ) ) {
226		continue;
227		}
228		$old_widgets = isset( $old_value[ $sidebar ] )
229		? $old_value[ $sidebar ]
230		: array();
231
232		$moved_to_inactive_recently = $this->sync_remove_widgets_from_sidebar( $new_widgets, $old_widgets, $sidebar, $new_value['wp_inactive_widgets'] );
233		$moved_to_inactive = array_merge( $moved_to_inactive, $moved_to_inactive_recently );
234
235
236		$moved_to_sidebar_recently = $this->sync_add_widgets_to_sidebar( $new_widgets, $old_widgets, $sidebar );
237		$moved_to_sidebar = array_merge( $moved_to_sidebar, $moved_to_sidebar_recently );
238
239		$this->sync_widgets_reordered( $new_widgets, $old_widgets, $sidebar );
240
241		}
242
243		// Treat inactive sidebar a bit differently
244		if ( ! empty( $moved_to_inactive ) ) {
245		/**
246		* Helps Sync log that a widgets IDs got moved to in active
247		*
248		* @since 4.9.0
249		*
250		* @param array $sidebar, Sidebar id got changed
251		*/
252		do_action( 'jetpack_widget_moved_to_inactive', $moved_to_inactive );
253		} elseif ( empty( $moved_to_sidebar ) &&
254		empty( $new_value['wp_inactive_widgets']) &&
255		! empty( $old_value['wp_inactive_widgets'] ) ) {
256		/**
257		* Helps Sync log that a got cleared from inactive.
258		*
259		* @since 4.9.0
260		*/
261		do_action( 'jetpack_cleared_inactive_widgets' );
262		}
263		}
264
265		private function get_theme_support_info() {
266		global $_wp_theme_features;
267
268		$theme_support = array();
269
270		foreach ( Jetpack_Sync_Defaults::$default_theme_support_whitelist as $theme_feature ) {
		0 ignored issues – show Bug introduced 2016-04-27 23:36 UTC by Report Bug Copy Issue Report The property `default_theme_support_whitelist` cannot be accessed from this context as it is declared `private` in class `Jetpack_Sync_Defaults`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
271		$has_support = current_theme_supports( $theme_feature );
272		if ( $has_support ) {
273		$theme_support[ $theme_feature ] = $_wp_theme_features[ $theme_feature ];
274		}
275		}
276
277		$theme = wp_get_theme();
278		$theme_support['name'] = $theme->name;
279		$theme_support['version'] = $theme->version;
280
281		return $theme_support;
282		}
283		}
284

Automattic / jetpack