Completed
Push — add/changelog-50 ( 40a63e...720d2c )
by Jeremy
108:21 queued 97:51
created

Jetpack_Options   C

Complexity

Total Complexity 56

Size/Duplication

Total Lines 402
Duplicated Lines 10.2 %

Coupling/Cohesion

Components 1
Dependencies 0

Importance

Changes 0
Metric Value
wmc 56
lcom 1
cbo 0
dl 41
loc 402
rs 6.5957
c 0
b 0
f 0

14 Methods

Rating   Name   Duplication   Size   Complexity  
B get_option_names() 0 69 5
D is_valid() 10 28 10
A is_network_option() 0 6 2
B get_option() 7 19 5
B get_option_and_ensure_autoload() 0 19 5
A update_grouped_option() 0 9 2
B update_option() 8 29 5
A update_options() 0 12 3
B delete_option() 0 26 6
A get_grouped_option() 0 8 3
A delete_grouped_option() 0 14 3
A delete_raw_option() 0 5 1
B update_raw_option() 0 27 3
A get_raw_option() 16 16 3

How to fix   Duplicated Code    Complexity   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

Complex Class

 Tip:   Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Jetpack_Options often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Jetpack_Options, and based on these observations, apply Extract Interface, too.

1
<?php
2
3
class Jetpack_Options {
4
5
	/**
6
	 * An array that maps a grouped option type to an option name.
7
	 * @var array
8
	 */
9
	private static $grouped_options = array(
10
		'compact' => 'jetpack_options',
11
		'private' => 'jetpack_private_options'
12
	);
13
14
	/**
15
	 * Returns an array of option names for a given type.
16
	 *
17
	 * @param string $type The type of option to return. Defaults to 'compact'.
18
	 *
19
	 * @return array
20
	 */
21
	public static function get_option_names( $type = 'compact' ) {
22
		switch ( $type ) {
23
		case 'non-compact' :
24
		case 'non_compact' :
25
			return array(
26
				'activated',
27
				'active_modules',
28
				'available_modules',
29
				'do_activate',
30
				'log',
31
				'slideshow_background_color',
32
				'widget_twitter',
33
				'wpcc_options',
34
				'relatedposts',
35
				'file_data',
36
				'autoupdate_plugins',          // (array)  An array of plugin ids ( eg. jetpack/jetpack ) that should be autoupdated
37
				'autoupdate_plugins_translations', // (array)  An array of plugin ids ( eg. jetpack/jetpack ) that should be autoupdated translation files.
38
				'autoupdate_themes',           // (array)  An array of theme ids ( eg. twentyfourteen ) that should be autoupdated
39
				'autoupdate_themes_translations', // (array)  An array of theme ids ( eg. twentyfourteen ) that should autoupdated translation files.
40
				'autoupdate_core',             // (bool)   Whether or not to autoupdate core
41
				'autoupdate_translations',     // (bool)   Whether or not to autoupdate all translations
42
				'json_api_full_management',    // (bool)   Allow full management (eg. Activate, Upgrade plugins) of the site via the JSON API.
43
				'sync_non_public_post_stati',  // (bool)   Allow synchronisation of posts and pages with non-public status.
44
				'site_icon_url',               // (string) url to the full site icon
45
				'site_icon_id',                // (int)    Attachment id of the site icon file
46
				'dismissed_manage_banner',     // (bool) Dismiss Jetpack manage banner allows the user to dismiss the banner permanently
47
				'restapi_stats_cache',         // (array) Stats Cache data.
48
				'unique_connection',           // (array)  A flag to determine a unique connection to wordpress.com two values "connected" and "disconnected" with values for how many times each has occured
49
				'protect_whitelist',           // (array) IP Address for the Protect module to ignore
50
				'sync_error_idc',              // (bool|array) false or array containing the site's home and siteurl at time of IDC error
51
				'safe_mode_confirmed',         // (bool) True if someone confirms that this site was correctly put into safe mode automatically after an identity crisis is discovered.
52
				'migrate_for_idc',             // (bool) True if someone confirms that this site should migrate stats and subscribers from its previous URL
53
			);
54
55
		case 'private' :
56
			return array(
57
				'blog_token',  // (string) The Client Secret/Blog Token of this site.
58
				'user_token',  // (string) The User Token of this site. (deprecated)
59
				'user_tokens'  // (array)  User Tokens for each user of this site who has connected to jetpack.wordpress.com.
60
			);
61
62
		case 'network' :
63
			return array(
64
				'file_data'                     // (array) List of absolute paths to all Jetpack modules
65
			);
66
		}
67
68
		return array(
69
			'id',                           // (int)    The Client ID/WP.com Blog ID of this site.
70
			'publicize_connections',        // (array)  An array of Publicize connections from WordPress.com
71
			'master_user',                  // (int)    The local User ID of the user who connected this site to jetpack.wordpress.com.
72
			'version',                      // (string) Used during upgrade procedure to auto-activate new modules. version:time
73
			'old_version',                  // (string) Used to determine which modules are the most recently added. previous_version:time
74
			'fallback_no_verify_ssl_certs', // (int)    Flag for determining if this host must skip SSL Certificate verification due to misconfigured SSL.
75
			'time_diff',                    // (int)    Offset between Jetpack server's clocks and this server's clocks. Jetpack Server Time = time() + (int) Jetpack_Options::get_option( 'time_diff' )
76
			'public',                       // (int|bool) If we think this site is public or not (1, 0), false if we haven't yet tried to figure it out.
77
			'videopress',                   // (array)  VideoPress options array.
78
			'is_network_site',              // (int|bool) If we think this site is a network or a single blog (1, 0), false if we haven't yet tried to figue it out.
79
			'social_links',                 // (array)  The specified links for each social networking site.
80
			'identity_crisis_whitelist',    // (array)  An array of options, each having an array of the values whitelisted for it.
81
			'gplus_authors',                // (array)  The Google+ authorship information for connected users.
82
			'last_heartbeat',               // (int)    The timestamp of the last heartbeat that fired.
83
			'jumpstart',                    // (string) A flag for whether or not to show the Jump Start.  Accepts: new_connection, jumpstart_activated, jetpack_action_taken, jumpstart_dismissed.
84
			'hide_jitm',                    // (array)  A list of just in time messages that we should not show because they have been dismissed by the user
85
			'custom_css_4.7_migration',     // (bool)   Whether Custom CSS has scanned for and migrated any legacy CSS CPT entries to the new Core format.
86
			'image_widget_migration',       // (bool)   Whether any legacy Image Widgets have been converted to the new Core widget
87
			'last_sync',                    // (int)    The last time a sync was performed
88
		);
89
	}
90
91
	/**
92
	 * Is the option name valid?
93
	 *
94
	 * @param string      $name  The name of the option
95
	 * @param string|null $group The name of the group that the option is in. Default to null, which will search non_compact.
96
	 *
97
	 * @return bool Is the option name valid?
98
	 */
99
	public static function is_valid( $name, $group = null ) {
100
		if ( is_array( $name ) ) {
101
			$compact_names = array();
102
			foreach ( array_keys( self::$grouped_options ) as $_group ) {
103
				$compact_names = array_merge( $compact_names, self::get_option_names( $_group ) );
104
			}
105
106
			$result = array_diff( $name, self::get_option_names( 'non_compact' ), $compact_names );
107
108
			return empty( $result );
109
		}
110
111 View Code Duplication
		if ( is_null( $group ) || 'non_compact' === $group ) {
112
			if ( in_array( $name, self::get_option_names( $group ) ) ) {
113
				return true;
114
			}
115
		}
116
117
		foreach ( array_keys( self::$grouped_options ) as $_group ) {
118 View Code Duplication
			if ( is_null( $group ) || $group === $_group ) {
119
				if ( in_array( $name, self::get_option_names( $_group ) ) ) {
120
					return true;
121
				}
122
			}
123
		}
124
125
		return false;
126
	}
127
128
	/**
129
	 * Checks if an option must be saved for the whole network in WP Multisite
130
	 *
131
	 * @param string $option_name Option name. It must come _without_ `jetpack_%` prefix. The method will prefix the option name.
132
	 *
133
	 * @return bool
134
	 */
135
	public static function is_network_option( $option_name ) {
136
		if ( ! is_multisite() ) {
137
			return false;
138
		}
139
		return in_array( $option_name, self::get_option_names( 'network' ) );
140
	}
141
142
	/**
143
	 * Returns the requested option.  Looks in jetpack_options or jetpack_$name as appropriate.
144
	 *
145
	 * @param string $name Option name. It must come _without_ `jetpack_%` prefix. The method will prefix the option name.
146
	 * @param mixed $default (optional)
147
	 *
148
	 * @return mixed
149
	 */
150
	public static function get_option( $name, $default = false ) {
151 View Code Duplication
		if ( self::is_valid( $name, 'non_compact' ) ) {
152
			if ( self::is_network_option( $name ) ) {
153
				return get_site_option( "jetpack_$name", $default );
154
			}
155
156
			return get_option( "jetpack_$name", $default );
157
		}
158
159
		foreach ( array_keys( self::$grouped_options ) as $group ) {
160
			if ( self::is_valid( $name, $group ) ) {
161
				return self::get_grouped_option( $group, $name, $default );
162
			}
163
		}
164
165
		trigger_error( sprintf( 'Invalid Jetpack option name: %s', $name ), E_USER_WARNING );
166
167
		return $default;
168
	}
169
170
	/**
171
	 * Returns the requested option, and ensures it's autoloaded in the future.
172
	 * This does _not_ adjust the prefix in any way (does not prefix jetpack_%)
173
	 *
174
	 * @param string $name Option name
175
	 * @param mixed $default (optional)
176
	 *
177
	 * @return mixed
178
	 */
179
	public static function get_option_and_ensure_autoload( $name, $default ) {
180
		// In this function the name is not adjusted by prefixing jetpack_
181
		// so if it has already prefixed, we'll replace it and then
182
		// check if the option name is a network option or not
183
		$jetpack_name = preg_replace( '/^jetpack_/', '', $name, 1 );
184
		$is_network_option = self::is_network_option( $jetpack_name );
185
		$value = $is_network_option ? get_site_option( $name ) : get_option( $name );
186
187
		if ( $value === false && $default !== false ) {
188
			if ( $is_network_option ) {
189
				update_site_option( $name, $default );
190
			} else {
191
				update_option( $name, $default );
192
			}
193
			$value = $default;
194
		}
195
196
		return $value;
197
	}
198
199
	private static function update_grouped_option( $group, $name, $value ) {
200
		$options = get_option( self::$grouped_options[ $group ] );
201
		if ( ! is_array( $options ) ) {
202
			$options = array();
203
		}
204
		$options[ $name ] = $value;
205
206
		return update_option( self::$grouped_options[ $group ], $options );
207
	}
208
209
	/**
210
	 * Updates the single given option.  Updates jetpack_options or jetpack_$name as appropriate.
211
	 *
212
	 * @param string $name Option name. It must come _without_ `jetpack_%` prefix. The method will prefix the option name.
213
	 * @param mixed $value Option value
214
	 * @param string $autoload If not compact option, allows specifying whether to autoload or not.
0 ignored issues
show
Documentation introduced by
Should the type for parameter $autoload not be string|null?

This check looks for @param annotations where the type inferred by our type inference engine differs from the declared type.

It makes a suggestion as to what type it considers more descriptive.

Most often this is a case of a parameter that can be null in addition to its declared types.

Loading history...
215
	 *
216
	 * @return bool Was the option successfully updated?
217
	 */
218
	public static function update_option( $name, $value, $autoload = null ) {
219
		/**
220
		 * Fires before Jetpack updates a specific option.
221
		 *
222
		 * @since 3.0.0
223
		 *
224
		 * @param str $name The name of the option being updated.
225
		 * @param mixed $value The new value of the option.
226
		 */
227
		do_action( 'pre_update_jetpack_option_' . $name, $name, $value );
228 View Code Duplication
		if ( self::is_valid( $name, 'non_compact' ) ) {
229
			if ( self::is_network_option( $name ) ) {
230
				return update_site_option( "jetpack_$name", $value );
231
			}
232
233
			return update_option( "jetpack_$name", $value, $autoload );
234
235
		}
236
237
		foreach ( array_keys( self::$grouped_options ) as $group ) {
238
			if ( self::is_valid( $name, $group ) ) {
239
				return self::update_grouped_option( $group, $name, $value );
240
			}
241
		}
242
243
		trigger_error( sprintf( 'Invalid Jetpack option name: %s', $name ), E_USER_WARNING );
244
245
		return false;
246
	}
247
248
	/**
249
	 * Updates the multiple given options.  Updates jetpack_options and/or jetpack_$name as appropriate.
250
	 *
251
	 * @param array $array array( option name => option value, ... )
252
	 */
253
	public static function update_options( $array ) {
254
		$names = array_keys( $array );
255
256
		foreach ( array_diff( $names, self::get_option_names(), self::get_option_names( 'non_compact' ), self::get_option_names( 'private' ) ) as $unknown_name ) {
257
			trigger_error( sprintf( 'Invalid Jetpack option name: %s', $unknown_name ), E_USER_WARNING );
258
			unset( $array[ $unknown_name ] );
259
		}
260
261
		foreach ( $names as $name ) {
262
			self::update_option( $name, $array[ $name ] );
263
		}
264
	}
265
266
	/**
267
	 * Deletes the given option.  May be passed multiple option names as an array.
268
	 * Updates jetpack_options and/or deletes jetpack_$name as appropriate.
269
	 *
270
	 * @param string|array $names Option names. They must come _without_ `jetpack_%` prefix. The method will prefix the option names.
271
	 *
272
	 * @return bool Was the option successfully deleted?
273
	 */
274
	public static function delete_option( $names ) {
275
		$result = true;
276
		$names  = (array) $names;
277
278
		if ( ! self::is_valid( $names ) ) {
0 ignored issues
show
Documentation introduced by
$names is of type array, but the function expects a string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
279
			trigger_error( sprintf( 'Invalid Jetpack option names: %s', print_r( $names, 1 ) ), E_USER_WARNING );
280
			return false;
281
		}
282
283
		foreach ( array_intersect( $names, self::get_option_names( 'non_compact' ) ) as $name ) {
284
			if ( self::is_network_option( $name ) ) {
285
				$result = delete_site_option( "jetpack_$name" );
286
			} else {
287
				$result = delete_option( "jetpack_$name" );
288
			}
289
290
		}
291
292
		foreach ( array_keys( self::$grouped_options ) as $group ) {
293
			if ( ! self::delete_grouped_option( $group, $names ) ) {
294
				$result = false;
295
			}
296
		}
297
298
		return $result;
299
	}
300
301
	private static function get_grouped_option( $group, $name, $default ) {
302
		$options = get_option( self::$grouped_options[ $group ] );
303
		if ( is_array( $options ) && isset( $options[ $name ] ) ) {
304
			return $options[ $name ];
305
		}
306
307
		return $default;
308
	}
309
310
	private static function delete_grouped_option( $group, $names ) {
311
		$options = get_option( self::$grouped_options[ $group ], array() );
312
313
		$to_delete = array_intersect( $names, self::get_option_names( $group ), array_keys( $options ) );
314
		if ( $to_delete ) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $to_delete of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
315
			foreach ( $to_delete as $name ) {
316
				unset( $options[ $name ] );
317
			}
318
319
			return update_option( self::$grouped_options[ $group ], $options );
320
		}
321
322
		return true;
323
	}
324
325
	// Raw option methods allow Jetpack to get / update / delete options via direct DB queries, including options
326
	// that are not created by the Jetpack plugin. This is helpful only in rare cases when we need to bypass
327
	// cache and filters.
328
329
	/**
330
	 * Deletes an option via $wpdb query.
331
	 *
332
	 * @param string $name Option name.
333
	 * 
334
	 * @return bool Is the option deleted?
335
	 */
336
	static function delete_raw_option( $name ) {
337
		global $wpdb;
338
		$result = $wpdb->query( $wpdb->prepare( "DELETE FROM $wpdb->options WHERE option_name = %s", $name ) );
339
		return $result;
340
	}
341
342
	/**
343
	 * Updates an option via $wpdb query.
344
	 *
345
	 * @param string $name Option name.
346
	 * @param mixed $value Option value.
347
	 * @param bool $autoload Specifying whether to autoload or not.
348
	 *
349
	 * @return bool Is the option updated?
350
	 */
351
	static function update_raw_option( $name, $value, $autoload = false ) {
352
		global $wpdb;
353
		$autoload_value = $autoload ? 'yes' : 'no';
354
355
		$serialized_value = maybe_serialize( $value );
356
		// try updating, if no update then insert
357
		// TODO: try to deal with the fact that unchanged values can return updated_num = 0
0 ignored issues
show
Coding Style Best Practice introduced by
Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker.
Loading history...
358
		// below we used "insert ignore" to at least suppress the resulting error
359
		$updated_num = $wpdb->query(
360
			$wpdb->prepare(
361
				"UPDATE $wpdb->options SET option_value = %s WHERE option_name = %s",
362
				$serialized_value,
363
				$name
364
			)
365
		);
366
367
		if ( ! $updated_num ) {
368
			$updated_num = $wpdb->query(
369
				$wpdb->prepare(
370
					"INSERT IGNORE INTO $wpdb->options ( option_name, option_value, autoload ) VALUES ( %s, %s, '$autoload_value' )",
371
					$name,
372
					$serialized_value
373
				)
374
			);
375
		}
376
		return $updated_num;
377
	}
378
379
	/**
380
	 * Gets an option via $wpdb query.
381
	 *
382
	 * @param string $name Option name.
383
	 * @param mixed $default Default option value if option is not found.
384
	 *
385
	 * @return mixed Option value, or null if option is not found and default is not specified.
386
	 */
387 View Code Duplication
	static function get_raw_option( $name, $default = null ) {
388
		global $wpdb;
389
		$value = $wpdb->get_var(
390
			$wpdb->prepare(
391
				"SELECT option_value FROM $wpdb->options WHERE option_name = %s LIMIT 1",
392
				$name
393
			)
394
		);
395
		$value = maybe_unserialize( $value );
396
397
		if ( $value === null && $default !== null ) {
398
			return $default;
399
		}
400
401
		return $value;
402
	}
403
404
}
405