Issues in class.jetpack-client-server.php - Fixed Issues - Inspection of "Confirm array is present" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — kraftbj-patch-5 ( c43ab3 )

unknown

created 2018-04-06 16:32 UTC

class.jetpack-client-server.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Client = Plugin
 * Client Server = API Methods the Plugin must respond to
 */
class Jetpack_Client_Server {

	/**
	 * Authorizations
	 */
	function client_authorize() {
		$data              = stripslashes_deep( $_GET );
		$data['auth_type'] = 'client';
		$role              = Jetpack::translate_current_user_to_role();
		$redirect          = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';

		check_admin_referer( "jetpack-authorize_{$role}_{$redirect}" );

		$result = $this->authorize( $data );
		if ( is_wp_error( $result ) ) {
			Jetpack::state( 'error', $result->get_error_code() );
			JetpackTracking::record_user_event( 'jpc_client_authorize_fail', array(
				'error_code' => $result->get_error_code(),
				'error_message' => $result->get_error_message()
			) );
		} else {
			/**
			 * Fires after the Jetpack client is authorized to communicate with WordPress.com.
			 *
			 * @since 4.2.0
			 *
			 * @param int Jetpack Blog ID.
			 */
			do_action( 'jetpack_client_authorized', Jetpack_Options::get_option( 'id' ) );
		}

		if ( wp_validate_redirect( $redirect ) ) {
			// Exit happens below in $this->do_exit()
			wp_safe_redirect( $redirect );
		} else {
			// Exit happens below in $this->do_exit()
			wp_safe_redirect( Jetpack::admin_url() );
		}

		JetpackTracking::record_user_event( 'jpc_client_authorize_success' );

		$this->do_exit();
	}

	function authorize( $data = array() ) {
		$redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';

		$jetpack_unique_connection = Jetpack_Options::get_option( 'unique_connection' );
		// Checking if site has been active/connected previously before recording unique connection
		if ( ! $jetpack_unique_connection ) {
			// jetpack_unique_connection option has never been set
			$jetpack_unique_connection = array(
				'connected'     => 0,
				'disconnected'  => 0,
				'version'       => '3.6.1',
			);

			update_option( 'jetpack_unique_connection', $jetpack_unique_connection );

			//track unique connection
			$jetpack = $this->get_jetpack();

			$jetpack->stat( 'connections', 'unique-connection' );
			$jetpack->do_stats( 'server_side' );
		}

		// increment number of times connected
		$jetpack_unique_connection['connected'] += 1;
		Jetpack_Options::update_option( 'unique_connection', $jetpack_unique_connection );

		$role = Jetpack::translate_current_user_to_role();

		if ( ! $role ) {
			return new Jetpack_Error( 'no_role', 'Invalid request.', 400 );
		}

		$cap = Jetpack::translate_role_to_cap( $role );
		if ( ! $cap ) {
			return new Jetpack_Error( 'no_cap', 'Invalid request.', 400 );
		}

		if ( ! empty( $data['error'] ) ) {
			return new Jetpack_Error( $data['error'], 'Error included in the request.', 400 );
		}

		if ( ! isset( $data['state'] ) ) {
			return new Jetpack_Error( 'no_state', 'Request must include state.', 400 );
		}

		if ( ! ctype_digit( $data['state'] ) ) {
			return new Jetpack_Error( $data['error'], 'State must be an integer.', 400 );
		}

		$current_user_id = get_current_user_id();
		if ( $current_user_id != $data['state'] ) {
			return new Jetpack_Error( 'wrong_state', 'State does not match current user.', 400 );
		}

		if ( empty( $data['code'] ) ) {
			return new Jetpack_Error( 'no_code', 'Request must include an authorization code.', 400 );
		}

		$token = $this->get_token( $data );

		if ( is_wp_error( $token ) ) {
			$code = $token->get_error_code();
			if ( empty( $code ) ) {
				$code = 'invalid_token';
			}
			return new Jetpack_Error( $code, $token->get_error_message(), 400 );
		}

		if ( ! $token ) {
			return new Jetpack_Error( 'no_token', 'Error generating token.', 400 );
		}

		$is_master_user = ! Jetpack::is_active();

		Jetpack::update_user_token( $current_user_id, sprintf( '%s.%d', $token, $current_user_id ), $is_master_user );

		if ( ! $is_master_user ) {
			Jetpack::state( 'message', 'linked' );
			// Don't activate anything since we are just connecting a user.
			return 'linked';
		}

		// If this site has been through the Jetpack Onboarding flow, delete the onboarding token
		Jetpack::invalidate_onboarding_token();

		// If redirect_uri is SSO, ensure SSO module is enabled
		parse_str( parse_url( $data['redirect_uri'], PHP_URL_QUERY ), $redirect_options );

		/** This filter is documented in class.jetpack-cli.php */
		$jetpack_start_enable_sso = apply_filters( 'jetpack_start_enable_sso', true );

		$activate_sso = (
			isset( $redirect_options['action'] ) &&
			'jetpack-sso' === $redirect_options['action'] &&
			$jetpack_start_enable_sso
		);
		$other_modules = $activate_sso
			? array( 'sso' )
			: array();

		$redirect_on_activation_error = ( 'client' === $data['auth_type'] ) ? true : false;
		if ( $active_modules = Jetpack_Options::get_option( 'active_modules' ) ) {
			Jetpack::delete_active_modules();

			Jetpack::activate_default_modules( 999, 1, array_merge( $active_modules, $other_modules ), $redirect_on_activation_error, false );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		} else {
			Jetpack::activate_default_modules( false, false, $other_modules, $redirect_on_activation_error, false );
		}

		// Since this is a fresh connection, be sure to clear out IDC options
		Jetpack_IDC::clear_all_idc_options();
		Jetpack_Options::delete_raw_option( 'jetpack_last_connect_url_check' );

		// Start nonce cleaner
		wp_clear_scheduled_hook( 'jetpack_clean_nonces' );
		wp_schedule_event( time(), 'hourly', 'jetpack_clean_nonces' );

		Jetpack::state( 'message', 'authorized' );
		return 'authorized';
	}

	public static function deactivate_plugin( $probable_file, $probable_title ) {
		include_once( ABSPATH . 'wp-admin/includes/plugin.php' );
		if ( is_plugin_active( $probable_file ) ) {
			deactivate_plugins( $probable_file );
			return 1;
		} else {
			// If the plugin is not in the usual place, try looking through all active plugins.
			$active_plugins = Jetpack::get_active_plugins();
			foreach ( $active_plugins as $plugin ) {
				$data = get_plugin_data( WP_PLUGIN_DIR . '/' . $plugin );
				if ( $data['Name'] == $probable_title ) {
					deactivate_plugins( $plugin );
					return 1;
				}
			}
		}

		return 0;
	}

	/**
	 * @return object|WP_Error
	 */
	function get_token( $data ) {
		$role = Jetpack::translate_current_user_to_role();

		if ( ! $role ) {
			return new Jetpack_Error( 'role', __( 'An administrator for this blog must set up the Jetpack connection.', 'jetpack' ) );
		}

		$client_secret = Jetpack_Data::get_access_token();
		if ( ! $client_secret ) {
			return new Jetpack_Error( 'client_secret', __( 'You need to register your Jetpack before connecting it.', 'jetpack' ) );
		}

		$redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';
		$redirect_uri = ( 'calypso' === $data['auth_type'] )
			? $data['redirect_uri']
			: add_query_arg( array(
				'action' => 'authorize',
				'_wpnonce' => wp_create_nonce( "jetpack-authorize_{$role}_{$redirect}" ),
				'redirect' => $redirect ? urlencode( $redirect ) : false,
			), menu_page_url( 'jetpack', false ) );

		// inject identity for analytics
		$tracks_identity = jetpack_tracks_get_identity( get_current_user_id() );

		$body = array(
			'client_id' => Jetpack_Options::get_option( 'id' ),
			'client_secret' => $client_secret->secret,
			'grant_type' => 'authorization_code',
			'code' => $data['code'],
			'redirect_uri' => $redirect_uri,
			'_ui' => $tracks_identity['_ui'],
			'_ut' => $tracks_identity['_ut'],
		);

		$args = array(
			'method' => 'POST',
			'body' => $body,
			'headers' => array(
				'Accept' => 'application/json',
			),
		);
		$response = Jetpack_Client::_wp_remote_request( Jetpack::fix_url_for_bad_hosts( Jetpack::api_url( 'token' ) ), $args );

		if ( is_wp_error( $response ) ) {
			return new Jetpack_Error( 'token_http_request_failed', $response->get_error_message() );
		}

		$code = wp_remote_retrieve_response_code( $response );
		$entity = wp_remote_retrieve_body( $response );

		if ( $entity ) {
			$json = json_decode( $entity );
		} else {
			$json = false;
		}

		if ( 200 != $code || ! empty( $json->error ) ) {
			if ( empty( $json->error ) ) {
				return new Jetpack_Error( 'unknown', '', $code );
			}

			$error_description = isset( $json->error_description ) ? sprintf( __( 'Error Details: %s', 'jetpack' ), (string) $json->error_description ) : '';

			return new Jetpack_Error( (string) $json->error, $error_description, $code );
		}

		if ( empty( $json->access_token ) || ! is_scalar( $json->access_token ) ) {
			return new Jetpack_Error( 'access_token', '', $code );
		}

		if ( empty( $json->token_type ) || 'X_JETPACK' != strtoupper( $json->token_type ) ) {
			return new Jetpack_Error( 'token_type', '', $code );
		}

		if ( empty( $json->scope ) ) {
			return new Jetpack_Error( 'scope', 'No Scope', $code );
		}

		@list( $role, $hmac ) = explode( ':', $json->scope );
		if ( empty( $role ) || empty( $hmac ) ) {
			return new Jetpack_Error( 'scope', 'Malformed Scope', $code );
		}

		if ( Jetpack::sign_role( $role ) !== $json->scope ) {
			return new Jetpack_Error( 'scope', 'Invalid Scope', $code );
		}

		if ( ! $cap = Jetpack::translate_role_to_cap( $role ) ) {
			return new Jetpack_Error( 'scope', 'No Cap', $code );
		}

		if ( ! current_user_can( $cap ) ) {
			return new Jetpack_Error( 'scope', 'current_user_cannot', $code );
		}

		/**
		 * Fires after user has successfully received an auth token.
		 *
		 * @since 3.9.0
		 */
		do_action( 'jetpack_user_authorized' );

		return (string) $json->access_token;
	}

	public function get_jetpack() {
		return Jetpack::init();
	}

	public function do_exit() {
		exit;
	}
}


1		<?php
2
3		/**
4		* Client = Plugin
5		* Client Server = API Methods the Plugin must respond to
6		*/
7		class Jetpack_Client_Server {
8
9		/**
10		* Authorizations
11		*/
12		function client_authorize() {
13		$data = stripslashes_deep( $_GET );
14		$data['auth_type'] = 'client';
15		$role = Jetpack::translate_current_user_to_role();
16		$redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';
17
18		check_admin_referer( "jetpack-authorize_{$role}_{$redirect}" );
19
20		$result = $this->authorize( $data );
21		if ( is_wp_error( $result ) ) {
22		Jetpack::state( 'error', $result->get_error_code() );
23		JetpackTracking::record_user_event( 'jpc_client_authorize_fail', array(
24		'error_code' => $result->get_error_code(),
25		'error_message' => $result->get_error_message()
26		) );
27		} else {
28		/**
29		* Fires after the Jetpack client is authorized to communicate with WordPress.com.
30		*
31		* @since 4.2.0
32		*
33		* @param int Jetpack Blog ID.
34		*/
35		do_action( 'jetpack_client_authorized', Jetpack_Options::get_option( 'id' ) );
36		}
37
38		if ( wp_validate_redirect( $redirect ) ) {
39		// Exit happens below in $this->do_exit()
40		wp_safe_redirect( $redirect );
41		} else {
42		// Exit happens below in $this->do_exit()
43		wp_safe_redirect( Jetpack::admin_url() );
44		}
45
46		JetpackTracking::record_user_event( 'jpc_client_authorize_success' );
47
48		$this->do_exit();
49		}
50
51		function authorize( $data = array() ) {
52		$redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';
53
54		$jetpack_unique_connection = Jetpack_Options::get_option( 'unique_connection' );
55		// Checking if site has been active/connected previously before recording unique connection
56		if ( ! $jetpack_unique_connection ) {
57		// jetpack_unique_connection option has never been set
58		$jetpack_unique_connection = array(
59		'connected' => 0,
60		'disconnected' => 0,
61		'version' => '3.6.1',
62		);
63
64		update_option( 'jetpack_unique_connection', $jetpack_unique_connection );
65
66		//track unique connection
67		$jetpack = $this->get_jetpack();
68
69		$jetpack->stat( 'connections', 'unique-connection' );
70		$jetpack->do_stats( 'server_side' );
71		}
72
73		// increment number of times connected
74		$jetpack_unique_connection['connected'] += 1;
75		Jetpack_Options::update_option( 'unique_connection', $jetpack_unique_connection );
76
77		$role = Jetpack::translate_current_user_to_role();
78
79		if ( ! $role ) {
80		return new Jetpack_Error( 'no_role', 'Invalid request.', 400 );
81		}
82
83		$cap = Jetpack::translate_role_to_cap( $role );
84		if ( ! $cap ) {
85		return new Jetpack_Error( 'no_cap', 'Invalid request.', 400 );
86		}
87
88		if ( ! empty( $data['error'] ) ) {
89		return new Jetpack_Error( $data['error'], 'Error included in the request.', 400 );
90		}
91
92		if ( ! isset( $data['state'] ) ) {
93		return new Jetpack_Error( 'no_state', 'Request must include state.', 400 );
94		}
95
96		if ( ! ctype_digit( $data['state'] ) ) {
97		return new Jetpack_Error( $data['error'], 'State must be an integer.', 400 );
98		}
99
100		$current_user_id = get_current_user_id();
101		if ( $current_user_id != $data['state'] ) {
102		return new Jetpack_Error( 'wrong_state', 'State does not match current user.', 400 );
103		}
104
105		if ( empty( $data['code'] ) ) {
106		return new Jetpack_Error( 'no_code', 'Request must include an authorization code.', 400 );
107		}
108
109		$token = $this->get_token( $data );
110
111		if ( is_wp_error( $token ) ) {
112		$code = $token->get_error_code();
113		if ( empty( $code ) ) {
114		$code = 'invalid_token';
115		}
116		return new Jetpack_Error( $code, $token->get_error_message(), 400 );
117		}
118
119		if ( ! $token ) {
120		return new Jetpack_Error( 'no_token', 'Error generating token.', 400 );
121		}
122
123		$is_master_user = ! Jetpack::is_active();
124
125		Jetpack::update_user_token( $current_user_id, sprintf( '%s.%d', $token, $current_user_id ), $is_master_user );
126
127		if ( ! $is_master_user ) {
128		Jetpack::state( 'message', 'linked' );
129		// Don't activate anything since we are just connecting a user.
130		return 'linked';
131		}
132
133		// If this site has been through the Jetpack Onboarding flow, delete the onboarding token
134		Jetpack::invalidate_onboarding_token();
135
136		// If redirect_uri is SSO, ensure SSO module is enabled
137		parse_str( parse_url( $data['redirect_uri'], PHP_URL_QUERY ), $redirect_options );
138
139		/** This filter is documented in class.jetpack-cli.php */
140		$jetpack_start_enable_sso = apply_filters( 'jetpack_start_enable_sso', true );
141
142		$activate_sso = (
143		isset( $redirect_options['action'] ) &&
144		'jetpack-sso' === $redirect_options['action'] &&
145		$jetpack_start_enable_sso
146		);
147		$other_modules = $activate_sso
148		? array( 'sso' )
149		: array();
150
151		$redirect_on_activation_error = ( 'client' === $data['auth_type'] ) ? true : false;
152	View Code Duplication	if ( $active_modules = Jetpack_Options::get_option( 'active_modules' ) ) {
153		Jetpack::delete_active_modules();
154
155		Jetpack::activate_default_modules( 999, 1, array_merge( $active_modules, $other_modules ), $redirect_on_activation_error, false );
		0 ignored issues – show Documentation introduced 2017-10-19 23:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this `999` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
156		} else {
157		Jetpack::activate_default_modules( false, false, $other_modules, $redirect_on_activation_error, false );
158		}
159
160		// Since this is a fresh connection, be sure to clear out IDC options
161		Jetpack_IDC::clear_all_idc_options();
162		Jetpack_Options::delete_raw_option( 'jetpack_last_connect_url_check' );
163
164		// Start nonce cleaner
165		wp_clear_scheduled_hook( 'jetpack_clean_nonces' );
166		wp_schedule_event( time(), 'hourly', 'jetpack_clean_nonces' );
167
168		Jetpack::state( 'message', 'authorized' );
169		return 'authorized';
170		}
171
172		public static function deactivate_plugin( $probable_file, $probable_title ) {
173		include_once( ABSPATH . 'wp-admin/includes/plugin.php' );
174		if ( is_plugin_active( $probable_file ) ) {
175		deactivate_plugins( $probable_file );
176		return 1;
177		} else {
178		// If the plugin is not in the usual place, try looking through all active plugins.
179		$active_plugins = Jetpack::get_active_plugins();
180		foreach ( $active_plugins as $plugin ) {
181		$data = get_plugin_data( WP_PLUGIN_DIR . '/' . $plugin );
182		if ( $data['Name'] == $probable_title ) {
183		deactivate_plugins( $plugin );
184		return 1;
185		}
186		}
187		}
188
189		return 0;
190		}
191
192		/**
193		* @return object\|WP_Error
194		*/
195		function get_token( $data ) {
196		$role = Jetpack::translate_current_user_to_role();
197
198		if ( ! $role ) {
199		return new Jetpack_Error( 'role', __( 'An administrator for this blog must set up the Jetpack connection.', 'jetpack' ) );
200		}
201
202		$client_secret = Jetpack_Data::get_access_token();
203		if ( ! $client_secret ) {
204		return new Jetpack_Error( 'client_secret', __( 'You need to register your Jetpack before connecting it.', 'jetpack' ) );
205		}
206
207		$redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';
208		$redirect_uri = ( 'calypso' === $data['auth_type'] )
209		? $data['redirect_uri']
210		: add_query_arg( array(
211		'action' => 'authorize',
212		'_wpnonce' => wp_create_nonce( "jetpack-authorize_{$role}_{$redirect}" ),
213		'redirect' => $redirect ? urlencode( $redirect ) : false,
214		), menu_page_url( 'jetpack', false ) );
215
216		// inject identity for analytics
217		$tracks_identity = jetpack_tracks_get_identity( get_current_user_id() );
218
219		$body = array(
220		'client_id' => Jetpack_Options::get_option( 'id' ),
221		'client_secret' => $client_secret->secret,
222		'grant_type' => 'authorization_code',
223		'code' => $data['code'],
224		'redirect_uri' => $redirect_uri,
225		'_ui' => $tracks_identity['_ui'],
226		'_ut' => $tracks_identity['_ut'],
227		);
228
229		$args = array(
230		'method' => 'POST',
231		'body' => $body,
232		'headers' => array(
233		'Accept' => 'application/json',
234		),
235		);
236		$response = Jetpack_Client::_wp_remote_request( Jetpack::fix_url_for_bad_hosts( Jetpack::api_url( 'token' ) ), $args );
237
238		if ( is_wp_error( $response ) ) {
239		return new Jetpack_Error( 'token_http_request_failed', $response->get_error_message() );
240		}
241
242		$code = wp_remote_retrieve_response_code( $response );
243		$entity = wp_remote_retrieve_body( $response );
244
245		if ( $entity ) {
246		$json = json_decode( $entity );
247		} else {
248		$json = false;
249		}
250
251		if ( 200 != $code \|\| ! empty( $json->error ) ) {
252		if ( empty( $json->error ) ) {
253		return new Jetpack_Error( 'unknown', '', $code );
254		}
255
256		$error_description = isset( $json->error_description ) ? sprintf( __( 'Error Details: %s', 'jetpack' ), (string) $json->error_description ) : '';
257
258		return new Jetpack_Error( (string) $json->error, $error_description, $code );
259		}
260
261		if ( empty( $json->access_token ) \|\| ! is_scalar( $json->access_token ) ) {
262		return new Jetpack_Error( 'access_token', '', $code );
263		}
264
265		if ( empty( $json->token_type ) \|\| 'X_JETPACK' != strtoupper( $json->token_type ) ) {
266		return new Jetpack_Error( 'token_type', '', $code );
267		}
268
269		if ( empty( $json->scope ) ) {
270		return new Jetpack_Error( 'scope', 'No Scope', $code );
271		}
272
273		@list( $role, $hmac ) = explode( ':', $json->scope );
274		if ( empty( $role ) \|\| empty( $hmac ) ) {
275		return new Jetpack_Error( 'scope', 'Malformed Scope', $code );
276		}
277
278		if ( Jetpack::sign_role( $role ) !== $json->scope ) {
279		return new Jetpack_Error( 'scope', 'Invalid Scope', $code );
280		}
281
282		if ( ! $cap = Jetpack::translate_role_to_cap( $role ) ) {
283		return new Jetpack_Error( 'scope', 'No Cap', $code );
284		}
285
286		if ( ! current_user_can( $cap ) ) {
287		return new Jetpack_Error( 'scope', 'current_user_cannot', $code );
288		}
289
290		/**
291		* Fires after user has successfully received an auth token.
292		*
293		* @since 3.9.0
294		*/
295		do_action( 'jetpack_user_authorized' );
296
297		return (string) $json->access_token;
298		}
299
300		public function get_jetpack() {
301		return Jetpack::init();
302		}
303
304		public function do_exit() {
305		exit;
306		}
307		}
308

Automattic / jetpack

Push — kraftbj-patch-5 ( c43ab3 )

class.jetpack-client-server.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like