Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | class Jetpack_Admin_Menu extends Admin_Menu { |
||
16 | |||
17 | /** |
||
18 | * Create the desired menu output. |
||
19 | */ |
||
20 | public function reregister_menu_items() { |
||
37 | |||
38 | /** |
||
39 | * Whether to use wp-admin pages rather than Calypso. |
||
40 | * |
||
41 | * @return bool |
||
42 | */ |
||
43 | public function should_link_to_wp_admin() { |
||
47 | |||
48 | /** |
||
49 | * Adds Posts menu. |
||
50 | * |
||
51 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
52 | */ |
||
53 | public function add_posts_menu( $wp_admin = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
57 | |||
58 | /** |
||
59 | * Adds Media menu. |
||
60 | * |
||
61 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
62 | */ |
||
63 | public function add_media_menu( $wp_admin = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
66 | |||
67 | /** |
||
68 | * Adds Page menu. |
||
69 | * |
||
70 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
71 | */ |
||
72 | public function add_page_menu( $wp_admin = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
76 | |||
77 | /** |
||
78 | * Adds a custom post type menu. |
||
79 | * |
||
80 | * @param string $post_type Custom post type. |
||
81 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
82 | */ |
||
83 | public function add_custom_post_type_menu( $post_type, $wp_admin = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
104 | |||
105 | /** |
||
106 | * Adds Comments menu. |
||
107 | * |
||
108 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
109 | */ |
||
110 | public function add_comments_menu( $wp_admin = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
113 | |||
114 | /** |
||
115 | * Adds Feedback menu. |
||
116 | */ |
||
117 | public function add_feedback_menu() { |
||
133 | |||
134 | /** |
||
135 | * Adds Jetpack menu. |
||
136 | */ |
||
137 | public function add_jetpack_menu() { |
||
151 | |||
152 | /** |
||
153 | * Adds Appearance menu. |
||
154 | * |
||
155 | * @param bool $wp_admin_themes Optional. Whether Themes link should point to Calypso or wp-admin. Default false (Calypso). |
||
156 | * @param bool $wp_admin_customize Optional. Whether Customize link should point to Calypso or wp-admin. Default false (Calypso). |
||
157 | */ |
||
158 | public function add_appearance_menu( $wp_admin_themes = false, $wp_admin_customize = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
164 | |||
165 | /** |
||
166 | * Adds Plugins menu. |
||
167 | * |
||
168 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
169 | */ |
||
170 | public function add_plugins_menu( $wp_admin = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
173 | |||
174 | /** |
||
175 | * Adds Users menu. |
||
176 | * |
||
177 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
178 | */ |
||
179 | View Code Duplication | public function add_users_menu( $wp_admin = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
|
186 | |||
187 | /** |
||
188 | * Adds Tools menu. |
||
189 | * |
||
190 | * @param bool $wp_admin_import Optional. Whether Import link should point to Calypso or wp-admin. Default false (Calypso). |
||
191 | * @param bool $wp_admin_export Optional. Whether Export link should point to Calypso or wp-admin. Default false (Calypso). |
||
192 | */ |
||
193 | public function add_tools_menu( $wp_admin_import = false, $wp_admin_export = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
206 | |||
207 | /** |
||
208 | * Adds Settings menu. |
||
209 | * |
||
210 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
211 | */ |
||
212 | public function add_options_menu( $wp_admin = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
215 | |||
216 | /** |
||
217 | * Adds WP Admin menu. |
||
218 | */ |
||
219 | public function add_wp_admin_menu() { |
||
230 | } |
||
231 |