Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 15 | class Atomic_Admin_Menu extends Admin_Menu { |
||
| 16 | |||
| 17 | /** |
||
| 18 | * Atomic_Admin_Menu constructor. |
||
| 19 | */ |
||
| 20 | protected function __construct() { |
||
| 31 | |||
| 32 | /** |
||
| 33 | * Create the desired menu output. |
||
| 34 | */ |
||
| 35 | View Code Duplication | public function reregister_menu_items() { |
|
| 52 | |||
| 53 | /** |
||
| 54 | * Adds Plugins menu. |
||
| 55 | * |
||
| 56 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 57 | */ |
||
| 58 | public function add_plugins_menu( $wp_admin = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
| 62 | |||
| 63 | /** |
||
| 64 | * Adds the site switcher link if user has more than one site. |
||
| 65 | */ |
||
| 66 | public function add_browse_sites_link() { |
||
| 76 | |||
| 77 | /** |
||
| 78 | * Adds a custom element class for Site Switcher menu item. |
||
| 79 | * |
||
| 80 | * @param array $menu Associative array of administration menu items. |
||
| 81 | * @return array |
||
| 82 | */ |
||
| 83 | View Code Duplication | public function set_browse_sites_link_class( array $menu ) { |
|
| 95 | |||
| 96 | /** |
||
| 97 | * Adds a link to the menu to create a new site. |
||
| 98 | */ |
||
| 99 | public function add_new_site_link() { |
||
| 116 | |||
| 117 | /** |
||
| 118 | * Adds site card component. |
||
| 119 | */ |
||
| 120 | public function add_site_card_menu() { |
||
| 149 | |||
| 150 | /** |
||
| 151 | * Adds a custom element class and id for Site Card's menu item. |
||
| 152 | * |
||
| 153 | * @param array $menu Associative array of administration menu items. |
||
| 154 | * @return array |
||
| 155 | */ |
||
| 156 | public function set_site_card_menu_class( array $menu ) { |
||
| 176 | |||
| 177 | /** |
||
| 178 | * Adds Upgrades menu. |
||
| 179 | */ |
||
| 180 | public function add_upgrades_menu() { |
||
| 185 | |||
| 186 | /** |
||
| 187 | * Adds Tools menu. |
||
| 188 | * |
||
| 189 | * @param bool $wp_admin_import Optional. Whether Import link should point to Calypso or wp-admin. Default false (Calypso). |
||
| 190 | * @param bool $wp_admin_export Optional. Whether Export link should point to Calypso or wp-admin. Default false (Calypso). |
||
| 191 | */ |
||
| 192 | public function add_tools_menu( $wp_admin_import = false, $wp_admin_export = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
| 196 | |||
| 197 | /** |
||
| 198 | * Adds Settings menu. |
||
| 199 | * |
||
| 200 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 201 | */ |
||
| 202 | public function add_options_menu( $wp_admin = false ) { |
||
| 203 | add_options_page( esc_attr__( 'Hosting Configuration', 'jetpack' ), __( 'Hosting Configuration', 'jetpack' ), 'manage_options', 'https://wordpress.com/hosting-config/' . $this->domain, null, 6 ); |
||
| 204 | |||
| 205 | parent::add_options_menu( $wp_admin ); |
||
| 206 | |||
| 207 | // No need to add a menu linking to WP Admin if there is already one. |
||
| 208 | if ( ! $wp_admin ) { |
||
| 209 | $parent_menu_slug = 'https://wordpress.com/settings/general/' . $this->domain; |
||
| 210 | add_submenu_page( $parent_menu_slug, esc_attr__( 'Advanced General', 'jetpack' ), __( 'Advanced General', 'jetpack' ), 'manage_options', 'options-general.php' ); |
||
| 211 | add_submenu_page( $parent_menu_slug, esc_attr__( 'Advanced Writing', 'jetpack' ), __( 'Advanced Writing', 'jetpack' ), 'manage_options', 'options-writing.php' ); |
||
| 212 | } |
||
| 213 | } |
||
| 214 | |||
| 215 | /** |
||
| 216 | * Adds a WordPress.org theme install menu item. |
||
| 217 | * |
||
| 218 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 219 | */ |
||
| 220 | public function add_theme_install_menu( $wp_admin = false ) { |
||
| 225 | |||
| 226 | /** |
||
| 227 | * Adds Appearance menu. |
||
| 228 | * |
||
| 229 | * @param bool $wp_admin_themes Optional. Whether Themes link should point to Calypso or wp-admin. Default false (Calypso). |
||
| 230 | * @param bool $wp_admin_customize Optional. Whether Customize link should point to Calypso or wp-admin. Default false (Calypso). |
||
| 231 | */ |
||
| 232 | public function add_appearance_menu( $wp_admin_themes = false, $wp_admin_customize = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
| 236 | |||
| 237 | /** |
||
| 238 | * Adds Users menu. |
||
| 239 | * |
||
| 240 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 241 | */ |
||
| 242 | public function add_users_menu( $wp_admin = false ) { |
||
| 254 | } |
||
| 255 |