Jetpack_Sync_Options::get_option() - Code Metrics - Inspection of "Rename read_option to get_option" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — branch-4.4 ( ced99a...8c5fae )

unknown

created 2016-11-29 23:17 UTC

Jetpack_Sync_Options::get_option() A

↳ Parent: Jetpack_Sync_Options

Complexity

Conditions	3
Paths	2

Size

Total Lines	16
Code Lines	10

Duplication

Lines	16
Ratio	100 %

Importance

Changes

Metric	Value
cc	3
eloc	10
nc	2
nop	2
dl	16
loc	16
rs	9.4285
c	0
b	0
f	0

<?php

/**
 * Simple class to read/write to the options table, bypassing 
 * problematic caching with get_option/set_option
 **/

class Jetpack_Sync_Options {

	static function delete_option( $name ) {
		global $wpdb;
		$wpdb->query( $wpdb->prepare( "DELETE FROM $wpdb->options WHERE option_name = %s", $name ) );
	}

	static function update_option( $name, $value, $autoload = false ) {

		$autoload_value = $autoload ? 'yes' : 'no';

		// we write our own option updating code to bypass filters/caching/etc on set_option/get_option
		global $wpdb;
		$serialized_value = maybe_serialize( $value );
		// try updating, if no update then insert
		// TODO: try to deal with the fact that unchanged values can return updated_num = 0

		// below we used "insert ignore" to at least suppress the resulting error
		$updated_num = $wpdb->query(
			$wpdb->prepare(
				"UPDATE $wpdb->options SET option_value = %s WHERE option_name = %s", 
				$serialized_value,
				$name
			)
		);

		if ( ! $updated_num ) {
			$updated_num = $wpdb->query(
				$wpdb->prepare(
					"INSERT IGNORE INTO $wpdb->options ( option_name, option_value, autoload ) VALUES ( %s, %s, '$autoload_value' )", 
					$name,
					$serialized_value
				)
			);
		}
		return $updated_num;
	}

	static function get_option( $name, $default = null ) {
		global $wpdb;
		$value = $wpdb->get_var( 
			$wpdb->prepare(
				"SELECT option_value FROM $wpdb->options WHERE option_name = %s LIMIT 1", 
				$name
			)
		);
		$value = maybe_unserialize( $value );

		if ( $value === null && $default !== null ) {
			return $default;
		}

		return $value;
	}
	
}

1		<?php
2
3		/**
4		* Simple class to read/write to the options table, bypassing
5		* problematic caching with get_option/set_option
6		**/
7
8		class Jetpack_Sync_Options {
9
10		static function delete_option( $name ) {
11		global $wpdb;
12		$wpdb->query( $wpdb->prepare( "DELETE FROM $wpdb->options WHERE option_name = %s", $name ) );
13		}
14
15		static function update_option( $name, $value, $autoload = false ) {
16
17		$autoload_value = $autoload ? 'yes' : 'no';
18
19		// we write our own option updating code to bypass filters/caching/etc on set_option/get_option
20		global $wpdb;
21		$serialized_value = maybe_serialize( $value );
22		// try updating, if no update then insert
23		// TODO: try to deal with the fact that unchanged values can return updated_num = 0
		0 ignored issues – show Coding Style Best Practice introduced 2016-11-23 01:16 UTC by Report Bug Copy Issue Report Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker. Loading history...
24		// below we used "insert ignore" to at least suppress the resulting error
25		$updated_num = $wpdb->query(
26		$wpdb->prepare(
27		"UPDATE $wpdb->options SET option_value = %s WHERE option_name = %s",
28		$serialized_value,
29		$name
30		)
31		);
32
33		if ( ! $updated_num ) {
34		$updated_num = $wpdb->query(
35		$wpdb->prepare(
36		"INSERT IGNORE INTO $wpdb->options ( option_name, option_value, autoload ) VALUES ( %s, %s, '$autoload_value' )",
37		$name,
38		$serialized_value
39		)
40		);
41		}
42		return $updated_num;
43		}
44
45	View Code Duplication	static function get_option( $name, $default = null ) {
46		global $wpdb;
47		$value = $wpdb->get_var(
48		$wpdb->prepare(
49		"SELECT option_value FROM $wpdb->options WHERE option_name = %s LIMIT 1",
50		$name
51		)
52		);
53		$value = maybe_unserialize( $value );
54
55		if ( $value === null && $default !== null ) {
56		return $default;
57		}
58
59		return $value;
60		}
61
62		}

Automattic / jetpack

Push — branch-4.4 ( ced99a...8c5fae )

Jetpack_Sync_Options::get_option() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like