Jetpack_Search_Debug_Bar::render() - Code Metrics - Inspection of "Run eslint --fix on the changed files" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — update/react-create-class ( 7f3c72...120f37 )

unknown

created 2018-01-30 20:09 UTC

Jetpack_Search_Debug_Bar::render() B

↳ Parent: Jetpack_Search_Debug_Bar

Complexity

Conditions	7
Paths	6

Size

Total Lines	56
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	45
nc	6
nop	0
dl	0
loc	56
rs	7.7489
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * Singleton class instantiated by Jetpack_Searc_Debug_Bar::instance() that handles
 * rendering the Jetpack Search debug bar menu item and panel.
 */
class Jetpack_Search_Debug_Bar extends Debug_Bar_Panel {
	/**
	 * Holds singleton instance
	 *
	 * @var Jetpack_Search_Debug_Bar
	 */
	protected static $instance = null;

	/**
	 * Holds an instance of Jetpack_Search
	 *
	 * @var Jetpack_Search
	 */
	private $jetpack_search;

	/**
	 * The title to use in the debug bar navigation
	 *
	 * @var string
	 */
	public $title;

	/**
	 * Constructor
	 */
	public function __construct() {
		$this->title( esc_html__( 'Jetpack Search', 'jetpack' ) );
		$this->jetpack_search = Jetpack_Search::instance();
		add_action( 'wp_enqueue_scripts', array( $this, 'enqueue_scripts' ) );
	}

	/**
	 * Returns the singleton instance of Jetpack_Search_Debug_Bar
	 *
	 * @return Jetpack_Search_Debug_Bar
	 */
	public static function instance() {
		if ( is_null( self::$instance ) ) {
			self::$instance = new Jetpack_Search_Debug_Bar();
		}
		return self::$instance;
	}

	/**
	 * Enqueues styles for our panel in the debug bar
	 *
	 * @return void
	 */
	public function enqueue_scripts() {
		wp_enqueue_style(
			'jetpack-search-debug-bar',
			plugins_url( '3rd-party/debug-bar/debug-bar.css', JETPACK__PLUGIN_FILE )
		);
		wp_enqueue_script(
			'jetpack-search-debug-bar',
			plugins_url( '3rd-party/debug-bar/debug-bar.js', JETPACK__PLUGIN_FILE ),
			array( 'jquery' )
		);
	}

	/**
	 * Should the Jetpack Search Debug Bar show?
	 *
	 * Since we've previously done a check for the search module being activated, let's just return true.
	 * Later on, we can update this to only show when `is_search()` is true.
	 *
	 * @return boolean
	 */
	public function is_visible() {
		return true;
	}

	/**
	 * Renders the panel content
	 *
	 * @return void
	 */
	public function render() {
		$last_query_info = $this->jetpack_search->get_last_query_info();

		// If not empty, let's reshuffle the order of some things.
		if ( ! empty( $last_query_info ) ) {
			$args     = $last_query_info['args'];
			$response = $last_query_info['response'];
			$response_code = $last_query_info['response_code'];

			unset( $last_query_info['args'] );
			unset( $last_query_info['response'] );
			unset( $last_query_info['response_code'] );

			if ( is_null( $last_query_info['es_time'] ) ) {
				$last_query_info['es_time'] = esc_html_x(
					'cache hit',
					'displayed in search results when results are cached',
					'jetpack'
				);
			}

			$temp = array_merge(
				array( 'response_code' => $response_code ),
				array( 'args' => $args ),
				$last_query_info,
				array( 'response' => $response )
			);

			$last_query_info = $temp;
		}
		?>
		<div class="jetpack-search-debug-bar">
			<h2><?php esc_html_e( 'Last query information:', 'jetpack' ); ?></h2>
			<?php if ( empty( $last_query_info ) ) : ?>
					<?php echo esc_html_x( 'None', 'Text displayed when there is no information', 'jetpack' ); ?>
			<?php
				else :
					foreach ( $last_query_info as $key => $info ) :
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
					?>
						<h3><?php echo esc_html( $key ); ?></h3>
					<?php
					if ( 'response' !== $key && 'args' !== $key ) :
					?>
						<pre><?php print_r( esc_html( $info ) ); ?></pre>
					<?php
					else :
						$this->render_json_toggle( $info );
					endif;
					?>
					<?php
					endforeach;
			endif;
			?>
		</div><!-- Closes .jetpack-search-debug-bar -->
		<?php
	}

	/**
	 * Responsible for rendering the HTML necessary for the JSON toggle
	 *
	 * @param array $value The resonse from the API as an array.
	 * @return void
	 */
	public function render_json_toggle( $value ) {
	?>
		<div class="json-toggle-wrap">
			<pre class="json"><?php echo wp_json_encode( $value ); ?></pre>
			<span class="pretty toggle"><?php echo esc_html_x( 'Pretty', 'label for formatting JSON', 'jetpack' ); ?></span>
			<span class="ugly toggle"><?php echo esc_html_x( 'Minify', 'label for formatting JSON', 'jetpack' ); ?></span>
		</div>
	<?php
	}
}


1			<?php
2
3			/**
4			* Singleton class instantiated by Jetpack_Searc_Debug_Bar::instance() that handles
5			* rendering the Jetpack Search debug bar menu item and panel.
6			*/
7			class Jetpack_Search_Debug_Bar extends Debug_Bar_Panel {
8			/**
9			* Holds singleton instance
10			*
11			* @var Jetpack_Search_Debug_Bar
12			*/
13			protected static $instance = null;
14
15			/**
16			* Holds an instance of Jetpack_Search
17			*
18			* @var Jetpack_Search
19			*/
20			private $jetpack_search;
21
22			/**
23			* The title to use in the debug bar navigation
24			*
25			* @var string
26			*/
27			public $title;
28
29			/**
30			* Constructor
31			*/
32			public function __construct() {
33			$this->title( esc_html__( 'Jetpack Search', 'jetpack' ) );
34			$this->jetpack_search = Jetpack_Search::instance();
35			add_action( 'wp_enqueue_scripts', array( $this, 'enqueue_scripts' ) );
36			}
37
38			/**
39			* Returns the singleton instance of Jetpack_Search_Debug_Bar
40			*
41			* @return Jetpack_Search_Debug_Bar
42			*/
43			public static function instance() {
44			if ( is_null( self::$instance ) ) {
45			self::$instance = new Jetpack_Search_Debug_Bar();
46			}
47			return self::$instance;
48			}
49
50			/**
51			* Enqueues styles for our panel in the debug bar
52			*
53			* @return void
54			*/
55			public function enqueue_scripts() {
56			wp_enqueue_style(
57			'jetpack-search-debug-bar',
58			plugins_url( '3rd-party/debug-bar/debug-bar.css', JETPACK__PLUGIN_FILE )
59			);
60			wp_enqueue_script(
61			'jetpack-search-debug-bar',
62			plugins_url( '3rd-party/debug-bar/debug-bar.js', JETPACK__PLUGIN_FILE ),
63			array( 'jquery' )
64			);
65			}
66
67			/**
68			* Should the Jetpack Search Debug Bar show?
69			*
70			* Since we've previously done a check for the search module being activated, let's just return true.
71			* Later on, we can update this to only show when `is_search()` is true.
72			*
73			* @return boolean
74			*/
75			public function is_visible() {
76			return true;
77			}
78
79			/**
80			* Renders the panel content
81			*
82			* @return void
83			*/
84			public function render() {
85			$last_query_info = $this->jetpack_search->get_last_query_info();
86
87			// If not empty, let's reshuffle the order of some things.
88			if ( ! empty( $last_query_info ) ) {
89			$args = $last_query_info['args'];
90			$response = $last_query_info['response'];
91			$response_code = $last_query_info['response_code'];
92
93			unset( $last_query_info['args'] );
94			unset( $last_query_info['response'] );
95			unset( $last_query_info['response_code'] );
96
97			if ( is_null( $last_query_info['es_time'] ) ) {
98			$last_query_info['es_time'] = esc_html_x(
99			'cache hit',
100			'displayed in search results when results are cached',
101			'jetpack'
102			);
103			}
104
105			$temp = array_merge(
106			array( 'response_code' => $response_code ),
107			array( 'args' => $args ),
108			$last_query_info,
109			array( 'response' => $response )
110			);
111
112			$last_query_info = $temp;
113			}
114			?>
115			<div class="jetpack-search-debug-bar">
116			<h2><?php esc_html_e( 'Last query information:', 'jetpack' ); ?></h2>
117			<?php if ( empty( $last_query_info ) ) : ?>
118			<?php echo esc_html_x( 'None', 'Text displayed when there is no information', 'jetpack' ); ?>
119			<?php
120			else :
121			foreach ( $last_query_info as $key => $info ) :
			0 ignored issues – show Bug introduced 2018-01-25 15:56 UTC by Report Bug Copy Issue Report The expression `$last_query_info` of type `boolean\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
122			?>
123			<h3><?php echo esc_html( $key ); ?></h3>
124			<?php
125			if ( 'response' !== $key && 'args' !== $key ) :
126			?>
127			<pre><?php print_r( esc_html( $info ) ); ?></pre>
128			<?php
129			else :
130			$this->render_json_toggle( $info );
131			endif;
132			?>
133			<?php
134			endforeach;
135			endif;
136			?>
137			</div><!-- Closes .jetpack-search-debug-bar -->
138			<?php
139			}
140
141			/**
142			* Responsible for rendering the HTML necessary for the JSON toggle
143			*
144			* @param array $value The resonse from the API as an array.
145			* @return void
146			*/
147			public function render_json_toggle( $value ) {
148			?>
149			<div class="json-toggle-wrap">
150			<pre class="json"><?php echo wp_json_encode( $value ); ?></pre>
151			<span class="pretty toggle"><?php echo esc_html_x( 'Pretty', 'label for formatting JSON', 'jetpack' ); ?></span>
152			<span class="ugly toggle"><?php echo esc_html_x( 'Minify', 'label for formatting JSON', 'jetpack' ); ?></span>
153			</div>
154			<?php
155			}
156			}
157

Automattic / jetpack

Push — update/react-create-class ( 7f3c72...120f37 )

Jetpack_Search_Debug_Bar::render() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like