WordAds_Sidebar_Widget - Code Metrics - Inspection of "Run eslint --fix on the changed files" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — update/react-create-class ( 7f3c72...120f37 )

unknown

created 2018-01-30 20:09 UTC

WordAds_Sidebar_Widget A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	102
Duplicated Lines	10.78 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes

Metric	Value
dl	11
loc	102
rs	10
c	0
b	0
f	0
wmc	16
lcom	2
cbo	1

4 Methods

Rating	Name	Duplication	Size	Complexity
B	form()	0	27	4
A	update()	0	11	2
A	__construct()	11	11	1
D	widget()	0	44	9

How to fix Duplicated Code

<?php

/**
 * Widget for inserting an ad into your sidebar
 *
 * @since 4.5.0
 */
class WordAds_Sidebar_Widget extends WP_Widget {

	private static $allowed_tags = array( 'mrec', 'wideskyscraper' );
	private static $num_widgets = 0;

	function __construct() {
		parent::__construct(
			'wordads_sidebar_widget',
			/** This filter is documented in modules/widgets/facebook-likebox.php */
			apply_filters( 'jetpack_widget_name', 'Ads' ),
			array(
				'description' => __( 'Insert an ad unit wherever you can place a widget.', 'jetpack' ),
				'customize_selective_refresh' => true
			)
		);
	}

	public function widget( $args, $instance ) {
		global $wordads;
		if ( $wordads->should_bail() ) {
			return false;
		}

		if ( ! isset( $instance['unit'] ) ) {
			$instance['unit'] = 'mrec';
		}

		self::$num_widgets++;
		$about = __( 'Advertisements', 'jetpack' );
		$width = WordAds::$ad_tag_ids[$instance['unit']]['width'];
		$height = WordAds::$ad_tag_ids[$instance['unit']]['height'];
		$unit_id = 1 == self::$num_widgets ? 3 : self::$num_widgets + 3; // 2nd belowpost is '4'
		$section_id = 0 === $wordads->params->blog_id ?
			WORDADS_API_TEST_ID :
			$wordads->params->blog_id . $unit_id;

		$snippet = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		if ( $wordads->option( 'wordads_house', true ) ) {
			$unit = 'mrec';
			if ( 'leaderboard' == $instance['unit'] && ! $this->params->mobile_device ) {
				$unit = 'leaderboard';
			} else if ( 'wideskyscraper' == $instance['unit'] ) {
				$unit = 'widesky';
			}

			$snippet = $wordads->get_house_ad( $unit );
		} else {
			$snippet = $wordads->get_ad_snippet( $section_id, $height, $width );
		}

		echo <<< HTML
		<div class="wpcnt">
			<div class="wpa">
				<span class="wpa-about">$about</span>
				<div class="u {$instance['unit']}">
					$snippet
				</div>
			</div>
		</div>
HTML;
	}

	public function form( $instance ) {
		// ad unit type
		if ( isset( $instance['unit'] ) ) {
			$unit = $instance['unit'];
		} else {
			$unit = 'mrec';
		}
		?>
		<p>
			<label for="<?php echo esc_attr( $this->get_field_id( 'unit' ) ); ?>"><?php _e( 'Tag Dimensions:', 'jetpack' ); ?></label>
			<select class="widefat" id="<?php echo esc_attr( $this->get_field_id( 'unit' ) ); ?>" name="<?php echo esc_attr( $this->get_field_name( 'unit' ) ); ?>">
		<?php
		foreach ( WordAds::$ad_tag_ids as $ad_unit => $properties ) {
				if ( ! in_array( $ad_unit, self::$allowed_tags ) ) {
					continue;
				}

				$splits = explode( '_', $properties['tag'] );
				$unit_pretty = "{$splits[0]} {$splits[1]}";
				$selected = selected( $ad_unit, $unit, false );
				echo "<option value='", esc_attr( $ad_unit ) ,"' ", $selected, '>', esc_html( $unit_pretty ) , '</option>';
			}
		?>
			</select>
		</p>
		<?php
	}

	public function update( $new_instance, $old_instance ) {
		$instance = $old_instance;

		if ( in_array( $new_instance['unit'], self::$allowed_tags ) ) {
			$instance['unit'] = $new_instance['unit'];
		} else {
			$instance['unit'] = 'mrec';
		}

		return $instance;
	}
}

add_action(
	'widgets_init',
	create_function(
// Instead of
$function = create_function('$a, $b', 'return $a + $b');

// Better use
$function = function($a, $b) { return $a + $b; }
		'',
		'return register_widget( "WordAds_Sidebar_Widget" );'
	)
);


1		<?php
2
3		/**
4		* Widget for inserting an ad into your sidebar
5		*
6		* @since 4.5.0
7		*/
8		class WordAds_Sidebar_Widget extends WP_Widget {
9
10		private static $allowed_tags = array( 'mrec', 'wideskyscraper' );
11		private static $num_widgets = 0;
12
13	View Code Duplication	function __construct() {
14		parent::__construct(
15		'wordads_sidebar_widget',
16		/** This filter is documented in modules/widgets/facebook-likebox.php */
17		apply_filters( 'jetpack_widget_name', 'Ads' ),
18		array(
19		'description' => __( 'Insert an ad unit wherever you can place a widget.', 'jetpack' ),
20		'customize_selective_refresh' => true
21		)
22		);
23		}
24
25		public function widget( $args, $instance ) {
26		global $wordads;
27		if ( $wordads->should_bail() ) {
28		return false;
29		}
30
31		if ( ! isset( $instance['unit'] ) ) {
32		$instance['unit'] = 'mrec';
33		}
34
35		self::$num_widgets++;
36		$about = __( 'Advertisements', 'jetpack' );
37		$width = WordAds::$ad_tag_ids[$instance['unit']]['width'];
38		$height = WordAds::$ad_tag_ids[$instance['unit']]['height'];
39		$unit_id = 1 == self::$num_widgets ? 3 : self::$num_widgets + 3; // 2nd belowpost is '4'
40		$section_id = 0 === $wordads->params->blog_id ?
41		WORDADS_API_TEST_ID :
42		$wordads->params->blog_id . $unit_id;
43
44		$snippet = '';
		0 ignored issues – show Unused Code introduced 2018-01-22 21:14 UTC by Report Bug Copy Issue Report `$snippet` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
45		if ( $wordads->option( 'wordads_house', true ) ) {
46		$unit = 'mrec';
47		if ( 'leaderboard' == $instance['unit'] && ! $this->params->mobile_device ) {
48		$unit = 'leaderboard';
49		} else if ( 'wideskyscraper' == $instance['unit'] ) {
50		$unit = 'widesky';
51		}
52
53		$snippet = $wordads->get_house_ad( $unit );
54		} else {
55		$snippet = $wordads->get_ad_snippet( $section_id, $height, $width );
56		}
57
58		echo <<< HTML
59		<div class="wpcnt">
60		<div class="wpa">
61		<span class="wpa-about">$about</span>
62		<div class="u {$instance['unit']}">
63		$snippet
64		</div>
65		</div>
66		</div>
67		HTML;
68		}
69
70		public function form( $instance ) {
71		// ad unit type
72		if ( isset( $instance['unit'] ) ) {
73		$unit = $instance['unit'];
74		} else {
75		$unit = 'mrec';
76		}
77		?>
78		<p>
79		<label for="<?php echo esc_attr( $this->get_field_id( 'unit' ) ); ?>"><?php _e( 'Tag Dimensions:', 'jetpack' ); ?></label>
80		<select class="widefat" id="<?php echo esc_attr( $this->get_field_id( 'unit' ) ); ?>" name="<?php echo esc_attr( $this->get_field_name( 'unit' ) ); ?>">
81		<?php
82		foreach ( WordAds::$ad_tag_ids as $ad_unit => $properties ) {
83		if ( ! in_array( $ad_unit, self::$allowed_tags ) ) {
84		continue;
85		}
86
87		$splits = explode( '_', $properties['tag'] );
88		$unit_pretty = "{$splits[0]} {$splits[1]}";
89		$selected = selected( $ad_unit, $unit, false );
90		echo "<option value='", esc_attr( $ad_unit ) ,"' ", $selected, '>', esc_html( $unit_pretty ) , '</option>';
91		}
92		?>
93		</select>
94		</p>
95		<?php
96		}
97
98		public function update( $new_instance, $old_instance ) {
99		$instance = $old_instance;
100
101		if ( in_array( $new_instance['unit'], self::$allowed_tags ) ) {
102		$instance['unit'] = $new_instance['unit'];
103		} else {
104		$instance['unit'] = 'mrec';
105		}
106
107		return $instance;
108		}
109		}
110
111		add_action(
112		'widgets_init',
113		create_function(
		0 ignored issues – show Security Best Practice introduced 2016-10-12 21:02 UTC by Report Bug Copy Issue Report The use of `create_function` is highly discouraged, better use a closure. `create_function` can pose a great security vulnerability as it is similar to `eval`, and could be used for arbitrary code execution. We highly recommend to use a closure instead. // Instead of $function = create_function('$a, $b', 'return $a + $b'); // Better use $function = function($a, $b) { return $a + $b; } Loading history...
114		'',
115		'return register_widget( "WordAds_Sidebar_Widget" );'
116		)
117		);
118

Automattic / jetpack

Push — update/react-create-class ( 7f3c72...120f37 )

WordAds_Sidebar_Widget A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like