Version_Selector::is_package_version_dev() - Code Metrics - Inspection of "[not verified] Autoloader: added initialization ch..." - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — fix/autoloader-inclusion ( 2b1591...08633b )

unknown

created 2021-01-20 01:08 UTC

Version_Selector::is_package_version_dev() A

↳ Parent: Version_Selector

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	7
Ratio	100 %

Importance

Changes

Metric	Value
cc	3
nc	2
nop	1
dl	7
loc	7
rs	10
c	0
b	0
f	0

<?php
/* HEADER */ // phpcs:ignore

/**
 * Used to select package versions.
 */
class Version_Selector {

	/**
	 * Checks whether the selected package version should be updated. Composer development
	 * package versions ('9999999-dev' or versions that start with 'dev-') are favored
	 * when the JETPACK_AUTOLOAD_DEV constant is set to true.
	 *
	 * @param String $selected_version The currently selected package version.
	 * @param String $compare_version The package version that is being evaluated to
	 *                                determine if the version needs to be updated.
	 *
	 * @return bool Returns true if the selected package version should be updated,
	 *                 else false.
	 */
	public function is_version_update_required( $selected_version, $compare_version ) {
		$use_dev_versions = defined( 'JETPACK_AUTOLOAD_DEV' ) && JETPACK_AUTOLOAD_DEV;

		if ( is_null( $selected_version ) ) {
			return true;
		}

		if ( $use_dev_versions && $this->is_dev_version( $selected_version ) ) {
			return false;
		}

		if ( $this->is_dev_version( $compare_version ) ) {
			if ( $use_dev_versions ) {
				return true;
			} else {
				return false;
			}
		}

		if ( version_compare( $selected_version, $compare_version, '<' ) ) {
			return true;
		}

		return false;
	}

	/**
	 * Checks whether the given package version is a development version.
	 *
	 * @param String $version The package version.
	 *
	 * @return bool True if the version is a dev version, else false.
	 */
	public function is_dev_version( $version ) {
		if ( 'dev-' === substr( $version, 0, 4 ) || '9999999-dev' === $version ) {
			return true;
		}

		return false;
	}
}


1		<?php
2		/* HEADER */ // phpcs:ignore
3
4		/**
5		* Used to select package versions.
6		*/
7		class Version_Selector {
8
9		/**
10		* Checks whether the selected package version should be updated. Composer development
11		* package versions ('9999999-dev' or versions that start with 'dev-') are favored
12		* when the JETPACK_AUTOLOAD_DEV constant is set to true.
13		*
14		* @param String $selected_version The currently selected package version.
15		* @param String $compare_version The package version that is being evaluated to
16		* determine if the version needs to be updated.
17		*
18		* @return bool Returns true if the selected package version should be updated,
19		* else false.
20		*/
21		public function is_version_update_required( $selected_version, $compare_version ) {
22		$use_dev_versions = defined( 'JETPACK_AUTOLOAD_DEV' ) && JETPACK_AUTOLOAD_DEV;
23
24		if ( is_null( $selected_version ) ) {
25		return true;
26		}
27
28		if ( $use_dev_versions && $this->is_dev_version( $selected_version ) ) {
29		return false;
30		}
31
32		if ( $this->is_dev_version( $compare_version ) ) {
33		if ( $use_dev_versions ) {
34		return true;
35		} else {
36		return false;
37		}
38		}
39
40		if ( version_compare( $selected_version, $compare_version, '<' ) ) {
41		return true;
42		}
43
44		return false;
45		}
46
47		/**
48		* Checks whether the given package version is a development version.
49		*
50		* @param String $version The package version.
51		*
52		* @return bool True if the version is a dev version, else false.
53		*/
54	View Code Duplication	public function is_dev_version( $version ) {
55		if ( 'dev-' === substr( $version, 0, 4 ) \|\| '9999999-dev' === $version ) {
56		return true;
57		}
58
59		return false;
60		}
61		}
62

Automattic / jetpack

Push — fix/autoloader-inclusion ( 2b1591...08633b )

Version_Selector::is_package_version_dev() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like