Completed
Push — renovate/mapbox-gl-0.x ( e1b5df...b1dfce )
by
unknown
61:50 queued 55:49
created

Class_Method_Missing   A

Complexity

Total Complexity 9

Size/Duplication

Total Lines 35
Duplicated Lines 28.57 %

Coupling/Cohesion

Components 1
Dependencies 3

Importance

Changes 0
Metric Value
dl 10
loc 35
rs 10
c 0
b 0
f 0
wmc 9
lcom 1
cbo 3

5 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 3 1
A to_csv_array() 0 8 1
A type() 0 3 1
A display_name() 0 3 1
A find_invocation_warnings() 10 10 5

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Automattic\Jetpack\Analyzer\Differences;
4
5
use Automattic\Jetpack\Analyzer\PersistentList\Item as PersistentListItem;
6
use Automattic\Jetpack\Analyzer\Invocations\Static_Call;
7
use Automattic\Jetpack\Analyzer\Warnings\Warning; // TODO - subclasses?
8
9
class Class_Method_Missing extends PersistentListItem implements Invocation_Warner {
10
	public $declaration;
11
12
	function __construct( $declaration ) {
13
		$this->declaration = $declaration;
14
	}
15
16
	function to_csv_array() {
17
		return array(
18
			$this->type(),
19
			$this->declaration->path,
20
			$this->declaration->line,
21
			$this->declaration->display_name(),
22
		);
23
	}
24
25
	public function type() {
26
		return 'method_missing';
27
	}
28
29
	public function display_name() {
30
		return $this->declaration->display_name();
31
	}
32
33 View Code Duplication
	public function find_invocation_warnings( $invocation, $warnings ) {
34
		if ( $invocation instanceof Static_Call ) {
35
			// check if it's instantiating this missing class
36
			if ( $invocation->class_name === $this->declaration->class_name
37
				&& $invocation->method_name === $this->declaration->method_name
38
				&& $this->declaration->static ) {
39
				$warnings->add( new Warning( $this->type(), $invocation->path, $invocation->line, 'Class static method ' . $this->declaration->display_name() . ' is missing', $this->declaration ) );
40
			}
41
		}
42
	}
43
}
44