Jetpack_Twitter_Cards - Code Metrics - Inspection of "Added all roles to initial state rather than only..." - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — add/stats-roles ( 7a9245...a2fa7c )

unknown

created 2016-07-13 16:39 UTC

Jetpack_Twitter_Cards C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	205
Duplicated Lines	1.46 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	65
lcom	1
cbo	3
dl	3
loc	205
rs	5.7894
c	0
b	0
f	0

11 Methods

Rating	Name	Duplication	Size	Complexity
F	twitter_cards_tags()	3	98	35
A	sanitize_twitter_user()	0	3	1
A	prioritize_creator_over_default_site()	0	6	3
C	twitter_cards_define_type_based_on_image_count()	0	34	14
A	twitter_cards_output()	0	3	2
A	settings_init()	0	13	1
A	sharing_global_options()	0	3	1
A	site_tag()	0	11	4
A	settings_field()	0	7	1
A	settings_validate()	0	5	2
A	init()	0	9	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Jetpack_Twitter_Cards often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Jetpack_Twitter_Cards, and based on these observations, apply Extract Interface, too.

<?php

/* Twitter Cards
 *
 * Hooks onto the Open Graph protocol and extends it by adding only the tags
 * we need for twitter cards.
 *
 * @see /wp-content/blog-plugins/open-graph.php
 * @see https://dev.twitter.com/cards/overview
 */
class Jetpack_Twitter_Cards {

	static function twitter_cards_tags( $og_tags ) {
		global $post;

		if ( post_password_required() ) {
			return $og_tags;
		}

		/** This action is documented in class.jetpack.php */
		if ( apply_filters( 'jetpack_disable_twitter_cards', false ) ) {
			return $og_tags;
		}

		/*
		 * These tags apply to any page (home, archives, etc)
		 */

		$site_tag = self::site_tag();
		/** This action is documented in modules/sharedaddy/sharing-sources.php */
		$site_tag = apply_filters( 'jetpack_sharing_twitter_via', $site_tag, ( is_singular() ? $post->ID : null ) );
		/** This action is documented in modules/sharedaddy/sharing-sources.php */
		$site_tag = apply_filters( 'jetpack_twitter_cards_site_tag', $site_tag, $og_tags );
		if ( ! empty( $site_tag ) ) {
			$og_tags['twitter:site'] = self::sanitize_twitter_user( $site_tag );
		}

		if ( ! is_singular() || ! empty( $og_tags['twitter:card'] ) ) {
			return $og_tags;
		}

		/*
		 * The following tags only apply to single pages.
		 */

		$card_type = 'summary';

		// Try to give priority to featured images
		if ( class_exists('Jetpack_PostImages') ) {
			$featured = Jetpack_PostImages::from_thumbnail( $post->ID, 240, 240 );
			if ( !empty( $featured ) && count( $featured ) > 0 ) {
				if ( (int) $featured[0]['src_width'] >= 280 && (int) $featured[0]['src_height'] >= 150 ) {
					$card_type = 'summary_large_image';
					$og_tags['twitter:image'] = esc_url( add_query_arg( 'w', 640, $featured[0]['src'] ) );
				} else {
					$og_tags['twitter:image'] = esc_url( add_query_arg( 'w', 240, $featured[0]['src'] ) );
				}
			}
		}

		// Only proceed with media analysis if a featured image has not superseded it already.
		if ( empty( $og_tags['twitter:image'] ) && empty( $og_tags['twitter:image:src'] ) ) {
			if ( ! class_exists( 'Jetpack_Media_Summary' ) && defined('IS_WPCOM') && IS_WPCOM ) {
				include( WP_CONTENT_DIR . '/lib/class.wpcom-media-summary.php' );
			}

			if ( ! class_exists( 'Jetpack_Media_Summary' ) ) {
				jetpack_require_lib( 'class.media-summary' );
			}

			// Test again, class should already be auto-loaded in Jetpack.
			// If not, skip extra media analysis and stick with a summary card
			if ( class_exists( 'Jetpack_Media_Summary' ) ) {
				$extract = Jetpack_Media_Summary::get( $post->ID );

				if ( 'gallery' == $extract['type'] ) {
					list( $og_tags, $card_type ) = self::twitter_cards_define_type_based_on_image_count( $og_tags, $extract );
				} elseif ( 'video' == $extract['type'] ) {
					// Leave as summary, but with large pict of poster frame (we know those comply to Twitter's size requirements)
					$card_type = 'summary_large_image';
					$og_tags['twitter:image'] = esc_url( add_query_arg( 'w', 640, $extract['image'] ) );
				} else {
					list( $og_tags, $card_type ) = self::twitter_cards_define_type_based_on_image_count( $og_tags, $extract );
				}
			}
		}

		$og_tags['twitter:card'] = $card_type;

		// If we have information on the author/creator, then include that as well
		if ( ! empty( $post ) && ! empty( $post->post_author ) ) {
			/** This action is documented in modules/sharedaddy/sharing-sources.php */
			$handle = apply_filters( 'jetpack_sharing_twitter_via', '', $post->ID );
			if ( ! empty( $handle ) && 'wordpressdotcom' != $handle && 'jetpack' != $handle ) {
				$og_tags['twitter:creator'] = self::sanitize_twitter_user( $handle );
			}
		}

		// Make sure we have a description for Twitter, their validator isn't happy without some content (single space not valid).
		if ( ! isset( $og_tags['og:description'] ) || '' == trim( $og_tags['og:description'] ) || __('Visit the post for more.', 'jetpack') == $og_tags['og:description'] ) { // empty( trim( $og_tags['og:description'] ) ) isn't valid php
			$has_creator = ( ! empty($og_tags['twitter:creator']) && '@wordpressdotcom' != $og_tags['twitter:creator'] ) ? true : false;
			if ( ! empty( $extract ) && 'video' == $extract['type'] ) { // use $extract['type'] since $card_type is 'summary' for video posts
				$og_tags['twitter:description'] = ( $has_creator ) ? sprintf( __('Video post by %s.', 'jetpack'), $og_tags['twitter:creator'] ) : __('Video post.', 'jetpack');
			} else {
				$og_tags['twitter:description'] = ( $has_creator ) ? sprintf( __('Post by %s.', 'jetpack'), $og_tags['twitter:creator'] ) : __('Visit the post for more.', 'jetpack');
			}
		}

		return $og_tags;
	}

	static function sanitize_twitter_user( $str ) {
		return '@' . preg_replace( '/^@/', '', $str );
	}

	static function prioritize_creator_over_default_site( $site_tag, $og_tags = array() ) {
		if ( ! empty( $og_tags['twitter:creator'] ) && in_array( $site_tag, array( '@wordpressdotcom', '@jetpack' ) ) ) {
			$site_tag = $og_tags['twitter:creator'];

		}
		return $site_tag;
	}

	static function twitter_cards_define_type_based_on_image_count( $og_tags, $extract ) {
		$card_type = 'summary';
		$img_count = $extract['count']['image'];

		if ( empty( $img_count ) ) {

			// No images, use Blavatar as a thumbnail for the summary type.
			if ( function_exists('blavatar_domain') ) {
				$blavatar_domain = blavatar_domain( site_url() );
				if ( blavatar_exists( $blavatar_domain ) ) {
					$og_tags['twitter:image'] = blavatar_url( $blavatar_domain, 'img', 240 );
				}
			}

			// Second fall back, Site Logo
			if ( empty( $og_tags['twitter:image'] ) && ( function_exists( 'jetpack_has_site_logo' ) && jetpack_has_site_logo() ) ) {
				$og_tags['twitter:image'] = jetpack_get_site_logo( 'url' );
			}

			// Third fall back, Site Icon
			if ( empty( $og_tags['twitter:image'] ) && ( function_exists( 'jetpack_has_site_icon' ) && jetpack_has_site_icon() ) ) {
				$og_tags['twitter:image'] = jetpack_site_icon_url( null, '240' );
			}

			// Not falling back on Gravatar, because there's no way to know if we end up with an auto-generated one.

		} elseif ( $img_count && ( 'image' == $extract['type'] || 'gallery' == $extract['type'] ) ) {
			// Test for $extract['type'] to limit to image and gallery, so we don't send a potential fallback image like a Gravatar as a photo post.
			$card_type = 'summary_large_image';
			$og_tags['twitter:image'] = esc_url( add_query_arg( 'w', 1400, ( empty( $extract['images'] ) ) ? $extract['image'] : $extract['images'][0]['url'] ) );
		}

		return array( $og_tags, $card_type );
	}

	static function twitter_cards_output( $og_tag ) {
		return ( false !== strpos( $og_tag, 'twitter:' ) ) ? preg_replace( '/property="([^"]+)"/', 'name="\1"', $og_tag ) : $og_tag;
	}

	static function settings_init() {
		add_settings_section( 'jetpack-twitter-cards-settings', 'Twitter Cards', '__return_false', 'sharing' );
		add_settings_field(
			'jetpack-twitter-cards-site-tag',
			__( 'Twitter Site Tag', 'jetpack' ),
			array( __CLASS__, 'settings_field' ),
			'sharing',
			'jetpack-twitter-cards-settings',
			array(
				'label_for' => 'jetpack-twitter-cards-site-tag',
			)
		);
	}

	static function sharing_global_options() {
		do_settings_fields( 'sharing', 'jetpack-twitter-cards-settings' );
	}

	static function site_tag() {
		$site_tag = Jetpack_Options::get_option_and_ensure_autoload( 'jetpack-twitter-cards-site-tag', '' );
		if ( empty( $site_tag ) ) {
			if ( defined( 'IS_WPCOM' ) && IS_WPCOM ) {
				return 'wordpressdotcom';
			} else {
				return;
			}
		}
		return $site_tag;
	}

	static function settings_field() {
		wp_nonce_field( 'jetpack-twitter-cards-settings', 'jetpack_twitter_cards_nonce', false );
		?>
		<input type="text" id="jetpack-twitter-cards-site-tag" class="regular-text" name="jetpack-twitter-cards-site-tag" value="<?php echo esc_attr( get_option( 'jetpack-twitter-cards-site-tag' ) ); ?>" />
		<p class="description" style="width: auto;"><?php esc_html_e( 'The Twitter username of the owner of this site\'s domain.', 'jetpack' ); ?></p>
		<?php
	}

	static function settings_validate() {
		if ( wp_verify_nonce( $_POST['jetpack_twitter_cards_nonce'], 'jetpack-twitter-cards-settings' ) ) {
			update_option( 'jetpack-twitter-cards-site-tag', trim( ltrim( strip_tags( $_POST['jetpack-twitter-cards-site-tag'] ), '@' ) ) );
		}
	}

	static function init() {
		add_filter( 'jetpack_open_graph_tags',        array( __CLASS__, 'twitter_cards_tags' ) );
		add_filter( 'jetpack_open_graph_output',      array( __CLASS__, 'twitter_cards_output' ) );
		add_filter( 'jetpack_twitter_cards_site_tag', array( __CLASS__, 'site_tag' ), -99 );
		add_filter( 'jetpack_twitter_cards_site_tag', array( __CLASS__, 'prioritize_creator_over_default_site' ), 99, 2 );
		add_action( 'admin_init',                     array( __CLASS__, 'settings_init' ) );
		add_action( 'sharing_global_options',         array( __CLASS__, 'sharing_global_options' ) );
		add_action( 'sharing_admin_update',           array( __CLASS__, 'settings_validate' ) );
	}
}

Jetpack_Twitter_Cards::init();


1		<?php
2
3		/* Twitter Cards
4		*
5		* Hooks onto the Open Graph protocol and extends it by adding only the tags
6		* we need for twitter cards.
7		*
8		* @see /wp-content/blog-plugins/open-graph.php
9		* @see https://dev.twitter.com/cards/overview
10		*/
11		class Jetpack_Twitter_Cards {
12
13		static function twitter_cards_tags( $og_tags ) {
14		global $post;
15
16		if ( post_password_required() ) {
17		return $og_tags;
18		}
19
20		/** This action is documented in class.jetpack.php */
21		if ( apply_filters( 'jetpack_disable_twitter_cards', false ) ) {
22		return $og_tags;
23		}
24
25		/*
26		* These tags apply to any page (home, archives, etc)
27		*/
28
29		$site_tag = self::site_tag();
30		/** This action is documented in modules/sharedaddy/sharing-sources.php */
31		$site_tag = apply_filters( 'jetpack_sharing_twitter_via', $site_tag, ( is_singular() ? $post->ID : null ) );
32		/** This action is documented in modules/sharedaddy/sharing-sources.php */
33		$site_tag = apply_filters( 'jetpack_twitter_cards_site_tag', $site_tag, $og_tags );
34		if ( ! empty( $site_tag ) ) {
35		$og_tags['twitter:site'] = self::sanitize_twitter_user( $site_tag );
36		}
37
38		if ( ! is_singular() \|\| ! empty( $og_tags['twitter:card'] ) ) {
39		return $og_tags;
40		}
41
42		/*
43		* The following tags only apply to single pages.
44		*/
45
46		$card_type = 'summary';
47
48		// Try to give priority to featured images
49		if ( class_exists('Jetpack_PostImages') ) {
50		$featured = Jetpack_PostImages::from_thumbnail( $post->ID, 240, 240 );
51		if ( !empty( $featured ) && count( $featured ) > 0 ) {
52		if ( (int) $featured[0]['src_width'] >= 280 && (int) $featured[0]['src_height'] >= 150 ) {
53		$card_type = 'summary_large_image';
54		$og_tags['twitter:image'] = esc_url( add_query_arg( 'w', 640, $featured[0]['src'] ) );
55		} else {
56		$og_tags['twitter:image'] = esc_url( add_query_arg( 'w', 240, $featured[0]['src'] ) );
57		}
58		}
59		}
60
61		// Only proceed with media analysis if a featured image has not superseded it already.
62		if ( empty( $og_tags['twitter:image'] ) && empty( $og_tags['twitter:image:src'] ) ) {
63	View Code Duplication	if ( ! class_exists( 'Jetpack_Media_Summary' ) && defined('IS_WPCOM') && IS_WPCOM ) {
64		include( WP_CONTENT_DIR . '/lib/class.wpcom-media-summary.php' );
65		}
66
67		if ( ! class_exists( 'Jetpack_Media_Summary' ) ) {
68		jetpack_require_lib( 'class.media-summary' );
69		}
70
71		// Test again, class should already be auto-loaded in Jetpack.
72		// If not, skip extra media analysis and stick with a summary card
73		if ( class_exists( 'Jetpack_Media_Summary' ) ) {
74		$extract = Jetpack_Media_Summary::get( $post->ID );
75
76		if ( 'gallery' == $extract['type'] ) {
77		list( $og_tags, $card_type ) = self::twitter_cards_define_type_based_on_image_count( $og_tags, $extract );
78		} elseif ( 'video' == $extract['type'] ) {
79		// Leave as summary, but with large pict of poster frame (we know those comply to Twitter's size requirements)
80		$card_type = 'summary_large_image';
81		$og_tags['twitter:image'] = esc_url( add_query_arg( 'w', 640, $extract['image'] ) );
82		} else {
83		list( $og_tags, $card_type ) = self::twitter_cards_define_type_based_on_image_count( $og_tags, $extract );
84		}
85		}
86		}
87
88		$og_tags['twitter:card'] = $card_type;
89
90		// If we have information on the author/creator, then include that as well
91		if ( ! empty( $post ) && ! empty( $post->post_author ) ) {
92		/** This action is documented in modules/sharedaddy/sharing-sources.php */
93		$handle = apply_filters( 'jetpack_sharing_twitter_via', '', $post->ID );
94		if ( ! empty( $handle ) && 'wordpressdotcom' != $handle && 'jetpack' != $handle ) {
95		$og_tags['twitter:creator'] = self::sanitize_twitter_user( $handle );
96		}
97		}
98
99		// Make sure we have a description for Twitter, their validator isn't happy without some content (single space not valid).
100		if ( ! isset( $og_tags['og:description'] ) \|\| '' == trim( $og_tags['og:description'] ) \|\| __('Visit the post for more.', 'jetpack') == $og_tags['og:description'] ) { // empty( trim( $og_tags['og:description'] ) ) isn't valid php
101		$has_creator = ( ! empty($og_tags['twitter:creator']) && '@wordpressdotcom' != $og_tags['twitter:creator'] ) ? true : false;
102		if ( ! empty( $extract ) && 'video' == $extract['type'] ) { // use $extract['type'] since $card_type is 'summary' for video posts
103		$og_tags['twitter:description'] = ( $has_creator ) ? sprintf( __('Video post by %s.', 'jetpack'), $og_tags['twitter:creator'] ) : __('Video post.', 'jetpack');
104		} else {
105		$og_tags['twitter:description'] = ( $has_creator ) ? sprintf( __('Post by %s.', 'jetpack'), $og_tags['twitter:creator'] ) : __('Visit the post for more.', 'jetpack');
106		}
107		}
108
109		return $og_tags;
110		}
111
112		static function sanitize_twitter_user( $str ) {
113		return '@' . preg_replace( '/^@/', '', $str );
114		}
115
116		static function prioritize_creator_over_default_site( $site_tag, $og_tags = array() ) {
117		if ( ! empty( $og_tags['twitter:creator'] ) && in_array( $site_tag, array( '@wordpressdotcom', '@jetpack' ) ) ) {
118		$site_tag = $og_tags['twitter:creator'];
		0 ignored issues – show Coding Style introduced 2016-07-12 10:37 UTC by Report Bug Copy Issue Report Consider using a different name than the parameter `$site_tag`. This often makes code more readable. Loading history...
119		}
120		return $site_tag;
121		}
122
123		static function twitter_cards_define_type_based_on_image_count( $og_tags, $extract ) {
124		$card_type = 'summary';
125		$img_count = $extract['count']['image'];
126
127		if ( empty( $img_count ) ) {
128
129		// No images, use Blavatar as a thumbnail for the summary type.
130		if ( function_exists('blavatar_domain') ) {
131		$blavatar_domain = blavatar_domain( site_url() );
132		if ( blavatar_exists( $blavatar_domain ) ) {
133		$og_tags['twitter:image'] = blavatar_url( $blavatar_domain, 'img', 240 );
134		}
135		}
136
137		// Second fall back, Site Logo
138		if ( empty( $og_tags['twitter:image'] ) && ( function_exists( 'jetpack_has_site_logo' ) && jetpack_has_site_logo() ) ) {
139		$og_tags['twitter:image'] = jetpack_get_site_logo( 'url' );
140		}
141
142		// Third fall back, Site Icon
143		if ( empty( $og_tags['twitter:image'] ) && ( function_exists( 'jetpack_has_site_icon' ) && jetpack_has_site_icon() ) ) {
144		$og_tags['twitter:image'] = jetpack_site_icon_url( null, '240' );
145		}
146
147		// Not falling back on Gravatar, because there's no way to know if we end up with an auto-generated one.
148
149		} elseif ( $img_count && ( 'image' == $extract['type'] \|\| 'gallery' == $extract['type'] ) ) {
150		// Test for $extract['type'] to limit to image and gallery, so we don't send a potential fallback image like a Gravatar as a photo post.
151		$card_type = 'summary_large_image';
152		$og_tags['twitter:image'] = esc_url( add_query_arg( 'w', 1400, ( empty( $extract['images'] ) ) ? $extract['image'] : $extract['images'][0]['url'] ) );
153		}
154
155		return array( $og_tags, $card_type );
156		}
157
158		static function twitter_cards_output( $og_tag ) {
159		return ( false !== strpos( $og_tag, 'twitter:' ) ) ? preg_replace( '/property="([^"]+)"/', 'name="\1"', $og_tag ) : $og_tag;
160		}
161
162		static function settings_init() {
163		add_settings_section( 'jetpack-twitter-cards-settings', 'Twitter Cards', '__return_false', 'sharing' );
164		add_settings_field(
165		'jetpack-twitter-cards-site-tag',
166		__( 'Twitter Site Tag', 'jetpack' ),
167		array( __CLASS__, 'settings_field' ),
168		'sharing',
169		'jetpack-twitter-cards-settings',
170		array(
171		'label_for' => 'jetpack-twitter-cards-site-tag',
172		)
173		);
174		}
175
176		static function sharing_global_options() {
177		do_settings_fields( 'sharing', 'jetpack-twitter-cards-settings' );
178		}
179
180		static function site_tag() {
181		$site_tag = Jetpack_Options::get_option_and_ensure_autoload( 'jetpack-twitter-cards-site-tag', '' );
182		if ( empty( $site_tag ) ) {
183		if ( defined( 'IS_WPCOM' ) && IS_WPCOM ) {
184		return 'wordpressdotcom';
185		} else {
186		return;
187		}
188		}
189		return $site_tag;
190		}
191
192		static function settings_field() {
193		wp_nonce_field( 'jetpack-twitter-cards-settings', 'jetpack_twitter_cards_nonce', false );
194		?>
195		<input type="text" id="jetpack-twitter-cards-site-tag" class="regular-text" name="jetpack-twitter-cards-site-tag" value="<?php echo esc_attr( get_option( 'jetpack-twitter-cards-site-tag' ) ); ?>" />
196		<p class="description" style="width: auto;"><?php esc_html_e( 'The Twitter username of the owner of this site\'s domain.', 'jetpack' ); ?></p>
197		<?php
198		}
199
200		static function settings_validate() {
201		if ( wp_verify_nonce( $_POST['jetpack_twitter_cards_nonce'], 'jetpack-twitter-cards-settings' ) ) {
202		update_option( 'jetpack-twitter-cards-site-tag', trim( ltrim( strip_tags( $_POST['jetpack-twitter-cards-site-tag'] ), '@' ) ) );
203		}
204		}
205
206		static function init() {
207		add_filter( 'jetpack_open_graph_tags', array( __CLASS__, 'twitter_cards_tags' ) );
208		add_filter( 'jetpack_open_graph_output', array( __CLASS__, 'twitter_cards_output' ) );
209		add_filter( 'jetpack_twitter_cards_site_tag', array( __CLASS__, 'site_tag' ), -99 );
210		add_filter( 'jetpack_twitter_cards_site_tag', array( __CLASS__, 'prioritize_creator_over_default_site' ), 99, 2 );
211		add_action( 'admin_init', array( __CLASS__, 'settings_init' ) );
212		add_action( 'sharing_global_options', array( __CLASS__, 'sharing_global_options' ) );
213		add_action( 'sharing_admin_update', array( __CLASS__, 'settings_validate' ) );
214		}
215		}
216
217		Jetpack_Twitter_Cards::init();
218

Automattic / jetpack