Jetpack_XMLRPC_Fallback::load_xmlrpc() - Code Metrics - Inspection of "Removing error logs, and making Jetpack's alternat..." - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — try/alt-xmlrpc ( 990d55...e08316 )

unknown

created 2017-05-30 16:49 UTC

Jetpack_XMLRPC_Fallback::load_xmlrpc() A

↳ Parent: Jetpack_XMLRPC_Fallback

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	0
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php 

/**
 * A bridge between WP's built-in REST and Jetpack's XMLRPC server
 */
class Jetpack_XMLRPC_Fallback {
	private $xmlrpc_server;

	function init() {
		register_rest_route( 'jetpack/v1', '/verify_registration', array(
			'methods' => 'POST',
			'callback' => array( $this, 'verify_registration' ),
		) );

		// fallback for anything not yet converted
		register_rest_route( 'jetpack/v1', '/xmlrpc', array(
			'methods' => 'POST',
			'callback' => array( $this, 'xmlrpc_fallback' ),
		) );
	}

	function verify_registration( $request ) {
		$this->load_xmlrpc();
		return $this->xmlrpc_server->verify_registration( array( $request['secret_1'], $request['state'] ) );
	}

	// allow invocation of Jetpack XMLRPC, and a handful of core XMLRPC methods, over REST
	// does NOT allow random XMLRPC requests
	function xmlrpc_fallback( $request ) {
		$this->load_xmlrpc();
		$methods = $this->xmlrpc->xmlrpc_methods();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
	}

	private function load_xmlrpc() {
		if ( ! $this->xmlrpc_server ) {
			require_once JETPACK__PLUGIN_DIR . 'class.jetpack-xmlrpc-server.php';
			$this->xmlrpc_server = new Jetpack_XMLRPC_Server();
		}
	}
}


1			<?php
2
3			/**
4			* A bridge between WP's built-in REST and Jetpack's XMLRPC server
5			*/
6			class Jetpack_XMLRPC_Fallback {
7			private $xmlrpc_server;
8
9			function init() {
10			register_rest_route( 'jetpack/v1', '/verify_registration', array(
11			'methods' => 'POST',
12			'callback' => array( $this, 'verify_registration' ),
13			) );
14
15			// fallback for anything not yet converted
16			register_rest_route( 'jetpack/v1', '/xmlrpc', array(
17			'methods' => 'POST',
18			'callback' => array( $this, 'xmlrpc_fallback' ),
19			) );
20			}
21
22			function verify_registration( $request ) {
23			$this->load_xmlrpc();
24			return $this->xmlrpc_server->verify_registration( array( $request['secret_1'], $request['state'] ) );
25			}
26
27			// allow invocation of Jetpack XMLRPC, and a handful of core XMLRPC methods, over REST
28			// does NOT allow random XMLRPC requests
29			function xmlrpc_fallback( $request ) {
30			$this->load_xmlrpc();
31			$methods = $this->xmlrpc->xmlrpc_methods();
			0 ignored issues – show Bug introduced 2017-04-27 22:30 UTC by Report Bug Copy Issue Report The property `xmlrpc` does not seem to exist. Did you mean `xmlrpc_server`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history... Unused Code introduced 2017-05-30 17:33 UTC by Report Bug Copy Issue Report `$methods` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
32			}
33
34			private function load_xmlrpc() {
35			if ( ! $this->xmlrpc_server ) {
36			require_once JETPACK__PLUGIN_DIR . 'class.jetpack-xmlrpc-server.php';
37			$this->xmlrpc_server = new Jetpack_XMLRPC_Server();
38			}
39			}
40			}
41

Automattic / jetpack

Push — try/alt-xmlrpc ( 990d55...e08316 )

Jetpack_XMLRPC_Fallback::load_xmlrpc() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like