Completed
Pull Request — add/masterbar-module (#6598)
by
unknown
213:49 queued 205:01
created
_inc/lib/class.media.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 	/**
88 88
 	 * Return an array of allowed mime_type items used to upload a media file.
89 89
 	 * 	
90
-	 * @return array mime_type array
90
+	 * @return string[] mime_type array
91 91
 	 */
92 92
 	static function get_allowed_mime_types( $default_mime_types ) {
93 93
 		return array_unique( array_merge( $default_mime_types, array(
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 	 * @param  object $media_item - media post object
255 255
 	 * @param  file $file - file recently added
256 256
 	 * @param  bool $has_original_media - condition is the original media has been already added
257
-	 * @return bool `true` if the item has been added. Otherwise `false`.
257
+	 * @return false|null `true` if the item has been added. Otherwise `false`.
258 258
 	 */
259 259
 	public static function register_revision( $media_item, $file, $has_original_media ) {
260 260
 		if ( is_wp_error( $file ) || ! $has_original_media ) {
@@ -282,6 +282,9 @@  discard block
 block discarded – undo
282 282
 		return $original;
283 283
 	}
284 284
 
285
+	/**
286
+	 * @param string $pathname
287
+	 */
285 288
 	public static function delete_file( $pathname ) {
286 289
 		if ( ! file_exists( $pathname ) || ! is_file( $pathname ) ) {
287 290
 			// let's touch a fake file to try to `really` remove the media file
@@ -297,7 +300,7 @@  discard block
 block discarded – undo
297 300
 	 * 
298 301
 	 * @param  number $media_id - media post ID
299 302
 	 * @param  string $filename - basename of the file ( name-of-file.ext )
300
-	 * @return bool `true` is the file has been removed, `false` if not.
303
+	 * @return boolean|null `true` is the file has been removed, `false` if not.
301 304
 	 */
302 305
 	private static function delete_media_history_file( $media_id, $filename ) {
303 306
 		$attached_path = get_attached_file( $media_id );
Please login to merge, or discard this patch.
json-endpoints/class.wpcom-json-api-edit-media-v1-2-endpoint.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@  discard block
 block discarded – undo
7 7
 	 * Update the media post grabbing the post values from
8 8
 	 * the `attrs` parameter
9 9
 	 *
10
-	 * @param  {Number} $media_id - post media ID
10
+	 * @param  integer $media_id - post media ID
11 11
 	 * @param  {Object} $attrs - `attrs` parameter sent from the client in the request body
12 12
 	 * @return bool|WP_Error `WP_Error` on failure. `true` on success.
13 13
 	 */
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 	/**
65 65
 	 * Get the image from a remote url and then save it locally.
66 66
 	 *
67
-	 * @param  {Number} $media_id - media post ID
67
+	 * @param  integer $media_id - media post ID
68 68
 	 * @param  {String} $url - image URL to save locally
69 69
 	 * @return {Array|WP_Error} An array with information about the new file saved or a WP_Error is something went wrong.
70 70
 	 */
Please login to merge, or discard this patch.
modules/masterbar/masterbar.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -80,6 +80,9 @@  discard block
 block discarded – undo
80 80
 		wp_enqueue_script( 'a8c_wpcom_masterbar_overrides', $this->wpcom_static_url( '/wp-content/mu-plugins/admin-bar/masterbar-overrides/masterbar.js' ) );
81 81
 	}
82 82
 
83
+	/**
84
+	 * @param string $file
85
+	 */
83 86
 	function wpcom_static_url( $file ) {
84 87
 		$i   = hexdec( substr( md5( $file ), - 1 ) ) % 2;
85 88
 		$url = 'https://s' . $i . '.wp.com' . $file;
@@ -255,6 +258,9 @@  discard block
 block discarded – undo
255 258
 		return $primary_anchor . $secondary_anchor;
256 259
 	}
257 260
 
261
+	/**
262
+	 * @param string $class
263
+	 */
258 264
 	public function create_menu_item_anchor( $class, $url, $label, $id ) {
259 265
 		return '<a href="' . $url . '" class="' . $class . '" id="' . $id . '">' . $label . '</a>';
260 266
 	}
Please login to merge, or discard this patch.