Automattic /
jetpack
| Conditions | 22 |
| Paths | 2 |
| Total Lines | 12 |
| Code Lines | 8 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 5 | function jetpack_featured_images_remove_post_thumbnail( $metadata, $object_id, $meta_key, $single ) { |
||
| 6 | $opts = jetpack_featured_images_get_settings(); |
||
| 7 | |||
| 8 | // Returns false if the archive option or singular option is unticked. |
||
| 9 | if ( ( true === $opts['archive'] && ( is_home() || is_archive() || is_search() ) && ! $opts['archive-option'] && ( isset( $meta_key ) && '_thumbnail_id' === $meta_key ) && in_the_loop() ) |
||
| 10 | || ( true === $opts['post'] && is_single() && ! $opts['post-option'] && ( isset( $meta_key ) && '_thumbnail_id' === $meta_key ) && in_the_loop() ) |
||
| 11 | || ( true === $opts['page'] && is_singular() && is_page() && ! $opts['page-option'] && ( isset( $meta_key ) && '_thumbnail_id' === $meta_key ) && in_the_loop() ) ) { |
||
| 12 | return false; |
||
| 13 | } else { |
||
| 14 | return $metadata; |
||
| 15 | } |
||
| 16 | } |
||
| 17 | add_filter( 'get_post_metadata', 'jetpack_featured_images_remove_post_thumbnail', true, 4 ); |
||
| 18 |
Loading history...
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.