Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Jetpack_Sync_Actions often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Jetpack_Sync_Actions, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 10 | class Jetpack_Sync_Actions { |
||
| 11 | static $sender = null; |
||
|
|
|||
| 12 | static $listener = null; |
||
| 13 | const INITIAL_SYNC_MULTISITE_INTERVAL = 10; |
||
| 14 | const DEFAULT_SYNC_CRON_INTERVAL = '1min'; |
||
| 15 | |||
| 16 | static function init() { |
||
| 17 | |||
| 18 | // Add a custom "every minute" cron schedule |
||
| 19 | add_filter( 'cron_schedules', array( __CLASS__, 'minute_cron_schedule' ) ); |
||
| 20 | |||
| 21 | // On jetpack authorization, schedule a full sync |
||
| 22 | add_action( 'jetpack_client_authorized', array( __CLASS__, 'schedule_full_sync' ), 10, 0 ); |
||
| 23 | |||
| 24 | // When importing via cron, do not sync |
||
| 25 | add_action( 'wp_cron_importer_hook', array( __CLASS__, 'set_is_importing_true' ), 1 ); |
||
| 26 | |||
| 27 | // Sync connected user role changes to .com |
||
| 28 | require_once dirname( __FILE__ ) . '/class.jetpack-sync-users.php'; |
||
| 29 | |||
| 30 | // everything below this point should only happen if we're a valid sync site |
||
| 31 | if ( ! self::sync_allowed() ) { |
||
| 32 | return; |
||
| 33 | } |
||
| 34 | |||
| 35 | // publicize filter to prevent publicizing blacklisted post types |
||
| 36 | add_filter( 'publicize_should_publicize_published_post', array( __CLASS__, 'prevent_publicize_blacklisted_posts' ), 10, 2 ); |
||
| 37 | |||
| 38 | // cron hooks |
||
| 39 | add_action( 'jetpack_sync_full', array( __CLASS__, 'do_full_sync' ), 10, 1 ); |
||
| 40 | add_action( 'jetpack_sync_cron', array( __CLASS__, 'do_cron_sync' ) ); |
||
| 41 | add_action( 'jetpack_sync_full_cron', array( __CLASS__, 'do_cron_full_sync' ) ); |
||
| 42 | |||
| 43 | self::init_sync_cron_jobs(); |
||
| 44 | |||
| 45 | /** |
||
| 46 | * Fires on every request before default loading sync listener code. |
||
| 47 | * Return false to not load sync listener code that monitors common |
||
| 48 | * WP actions to be serialized. |
||
| 49 | * |
||
| 50 | * By default this returns true for cron jobs, non-GET-requests, or requests where the |
||
| 51 | * user is logged-in. |
||
| 52 | * |
||
| 53 | * @since 4.2.0 |
||
| 54 | * |
||
| 55 | * @param bool should we load sync listener code for this request |
||
| 56 | */ |
||
| 57 | if ( apply_filters( 'jetpack_sync_listener_should_load', |
||
| 58 | ( |
||
| 59 | ( isset( $_SERVER["REQUEST_METHOD"] ) && 'GET' !== $_SERVER['REQUEST_METHOD'] ) |
||
| 60 | || |
||
| 61 | is_user_logged_in() |
||
| 62 | || |
||
| 63 | defined( 'PHPUNIT_JETPACK_TESTSUITE' ) |
||
| 64 | || |
||
| 65 | defined( 'DOING_CRON' ) && DOING_CRON |
||
| 66 | ) |
||
| 67 | ) ) { |
||
| 68 | self::initialize_listener(); |
||
| 69 | } |
||
| 70 | |||
| 71 | /** |
||
| 72 | * Fires on every request before default loading sync sender code. |
||
| 73 | * Return false to not load sync sender code that serializes pending |
||
| 74 | * data and sends it to WPCOM for processing. |
||
| 75 | * |
||
| 76 | * By default this returns true for cron jobs, POST requests, admin requests, or requests |
||
| 77 | * by users who can manage_options. |
||
| 78 | * |
||
| 79 | * @since 4.2.0 |
||
| 80 | * |
||
| 81 | * @param bool should we load sync sender code for this request |
||
| 82 | */ |
||
| 83 | if ( apply_filters( 'jetpack_sync_sender_should_load', |
||
| 84 | ( |
||
| 85 | ( isset( $_SERVER["REQUEST_METHOD"] ) && 'POST' === $_SERVER['REQUEST_METHOD'] ) |
||
| 86 | || |
||
| 87 | current_user_can( 'manage_options' ) |
||
| 88 | || |
||
| 89 | is_admin() |
||
| 90 | || |
||
| 91 | defined( 'PHPUNIT_JETPACK_TESTSUITE' ) |
||
| 92 | || |
||
| 93 | defined( 'DOING_CRON' ) && DOING_CRON |
||
| 94 | ) |
||
| 95 | ) ) { |
||
| 96 | self::initialize_sender(); |
||
| 97 | add_action( 'shutdown', array( self::$sender, 'do_sync' ) ); |
||
| 98 | } |
||
| 99 | |||
| 100 | } |
||
| 101 | |||
| 102 | static function sync_allowed() { |
||
| 103 | return ( ! Jetpack_Sync_Settings::get_setting( 'disable' ) && Jetpack::is_active() && ! ( Jetpack::is_development_mode() || Jetpack::is_staging_site() ) ) |
||
| 104 | || defined( 'PHPUNIT_JETPACK_TESTSUITE' ); |
||
| 105 | } |
||
| 106 | |||
| 107 | static function prevent_publicize_blacklisted_posts( $should_publicize, $post ) { |
||
| 108 | if ( in_array( $post->post_type, Jetpack_Sync_Settings::get_setting( 'post_types_blacklist' ) ) ) { |
||
| 109 | return false; |
||
| 110 | } |
||
| 111 | |||
| 112 | return $should_publicize; |
||
| 113 | } |
||
| 114 | |||
| 115 | static function set_is_importing_true() { |
||
| 118 | |||
| 119 | static function send_data( $data, $codec_name, $sent_timestamp, $queue_id ) { |
||
| 120 | Jetpack::load_xml_rpc_client(); |
||
| 121 | |||
| 122 | $query_args = array( |
||
| 123 | 'sync' => '1', // add an extra parameter to the URL so we can tell it's a sync action |
||
| 124 | 'codec' => $codec_name, // send the name of the codec used to encode the data |
||
| 125 | 'timestamp' => $sent_timestamp, // send current server time so we can compensate for clock differences |
||
| 126 | 'queue' => $queue_id, // sync or full_sync |
||
| 127 | ); |
||
| 128 | |||
| 129 | if ( Jetpack::sync_idc_optin() ) { |
||
| 130 | $query_args['home'] = get_home_url(); // Send home url option to check for Identity Crisis server-side |
||
| 131 | $query_args['siteurl'] = get_site_url(); // Send home url option to check for Identity Crisis server-side |
||
| 132 | } |
||
| 133 | |||
| 134 | $url = add_query_arg( $query_args, Jetpack::xmlrpc_api_url() ); |
||
| 135 | |||
| 136 | $rpc = new Jetpack_IXR_Client( array( |
||
| 137 | 'url' => $url, |
||
| 138 | 'user_id' => JETPACK_MASTER_USER, |
||
| 139 | 'timeout' => 30, |
||
| 140 | ) ); |
||
| 141 | |||
| 142 | $result = $rpc->query( 'jetpack.syncActions', $data ); |
||
| 143 | |||
| 144 | if ( ! $result ) { |
||
| 145 | return $rpc->get_jetpack_error(); |
||
| 146 | } |
||
| 147 | |||
| 148 | return $rpc->getResponse(); |
||
| 149 | } |
||
| 150 | |||
| 151 | static function schedule_initial_sync( $new_version = null, $old_version = null ) { |
||
| 179 | |||
| 180 | static function schedule_full_sync( $modules = null, $time_offset = 1 ) { |
||
| 181 | if ( ! self::sync_allowed() ) { |
||
| 208 | |||
| 209 | static function unschedule_all_full_syncs() { |
||
| 218 | |||
| 219 | static function is_scheduled_full_sync( $modules = null ) { |
||
| 233 | |||
| 234 | static function do_full_sync( $modules = null ) { |
||
| 243 | |||
| 244 | static function minute_cron_schedule( $schedules ) { |
||
| 253 | |||
| 254 | // try to send actions until we run out of things to send, |
||
| 255 | // or have to wait more than 15s before sending again, |
||
| 256 | // or we hit a lock or some other sending issue |
||
| 257 | View Code Duplication | static function do_cron_sync() { |
|
| 284 | |||
| 285 | View Code Duplication | static function do_cron_full_sync() { |
|
| 312 | |||
| 313 | static function initialize_listener() { |
||
| 317 | |||
| 318 | static function initialize_sender() { |
||
| 325 | |||
| 326 | static function sanitize_filtered_sync_cron_schedule( $schedule ) { |
||
| 337 | |||
| 338 | static function maybe_schedule_sync_cron( $schedule, $hook ) { |
||
| 353 | |||
| 354 | static function init_sync_cron_jobs() { |
||
| 375 | } |
||
| 376 | |||
| 392 |
The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using
the property is implicitly global.
To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2.