Jetpack_Search_Helpers::remove_query_arg() - Code Metrics - Inspection of "Merge branch 'master' into update/search/widget-au..." - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — update/search/widget-author-ag... ( e3f86a...0871f4 )

by Alex

created 2018-01-25 23:40 UTC

Jetpack_Search_Helpers::remove_query_arg() A

↳ Parent: Jetpack_Search_Helpers

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	3
nc	2
nop	2
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

class Jetpack_Search_Helpers {
	const FILTER_WIDGET_BASE = 'jetpack-search-filters';

	static function get_search_url() {
		$query_args = $_GET;

		// Handle the case where a permastruct is being used, such as /search/{$query}
		if ( ! isset( $query_args['s'] ) ) {
			$query_args['s'] = get_search_query();
		}

		if ( isset( $query_args['paged'] ) ) {
			unset( $query_args['paged'] );
		}

		$query = http_build_query( $query_args );
		return home_url( "?{$query}" );
	}

	static function add_query_arg( $key, $value = false, $url = false ) {
		$url = empty( $url ) ? self::get_search_url() : $url;
		if ( is_array( $key ) ) {
			return add_query_arg( $key, $url );
		}

		return add_query_arg( $key, $value, $url );
	}

	static function remove_query_arg( $key, $url = false ) {
		$url = empty( $url ) ? self::get_search_url() : $url;
		return remove_query_arg( $key, $url );
	}

	static function get_widget_option_name() {
		return sprintf( 'widget_%s', self::FILTER_WIDGET_BASE );
	}

	static function get_widgets_from_option() {
		$widget_options = get_option( self::get_widget_option_name(), array() );

		// We don't need this
		if ( ! empty( $widget_options ) && isset( $widget_options['_multiwidget'] ) ) {
			unset( $widget_options['_multiwidget'] );
		}

		return $widget_options;
	}

	static function build_widget_id( $number ) {
		return sprintf( '%s-%d', self::FILTER_WIDGET_BASE, $number );
	}

	static function is_active_widget( $widget_id ) {
		return (bool) is_active_widget( false, $widget_id, self::FILTER_WIDGET_BASE );
	}

	static function get_filters_from_widgets() {
		$filters = array();

		$widget_options = self::get_widgets_from_option();
		if ( empty( $widget_options ) ) {
			return $filters;
		}

		foreach ( (array) $widget_options as $number => $settings ) {
			$widget_id = self::build_widget_id( $number );
			if ( ! self::is_active_widget( $widget_id ) || empty( $settings['filters'] ) ) {
				continue;
			}

			if ( empty( $settings['use_filters'] ) ) {
				continue;
			}

			foreach ( (array) $settings['filters'] as $widget_filter ) {
				$widget_filter['widget_id'] = $widget_id;
				$key = sprintf( '%s_%d', $widget_filter['type'], count( $filters ) );

				if ( empty( $widget_filter['name'] ) ) {
					switch ( $widget_filter['type'] ) {
						case 'post_type':
							$widget_filter['name'] = _x( 'Post Types', 'label for filtering posts', 'jetpack' );
							break;
						case 'date_histogram':
							switch ( $widget_filter['field'] ) {
								case 'post_date':
								case 'post_date_gmt':
									switch ( $widget_filter['interval'] ) {
										case 'month':
											$widget_filter['name'] = _x( 'Month', 'label for filtering posts', 'jetpack' );
											break;
										case 'year':
											$widget_filter['name'] = _x( 'Year', 'label for filtering posts', 'jetpack' );
											break;
									}
									break;
								case 'post_modified':
								case 'post_modified_gmt':
									switch ( $widget_filter['interval'] ) {
										case 'month':
											$widget_filter['name'] = _x( 'Month Updated', 'label for filtering posts', 'jetpack' );
											break;
										case 'year':
											$widget_filter['name'] = _x( 'Year Updated', 'label for filtering posts', 'jetpack' );
											break;
									}
									break;
							}
							break;
						case 'taxonomy':
							$tax = get_taxonomy( $widget_filter['taxonomy'] );
							if ( ! $tax ) {
								break;
							}

							if ( isset( $tax->label ) ) {
								$widget_filter['name'] = $tax->label;
							} else if ( isset( $tax->labels ) && isset( $tax->labels->name ) ) {
								$widget_filter['name'] = $tax->labels->name;
							}
							break;
					}
				}

				$filters[ $key ] = $widget_filter;
			}
		}

		return $filters;
	}

	/**
	 * Whether we should rerun a search in the customizer preview or not.
	 *
	 * @since 5.8.0
	 *
	 * @return bool
	 */
	static function should_rerun_search_in_customizer_preview() {
		// Only update when in a customizer preview and data is being posted.
		// Check for $_POST removes an extra update when the customizer loads.
		//
		// Note: We use $GLOBALS['wp_customize'] here instead of is_customize_preview() to support unit tests.
		if ( ! isset( $GLOBALS['wp_customize'] ) || ! $GLOBALS['wp_customize']->is_preview() || empty( $_POST ) ) {
			return false;
		}

		return true;
	}

	/**
	 * Since PHP's built-in array_diff() works by comparing the values that are in array 1 to the other arrays,
	 * if there are less values in array 1, it's possible to get an empty diff where one might be expected.
	 *
	 * @since 5.8.0
	 *
	 * @param array $array_1
	 * @param array $array_2
	 *
	 * @return array
	 */
	static function array_diff( $array_1, $array_2 ) {
		// If the array counts are the same, then the order doesn't matter. If the count of
		// $array_1 is higher than $array_2, that's also fine. If the count of $array_2 is higher,
		// we need to swap the array order though.
		if ( count( $array_1 ) != count( $array_2 ) && count( $array_2 ) > count( $array_1 ) ) {
			$temp = $array_1;
			$array_1 = $array_2;
			$array_2 = $temp;
		}

		// Disregard keys
		return array_values( array_diff( $array_1, $array_2 ) );
	}

	/**
	 * Given the widget instance, will return true when selected post types differ from searchable post types.
	 *
	 * @since 5.8.0
	 *
	 * @param array $instance
	 * @return bool
	 */
	static function post_types_differ_searchable( $instance ) {
		if ( empty( $instance['post_types'] ) ) {
			return false;
		}

		$searchable_post_types = get_post_types( array( 'exclude_from_search' => false ) );
		$diff_of_searchable = self::array_diff( $searchable_post_types, (array) $instance['post_types'] );

		return ! empty( $diff_of_searchable );
	}

	/**
	 * Given the widget instance, will return true when selected post types differ from the post type filters
	 * applied to the search.
	 *
	 * @since 5.8.0
	 *
	 * @param array $instance
	 * @return bool
	 */
	static function post_types_differ_query( $instance ) {
		if ( empty( $instance['post_types'] ) ) {
			return false;
		}

		if ( empty( $_GET['post_type'] ) ) {
			$post_types_from_query = array();
		} else if ( is_array( $_GET['post_type'] ) ) {
			$post_types_from_query = $_GET['post_type'];
		} else {
			$post_types_from_query = (array) explode( ',',  $_GET['post_type'] );
		}

		$post_types_from_query = array_map( 'trim', $post_types_from_query );

		$diff_query = self::array_diff( (array) $instance['post_types'], $post_types_from_query );
		return ! empty( $diff_query );
	}

	static function get_widget_tracks_value( $old_value, $new_value ) {
		$old_value = (array) $old_value;
		if ( isset( $old_value['_multiwidget'] ) ) {
			unset( $old_value['_multiwidget'] );
		}

		$new_value = (array) $new_value;
		if ( isset( $new_value['_multiwidget'] ) ) {
			unset( $new_value['_multiwidget'] );
		}

		$action = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$old_keys = array_keys( $old_value );
		$new_keys = array_keys( $new_value );

		if ( count( $new_keys ) > count( $old_keys ) ) { // This is the case for a widget being added
			$diff = self::array_diff( $new_keys, $old_keys );
			$action = 'widget_added';
			$widget = empty( $diff ) || ! isset( $new_value[ $diff[0] ] )
				? false
				: $new_value[ $diff[0] ];
		} else if ( count( $old_keys ) > count( $new_keys ) ) { // This is the case for a widget being deleted
			$diff = self::array_diff( $old_keys, $new_keys );
			$action = 'widget_deleted';
			$widget = empty( $diff ) || ! isset( $old_value[ $diff[0] ] )
				? false
				: $old_value[ $diff[0] ];
		} else {
			$action = 'widget_updated';
			$widget = false;

			// This is a bit crazy. Since there can be multiple widgets stored in a single option,
			// we need to diff the old and new values to figure out which widget was updated.
			foreach ( $new_value as $key => $new_instance ) {
				if ( ! isset( $old_value[ $key ] ) ) {
					continue;
				}
				$old_instance = $old_value[ $key ];

				// First, let's test the keys of each instance
				$diff = self::array_diff( array_keys( $new_instance ), array_keys( $old_instance ) );
				if ( ! empty( $diff ) ) {
					$widget = $new_instance;
					break;
				}

				// Next, lets's loop over each value and compare it
				foreach ( $new_instance as $k => $v ) {
					if ( is_scalar( $v ) && (string) $v !== (string) $old_instance[ $k ] ) {
						$widget = $new_instance;
						break;
					}

					if ( 'filters' == $k ) {
						if ( count( $new_instance['filters'] ) != count( $old_instance['filters'] ) ) {
							$widget = $new_instance;
							break;
						}

						foreach ( $v as $filter_key => $new_filter_value ) {
							$diff = self::array_diff( $new_filter_value, $old_instance[ 'filters' ][ $filter_key ] );
							if ( ! empty( $diff ) ) {
								$widget = $new_instance;
								break;
							}
						}
					}
				}
			}
		}

		if ( empty( $action ) || empty( $widget ) ) {
			return false;
		}

		return array(
			'action' => $action,
			'widget' => self::get_widget_properties_for_tracks( $widget ),
		);
	}

	static function get_widget_properties_for_tracks( $widget ) {
		$sanitized = array();

		foreach ( (array) $widget as $key => $value ) {
			if ( '_multiwidget' == $key ) {
				continue;
			}
			if ( is_scalar( $value ) ) {
				$key = str_replace( '-', '_', sanitize_key( $key ) );
				$key = "widget_{$key}";
				$sanitized[ $key ] = $value;
			}
		}

		$filters_properties = ! empty( $widget['filters'] )
			? self::get_filter_properties_for_tracks( $widget['filters'] )
			: array();

		return array_merge( $sanitized, $filters_properties );
	}

	static function get_filter_properties_for_tracks( $filters ) {
		if ( empty( $filters ) ) {
			return $filters;
		}

		$filters_properties = array(
			'widget_filter_count' => count( $filters ),
		);

		foreach ( $filters as $filter ) {
			if ( empty( $filter['type'] ) ) {
				continue;
			}

			$key = sprintf( 'widget_filter_type_%s', $filter['type'] );
			if ( isset( $filters_properties[ $key ] ) ) {
				$filters_properties[ $key ]++;
			} else {
				$filters_properties[ $key ] = 1;
			}
		}

		return $filters_properties;
	}
}


1		<?php
2
3		class Jetpack_Search_Helpers {
4		const FILTER_WIDGET_BASE = 'jetpack-search-filters';
5
6		static function get_search_url() {
7		$query_args = $_GET;
8
9		// Handle the case where a permastruct is being used, such as /search/{$query}
10		if ( ! isset( $query_args['s'] ) ) {
11		$query_args['s'] = get_search_query();
12		}
13
14		if ( isset( $query_args['paged'] ) ) {
15		unset( $query_args['paged'] );
16		}
17
18		$query = http_build_query( $query_args );
19		return home_url( "?{$query}" );
20		}
21
22		static function add_query_arg( $key, $value = false, $url = false ) {
23		$url = empty( $url ) ? self::get_search_url() : $url;
24		if ( is_array( $key ) ) {
25		return add_query_arg( $key, $url );
26		}
27
28		return add_query_arg( $key, $value, $url );
29		}
30
31		static function remove_query_arg( $key, $url = false ) {
32		$url = empty( $url ) ? self::get_search_url() : $url;
33		return remove_query_arg( $key, $url );
34		}
35
36		static function get_widget_option_name() {
37		return sprintf( 'widget_%s', self::FILTER_WIDGET_BASE );
38		}
39
40		static function get_widgets_from_option() {
41		$widget_options = get_option( self::get_widget_option_name(), array() );
42
43		// We don't need this
44		if ( ! empty( $widget_options ) && isset( $widget_options['_multiwidget'] ) ) {
45		unset( $widget_options['_multiwidget'] );
46		}
47
48		return $widget_options;
49		}
50
51		static function build_widget_id( $number ) {
52		return sprintf( '%s-%d', self::FILTER_WIDGET_BASE, $number );
53		}
54
55		static function is_active_widget( $widget_id ) {
56		return (bool) is_active_widget( false, $widget_id, self::FILTER_WIDGET_BASE );
57		}
58
59		static function get_filters_from_widgets() {
60		$filters = array();
61
62		$widget_options = self::get_widgets_from_option();
63		if ( empty( $widget_options ) ) {
64		return $filters;
65		}
66
67		foreach ( (array) $widget_options as $number => $settings ) {
68		$widget_id = self::build_widget_id( $number );
69		if ( ! self::is_active_widget( $widget_id ) \|\| empty( $settings['filters'] ) ) {
70		continue;
71		}
72
73		if ( empty( $settings['use_filters'] ) ) {
74		continue;
75		}
76
77		foreach ( (array) $settings['filters'] as $widget_filter ) {
78		$widget_filter['widget_id'] = $widget_id;
79		$key = sprintf( '%s_%d', $widget_filter['type'], count( $filters ) );
80
81		if ( empty( $widget_filter['name'] ) ) {
82		switch ( $widget_filter['type'] ) {
83		case 'post_type':
84		$widget_filter['name'] = _x( 'Post Types', 'label for filtering posts', 'jetpack' );
85		break;
86		case 'date_histogram':
87		switch ( $widget_filter['field'] ) {
88		case 'post_date':
89	View Code Duplication	case 'post_date_gmt':
90		switch ( $widget_filter['interval'] ) {
91		case 'month':
92		$widget_filter['name'] = _x( 'Month', 'label for filtering posts', 'jetpack' );
93		break;
94		case 'year':
95		$widget_filter['name'] = _x( 'Year', 'label for filtering posts', 'jetpack' );
96		break;
97		}
98		break;
99		case 'post_modified':
100	View Code Duplication	case 'post_modified_gmt':
101		switch ( $widget_filter['interval'] ) {
102		case 'month':
103		$widget_filter['name'] = _x( 'Month Updated', 'label for filtering posts', 'jetpack' );
104		break;
105		case 'year':
106		$widget_filter['name'] = _x( 'Year Updated', 'label for filtering posts', 'jetpack' );
107		break;
108		}
109		break;
110		}
111		break;
112		case 'taxonomy':
113		$tax = get_taxonomy( $widget_filter['taxonomy'] );
114		if ( ! $tax ) {
115		break;
116		}
117
118		if ( isset( $tax->label ) ) {
119		$widget_filter['name'] = $tax->label;
120		} else if ( isset( $tax->labels ) && isset( $tax->labels->name ) ) {
121		$widget_filter['name'] = $tax->labels->name;
122		}
123		break;
124		}
125		}
126
127		$filters[ $key ] = $widget_filter;
128		}
129		}
130
131		return $filters;
132		}
133
134		/**
135		* Whether we should rerun a search in the customizer preview or not.
136		*
137		* @since 5.8.0
138		*
139		* @return bool
140		*/
141		static function should_rerun_search_in_customizer_preview() {
142		// Only update when in a customizer preview and data is being posted.
143		// Check for $_POST removes an extra update when the customizer loads.
144		//
145		// Note: We use $GLOBALS['wp_customize'] here instead of is_customize_preview() to support unit tests.
146		if ( ! isset( $GLOBALS['wp_customize'] ) \|\| ! $GLOBALS['wp_customize']->is_preview() \|\| empty( $_POST ) ) {
147		return false;
148		}
149
150		return true;
151		}
152
153		/**
154		* Since PHP's built-in array_diff() works by comparing the values that are in array 1 to the other arrays,
155		* if there are less values in array 1, it's possible to get an empty diff where one might be expected.
156		*
157		* @since 5.8.0
158		*
159		* @param array $array_1
160		* @param array $array_2
161		*
162		* @return array
163		*/
164		static function array_diff( $array_1, $array_2 ) {
165		// If the array counts are the same, then the order doesn't matter. If the count of
166		// $array_1 is higher than $array_2, that's also fine. If the count of $array_2 is higher,
167		// we need to swap the array order though.
168		if ( count( $array_1 ) != count( $array_2 ) && count( $array_2 ) > count( $array_1 ) ) {
169		$temp = $array_1;
170		$array_1 = $array_2;
171		$array_2 = $temp;
172		}
173
174		// Disregard keys
175		return array_values( array_diff( $array_1, $array_2 ) );
176		}
177
178		/**
179		* Given the widget instance, will return true when selected post types differ from searchable post types.
180		*
181		* @since 5.8.0
182		*
183		* @param array $instance
184		* @return bool
185		*/
186		static function post_types_differ_searchable( $instance ) {
187		if ( empty( $instance['post_types'] ) ) {
188		return false;
189		}
190
191		$searchable_post_types = get_post_types( array( 'exclude_from_search' => false ) );
192		$diff_of_searchable = self::array_diff( $searchable_post_types, (array) $instance['post_types'] );
193
194		return ! empty( $diff_of_searchable );
195		}
196
197		/**
198		* Given the widget instance, will return true when selected post types differ from the post type filters
199		* applied to the search.
200		*
201		* @since 5.8.0
202		*
203		* @param array $instance
204		* @return bool
205		*/
206		static function post_types_differ_query( $instance ) {
207		if ( empty( $instance['post_types'] ) ) {
208		return false;
209		}
210
211		if ( empty( $_GET['post_type'] ) ) {
212		$post_types_from_query = array();
213		} else if ( is_array( $_GET['post_type'] ) ) {
214		$post_types_from_query = $_GET['post_type'];
215		} else {
216		$post_types_from_query = (array) explode( ',', $_GET['post_type'] );
217		}
218
219		$post_types_from_query = array_map( 'trim', $post_types_from_query );
220
221		$diff_query = self::array_diff( (array) $instance['post_types'], $post_types_from_query );
222		return ! empty( $diff_query );
223		}
224
225		static function get_widget_tracks_value( $old_value, $new_value ) {
226		$old_value = (array) $old_value;
227		if ( isset( $old_value['_multiwidget'] ) ) {
228		unset( $old_value['_multiwidget'] );
229		}
230
231		$new_value = (array) $new_value;
232		if ( isset( $new_value['_multiwidget'] ) ) {
233		unset( $new_value['_multiwidget'] );
234		}
235
236		$action = '';
		0 ignored issues – show Unused Code introduced 2018-01-23 22:50 UTC by Report Bug Copy Issue Report `$action` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
237		$old_keys = array_keys( $old_value );
238		$new_keys = array_keys( $new_value );
239
240		if ( count( $new_keys ) > count( $old_keys ) ) { // This is the case for a widget being added
241		$diff = self::array_diff( $new_keys, $old_keys );
242		$action = 'widget_added';
243		$widget = empty( $diff ) \|\| ! isset( $new_value[ $diff[0] ] )
244		? false
245		: $new_value[ $diff[0] ];
246		} else if ( count( $old_keys ) > count( $new_keys ) ) { // This is the case for a widget being deleted
247		$diff = self::array_diff( $old_keys, $new_keys );
248		$action = 'widget_deleted';
249		$widget = empty( $diff ) \|\| ! isset( $old_value[ $diff[0] ] )
250		? false
251		: $old_value[ $diff[0] ];
252		} else {
253		$action = 'widget_updated';
254		$widget = false;
255
256		// This is a bit crazy. Since there can be multiple widgets stored in a single option,
257		// we need to diff the old and new values to figure out which widget was updated.
258		foreach ( $new_value as $key => $new_instance ) {
259		if ( ! isset( $old_value[ $key ] ) ) {
260		continue;
261		}
262		$old_instance = $old_value[ $key ];
263
264		// First, let's test the keys of each instance
265		$diff = self::array_diff( array_keys( $new_instance ), array_keys( $old_instance ) );
266		if ( ! empty( $diff ) ) {
267		$widget = $new_instance;
268		break;
269		}
270
271		// Next, lets's loop over each value and compare it
272		foreach ( $new_instance as $k => $v ) {
273		if ( is_scalar( $v ) && (string) $v !== (string) $old_instance[ $k ] ) {
274		$widget = $new_instance;
275		break;
276		}
277
278		if ( 'filters' == $k ) {
279		if ( count( $new_instance['filters'] ) != count( $old_instance['filters'] ) ) {
280		$widget = $new_instance;
281		break;
282		}
283
284		foreach ( $v as $filter_key => $new_filter_value ) {
285		$diff = self::array_diff( $new_filter_value, $old_instance[ 'filters' ][ $filter_key ] );
286		if ( ! empty( $diff ) ) {
287		$widget = $new_instance;
288		break;
289		}
290		}
291		}
292		}
293		}
294		}
295
296		if ( empty( $action ) \|\| empty( $widget ) ) {
297		return false;
298		}
299
300		return array(
301		'action' => $action,
302		'widget' => self::get_widget_properties_for_tracks( $widget ),
303		);
304		}
305
306		static function get_widget_properties_for_tracks( $widget ) {
307		$sanitized = array();
308
309		foreach ( (array) $widget as $key => $value ) {
310		if ( '_multiwidget' == $key ) {
311		continue;
312		}
313		if ( is_scalar( $value ) ) {
314		$key = str_replace( '-', '_', sanitize_key( $key ) );
315		$key = "widget_{$key}";
316		$sanitized[ $key ] = $value;
317		}
318		}
319
320		$filters_properties = ! empty( $widget['filters'] )
321		? self::get_filter_properties_for_tracks( $widget['filters'] )
322		: array();
323
324		return array_merge( $sanitized, $filters_properties );
325		}
326
327		static function get_filter_properties_for_tracks( $filters ) {
328		if ( empty( $filters ) ) {
329		return $filters;
330		}
331
332		$filters_properties = array(
333		'widget_filter_count' => count( $filters ),
334		);
335
336		foreach ( $filters as $filter ) {
337		if ( empty( $filter['type'] ) ) {
338		continue;
339		}
340
341		$key = sprintf( 'widget_filter_type_%s', $filter['type'] );
342		if ( isset( $filters_properties[ $key ] ) ) {
343		$filters_properties[ $key ]++;
344		} else {
345		$filters_properties[ $key ] = 1;
346		}
347		}
348
349		return $filters_properties;
350		}
351		}
352

Automattic / jetpack

Push — update/search/widget-author-ag... ( e3f86a...0871f4 )

Jetpack_Search_Helpers::remove_query_arg() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like