Automattic /
jetpack
| Conditions | 13 |
| Paths | 432 |
| Total Lines | 48 |
| Code Lines | 34 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 102 | public static function generate_stats_array( $prefix = '' ) { |
||
| 103 | $return = array(); |
||
| 104 | |||
| 105 | $return["{$prefix}version"] = JETPACK__VERSION; |
||
| 106 | $return["{$prefix}wp-version"] = get_bloginfo( 'version' ); |
||
| 107 | $return["{$prefix}php-version"] = PHP_VERSION; |
||
| 108 | $return["{$prefix}branch"] = floatval( JETPACK__VERSION ); |
||
| 109 | $return["{$prefix}wp-branch"] = floatval( get_bloginfo( 'version' ) ); |
||
| 110 | $return["{$prefix}php-branch"] = floatval( PHP_VERSION ); |
||
| 111 | $return["{$prefix}public"] = Jetpack_Options::get_option( 'public' ); |
||
| 112 | $return["{$prefix}ssl"] = Jetpack::permit_ssl(); |
||
| 113 | $return["{$prefix}is-https"] = is_ssl() ? 'https' : 'http'; |
||
| 114 | $return["{$prefix}language"] = get_bloginfo( 'language' ); |
||
| 115 | $return["{$prefix}charset"] = get_bloginfo( 'charset' ); |
||
| 116 | $return["{$prefix}is-multisite"] = is_multisite() ? 'multisite' : 'singlesite'; |
||
| 117 | $return["{$prefix}identitycrisis"] = Jetpack::check_identity_crisis() ? 'yes' : 'no'; |
||
| 118 | $return["{$prefix}plugins"] = implode( ',', Jetpack::get_active_plugins() ); |
||
| 119 | $return["{$prefix}manage-enabled"] = Jetpack::is_module_active( 'manage' ); |
||
| 120 | |||
| 121 | if ( ! function_exists( 'get_plugins' ) ) { |
||
| 122 | require_once( ABSPATH . 'wp-admin/includes/plugin.php' ); |
||
| 123 | } |
||
| 124 | /** This filter is documented in wp-admin/includes/class-wp-plugins-list-table.php */ |
||
| 125 | $return["{$prefix}qty-plugins"] = sizeof( apply_filters( 'all_plugins', get_plugins() ) ); |
||
| 126 | $return["{$prefix}qty-plugins-active"] = sizeof( Jetpack::get_active_plugins() ); // Includes network-activated plugins. |
||
| 127 | $return["{$prefix}qty-mu-plugins"] = sizeof( Jetpack::glob_php( WPMU_PLUGIN_DIR ) ); |
||
| 128 | $return["{$prefix}qty-themes"] = sizeof( wp_get_themes( array( 'allowed' => true ) ) ); |
||
| 129 | |||
| 130 | // is-multi-network can have three values, `single-site`, `single-network`, and `multi-network` |
||
| 131 | $return["{$prefix}is-multi-network"] = 'single-site'; |
||
| 132 | if ( is_multisite() ) { |
||
| 133 | $return["{$prefix}is-multi-network"] = Jetpack::is_multi_network() ? 'multi-network' : 'single-network'; |
||
| 134 | } |
||
| 135 | |||
| 136 | if ( ! empty( $_SERVER['SERVER_ADDR'] ) || ! empty( $_SERVER['LOCAL_ADDR'] ) ) { |
||
| 137 | $ip = ! empty( $_SERVER['SERVER_ADDR'] ) ? $_SERVER['SERVER_ADDR'] : $_SERVER['LOCAL_ADDR']; |
||
| 138 | $ip_arr = array_map( 'intval', explode( '.', $ip ) ); |
||
| 139 | if ( 4 == count( $ip_arr ) ) { |
||
| 140 | $return["{$prefix}ip-2-octets"] = implode( '.', array_slice( $ip_arr, 0, 2 ) ); |
||
| 141 | } |
||
| 142 | } |
||
| 143 | |||
| 144 | foreach ( Jetpack::get_available_modules() as $slug ) { |
||
| 145 | $return["{$prefix}module-{$slug}"] = Jetpack::is_module_active( $slug ) ? 'on' : 'off'; |
||
| 146 | } |
||
| 147 | |||
| 148 | return $return; |
||
| 149 | } |
||
| 150 | |||
| 167 |
Adding a
@returnannotation to a constructor is not recommended, since a constructor does not have a meaningful return value.Please refer to the PHP core documentation on constructors.