Jetpack_Sync_Client

Complexity

Total Complexity

38

Size/Duplication

Total Lines	215
Duplicated Lines	0 %

Coupling/Cohesion

Components	3
Dependencies	4

Importance

Changes	18
Bugs	3	Features	2

18 Methods

Rating	Name	Duplication	Size	Complexity
A	maybe_sync_constants()	0	9	2
A	get_all_constants()	0	6	1
A	get_constant()	0	7	2
A	get_check_sum()	0	3	1
A	get_actions()	0	4	1
A	get_all_actions()	0	3	1
A	getInstance()	0	7	2
A	__construct()	0	6	1
B	init()	0	48	4
A	set_options_whitelist()	0	3	1
B	is_whitelisted_option()	0	10	5
A	set_codec()	0	3	1
A	set_sync_queue()	0	3	1
B	action_handler()	0	19	5
A	switch_theme_handler()	0	5	1
C	do_sync()	0	38	7
A	reset_state()	0	6	1
A	set_constants_whitelist()	0	3	1

<?php
require_once dirname( __FILE__ ) . '/class.jetpack-sync-deflate-codec.php';
require_once dirname( __FILE__ ) . '/class.jetpack-sync-queue.php';

class Jetpack_Sync_Client {
	static $default_options_whitelist = array( 'stylesheet', '/^theme_mods_.*$/' );

The visibility should be declared for property $default_options_whitelist.

	static $default_constants_whitelist = array();

The visibility should be declared for property $default_constants_whitelist.

	private $sync_queue;
	private $codec;
	private $options_whitelist;
	private $constants_whitelist;
	private $meta_types = array( 'post' );

	// singleton functions
	private static $instance;

	public static function getInstance() {
		if (null === static::$instance) {

Since $instance is declared private, accessing it with static will lead to errors in possible sub-classes; consider using self, or increasing the visibility of $instance to at least protected.

			static::$instance = new static();

Since $instance is declared private, accessing it with static will lead to errors in possible sub-classes; consider using self, or increasing the visibility of $instance to at least protected.

		}
		
		return static::$instance;

Since $instance is declared private, accessing it with static will lead to errors in possible sub-classes; consider using self, or increasing the visibility of $instance to at least protected.

	}

	// this is necessary because you can't use "new" when you declare instance properties >:(
	protected function __construct() {
		$this->sync_queue = new Jetpack_Sync_Queue( 'sync', 100 );
		$this->codec = new Jetpack_Sync_Deflate_Codec();
		$this->options_whitelist = self::$default_options_whitelist;
		$this->init();
	}

	private function init() {
		$handler = array( $this, 'action_handler' );

		// posts
		add_action( 'wp_insert_post', $handler, 10, 3 );
		add_action( 'deleted_post', $handler, 10 );

		// comments
		add_action( 'wp_insert_comment', $handler, 10, 2 );
		add_action( 'deleted_comment', $handler, 10 );
		add_action( 'trashed_comment', $handler, 10 );
		add_action( 'spammed_comment', $handler, 10 );

		// even though it's messy, we implement these hooks because 
		// the edit_comment hook doesn't include the data
		// so this saves us a DB read for every comment event
		foreach ( array( '', 'trackback', 'pingback' ) as $comment_type ) {
			foreach ( array( 'unapproved', 'approved' ) as $comment_status ) {
				add_action( "comment_{$comment_status}_{$comment_type}", $handler, 10, 2 );
			}
		}

		// options
		add_action( 'added_option', $handler, 10, 2 );
		add_action( 'updated_option', $handler, 10, 3 );
		add_action( 'deleted_option', $handler, 10, 1 );

		// themes
		add_action( 'jetpack_sync_current_theme_support', $handler, 10 ); // custom hook, see meta-hooks below
		add_action( 'jetpack_sync_current_constants', $handler, 10 );

		// post-meta, and in the future - other meta?
		foreach ( $this->meta_types as $meta_type ) {
			// we need to make sure we don't commit before we receive these,
			// because they're invoked after meta changes are saved to the DB
			add_action( "added_{$meta_type}_meta", $handler, 99, 4 );
			add_action( "updated_{$meta_type}_meta", $handler, 99, 4 );
			add_action( "deleted_{$meta_type}_meta", $handler, 99, 4 );
		}

		/**
		 * Other hooks - fire synthetic hooks for all the properties we need to sync, 
		 * e.g. when a theme changes
		 */

		// themes
		add_action( 'switch_theme', array( $this, 'switch_theme_handler' ) );
	}

	function set_options_whitelist( $options ) {
		$this->options_whitelist = $options;
	}

	function set_constants_whitelist( $constants ) {
		$this->constants_whitelist = $constants;
	}

	function is_whitelisted_option( $option ) {
		foreach ( $this->options_whitelist as $whitelisted_option ) {
			if ( $whitelisted_option[0] === '/' && preg_match( $whitelisted_option, $option ) ) {
				return true;
			} elseif ( $whitelisted_option === $option ) {
				return true;
			}
		}
		return false;
	}

	function set_codec( iJetpack_Sync_Codec $codec ) {
		$this->codec = $codec;
	}

	function set_sync_queue( $queue ) {
		$this->sync_queue = $queue;
	}

	function action_handler() {
		$current_filter = current_filter();
		$args           = func_get_args();

		if ( $current_filter === 'wp_insert_post' && $args[1]->post_type === 'revision' ) {
			return;
		}

		if ( in_array( $current_filter, array( 'deleted_option', 'added_option', 'updated_option' ) ) 
			&& 
			! $this->is_whitelisted_option( $args[0] ) ) {
			return;
		}
		Jetpack_Sync::schedule_sync();
		$this->sync_queue->add( array(
			$current_filter,
			$args
		) );
	}

	function switch_theme_handler() {
		global $_wp_theme_features;
		
		do_action( 'jetpack_sync_current_theme_support', $_wp_theme_features );
	}

	function do_sync() {
		$this->maybe_sync_constants();

		// TODO: only send buffer once, then do the rest in a cron job

Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker.

		$iters = 0;
		while ( ( $buffer = $this->sync_queue->checkout() ) && $iters < 100 ) {

			if ( !$buffer ) {
				// buffer has no items
				return;
			}

			if ( is_wp_error( $buffer) ) {
				error_log("Error fetching buffer: ".$buffer->get_error_message());

The method get_error_message() does not seem to exist on object<Jetpack_Sync_Queue_Buffer>.

				return;
			}

			$data = $this->codec->encode( $buffer->get_items() );

			/**
			 * Fires when data is ready to send to the server.
			 * Return false or WP_Error to abort the sync (e.g. if there's an error)
			 * The items will be automatically re-sent later
			 *
			 * @since 4.1
			 *
			 * @param array $data The action buffer
			 */
			$result = apply_filters( 'jetpack_sync_client_send_data', $data );

			if ( !$result || is_wp_error( $result ) ) {
				$this->sync_queue->checkin( $buffer );
			} else {
				$this->sync_queue->close( $buffer );
			}
			$iters += 1;
		}
	}
	
	private function maybe_sync_constants() {
		$constants = $this->get_all_constants();
		$constants_check_sum = $this->get_check_sum( $constants );
		$check_sum_option = 'jetpack_constants_sync_checksum';
		if ( $constants_check_sum !== get_option( $check_sum_option ) ) {
			do_action( 'jetpack_sync_current_constants', $constants );
			update_option( $check_sum_option, $constants_check_sum );
		}
	}

	private function get_all_constants() {
		return 	array_combine( 
					$this->constants_whitelist, 
					array_map( array( $this, 'get_constant' ), $this->constants_whitelist ) 
				);
	}

	private function get_constant( $constant ) {
		if ( defined( $constant ) ) {
			return constant( $constant );
		}

		return null;
	}

	private function get_check_sum( $values ) {
		return crc32( serialize( $values ) );
	}

	function get_actions() {
		// TODO: we should only send a bit at a time, flush_all sends everything

Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker.

		return $this->sync_queue->flush_all();
	}

	function get_all_actions() {
		return $this->sync_queue->get_all();
	}

	function reset_state() {
		$this->codec = new Jetpack_Sync_Deflate_Codec();
		$this->constants_whitelist = self::$default_constants_whitelist;
		$this->options_whitelist = self::$default_options_whitelist;
		$this->sync_queue->reset();
	}
}